drop pytype from CI checks
less useful as more type hints are added
This commit is contained in:
parent
f7ae4c3ef4
commit
30f5a82d35
2
.github/workflows/pythonpackage.yml
vendored
2
.github/workflows/pythonpackage.yml
vendored
@ -26,5 +26,5 @@ jobs:
|
||||
pip install -r requirements.qt
|
||||
- name: Run checks
|
||||
run: |
|
||||
make check pytype
|
||||
make check
|
||||
|
||||
|
@ -54,12 +54,11 @@ but not very good at type inference, so it is mostly useful for checking code
|
||||
that has type signatures. It is able to read the bundled Qt stubs, and works
|
||||
across the whole Anki codebase.
|
||||
|
||||
When you use 'make pytype', Anki will typecheck the code with pytype. Pytype
|
||||
You can optionally use 'make pytype' to typecheck the code with pytype. Pytype
|
||||
is much slower, but it can catch errors in untyped code that mypy misses. It
|
||||
is not able to check the aqt/* code, as it can't read the Qt stubs, and it is
|
||||
not currently compatible with Python 3.8. It can also be difficult to build,
|
||||
so it is not included in the default 'make check', but it will be run when a
|
||||
pull request is submitted.
|
||||
not currently compatible with Python 3.8. It can be difficult to build on
|
||||
some platforms.
|
||||
|
||||
The Qt stubs are not perfect, so you'll find when doing things like connecting
|
||||
signals, you may have to add the following to the end of a line to silence
|
||||
|
Loading…
Reference in New Issue
Block a user