diff --git a/.github/workflows/pythonpackage.yml b/.github/workflows/pythonpackage.yml index 6db2b10bd..cb3e23425 100644 --- a/.github/workflows/pythonpackage.yml +++ b/.github/workflows/pythonpackage.yml @@ -26,5 +26,5 @@ jobs: pip install -r requirements.qt - name: Run checks run: | - make check pytype + make check diff --git a/README.contributing b/README.contributing index bf966b2a7..ce98f6137 100644 --- a/README.contributing +++ b/README.contributing @@ -54,12 +54,11 @@ but not very good at type inference, so it is mostly useful for checking code that has type signatures. It is able to read the bundled Qt stubs, and works across the whole Anki codebase. -When you use 'make pytype', Anki will typecheck the code with pytype. Pytype +You can optionally use 'make pytype' to typecheck the code with pytype. Pytype is much slower, but it can catch errors in untyped code that mypy misses. It is not able to check the aqt/* code, as it can't read the Qt stubs, and it is -not currently compatible with Python 3.8. It can also be difficult to build, -so it is not included in the default 'make check', but it will be run when a -pull request is submitted. +not currently compatible with Python 3.8. It can be difficult to build on +some platforms. The Qt stubs are not perfect, so you'll find when doing things like connecting signals, you may have to add the following to the end of a line to silence