RumovZ
72f6f9a47a
Tweak comment
...
Co-authored-by: Damien Elmes <dae@users.noreply.github.com>
2021-09-28 11:48:35 +02:00
RumovZ
46ffbb936d
Speed up to_row_of_unselected_note()
...
Skip rows between selected rows and return fetched note ids.
2021-09-28 11:47:13 +02:00
RumovZ
a592c5b3a9
Cache selectionModel().selectedRows()
2021-09-28 11:45:22 +02:00
RumovZ
eac8972a28
Calculate len_selection
depending on modifiers
...
If no modifiers are pressed, a single row has probably been clicked and
`selectedRows()` is fast, while a lot of rows might have been deselcted.
2021-09-28 10:22:20 +02:00
RumovZ
287854d014
Prefer selectionModel().reset()
over .clear()
...
The latter triggers `selectionChanged()` unreliably, probably due to the
aggregation of chronologically close events, causing problems in
tracking `_len_selection`. `reset()` never emits signals.
2021-09-28 10:19:33 +02:00
RumovZ
f89811870e
Calculate number of selected rows manually
...
`len(self._view.selectionModel().selectedRows())` is slow for large
selections, because Qt queries flags() for every selected cell, so we
calculate the number of selected rows ourselves.
2021-09-27 10:15:53 +02:00
RumovZ
18f0d026b5
Switch to new row before deleting notes
...
The table now properly deselects deleted rows, but that takes effort and
it's more convenient to have a selected row after deleting.
2021-09-25 17:28:38 +02:00
RumovZ
f54f15cd44
Handle deleted or restored rows
...
- Cache the result of 'table.len_selection()'
- Update this cache manually when a row was deleted or restored
- Emit 'dataChanged()' after such a change to fix flags not updating
correctly to the shortcut in 'model.flags()'
- Remove/retsore focus if the current element was deleted/restored
2021-09-25 17:16:53 +02:00
RumovZ
3a8c494544
Only check flags of cached rows
...
Speeds up the selection process (esp. Ctrl+A) by avoiding to fetch rows.
Co-authored-by: BlueGreenMagick <BlueGreenMagick@users.noreply.github.com>
2021-09-25 15:32:22 +02:00
RumovZ
73ec0a2b2e
Add callbacks to row fetching routine
...
Called when a row is detected that has been deleted or restored.
2021-09-25 15:27:19 +02:00
RumovZ
2b5bf23bbd
Check 'index.isValid()' in 'table.model'
2021-09-25 15:21:06 +02:00
Damien Elmes
09cc55b0d3
Merge pull request #1376 from hgiesel/mathjaxcleanupv2
...
Mathjax Cleanup
2021-09-21 18:39:27 +10:00
Damien Elmes
d091a547a4
Merge pull request #1375 from RumovZ/disable-actions
...
Disable unusable browser actions on row change
2021-09-21 18:38:30 +10:00
Damien Elmes
5f950dff3d
bump version
2021-09-21 16:30:15 +10:00
Damien Elmes
81a8fe039b
Merge pull request #1379 from BlueGreenMagick/dont-fill-empty-on-add-cards
...
set CardLayout fill_empty=False for add cards editor
2021-09-21 15:08:54 +10:00
Damien Elmes
1ceb9965ad
add hidden option to disable tooltips in browse screen
...
https://forums.ankiweb.net/t/browser-text-pop-up-when-hovering-over-card-poll/13254
2021-09-21 15:03:37 +10:00
Damien Elmes
9720592519
temporary fix for error on deleting ( #1374 )
2021-09-20 22:02:44 +10:00
Damien Elmes
66fc9cdbd8
add startup message about forcing Wayland
2021-09-20 21:42:16 +10:00
Damien Elmes
cdad1efdcf
Revert "Merge pull request #1364 from evandroforks/fix_unclosed_python_file"
...
This reverts commit c05475a49e54ed7a56bc635e5e5528334d4ba6ac.
Revert "possible fix for reported audio issues"
This reverts commit f00f7f099f
.
Reverting in case https://forums.ankiweb.net/t/2-1-48-release-candidate/13268/10
is related to this change. If the issue persists, we'll know this was
not the cause.
2021-09-20 21:39:15 +10:00
bluegreenmagick
f3db3fa768
set CardLayout fill_empty=False for add cards editor
...
Card layout view functions as a previewer in add cards dialog
so displaying accurately is more important than having placeholders.
Especially for card layouts using conditional-not fields {{^Field}}
card layout is rendered badly.
2021-09-20 18:34:49 +09:00
Henrik Giesel
3f1da03615
Allow for explicit any
2021-09-17 21:30:32 +02:00
Henrik Giesel
51c0cedaf5
Make HandleSelection perfectly size when first activating
2021-09-17 21:23:04 +02:00
Henrik Giesel
06d1ec6af4
Fix missizing of HandleSelection when first moving from empty to Mathjax
2021-09-17 20:54:37 +02:00
Henrik Giesel
88fd31a099
Ugly fix: do not execute moveCursorPastPostfix when front includes "anki-mathjax"
2021-09-17 20:12:11 +02:00
RumovZ
40bad0f65d
Disable unusable browser actions on row change
2021-09-17 16:16:34 +02:00
Henrik Giesel
c30ba6a3f6
Add ChangeTimer.prototype.fireImmediately
...
so Mathjax is saved when exiting editor prematurely
2021-09-16 14:47:05 +02:00
Henrik Giesel
a1dde7c966
Wrap Mathjax compilation into try/catch
2021-09-16 14:31:20 +02:00
Damien Elmes
f00f7f099f
possible fix for reported audio issues
...
https://forums.ankiweb.net/t/2-1-48-release-candidate/13268/6
This is the only area of the sound code that has changed since 2.1.47
2021-09-16 10:27:37 +10:00
Damien Elmes
22e8ce3eb3
Merge pull request #1324 from hgiesel/mathjaxboxv4
...
MathJax Preview + In-line editor
2021-09-16 10:27:08 +10:00
Henrik Giesel
60690e0557
Rename StickyBar and StickyBottom to StickyHeader and StickyFooter
2021-09-15 23:15:55 +02:00
Henrik Giesel
896b40c873
Remove now unused import in TagEditor
2021-09-15 22:59:47 +02:00
Henrik Giesel
9f56d51811
Fix suggestions not showing when typing space in a TagInput
2021-09-15 22:54:53 +02:00
Henrik Giesel
b502ceedca
Make the ImageHandle and MathjaxHandle dropdowns perfectly touch the HandleSelection
2021-09-15 22:26:32 +02:00
Henrik Giesel
1f09402066
Stop propagation for paste in MathjaxHandle editor
2021-09-15 22:14:38 +02:00
Henrik Giesel
97647e7b24
Prevent hiding handles by clicking on handles
2021-09-15 17:56:56 +02:00
Henrik Giesel
9001b597da
Remove style attribute after remove float property if not styling left
2021-09-15 17:36:48 +02:00
Henrik Giesel
9b7ea75399
Always correctly update MathjaxHandle position
2021-09-15 17:05:43 +02:00
Henrik Giesel
ce9674f824
Correctly pass down dropdownObject...
2021-09-15 16:16:42 +02:00
Henrik Giesel
7c6f6533c1
Using dropdownApi is much less faulty than using dropdownObject
...
- Update MathjaxSelection and Dropdown more reliably
2021-09-15 15:52:56 +02:00
Henrik Giesel
c227c7dc39
Make StickyBottom actually stick and make editor fullsize + flexbox
2021-09-15 15:21:37 +02:00
Henrik Giesel
c46f39c88e
Import saveField from editor/saving.ts
2021-09-15 14:09:25 +02:00
Henrik Giesel
54b6491ce3
Remove duplicate outline:none
2021-09-15 13:46:07 +02:00
Henrik Giesel
71bdeeba39
Apply specific CSS to Mathjax CodeMirror
2021-09-15 13:46:04 +02:00
Henrik Giesel
219557afda
Satisfy eslint
2021-09-15 13:45:20 +02:00
Henrik Giesel
ec9b43d3ab
Use editorfield instead of editor-field
2021-09-15 13:45:20 +02:00
Henrik Giesel
c8c9c64ea5
Vertically center inline Mathjax
2021-09-15 13:45:20 +02:00
Henrik Giesel
c02973a85d
Generalize accesing anki-mathjax from image in MathjaxHandle
2021-09-15 13:45:20 +02:00
Henrik Giesel
b6bea18b22
Add copyright header to saving.ts
2021-09-15 13:45:20 +02:00
Henrik Giesel
09819d4e7d
Satisfy eslint
2021-09-15 13:45:19 +02:00
Henrik Giesel
e269fe73da
Define CodeMirror in external codeMirror.ts
2021-09-15 13:45:19 +02:00