langfingaz/anki
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
e364b36dc4
anki/qt/aqt
History
Damien Elmes e364b36dc4 experiment with preserving search when resetting 
Up until now, we've been forcing a new search whenever reset is called.
The primary reason was that the card list display routines did not expect
a card or note to have been removed. By updating the model to show
"(deleted)" when a card or note is missing, we no longer have to repeat
the search.

This has a few advantages:

- Searches, especially complex ones, can be slow to execute. When we
perform them after every operation like a delete, it can make Anki feel
sluggish.
- The fact that notes have been deleted becomes more obvious - some users
found it easy to miss the "deleted" pop-up in the past.

This change does not just affect deletions, as many other operations
trigger a reset as well. In the past, when using 'set due date' in the
review screen for example, it caused an ugly flicker in the browser screen,
and could be slow when the current search couldn't be quickly redone.

The disadvantage of this approach is that the displayed content may
not reflect the specified search, which has the potential to be confusing.
But if that turns out to be a problem, it could be (partly) alleviated by
displaying a refresh button next to the search bar when the search may
need to be refreshed.

Feedback welcome!
2021-03-19 19:45:21 +10:00
..
data Remove explicit popperjs again, because it's included in bootstrap.bundle 2021-03-09 13:37:56 +01:00
forms Merge branch 'master' into sidebar-tools 2021-03-11 12:08:32 +01:00
__init__.py convert qt strings to f-strings with flynt 2021-02-11 10:09:06 +10:00
about.py Update about screen 2021-03-10 11:34:28 +01:00
addcards.py Simplify note adding and the deck/notetype choosers 2021-03-10 11:53:27 +10:00
addons.py don't show routine update when not update_enabled 2021-03-09 22:27:28 +09:00
browser.py experiment with preserving search when resetting 2021-03-19 19:45:21 +10:00
BUILD.bazel winrt 1.0.20239.1 isn't available for python 3.9 2020-12-23 20:31:13 +10:00
clayout.py commit immediately when there's no active checkpoint 2021-03-10 11:47:53 +10:00
colors.py move remaining Filter button items into sidebar 2021-02-05 18:58:22 +10:00
customstudy.py tweak search wording and tidy up API 2021-02-11 19:57:19 +10:00
dbcheck.py nest progress messages and remove Python wrapper class 2021-02-08 16:40:27 +10:00
deckbrowser.py deck deletion in deck list was not resetting state 2021-03-19 19:45:20 +10:00
deckchooser.py Simplify note adding and the deck/notetype choosers 2021-03-10 11:53:27 +10:00
deckconf.py minor code cleanups with pyupgrade 2021-02-11 09:43:40 +10:00
dyndeckconf.py Make clickable dyndeck labels fixed in size 2021-03-01 11:26:52 +01:00
editcurrent.py commit immediately when there's no active checkpoint 2021-03-10 11:47:53 +10:00
editor.py expand backend Preferences and make undoable 2021-03-10 18:51:03 +10:00
emptycards.py nest NoteWithEmptyCards 2021-02-08 19:11:16 +10:00
errors.py convert qt strings to f-strings with flynt 2021-02-11 10:09:06 +10:00
exporting.py minor code cleanups with pyupgrade 2021-02-11 09:43:40 +10:00
fields.py convert qt strings to f-strings with flynt 2021-02-11 10:09:06 +10:00
gui_hooks.py fix qt/ pylints 2021-01-07 16:21:50 +10:00
hooks_gen.py symlink generated .py/.pyi into tree to fix Python code completion 2020-12-16 11:36:42 +10:00
importing.py Simplify note adding and the deck/notetype choosers 2021-03-10 11:53:27 +10:00
legacy.py minor code cleanups with pyupgrade 2021-02-11 09:43:40 +10:00
main.py avoid hanging UI when undoing in browse screen 2021-03-12 18:54:08 +10:00
mediacheck.py tweak search wording and tidy up API 2021-02-11 19:57:19 +10:00
mediasrv.py convert qt strings to f-strings with flynt 2021-02-11 10:09:06 +10:00
mediasync.py nest progress messages and remove Python wrapper class 2021-02-08 16:40:27 +10:00
modelchooser.py Simplify note adding and the deck/notetype choosers 2021-03-10 11:53:27 +10:00
models.py convert qt strings to f-strings with flynt 2021-02-11 10:09:06 +10:00
mpv.py convert qt strings to f-strings with flynt 2021-02-11 10:09:06 +10:00
notetypechooser.py Simplify note adding and the deck/notetype choosers 2021-03-10 11:53:27 +10:00
overview.py convert qt strings to f-strings with flynt 2021-02-11 10:09:06 +10:00
pinnedmodules.py fix rsbackend compat issues 2021-02-08 09:51:51 +10:00
platform.py turn top bar dark when night mode enabled on macOS 2021-02-04 19:19:56 +10:00
preferences.py expand backend Preferences and make undoable 2021-03-10 18:51:03 +10:00
previewer.py remove unnecessary setMod() calls 2021-03-10 11:47:53 +10:00
profiles.py expand backend Preferences and make undoable 2021-03-10 18:51:03 +10:00
progress.py convert qt strings to f-strings with flynt 2021-02-11 10:09:06 +10:00
py.typed mark anki and aqt modules as having typing info 2020-01-13 13:03:37 +10:00
qt.py more typing updates 2021-02-02 23:31:55 +10:00
reviewer.py 'set due date' now undoable 2021-03-12 14:50:31 +10:00
scheduling.py make 'forget card' undoable; remove checkpoint() in set_due_date 2021-03-12 16:13:50 +10:00
schema_change_tracker.py add a bunch of return types 2021-02-01 23:53:23 +10:00
sidebar.py Improve grouping of sidebar methods 2021-03-13 09:45:06 +01:00
sound.py convert qt strings to f-strings with flynt 2021-02-11 10:09:06 +10:00
stats.py commit immediately when there's no active checkpoint 2021-03-10 11:47:53 +10:00
studydeck.py Merge pull request #1040 from RumovZ/deck-name-err 2021-03-01 09:40:55 +10:00
sync.py nest progress messages and remove Python wrapper class 2021-02-08 16:40:27 +10:00
tagedit.py convert qt strings to f-strings with flynt 2021-02-11 10:09:06 +10:00
taglimit.py convert qt strings to f-strings with flynt 2021-02-11 10:09:06 +10:00
taskman.py more typing updates 2021-02-02 23:31:55 +10:00
theme.py minor code cleanups with pyupgrade 2021-02-11 09:43:40 +10:00
toolbar.py minor code cleanups with pyupgrade 2021-02-11 09:43:40 +10:00
tts.py convert qt strings to f-strings with flynt 2021-02-11 10:09:06 +10:00
update.py more typing updates 2021-02-02 23:31:55 +10:00
utils.py Revert "Merge pull request #1066 from RumovZ/editor-save-dec" 2021-03-12 15:44:19 +10:00
webview.py convert qt strings to f-strings with flynt 2021-02-11 10:09:06 +10:00
wheel_description.txt move aqt_data into source folder; implement wheel building 2020-11-04 12:14:03 +10:00
winpaths.py convert qt strings to f-strings with flynt 2021-02-11 10:09:06 +10:00