97f43fbd45
Profiling revealed that binding to clientWidth for each component in the deck options was taking up a sizable amount of time, due to the inefficient way it's implemented: https://github.com/sveltejs/svelte/issues/7583 In one case, we can instead defer checking clientWidth until we go to display the popover. In the other case, we can achieve the revert button positioning a different way. The last change dropped the speed index in Chrome from 1.4s to 1s; this change brings it down to 0.7s. Also fixed the hovered select element from jiggling due to a different border width when hovering.
102 lines
2.3 KiB
Svelte
102 lines
2.3 KiB
Svelte
<!--
|
|
Copyright: Ankitects Pty Ltd and contributors
|
|
License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
|
|
-->
|
|
<script lang="ts">
|
|
export let id: string | undefined = undefined;
|
|
export let role: string | undefined = undefined;
|
|
export let selected = false;
|
|
let className = "";
|
|
export { className as class };
|
|
|
|
export let buttonRef: HTMLButtonElement | undefined = undefined;
|
|
|
|
export let tooltip: string | undefined = undefined;
|
|
|
|
export let active = false;
|
|
export let disabled = false;
|
|
|
|
const rtl: boolean = window.getComputedStyle(document.body).direction == "rtl";
|
|
|
|
$: if (buttonRef && active) {
|
|
buttonRef!.scrollIntoView({
|
|
behavior: "smooth",
|
|
block: "nearest",
|
|
});
|
|
}
|
|
|
|
export let tabbable = false;
|
|
</script>
|
|
|
|
<button
|
|
bind:this={buttonRef}
|
|
{id}
|
|
{role}
|
|
aria-selected={selected}
|
|
tabindex={tabbable ? 0 : -1}
|
|
class="dropdown-item {className}"
|
|
class:active
|
|
class:rtl
|
|
title={tooltip}
|
|
{disabled}
|
|
on:mouseenter
|
|
on:focus
|
|
on:keydown
|
|
on:click
|
|
on:mousedown|preventDefault
|
|
>
|
|
<slot />
|
|
</button>
|
|
|
|
<style lang="scss">
|
|
button {
|
|
display: flex;
|
|
justify-content: start;
|
|
width: 100%;
|
|
padding: 0.25rem 1rem;
|
|
white-space: nowrap;
|
|
font-size: var(--dropdown-font-size, small);
|
|
|
|
background: none;
|
|
box-shadow: none !important;
|
|
border: none;
|
|
border-radius: 0;
|
|
color: var(--fg);
|
|
|
|
&:hover {
|
|
border: none;
|
|
}
|
|
|
|
&:hover:not([disabled]) {
|
|
background: var(--highlight-bg);
|
|
color: var(--highlight-fg);
|
|
}
|
|
|
|
&.focus {
|
|
// TODO this is subtly different from hovering with the mouse for some reason
|
|
@extend button, :hover;
|
|
}
|
|
|
|
&[disabled] {
|
|
cursor: default;
|
|
color: var(--fg-disabled);
|
|
}
|
|
|
|
/* selection highlight */
|
|
&:not(.rtl) {
|
|
border-left: 3px solid transparent;
|
|
}
|
|
&.rtl {
|
|
border-right: 3px solid transparent;
|
|
}
|
|
&.active {
|
|
&:not(.rtl) {
|
|
border-left-color: var(--border-focus);
|
|
}
|
|
&.rtl {
|
|
border-right-color: var(--border-focus);
|
|
}
|
|
}
|
|
}
|
|
</style>
|