langfingaz/anki
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
2,059 Commits 1 Branch 1 Tag 37 MiB
Rust 45.4%
Python 30.8%
TypeScript 11%
Svelte 10.7%
SCSS 1.1%
Other 0.7%
c670dd65b4
Go to file
Arthur-Milchior c670dd65b4 Correct a bug during add-on update 
If an add-on folder contains only number, but does not contains a
meta.json file, or if this file does not contains a "mod" value, then
the following uninformative message error occur:
```Python
  File "aqt/addons.py", line 387, in onCheckForUpdates
  File "aqt/addons.py", line 183, in checkForUpdates
  File "aqt/addons.py", line 199, in _updatedIds
<class 'TypeError'>: '<' not supported between instances of 'NoneType' and 'int'
```

This is because there is a .get in a code while the None value makes
no sens. Thus, I replaced None by a 0 value. Which ensure that, if the
last modification time is missing, the update will be done. Three case
may occur:
* either the addon is already up to date, and it's only a waste of
  bandwidth
* either the add-on is not up to date, and updating was the initial
  goal anyway
* Or some change did occur in the add-on folder (which is actually
  probably, since it would explain the "missing mod problem"; in this
  case this change may be lost, but thout would be the same problem
  if the mod number was still there.

Other solutions which I could implement would be:
* asking for the user whether they want to update
* considering that it's not an ankiweb related add-on anymore, and
  ignore it.
2019-02-18 12:29:08 +01:00
anki style and arg order fix 2019-02-18 12:44:04 +10:00
aqt Correct a bug during add-on update 2019-02-18 12:29:08 +01:00
designer Use system-default fixed font for debug entry and log 2019-02-16 10:26:49 +01:00
tests fix importing unit test 2018-11-18 15:27:37 +10:00
tools use nosetests3 if available 2018-10-04 17:56:50 +10:00
web update copyright and clarify licenses 2019-02-05 14:01:33 +10:00
.gitignore include git hash in version info 2018-12-13 20:59:06 +10:00
.travis.yml no parallel processing in travis run 2018-01-27 19:06:49 +10:00
anki.1 merged libanki and ankiqt into single distro 2012-12-21 16:51:59 +09:00
anki.desktop update anki.desktop (thanks to julian) 2017-01-24 18:29:31 +10:00
anki.png merged libanki and ankiqt into single distro 2012-12-21 16:51:59 +09:00
anki.xml update file associations 2018-08-20 14:38:22 +10:00
anki.xpm merged libanki and ankiqt into single distro 2012-12-21 16:51:59 +09:00
LICENSE update copyright and clarify licenses 2019-02-05 14:01:33 +10:00
LICENSE.logo clarify logo license 2017-09-06 17:01:23 +10:00
Makefile add missing license file 2018-03-17 10:37:50 +10:00
pkgkey.asc add public key for release signing 2018-09-18 10:40:45 +10:00
README.contributing Update README.contributing 2018-07-10 09:13:10 -07:00
README.development Update pip command for PyQt packaging changes 2019-02-15 13:51:57 +01:00
README.md readme tweak 2017-08-16 20:02:09 +10:00
requirements.txt require psutil on win32 2019-02-16 13:03:16 +10:00
runanki explicit python3 in runanki, remove /usr/share ref 2016-06-28 15:47:09 +10:00

README.md

Anki

This is the development branch of Anki.

For stable builds, please see https://apps.ankiweb.net.

For non-developers who want to try this development code, the easiest way is to use a binary package - please see https://anki.tenderapp.com/discussions/beta-testing

To run from source, please see README.development.

Build Status