a3d9f90af5
ts_library() is deprecated and will presumably be dropped from a future rules_nodejs, and it wasn't working with the jest tests after updating, so we switch over to ts_project(). There are some downsides: - It's a bit slower, as the worker mode doesn't appear to function at the moment. - Getting it working with a mix of source files and generated files was quite tricky, especially as things behave differently on Windows, and differently when editing with VS Code. Solved with a small patch to the rules, and a wrapper script that copies everything into the bin folder first. To keep VS Code working correctly as well, the built files are symlinked into the source folder. - TS libraries are not implicitly linked to node_modules, so they can't be imported with an absolute name like "lib/proto" - we need to use relative paths like "../lib/proto" instead. Adjusting "paths" in tsconfig.json makes it work for TS compilation, but then it fails at the esbuild stage. We could resolve it by wrapping the TS libraries in a subsequent js_library() call, but that has the downside of losing the transient dependencies, meaning they need to be listed again. Alternatively we might be able to solve it in the future by adjusting esbuild, but for now the paths have been made relative to keep things simple. Upsides: - Along with updates to the Svelte tooling, Svelte typing has improved. All exports made in a Svelte file are now visible to other files that import them, and we no longer rebuild the Svelte files when TS files are updated, as the Svelte files do no type checking themselves, and are just a simple transpilation. Svelte-check now works on Windows again, and there should be no errors when editing in VS Code after you've built the project. The only downside seems to be that cmd+clicking on a Svelte imports jumps to the .d.ts file instead of the original now; presumably they'll fix that in a future plugin update. - Each subfolder now has its own tsconfig.json, and tsc can be called directly for testing purposes (but beware it will place build products in the source tree): ts/node_modules/.bin/tsc -b ts - We can drop the custom esbuild_toolchain, as it's included in the latest rules_nodejs. Other changes: - "image_module_support" is moved into lib/, and imported with <reference types=...> - Images are now imported directly from their npm package; the extra copy step has been removed. Windows users may need to use "bazel clean" before building this, due to old files lying around in the build folder.
223 lines
6.9 KiB
TypeScript
223 lines
6.9 KiB
TypeScript
// Copyright: Ankitects Pty Ltd and contributors
|
|
// License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
|
|
// languageServerHost taken from MIT sources - see below.
|
|
|
|
import * as fs from "fs";
|
|
import * as worker from "@bazel/worker";
|
|
import { svelte2tsx } from "svelte2tsx";
|
|
import preprocess from "svelte-preprocess";
|
|
import { basename } from "path";
|
|
import * as ts from "typescript";
|
|
import * as svelte from "svelte/compiler.js";
|
|
|
|
let parsedCommandLine: ts.ParsedCommandLine = {
|
|
fileNames: [],
|
|
errors: [],
|
|
options: {
|
|
jsx: ts.JsxEmit.Preserve,
|
|
declaration: true,
|
|
emitDeclarationOnly: true,
|
|
skipLibCheck: true,
|
|
},
|
|
};
|
|
|
|
// We avoid hitting the filesystem for ts/d.ts files after initial startup - the
|
|
// .ts file we generate can be injected directly into our cache, and Bazel
|
|
// should restart us if the Svelte or TS typings change.
|
|
|
|
interface FileContent {
|
|
text: string;
|
|
version: number;
|
|
}
|
|
const fileContent: Map<string, FileContent> = new Map();
|
|
|
|
function getFileContent(path: string): FileContent {
|
|
let content = fileContent.get(path);
|
|
if (!content) {
|
|
content = {
|
|
text: ts.sys.readFile(path)!,
|
|
version: 0,
|
|
};
|
|
fileContent.set(path, content);
|
|
}
|
|
return content;
|
|
}
|
|
|
|
function updateFileContent(path: string, text: string): void {
|
|
let content = fileContent.get(path);
|
|
if (content) {
|
|
content.text = text;
|
|
content.version += 1;
|
|
} else {
|
|
content = {
|
|
text,
|
|
version: 0,
|
|
};
|
|
fileContent.set(path, content);
|
|
}
|
|
}
|
|
|
|
// based on https://github.com/Asana/bazeltsc/blob/7dfa0ba2bd5eb9ee556e146df35cf793fad2d2c3/src/bazeltsc.ts (MIT)
|
|
const languageServiceHost: ts.LanguageServiceHost = {
|
|
getCompilationSettings: (): ts.CompilerOptions => parsedCommandLine.options,
|
|
getScriptFileNames: (): string[] => parsedCommandLine.fileNames,
|
|
getScriptVersion: (path: string): string => {
|
|
return getFileContent(path).version.toString();
|
|
},
|
|
getScriptSnapshot: (path: string): ts.IScriptSnapshot | undefined => {
|
|
// if (!ts.sys.fileExists(fileName)) {
|
|
const text = getFileContent(path).text;
|
|
return {
|
|
getText: (start: number, end: number) => {
|
|
if (start === 0 && end === text.length) {
|
|
// optimization
|
|
return text;
|
|
} else {
|
|
return text.slice(start, end);
|
|
}
|
|
},
|
|
getLength: () => text.length,
|
|
getChangeRange: (
|
|
oldSnapshot: ts.IScriptSnapshot
|
|
): ts.TextChangeRange | undefined => {
|
|
return undefined;
|
|
},
|
|
};
|
|
},
|
|
getCurrentDirectory: ts.sys.getCurrentDirectory,
|
|
getDefaultLibFileName: ts.getDefaultLibFilePath,
|
|
};
|
|
|
|
const languageService = ts.createLanguageService(languageServiceHost);
|
|
|
|
function compile(tsPath: string) {
|
|
parsedCommandLine.fileNames = [tsPath];
|
|
const program = languageService.getProgram()!;
|
|
const tsHost = ts.createCompilerHost(parsedCommandLine.options);
|
|
const createdFiles = {};
|
|
tsHost.writeFile = (fileName, contents) => (createdFiles[fileName] = contents);
|
|
program.emit(undefined /* all files */, tsHost.writeFile);
|
|
return createdFiles[parsedCommandLine.fileNames[0].replace(".tsx", ".d.ts")];
|
|
}
|
|
|
|
function writeFile(file, data): Promise<void> {
|
|
return new Promise((resolve, reject) => {
|
|
fs.writeFile(file, data, (err) => {
|
|
if (err) {
|
|
reject(err);
|
|
return;
|
|
}
|
|
resolve();
|
|
});
|
|
});
|
|
}
|
|
|
|
function readFile(file) {
|
|
return new Promise((resolve, reject) => {
|
|
fs.readFile(file, "utf8", (err, data) => {
|
|
if (err) {
|
|
reject(err);
|
|
return;
|
|
}
|
|
resolve(data);
|
|
});
|
|
});
|
|
}
|
|
|
|
async function writeDts(tsPath, dtsPath) {
|
|
const dtsSource = compile(tsPath);
|
|
await writeFile(dtsPath, dtsSource);
|
|
}
|
|
|
|
function writeTs(svelteSource, sveltePath, tsPath): void {
|
|
let tsSource = svelte2tsx(svelteSource, {
|
|
filename: sveltePath,
|
|
isTsFile: true,
|
|
mode: "dts",
|
|
});
|
|
let codeLines = tsSource.code.split("\n");
|
|
updateFileContent(tsPath, codeLines.join("\n"));
|
|
}
|
|
|
|
async function writeJs(
|
|
source: string,
|
|
inputFilename: string,
|
|
outputJsPath: string,
|
|
outputCssPath: string,
|
|
binDir: string,
|
|
genDir: string
|
|
): Promise<void> {
|
|
const preprocessOptions = preprocess({
|
|
scss: {
|
|
includePaths: [
|
|
"ts/sass",
|
|
`${binDir}/ts/sass`,
|
|
`${genDir}/ts/sass`,
|
|
// a nasty hack to ensure ts/sass/... resolves correctly
|
|
// when invoked from an external workspace
|
|
`${binDir}/external/ankidesktop/ts/sass`,
|
|
`${genDir}/external/ankidesktop/ts/sass`,
|
|
`${binDir}/../../../external/ankidesktop/ts/sass`,
|
|
],
|
|
},
|
|
});
|
|
|
|
try {
|
|
const processed = await svelte.preprocess(source, preprocessOptions, {
|
|
filename: inputFilename,
|
|
});
|
|
const result = svelte.compile(processed.toString!(), {
|
|
format: "esm",
|
|
css: false,
|
|
generate: "dom",
|
|
filename: outputJsPath,
|
|
});
|
|
// warnings are an error
|
|
if (result.warnings.length > 0) {
|
|
console.log(`warnings during compile: ${result.warnings}`);
|
|
}
|
|
// write out the css file
|
|
const outputCss = result.css.code ?? "";
|
|
await writeFile(outputCssPath, outputCss);
|
|
// if it was non-empty, prepend a reference to it in the js file, so that
|
|
// it's included in the bundled .css when bundling
|
|
const outputSource =
|
|
(outputCss ? `import "./${basename(outputCssPath)}";` : "") +
|
|
result.js.code;
|
|
await writeFile(outputJsPath, outputSource);
|
|
} catch (err) {
|
|
console.log(`compile failed: ${err}`);
|
|
return;
|
|
}
|
|
}
|
|
|
|
async function compileSvelte(args) {
|
|
const [sveltePath, mjsPath, dtsPath, cssPath, binDir, genDir] = args;
|
|
const svelteSource = (await readFile(sveltePath)) as string;
|
|
|
|
const mockTsPath = sveltePath + ".tsx";
|
|
writeTs(svelteSource, sveltePath, mockTsPath);
|
|
await writeDts(mockTsPath, dtsPath);
|
|
await writeJs(svelteSource, sveltePath, mjsPath, cssPath, binDir, genDir);
|
|
|
|
return true;
|
|
}
|
|
|
|
function main() {
|
|
if (worker.runAsWorker(process.argv)) {
|
|
console.log = worker.log;
|
|
worker.log("Svelte running as a Bazel worker");
|
|
worker.runWorkerLoop(compileSvelte);
|
|
} else {
|
|
const paramFile = process.argv[2].replace(/^@/, "");
|
|
const commandLineArgs = fs.readFileSync(paramFile, "utf-8").trim().split("\n");
|
|
console.log("Svelte running as a standalone process");
|
|
compileSvelte(commandLineArgs);
|
|
}
|
|
}
|
|
|
|
if (require.main === module) {
|
|
main();
|
|
process.exitCode = 0;
|
|
}
|