Henrik Giesel
37ed3e8209
Fix some code quality issues
2021-04-15 13:09:49 +02:00
Henrik Giesel
96feba7a3e
Pass in buttons and menus directly as stores
2021-04-15 13:09:49 +02:00
Henrik Giesel
8b906100c0
Make --toolbar-size a parameter
2021-04-15 13:09:49 +02:00
Henrik Giesel
9cbab08b00
Add ButtonDropdown for dropdowns like the MathJax dropdown on AnkiMobile
2021-04-15 13:09:49 +02:00
Henrik Giesel
6953389798
Add exports for add-ons
2021-04-15 13:09:49 +02:00
Henrik Giesel
45992b68cd
Make it easier to update buttons and menus
2021-04-15 13:09:49 +02:00
Henrik Giesel
7f42b38e7a
Add labels and titles to all buttons
2021-04-15 13:09:49 +02:00
Henrik Giesel
216b93c060
Add titles to buttons with lazyProperties
2021-04-15 13:09:49 +02:00
Henrik Giesel
4e6d5d9adb
Move logic from index.ts to their individual files
2021-04-15 13:09:49 +02:00
Henrik Giesel
3ddbc1e6c3
Add first lazily loaded i18n strings
2021-04-15 13:09:49 +02:00
Henrik Giesel
9b68a5c2c3
Give select an effect on :hover
2021-04-15 13:09:49 +02:00
Henrik Giesel
5f498e6142
Make select display inline-block
2021-04-15 13:09:49 +02:00
Henrik Giesel
fb668c56e6
Make Toolbar resizable through a single CSS variable --toolbar-size
2021-04-15 13:09:49 +02:00
Henrik Giesel
f526b51ea2
Add SelectButton
2021-04-15 13:09:49 +02:00
Henrik Giesel
fa900e1565
Add dropdown menu to mathjax button
2021-04-15 13:09:49 +02:00
Henrik Giesel
391f64f648
Make it so you can include DropdownMenus on all kinds of buttons
2021-04-15 13:09:49 +02:00
Henrik Giesel
5eb07d3fc7
WIP: Turn DropdownMenu into a _decorator_ usable with all other button types
2021-04-15 13:09:49 +02:00
Henrik Giesel
a820059b8f
Utilize enableButtons disableButtons from Svelte component
2021-04-15 13:09:49 +02:00
Henrik Giesel
9340d20c20
Display .active:active as :hover buttons
2021-04-15 13:09:49 +02:00
Henrik Giesel
4280bf28f8
Add active shadow on ColorPicker
2021-04-15 13:09:49 +02:00
Henrik Giesel
e25583d7ff
Move display:flex from outer div to ButtonGroup ul
2021-04-15 13:09:49 +02:00
Henrik Giesel
7f5e9b1b33
Add negative tabindex
2021-04-15 13:09:49 +02:00
Henrik Giesel
b5b9c79f1c
Add mathjaxButton and htmlButton instead of more button
2021-04-15 13:09:49 +02:00
Henrik Giesel
77de6c0288
Make icons slightly smaller, so they are the same size as before
2021-04-15 13:09:49 +02:00
Henrik Giesel
12021228a5
Make all buttons functional
2021-04-15 13:09:49 +02:00
Henrik Giesel
2f808fe60c
Move initialization logic from EditorToolbar to index.ts
2021-04-15 13:09:49 +02:00
Henrik Giesel
bf433f13be
Simplify General Toolbar structure
2021-04-15 13:09:49 +02:00
Henrik Giesel
773f431bb8
Merge buttons to one OuterButtonGroup
...
- keeping up the concept of left / right buttons might not be necessary anymore
- This might make it easier to display them on mobile, and simplifies the logic
2021-04-15 13:09:49 +02:00
Henrik Giesel
8c931af17c
Make all Leaf buttons 30px high and give same vertical-align
2021-04-15 13:09:49 +02:00
Henrik Giesel
0269c97b2e
Rename IconButtonInner to InnerButton, as it does not necessarily contain an Icon
2021-04-15 13:09:49 +02:00
Henrik Giesel
a12e39a15f
Add hover and active effects
2021-04-15 13:09:49 +02:00
Henrik Giesel
b26c4294ec
Display ButtonGroups inline-block
2021-04-15 13:09:49 +02:00
Henrik Giesel
9563da37d3
Add ButtonGroup for grouping of toolbar items
2021-04-15 13:09:49 +02:00
Henrik Giesel
ccb7c5d68a
Add CommandIconButton functionality
2021-04-15 13:09:49 +02:00
Henrik Giesel
0963d53e0c
Add color.ts for foreground color and color picker
2021-04-15 13:09:49 +02:00
Henrik Giesel
fee78d2570
Add remaining icons for toolbar
2021-04-15 13:09:49 +02:00
Henrik Giesel
a0a9619722
Include icons directly in ts lib
2021-04-15 13:09:49 +02:00
Henrik Giesel
7787a7827f
First implementation
2021-04-15 13:09:48 +02:00
Henrik Giesel
de77e40e4d
Add ts/editor-toolbar
2021-04-15 13:09:48 +02:00
Damien Elmes
6f3e682c9f
move bootstrap into ts/sass
2021-04-15 16:10:01 +10:00
Damien Elmes
b0206ec1bf
support external building of sass; node_modules->ts/bootstrap
2021-04-15 15:59:17 +10:00
Damien Elmes
6cee43631a
allow passing sass deps to svelte compile/check
2021-04-15 14:27:53 +10:00
Damien Elmes
2d417b1160
update other ts deps
2021-04-15 10:59:29 +10:00
Damien Elmes
121e8db22a
remove unused esbuild package, and update rules_nodejs packages
2021-04-15 10:57:19 +10:00
Damien Elmes
13d415f8e3
move esbuild into separate repo
...
Most of our changes have been upstreamed, but the toolchain change
probably won't be merged soon, and a separate git repo will make it
easier to track upstream changes.
@hgiesel output_css=True will need to be changed to output_css="foo.css"
instead
2021-04-15 10:53:49 +10:00
Damien Elmes
b9b1fe81b1
fix initial ease not being updated
2021-04-14 23:01:03 +10:00
Damien Elmes
7f738c11a2
deck config prototype work in progress
...
Still in the early stages, and not hooked up yet.
2021-04-14 22:33:10 +10:00
Damien Elmes
e6306bb29d
Merge pull request #1128 from hgiesel/webviewcss3
...
Remove unnecessary exports from sass/BUILD.bazel
2021-04-14 21:28:25 +10:00
Damien Elmes
646b58a1a9
experiment with making bootstrap scss available as a library
...
This will allow us to import the local sass lib, then use something
like the following in our sass:
@import "ts/bootstrap/functions";
@import "ts/bootstrap/variables";
@import "ts/bootstrap/mixins";
@import "ts/bootstrap/helpers";
@import "ts/bootstrap/dropdown";
@import "ts/bootstrap/forms";
@import "ts/bootstrap/buttons";
@import "ts/bootstrap/button-group";
I'm currently trialing it out on a prototype reimplementation of the
deck options screen. Unfortunately bootstrap don't seem to support the
@use syntax, so we need to @import everything
2021-04-14 21:27:34 +10:00
Henrik Giesel
a9439eaf02
Remove unnecessary exports from sass/BUILD.bazel
...
I think these were just part of an unsuccessful experiment
Partially reverses cfb9ed267f
2021-04-14 12:31:42 +02:00
Damien Elmes
cca9195ea5
run prettier on some sass files
2021-04-14 18:22:33 +10:00
Damien Elmes
c49d6ce49f
run black/isort on Python scripts
2021-04-14 18:22:02 +10:00
Damien Elmes
7b2b4528b3
Merge pull request #1125 from hgiesel/scrollbarcorner
...
Color Scrollbar bottom right corner
2021-04-14 12:43:34 +10:00
Henrik Giesel
f891a98087
Color in the Scrollbar corner at the bottom right into the appropriate color
2021-04-13 21:41:15 +02:00
Henrik Giesel
cfb9ed267f
Create explicit dependencies for the congrats,editor,graphs scss files
2021-04-13 19:47:03 +02:00
Henrik Giesel
a76f1d64ad
Move compile_sass.bzl to /ts + Remove core.css from data/web (unused?)
2021-04-13 19:47:03 +02:00
Henrik Giesel
ffd159f9a0
Declare dependencies in data/web/css
2021-04-13 19:47:03 +02:00
Henrik Giesel
85808e4cbf
Make h1 explicitly bold in Graph.svelte
2021-04-13 19:47:03 +02:00
Henrik Giesel
8f0f8f9af8
Use graphs-base and congrats-base
2021-04-13 19:47:03 +02:00
Henrik Giesel
fee6ee7319
Do not include webview.css for editor
2021-04-13 19:47:03 +02:00
Henrik Giesel
825509ba0c
Move card_counts and split off fusion_vars
2021-04-13 19:47:03 +02:00
Henrik Giesel
fbc21f0090
Add base.scss
2021-04-13 19:47:03 +02:00
Damien Elmes
62423bd041
add missing copyright headers to *.svelte
2021-04-13 19:02:41 +10:00
Damien Elmes
e520e8df02
add missing copyright headers to *.ts
2021-04-13 18:57:08 +10:00
Damien Elmes
26ac64526c
disable Jest tests on Windows again
...
It looks like the templated_args change only masked the error last time;
Jest seems broken on Windows with both the patched .24 version, latest
stable, and the new beta version too, presumably because symlinks are
being handled differently on Windows somehow. It might be possible to
hack around the issue by patching the following file, but I'm not sure:
https://github.com/facebook/jest/blob/master/packages/jest-haste-map/src/crawlers/node.ts
2021-04-12 15:39:46 +10:00
Damien Elmes
9440898e60
add naturalWholeUnit() and basic tests to lib/time.ts
...
naturalWholeUnit() is not currently used
2021-04-12 14:42:06 +10:00
Damien Elmes
829b99e5b2
force number in protobuf generation
...
Anki's object IDs and millisecond timestamps fit within MAX_SAFE_INTEGER.
2021-04-12 14:33:20 +10:00
Damien Elmes
6e4cdc52a6
stop Svelte warnings from failing the build
...
+ check for them at test time
2021-04-12 14:28:09 +10:00
Damien Elmes
94330fc0eb
fix jest
...
- templated_args was missing --node_modules= prefix, and was causing
tests to pass unconditionally
- update to beta of jest 27, which introduces an option to fix the
symlink handling, and is approx twice as fast to start up
2021-04-12 09:43:31 +10:00
Damien Elmes
c1c14419a2
switch esbuild to a toolchain
2021-04-07 15:19:23 +10:00
Damien Elmes
4975f47ea3
update to latest esbuild
2021-04-07 14:54:40 +10:00
abdo
09985ce57f
Fix graph labels display in RTL layout
2021-04-02 06:25:38 +03:00
Damien Elmes
ddcb2adf71
add docstring to forEditorField
2021-03-29 18:13:45 +10:00
Damien Elmes
0e4bcbd69b
Merge pull request #1101 from Arthur-Milchior/TS_type
...
NF: add type ts
2021-03-29 18:09:56 +10:00
Damien Elmes
f1780e6e24
move loader arg into esbuild() invocation
...
upstream.bzl should be kept as close to upstream as possible, so that
it's easier to send changes upstream and pull in future changes
2021-03-29 17:59:06 +10:00
Arthur Milchior
a114f36b4c
NF: add type ts
2021-03-28 23:59:16 +02:00
Henrik Giesel
922ee56ce8
Add copy_bootstrap_icons macro
2021-03-28 18:50:37 +02:00
Henrik Giesel
7dcb3ae678
Include pin-angle icon via inline SVG
2021-03-28 16:15:30 +02:00
Damien Elmes
dbfbcc36c6
define file extension in .d.ts so typescript doesn't complain
2021-03-28 16:15:28 +02:00
Henrik Giesel
3a44ffe2bb
Unsuccessfully try to add text loader for .svg files
2021-03-28 16:14:52 +02:00
Henrik Giesel
bbea9ac9d7
Remove bootstrap-icons from css folder
2021-03-28 16:14:52 +02:00
Damien Elmes
0d49b3eabb
move back to latest Jest
...
Patch is no longer required after previous change
2021-03-28 21:44:55 +10:00
Damien Elmes
493557aee7
fix Jest on Windows
2021-03-28 20:59:51 +10:00
Damien Elmes
f46f4cbf17
Revert "disable Jest tests on Windows for now"
...
This reverts commit 36022844bb
.
2021-03-28 20:59:31 +10:00
Damien Elmes
36022844bb
disable Jest tests on Windows for now
2021-03-28 20:34:10 +10:00
Damien Elmes
c891f45ed9
add Jest for TS unit tests
...
@hgiesel the reason no files were being found is because Jest ignores
symlinks by default. The Bazel example includes a patch we can use
to work around it, and Jest plan to add symlink support in a future
update.
https://github.com/bazelbuild/rules_nodejs/blob/stable/examples/jest/patches/jest-haste-map%2B24.9.0.patch
https://github.com/facebook/jest/pull/9351
2021-03-28 19:41:20 +10:00
Henrik Giesel
05ea624f85
Utilize ts/tsconfig.js from ts/{editor,html-filter}
2021-03-28 19:41:20 +10:00
Henrik Giesel
fb9461508e
No need to explicitly import from index
2021-03-28 19:41:20 +10:00
Henrik Giesel
35beebcfa6
Satisfy formatter
2021-03-28 19:41:20 +10:00
Henrik Giesel
861c723ec0
Avoid using outerHTML + Fix regression
2021-03-28 19:41:20 +10:00
Henrik Giesel
f9259621a6
Change filter logic in html-filter/element: predicate true, means it stays in
2021-03-28 19:41:20 +10:00
Henrik Giesel
519aea2ea8
Move html-filter into its own directory
2021-03-28 19:41:20 +10:00
Henrik Giesel
730dfdd527
Insert break statements into switch
2021-03-28 19:41:20 +10:00
Henrik Giesel
39aa549ac9
Create htmlFilter{Node,Styling} for better separation of concerns
2021-03-28 19:41:20 +10:00
Henrik Giesel
d3d3720b39
Put filterElement logic completely into its own file
2021-03-28 19:41:20 +10:00
Henrik Giesel
1d4d7fabec
Move most of tags allowed to its own file
2021-03-28 19:41:20 +10:00
Henrik Giesel
592d73c344
Refactor htmlFilter to use function declarations
2021-03-28 19:41:20 +10:00
Damien Elmes
76127126a6
use relative link to sass file
...
links relative to workspace root break when invoked from an external
repo
2021-03-28 12:37:21 +10:00
Damien Elmes
f3a3bb5467
add links to pending PRs
2021-03-28 12:32:40 +10:00
Damien Elmes
559d1a4793
fix(esbuild): files not being found when building external repo
...
An esbuild rule that ran fine in a local repo (eg bazel build //:my_esbuild_rule)
fails when built externally (eg bazel build @other_workspace//:my_esbuild_rule).
By prepending the workspace root to the bin path, the resulting base
URL works correctly in both local and remote repo invocations, allowing
esbuild output to be consumed by a different repo.
This change fixes remote repos in Bazel 4.0.0. 3.7.0 seems to require a
workspace_root.replace("external/", "") call first in order
to get the correct location. So while this patch should not break anything
that was not already broken, it only fixes/adds support for remote repos
in 4.0+.
2021-03-28 11:30:15 +10:00