Commit Graph

4240 Commits

Author SHA1 Message Date
Damien Elmes
a4d33dbdb0 report filename when unable to read data 2020-04-30 08:02:08 +10:00
Damien Elmes
18a6218a77 don't throw an error when a file is greater than MAXPATH
https://anki.tenderapp.com/discussions/ankidesktop/40931-check-media-error
2020-04-30 08:01:45 +10:00
Damien Elmes
4e33775ed4 drop type answer requirement special case
While it makes no sense to have the typing box on the front without
another non-empty field, "the front of this card is empty" when
a typing box is on the template seems to be confusing some users, so
it is clearer to show them the box.
2020-04-29 21:29:16 +10:00
Damien Elmes
d36bd33972 AnkiDroid expects timer to be an integer
https://github.com/ankidroid/Anki-Android/issues/6089#issuecomment-621110598
2020-04-29 20:52:00 +10:00
Damien Elmes
913c268705
Merge pull request #592 from BlueGreenMagick/tabwidth
Set tab width to 4 spaces
2020-04-29 18:32:40 +10:00
Damien Elmes
92292c8c05
Merge pull request #595 from evandroforks/set_github_actions_cache
Reset the GitHub Actions cache for pyenv for
2020-04-29 18:18:50 +10:00
Damien Elmes
6268d57b84
Merge pull request #596 from evandroforks/make_github_actions_name_pretty
Make the checks.yml OS name prettier
2020-04-29 18:16:16 +10:00
Damien Elmes
ff72325f05
Merge pull request #593 from evandroforks/add_generated_file_warning
Added an warning that rslib/build.rs is automatically generating file
2020-04-29 18:15:56 +10:00
evandrocoan
4e8bca2c3d Make the checks.yml OS name prettier 2020-04-29 03:38:40 -03:00
evandrocoan
14c85a56ee Reset the GitHub Actions cache for pyenv for
Fix astroid update breaking build
https://github.com/ankitects/pylint/pull/1
2020-04-29 03:22:12 -03:00
evandrocoan
f6f1e3cbb3 Added an warning that rslib/build.rs is automatically generated file 2020-04-29 01:21:49 -03:00
BlueGreenMagick
be6a5e2f13 Set tab width to 4 spaces
setTabStopWidth is deprecated, and setTabStopDistance is preferred
It's not entirely accurate however, which you can see
when you compare 10 tabs and 40 spaces
2020-04-29 11:34:09 +09:00
Damien Elmes
00cf4fc585 bump version 2020-04-28 08:57:56 +10:00
Arthur Milchior
3378daeca3 remove an useless asignment
Because fields of new notes are empty by default
2020-04-28 00:31:30 +02:00
Arthur Milchior
93d83e760b remove a try, for code clarity 2020-04-28 00:31:24 +02:00
Damien Elmes
0c8f6ced09 Revert "Merge pull request #583 from Arthur-Milchior/remove_a_try"
This reverts commit e9ca61d1eb, reversing
changes made to abb80231a5.
2020-04-28 07:38:23 +10:00
Arthur Milchior
e86817305a mw.debug_diag is the dialog and not the window
This will allow, for example, for add-ons to do self.debugDiag.text
and access the debugger text. I see very little reason to have a
direct access to the dialog window.

I should note that self.debugDiag is never used anywhere in the code,
so I think it should be deleted; unless you've heard of some add-on
using it.
2020-04-27 11:55:33 +02:00
Damien Elmes
01fc958c0e
Merge pull request #587 from BlueGreenMagick/tags
remove unnecessary code
2020-04-27 19:25:42 +10:00
Damien Elmes
e9ca61d1eb
Merge pull request #583 from Arthur-Milchior/remove_a_try
Simplify the code slightly
2020-04-27 19:12:00 +10:00
Damien Elmes
abb80231a5
Merge pull request #582 from evandroforks/fix_make_clean
Fixed make clean rule not working on Windows
2020-04-27 19:10:21 +10:00
Damien Elmes
5746302817
Merge pull request #581 from BlueGreenMagick/use-var-name
use variable names
2020-04-27 19:10:04 +10:00
Damien Elmes
3c36b7cf81
Merge pull request #579 from evandroforks/fix_msgmerge_not_failing_on_error
Fix msgmerge not failing on error
2020-04-27 19:05:27 +10:00
Damien Elmes
c35a25790b
Merge pull request #578 from evandroforks/fix_makefile_comments
Fixed Makefile comments showing up on the console
2020-04-27 19:05:03 +10:00
BlueGreenMagick
55eb0d1e68 remove unnecessary code 2020-04-27 10:05:38 +09:00
Arthur Milchior
31164adaec addButton always save function 2020-04-26 17:01:47 +02:00
Arthur Milchior
e4a0ccc059 remove an useless asignment
Because fields of new notes are empty by default
2020-04-26 14:49:16 +02:00
Arthur Milchior
1771be8f1e remove a try, for code clarity 2020-04-26 14:49:11 +02:00
BlueGreenMagick
f23a361876 use variable names 2020-04-26 15:47:19 +09:00
evandrocoan
26480fb13c Fixed make clean rule not working on Windows 2020-04-26 03:02:02 -03:00
evandrocoan
06056236c0 Fixed build-mo-files not failing the build when msgmerge
is not found:
https://github.com/ankitects/anki/runs/617116053?check_suite_focus=true#step:27:1244

The build was not falling because when you do `(commands)` in a
shell script, the `set -e` directive is not inherited. Then, either
do not start a new shell or just use an if to test the error condition.
2020-04-25 05:17:24 -03:00
evandrocoan
aca5d177bf Fix macos not find gettex, msgfmt: command not found
https://github.com/ankitects/anki/runs/617116053?check_suite_focus=true#step:27:1244
Compiling *.po...
./scripts/build-mo-files: line 18: msgfmt: command not found
./scripts/build-mo-files: line 18: msgmerge: command not found
2020-04-25 05:17:18 -03:00
evandrocoan
7099259afa Fixed Makefile comments showing up on the console
Makefile comments inside rules have to be put in the beginning
of the line, otherwise they are passed to shell when running the
recipe.
2020-04-24 21:48:46 -03:00
Damien Elmes
359b9f5cd5 use same cargo rspy target dir for wheel build 2020-04-25 10:08:24 +10:00
Damien Elmes
8dfd362fed support globbing chars inside word boundary search 2020-04-25 09:43:08 +10:00
Damien Elmes
fd844a0d5a add w: shortcut for searching on word boundaries 2020-04-25 08:48:01 +10:00
Damien Elmes
9dcbb8958d
Merge pull request #576 from evandroforks/fix_ripgrep_not_failing
trailing-newlines.sh should exit with error code 1
2020-04-23 20:02:50 +10:00
Damien Elmes
361959bdc4
Merge pull request #573 from evandroforks/printWidth100
Set .prettierrc printWidth to 88 because the default is too short
2020-04-23 20:01:58 +10:00
evandrocoan
51ec5d0fa9 Set .prettierrc printWidth to 88 because the default is too short 2020-04-22 23:11:03 -03:00
evandrocoan
a5061b5a34 trailing-newlines.sh should exit with error code 1 otherwise
the script will not fail/stop.
2020-04-22 20:08:17 -03:00
Damien Elmes
1661cad801
Merge pull request #574 from evandroforks/fix_ubunut_ripgrep
Fixed ripgrep not installing on ubuntu anymore
2020-04-21 13:50:26 +10:00
evandrocoan
e46421c7c9 Fixed ripgrep not installing on ubuntu anymore
https://github.com/BurntSushi/ripgrep#installation
https://github.com/BurntSushi/ripgrep/issues/1232

N.B. Various snaps for ripgrep on Ubuntu are also available, but none of them seem to work right and generate a number of very strange bug reports that I don't know how to fix and don't have the time to fix. Therefore, it is no longer a recommended installation option.)
2020-04-20 20:28:38 -03:00
Damien Elmes
4b8cf631d5 add selectable flag while preserving link clicking
https://anki.tenderapp.com/discussions/beta-testing/1920-config-can-copy-paste-but-cant-click-links-now
2020-04-21 09:11:56 +10:00
Damien Elmes
ce589fb975 Revert "Merge pull request #562 from ijgnd/master"
This reverts commit 4fb9dc734b, reversing
changes made to c8fb409a49.

https://anki.tenderapp.com/discussions/beta-testing/1920-config-can-copy-paste-but-cant-click-links-now
2020-04-21 09:10:45 +10:00
Damien Elmes
683f664d85 fix deleting deck configs 2020-04-20 13:23:05 +10:00
Damien Elmes
335815ab9c fix renaming not updating dropdown 2020-04-20 13:17:55 +10:00
Damien Elmes
c023bdd78e fix adding deck configs 2020-04-20 13:15:23 +10:00
Damien Elmes
ec6c0f86fb remove python version debugging from ./run 2020-04-20 11:21:27 +10:00
Damien Elmes
385dbf88c3
Merge pull request #569 from evandroforks/limit_error_message_size
Also limit the size of the error message
2020-04-20 11:14:53 +10:00
Damien Elmes
87f9131fbc
Merge pull request #568 from zenogantner/patch-3
make links to README.{development,contributing}
2020-04-20 11:14:21 +10:00
Damien Elmes
2939931004 split scheduling prefs into separate tab
https://anki.tenderapp.com/discussions/ankidesktop/40610-windows-anki-everything-was-enlarged-to-150
https://anki.tenderapp.com/discussions/beta-testing/1916-preferences-screen-partly-invisible
2020-04-20 11:11:00 +10:00