langfingaz/anki
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
9,488 Commits 2 Branches 2 Tags 39 MiB
d6b8520d03
Commit Graph

1590 Commits

Author SHA1 Message Date
Henrik Giesel
c63e0abd68
Fix prettier after moving node_modules to repo dir (#1413) 2021-10-09 10:13:14 +10:00
Henrik Giesel
dec0fbe845
Refactor i18n (#1405) 
Merging note: the typing changes were fixed in a separate PR.

* Put rootDirs into subprojects

- typings do not work for any ts or svelte files
- if we set the 'rootDirs' in ts/tsconfig.json to '../bazel-bin/ts' and then inherit
  them from e.g. editor, the root will be changed to '../../bazel-bin/ts',
  however editor needs look in '../../bazel-bin/ts/editor' instead.

* Rename i18n and i18n_helpers to i18n-generated and i18n

- This way, we can restrict the awkwardness of importing files outside
  the ts directory within lib

* Fix missing typing of i18n and backend_proto by adding back symlinks

* Split up i18n-generated into i18n-{translate,modules}

* Change i18n from singleton to functions

* Revert "Put rootDirs into subprojects"

This partially reverts commit e1d4292ce3979e7b7ee21bf3951b8a462d45c29c.

It seems like this might not be necessary after all.
However some other change made on this branch seems to have fixed
the .svelte.d.ts imports

* Introduce i18n-bundles to remove circular import

There was a circular import i18n.ts <-> i18n-translate.ts

* Create own directory for i18n

* Move lib/i18n/translate to lib/translate

* This restores tree shaking

* Update tsconfig libs and module

* es2018-2020 have wide support on all modern browsers including

* Switch bundles and langs inside i18n to variables again

* Add missing copyright header

* Rename translate.ts to ftl.ts

* Remove the symlinks again

I added them to fix to have completion for tr, however this would have
also have meant to abandon the tree shaking.
As we want to have tree shaking, it's also not necessary to have the
symlinks anymore

* Revert "Update tsconfig libs and module"

This reverts commit 0a96776a475e9901c1f9f3407c726d1d002fb9ef.

* move withCollapsedWhitespace back to i18n/utils

* Add back /ts as in rootDirs
 2021-10-07 23:31:49 +10:00
Damien Elmes
79ceb89637 svelte needs its shims to generate prop typing 
I erroneously removed them near the end of the ts_project work, and
didn't realise the properties had broken.
 2021-10-07 21:33:21 +10:00
Damien Elmes
1aaf8fce1e fix invalid arg to ButtonGroup revealed by typing fix 2021-10-07 21:33:15 +10:00
Damien Elmes
46b80ca773 move node_modules into root folder [action required] 
Recommend removing ts/node_modules folder before attempting to
build after this update.

This moves ts/node_modules into the root of the project to work around
https://github.com/ankitects/anki/pull/1405#issuecomment-936213861

Also fixes the sass errors shown when running scripts/svelte-check
 2021-10-07 11:42:27 +10:00
Damien Elmes
046c6c55d3 use extra rootDir in tsconfig instead of symlinks 
The nice thing about the symlink approach is that it allowed tsc -b
to function without any changes to the tsconfig.json file, but it meant
there were extra links we had to maintain. So instead, we just add an
extra rootDirs entry, and add two commented-out lines that can be
uncommented when wanting to build with tsc directly.
 2021-10-01 18:36:52 +10:00
Damien Elmes
e9d71bfbe4 yarn upgrade --latest 
bootstrap still held back
 2021-10-01 12:52:53 +10:00
Damien Elmes
a3d9f90af5 update to latest rules_nodejs & switch to ts_project 
ts_library() is deprecated and will presumably be dropped from a
future rules_nodejs, and it wasn't working with the jest tests
after updating, so we switch over to ts_project().

There are some downsides:

- It's a bit slower, as the worker mode doesn't appear to function
at the moment.
- Getting it working with a mix of source files and generated files
was quite tricky, especially as things behave differently on Windows,
and differently when editing with VS Code. Solved with a small patch
to the rules, and a wrapper script that copies everything into the
bin folder first. To keep VS Code working correctly as well, the built
files are symlinked into the source folder.
- TS libraries are not implicitly linked to node_modules, so they
can't be imported with an absolute name like "lib/proto" - we need
to use relative paths like "../lib/proto" instead. Adjusting "paths"
in tsconfig.json makes it work for TS compilation, but then it fails
at the esbuild stage. We could resolve it by wrapping the TS
libraries in a subsequent js_library() call, but that has the downside
of losing the transient dependencies, meaning they need to be listed
again.  Alternatively we might be able to solve it in the future by
adjusting esbuild, but for now the paths have been made relative to
keep things simple.

Upsides:

- Along with updates to the Svelte tooling, Svelte typing has improved.
All exports made in a Svelte file are now visible to other files that
import them, and we no longer rebuild the Svelte files when TS files
are updated, as the Svelte files do no type checking themselves, and
are just a simple transpilation. Svelte-check now works on Windows again,
and there should be no errors when editing in VS Code after you've
built the project. The only downside seems to be that cmd+clicking
on a Svelte imports jumps to the .d.ts file instead of the original now;
presumably they'll fix that in a future plugin update.
- Each subfolder now has its own tsconfig.json, and tsc can be called
directly for testing purposes (but beware it will place build products
in the source tree): ts/node_modules/.bin/tsc -b ts
- We can drop the custom esbuild_toolchain, as it's included in the
latest rules_nodejs.

Other changes:

- "image_module_support" is moved into lib/, and imported with
<reference types=...>
- Images are now imported directly from their npm package; the
extra copy step has been removed.

Windows users may need to use "bazel clean" before building this,
due to old files lying around in the build folder.
 2021-10-01 12:52:53 +10:00
Damien Elmes
e46ca4ee54 update svelte-check 
Invoking from scripts/svelte-check is currently broken due to sass
imports - it appears to have been broken some time back.
 2021-09-29 12:27:27 +10:00
Damien Elmes
604247482d handle changed aria-expanded typing 2021-09-29 12:20:27 +10:00
Damien Elmes
d44b49294b make 'for' argument optional in TooltipLabel 
The latest svelte-check has revealed we were not passing 'for' in
when we should have been. This is a quick hack to get the tests passing
again, but a better approach that actually makes this accessible again
would be good in the future.
 2021-09-29 12:20:03 +10:00
Damien Elmes
04ba24cb54 silence execCommand deprecation warnings for now 2021-09-29 11:36:37 +10:00
Damien Elmes
e660e0a3e5 update svelte2tsx 
We can now use the typings from the Svelte library instead of the
svelte2tsx shims
 2021-09-25 11:07:31 +10:00
Damien Elmes
dc20300794 update to TypeScript 4.4.x 2021-09-23 09:53:37 +10:00
Damien Elmes
82f1cda09a fixes for TypeScript 4.4.x 
closes #1386
 2021-09-23 09:52:21 +10:00
Damien Elmes
94c4f99343 update ts deps 
typescript and bootstrap have been pinned for now:

https://github.com/ankitects/anki/issues/1386
https://github.com/ankitects/anki/issues/1385

hint failures for svelte-check have also been temporarily turned
off, due to it now complaining about document.execCommand():

Hint: The signature '(commandId: string, showUI?: boolean, value?: string): boolean' of 'document.execCommand' is deprecated. (ts)
    const wrapWithForecolor = (color: string) => () => {
        document.execCommand("forecolor", false, color);
    };

Will follow up in #1377
 2021-09-22 23:21:39 +10:00
Henrik Giesel
3f1da03615 Allow for explicit any 2021-09-17 21:30:32 +02:00
Henrik Giesel
51c0cedaf5 Make HandleSelection perfectly size when first activating 2021-09-17 21:23:04 +02:00
Henrik Giesel
06d1ec6af4 Fix missizing of HandleSelection when first moving from empty to Mathjax 2021-09-17 20:54:37 +02:00
Henrik Giesel
88fd31a099 Ugly fix: do not execute moveCursorPastPostfix when front includes "anki-mathjax" 2021-09-17 20:12:11 +02:00
Henrik Giesel
c30ba6a3f6 Add ChangeTimer.prototype.fireImmediately 
so Mathjax is saved when exiting editor prematurely
 2021-09-16 14:47:05 +02:00
Henrik Giesel
a1dde7c966 Wrap Mathjax compilation into try/catch 2021-09-16 14:31:20 +02:00
Henrik Giesel
60690e0557 Rename StickyBar and StickyBottom to StickyHeader and StickyFooter 2021-09-15 23:15:55 +02:00
Henrik Giesel
896b40c873 Remove now unused import in TagEditor 2021-09-15 22:59:47 +02:00
Henrik Giesel
9f56d51811 Fix suggestions not showing when typing space in a TagInput 2021-09-15 22:54:53 +02:00
Henrik Giesel
b502ceedca Make the ImageHandle and MathjaxHandle dropdowns perfectly touch the HandleSelection 2021-09-15 22:26:32 +02:00
Henrik Giesel
1f09402066 Stop propagation for paste in MathjaxHandle editor 2021-09-15 22:14:38 +02:00
Henrik Giesel
97647e7b24 Prevent hiding handles by clicking on handles 2021-09-15 17:56:56 +02:00
Henrik Giesel
9001b597da Remove style attribute after remove float property if not styling left 2021-09-15 17:36:48 +02:00
Henrik Giesel
9b7ea75399 Always correctly update MathjaxHandle position 2021-09-15 17:05:43 +02:00
Henrik Giesel
ce9674f824 Correctly pass down dropdownObject... 2021-09-15 16:16:42 +02:00
Henrik Giesel
7c6f6533c1 Using dropdownApi is much less faulty than using dropdownObject 
- Update MathjaxSelection and Dropdown more reliably
 2021-09-15 15:52:56 +02:00
Henrik Giesel
c227c7dc39 Make StickyBottom actually stick and make editor fullsize + flexbox 2021-09-15 15:21:37 +02:00
Henrik Giesel
c46f39c88e Import saveField from editor/saving.ts 2021-09-15 14:09:25 +02:00
Henrik Giesel
54b6491ce3 Remove duplicate outline:none 2021-09-15 13:46:07 +02:00
Henrik Giesel
71bdeeba39 Apply specific CSS to Mathjax CodeMirror 2021-09-15 13:46:04 +02:00
Henrik Giesel
219557afda Satisfy eslint 2021-09-15 13:45:20 +02:00
Henrik Giesel
ec9b43d3ab Use editorfield instead of editor-field 2021-09-15 13:45:20 +02:00
Henrik Giesel
c8c9c64ea5 Vertically center inline Mathjax 2021-09-15 13:45:20 +02:00
Henrik Giesel
c02973a85d Generalize accesing anki-mathjax from image in MathjaxHandle 2021-09-15 13:45:20 +02:00
Henrik Giesel
b6bea18b22 Add copyright header to saving.ts 2021-09-15 13:45:20 +02:00
Henrik Giesel
09819d4e7d Satisfy eslint 2021-09-15 13:45:19 +02:00
Henrik Giesel
e269fe73da Define CodeMirror in external codeMirror.ts 2021-09-15 13:45:19 +02:00
Henrik Giesel
e71aed7146 Correctly import CodeMirror 2021-09-15 13:45:19 +02:00
Henrik Giesel
a3fef552bd Include codemirror libs for svelte 2021-09-15 13:45:19 +02:00
Henrik Giesel
c663785264 Satisfy eslint 2021-09-15 13:45:19 +02:00
Henrik Giesel
111d34c17b Remove empty constructor 2021-09-15 13:45:19 +02:00
Henrik Giesel
e06ff2ae3c Focus on mount when using Mathjax shortcuts 2021-09-15 13:45:17 +02:00
Henrik Giesel
af556c391d Fix alignment of empty icon 2021-09-15 13:43:37 +02:00
Henrik Giesel
de056fbd89 Change Wrap commands / shortcuts to use anki-mathjax 2021-09-15 13:42:36 +02:00
Henrik Giesel
c3f56ad5cd Refactor editable/mathjax.ts 2021-09-15 13:33:25 +02:00
Henrik Giesel
45d0cc49e6 Set fixed fontSizef or mathjax in editor for now 2021-09-15 13:33:25 +02:00
Henrik Giesel
b5900da0b4 Set color of Mathjax depending on nightMode 2021-09-15 13:33:24 +02:00
Henrik Giesel
6856850a0f Wrap Mathjax buttons into toolbar 2021-09-15 13:33:24 +02:00
Henrik Giesel
f76cf24e9d Move wrap to lib to allow editable to use it 2021-09-15 13:33:24 +02:00
Henrik Giesel
b6dfbcbc20 Move setting inCodable to false into codable 2021-09-15 13:33:23 +02:00
Henrik Giesel
1e94f7f16f Display Mathjax error as title (tooltip) 2021-09-15 13:33:23 +02:00
Henrik Giesel
8fa6d0045d Show title on mathjax image 2021-09-15 13:33:22 +02:00
Henrik Giesel
fca31465b4 Display error Mathjax correctly 2021-09-15 13:33:22 +02:00
Henrik Giesel
c88223e069 Show math icon if Mathjax is empty 2021-09-15 13:33:22 +02:00
Henrik Giesel
7ba85a2fbe Disallow draggin of mathjax + only ever have one handle active 2021-09-15 13:33:21 +02:00
Henrik Giesel
9ef4bb15c6 Fix return behavior on Mathjax decorated element 2021-09-15 13:33:21 +02:00
Henrik Giesel
4576ce8cc3 Watch for childList instead of subtree 2021-09-15 13:33:21 +02:00
Henrik Giesel
b361bcc69f Display Mathjax editor and buttons at the same time 2021-09-15 13:33:20 +02:00
Henrik Giesel
b06b5e9151 Generalize ChangeTimer and use it in Mathjax editor 2021-09-15 13:33:20 +02:00
Henrik Giesel
cb762b880e Add ResizeObserver for MathjaxHandle 2021-09-15 13:33:20 +02:00
Henrik Giesel
7168cbf99a Update editor when editing Mathjax 2021-09-15 13:33:19 +02:00
Henrik Giesel
701f260c3f Wait for stylesheets to load before setting field content 2021-09-15 13:33:19 +02:00
Henrik Giesel
ea01183bfd Move elements inserted into decorated component no matter the position 2021-09-15 13:33:19 +02:00
Henrik Giesel
8ddb0bc6ed Fix some cases where Mathjax whitespace formatting is destroyed 2021-09-15 13:33:19 +02:00
Henrik Giesel
1185593fee Use CodeMirror for Mathjax Editor 2021-09-15 13:33:18 +02:00
Henrik Giesel
882a2710a9 Autoupdate mathjax image 
* propably should use changeTimer here
 2021-09-15 13:33:18 +02:00
Henrik Giesel
ce2dbaafb9 Fix focus issues with Mathjax editor 2021-09-15 13:33:18 +02:00
Henrik Giesel
0f92664d4a First implementation of MathjaxHandleEditor 
+ use manual focus highlighting on editing-area
 2021-09-15 13:33:17 +02:00
Henrik Giesel
df24682b2a Make Mathjax menu also a floating dropdown menu like ImageHandle 2021-09-15 13:33:17 +02:00
Henrik Giesel
241d5cdd13 Fix MathJax overlay after rebase 2021-09-15 13:33:17 +02:00
Henrik Giesel
ed4621de9e Add InlineBlock buttons to mathjax components 2021-09-15 13:33:12 +02:00
Henrik Giesel
f9a3c513ce Add HandleControl to MathjaxHandle 2021-09-15 13:32:33 +02:00
Henrik Giesel
a37460dbbe Display Mathjax handle when clicking mathjax 2021-09-15 13:32:33 +02:00
Henrik Giesel
922461ea47 Rename showImageHandle to showHandles 2021-09-15 13:32:33 +02:00
Henrik Giesel
6a1fae53df Formalize "Decorated components API" 2021-09-15 13:32:32 +02:00
Henrik Giesel
9fb0ce973b Implement moveNodesInsertedBeforeEndToAfterEnd 
This will prevent the user typing into the decorated elements
by accident because they place cursor behind it
 2021-09-15 13:32:32 +02:00
Henrik Giesel
d7e0f77439 Unify anki-mathjax-* to just anki-mathjax 2021-09-15 13:32:32 +02:00
Henrik Giesel
6b14afda27 Add MathjaxHandle 2021-09-15 13:32:32 +02:00
Henrik Giesel
14aaa10bf3 Implement latex highlighting for Latex in codable 2021-09-15 13:32:32 +02:00
Henrik Giesel
6953ea9703 Use margin:auto instead of text-align:center for mathjax-block 2021-09-15 13:32:31 +02:00
Henrik Giesel
167370fcb7 Do not start ImageHandle for images with [data-anki] 2021-09-15 13:32:31 +02:00
Henrik Giesel
7950078e2b Nicely portray mathjax with right color + alignment in Editor 2021-09-15 13:32:31 +02:00
Henrik Giesel
b0378690c0 Enable edit mode for mathjax blocks 2021-09-15 13:32:31 +02:00
Henrik Giesel
cd36fe2518 Correctly include editable css 2021-09-15 13:32:31 +02:00
Henrik Giesel
1465d3a848 Survive to Codable and back 2021-09-15 13:32:31 +02:00
Henrik Giesel
b0b2ae3ece Transform to mathjax components for fieldHTML 2021-09-15 13:32:31 +02:00
Henrik Giesel
5129aca66f Implement MathjaxBlock 2021-09-15 13:32:30 +02:00
Henrik Giesel
9b2378c3d2 Introduce editable module 2021-09-15 13:32:30 +02:00
Henrik Giesel
dd280038a8 Prevent tooltip expanding body tag in editor 2021-09-15 02:24:09 +02:00
Henrik Giesel
a6504e3f47 Do not stop showing suggestions when entering double colon for separator 2021-09-15 02:02:19 +02:00
Damien Elmes
c9d3e5462e bikeshedding: amount -> match_limit 
+ convert from u32 in backend method
 2021-09-12 11:57:49 +10:00
Henrik Giesel
e85c93f3e7 Cap tag suggestions at 500 2021-09-10 01:13:50 +02:00
Henrik Giesel
1fd7fe4391 Fix crosshair not showing on main text of Tag when in select mode 2021-09-09 22:31:16 +02:00
Henrik Giesel
95058ba23f Introduce TagEditMode as a wrapper around TagWithTooltip 2021-09-09 21:47:07 +02:00
Henrik Giesel
0fdd2d9c52 Only hide DeleteBadge when hovering on tag 2021-09-09 20:16:52 +02:00
Henrik Giesel
69c6265111 Align suggestions with start of tag 2021-09-09 19:03:06 +02:00
Henrik Giesel
4029a608bc Only show tag tooltip on hover, not focus 2021-09-09 18:36:29 +02:00
Henrik Giesel
9b20ca2da4 Scroll suggestion tag into view 2021-09-09 18:32:58 +02:00
Henrik Giesel
75ed24b7ea Do not use overflow-x on ButtonToolbar 
* Fixes deck-options dropdown not showing.
  It seems like it's no longer necessary
 2021-09-09 17:50:02 +02:00
Henrik Giesel
63c00db502 Fix Tag SPACER 2021-09-09 17:28:00 +02:00
Henrik Giesel
4fc3e059be Bubble up some functionality from Tag to TagWithTooltip and TagDeleteBadge 2021-09-09 17:18:47 +02:00
Henrik Giesel
fd89f296dd Remove unused import 2021-09-09 15:38:12 +02:00
Henrik Giesel
8fd4412dbe Fix bug where sometimes Autocomplete menu would not show even though suggestions exist 2021-09-09 15:38:11 +02:00
Henrik Giesel
8d8a559f73 Use noSuggestions 2021-09-09 15:38:11 +02:00
Henrik Giesel
60b1d65351 Update Autocomplete position when suggestion selection makes it move to the next row 2021-09-09 15:38:10 +02:00
Henrik Giesel
7bdf9aaf00 Set disabled class on TagInput from WithAutocomplete 2021-09-09 15:38:10 +02:00
Henrik Giesel
eb3bc08420 Explicitly not support dropleft/dropright 
We'll deal with it when we have a use case
 2021-09-09 15:38:09 +02:00
Henrik Giesel
18b838a173 Correctly place dropdown and only update if there's activeInput 2021-09-09 15:38:09 +02:00
Henrik Giesel
9e1f2aa262 Take most recent input as basis for suggestions 2021-09-09 15:38:09 +02:00
Damien Elmes
4da1c77220 add basic tag completion to backend 
Matches should arrive in alphabetical order. Currently results are not
capped (JS should be able to handle ~1k tags without too much hassle),
and no reordering based on match location is done. Matches are substring
based, and multiple can be provided, eg "foo::bar" will match
"foof::baz::abbar".

This is not hooked up properly on the frontend at the moment -
updateSuggestions() seems to be missing the most recently typed character,
and is not updating the list of completions half the time.
 2021-09-09 15:38:08 +02:00
Henrik Giesel
c5d507461a Decrease tag margins 2021-09-09 15:38:08 +02:00
Henrik Giesel
fc09212365 Add bottom padding to selected tag badge as well 2021-09-09 15:38:07 +02:00
Henrik Giesel
b628e9df75 Use new style highlight for selected tags 2021-09-09 15:38:07 +02:00
Henrik Giesel
9d73e928a6 Add slight padding around add tag icon 2021-09-09 15:38:07 +02:00
Henrik Giesel
088420dff2 Add a zero-width tag to prevent resizing when adding tag 2021-09-09 15:38:06 +02:00
Henrik Giesel
5156ed62c3 Un-reverse TagEditor autocompletion navigation 2021-09-09 15:38:06 +02:00
Henrik Giesel
b8a5b5d685 Decrease padding of AutocompleteItem 2021-09-09 15:38:06 +02:00
Henrik Giesel
f79e2aca92 Adjust border radius of tags to fit new fields 2021-09-09 15:38:05 +02:00
Henrik Giesel
96cbca8fb6 Update to use shortened SCSS paths for some components 2021-09-09 15:38:05 +02:00
Henrik Giesel
647a2a3e59 Satisfy formatter 2021-09-09 15:38:04 +02:00
Henrik Giesel
8ee6ccf853 Rename tagEditor tag-editor.ts 2021-09-09 15:38:04 +02:00
Henrik Giesel
b49112a910 Refer to ./ instead of components/ from within components 2021-09-09 15:38:04 +02:00
Henrik Giesel
f5b58442ce Fix ts/components:svelte_check 2021-09-09 15:38:03 +02:00
Henrik Giesel
a0970e8515 Add scrollbar_lib to components 2021-09-09 15:38:03 +02:00
Henrik Giesel
8bcb0635ba Fix eslint 2021-09-09 15:38:02 +02:00
Henrik Giesel
ef539bcb37 Fix colon insertion behavior 2021-09-09 15:38:02 +02:00
Henrik Giesel
85691fada2 Replace delim char with colons on copying tags 2021-09-09 15:38:02 +02:00
Henrik Giesel
46e607a777 Fix TagSpacer 2021-09-09 15:38:01 +02:00
Henrik Giesel
04b75859cc Implement nowrap mode 2021-09-09 15:38:01 +02:00
Henrik Giesel
28b1c09cda Implement TagWithTooltip 2021-09-09 15:38:00 +02:00
Henrik Giesel
7058d14d25 Move WithTooltip to components 2021-09-09 15:38:00 +02:00
Henrik Giesel
3de1d6e604 Use Unicode delimiter character 2021-09-09 15:38:00 +02:00
Henrik Giesel
6ccf75a077 Improve space behavior 2021-09-09 15:37:59 +02:00
Henrik Giesel
ab429ec413 Improve enter behavior 2021-09-09 15:37:59 +02:00
Henrik Giesel
5f1bcb691e Split when no autocomplete item is selected 2021-09-09 15:37:59 +02:00
Henrik Giesel
a27720d703 Add tag shorting behavior 2021-09-09 15:37:58 +02:00
Henrik Giesel
ffb1f3bff2 Space out Sticky Bottom with Spacer component 2021-09-09 15:37:58 +02:00
Henrik Giesel
821c65d4ad Deselect on clicking delete icon 2021-09-09 15:37:58 +02:00
Henrik Giesel
6e53ea8a6d Add small horizontal margin so selected highlight can show 2021-09-09 15:37:57 +02:00
Henrik Giesel
280a724957 Special handling of Backspace/Delete etc. for displaying shortcuts 2021-09-09 15:37:57 +02:00
Henrik Giesel
6d21c16250 Add select all shortcut 
+ Remove addEventListener for Ctrl+C/V/A
  It seems like they're really not necessary
 2021-09-09 15:37:57 +02:00
Henrik Giesel
d40e0df11b Position stickyBottom fixed 2021-09-09 15:37:56 +02:00
Henrik Giesel
d15d6d1584 Improve positioning of tag editor badges 2021-09-09 15:37:56 +02:00
Henrik Giesel
16e6da893b Fix after rebase 2021-09-09 15:37:56 +02:00
Henrik Giesel
5a988f72fa Improve paste behavior 2021-09-09 15:37:55 +02:00
Henrik Giesel
cdc4fd0ef8 Do not update/activate Autocomplete on Control+C,A,V 2021-09-09 15:37:55 +02:00
Henrik Giesel
63dc42cff6 Do not open autocomplete on clicking input 2021-09-09 15:37:55 +02:00
Henrik Giesel
95806c5176 Allow clicking on suggestion items 2021-09-09 15:37:54 +02:00
Henrik Giesel
2dff6cf4be Pass activeName to Tag as well 2021-09-09 15:37:54 +02:00
Henrik Giesel
9499bc1505 Adjust position so tags do not even move a single pixel when going into editing 2021-09-09 15:37:54 +02:00
Henrik Giesel
6642a11482 Adjust paddings a bit more 2021-09-09 15:37:54 +02:00
Henrik Giesel
f2cd23ff22 Center delete icon without padding/margin 2021-09-09 15:37:53 +02:00
Henrik Giesel
201773e7c6 Fix autocomplete dropdown 
+ find a different solution for making tags and tag inputs same size
 2021-09-09 15:37:53 +02:00
Henrik Giesel
3dff89fda5 Switch WithAutocomplete to WithDropdown and fix SelectedTagBadge 2021-09-09 15:37:53 +02:00
Henrik Giesel
874a315f83 Add SelectedTagBadge to offer context items for selected tags 2021-09-09 15:37:53 +02:00
Henrik Giesel
00de99880b Implement selectRange 2021-09-09 15:37:52 +02:00
Henrik Giesel
376f543680 Make automatic deselect when leaving tag editor 2021-09-09 15:37:52 +02:00
Henrik Giesel
080b80e3ce Make tags selectable 2021-09-09 15:37:52 +02:00
Henrik Giesel
0ff0e87dbc Implement controlPressed and shiftPressed 2021-09-09 15:37:52 +02:00
Henrik Giesel
4601ebb347 Create lib/keys.ts 2021-09-09 15:37:52 +02:00
Henrik Giesel
5c2911c053 First steps toward tag selection 2021-09-09 15:37:51 +02:00
Henrik Giesel
d3191d7ecb Implement autocomplete hiding on empty activeInput + remove logging 2021-09-09 15:37:51 +02:00
Henrik Giesel
392326b863 Fix behavior when autocompletion shows 2021-09-09 15:37:51 +02:00
Henrik Giesel
54c1f54ab0 Fix join behavior and exclude Backspace/Delete from printable character 2021-09-09 15:37:51 +02:00
Henrik Giesel
e876a374e2 Disable toggle on clicking element (toggle) for WithAutocomplete 2021-09-09 15:37:51 +02:00
Henrik Giesel
bb166392b1 Improve no reflow a little bit 2021-09-09 15:37:51 +02:00
Henrik Giesel
85567fddd9 Fix autocomplete showing on arrow keys and height resize on no tags 2021-09-09 15:37:50 +02:00
Henrik Giesel
a29d21f4fd Implement accepting suggestions via Enter 2021-09-09 15:37:50 +02:00
Henrik Giesel
b93646209a Introduce AutocompleteItem 
* needs too much custom styling / behavior to be done with DropdownItem
 2021-09-09 15:37:50 +02:00
Henrik Giesel
b2d2cb8715 suggestions -> suggestionsPromise, so it works with external APIs 2021-09-09 15:37:50 +02:00
Henrik Giesel
a515a9899b Don't allow Enter/Tab/Arrows for Autocomplete, if not active 
Don't show Autocomplete, if there are no items available
 2021-09-09 15:37:49 +02:00
Henrik Giesel
bbef2ab6b4 Have WithAutocomplete export its API 
allows it to be used in more contexts
 2021-09-09 15:37:49 +02:00
Henrik Giesel
ed1f19048d Rename TagAutocomplete to WithAutocomplete 
It's general enough to be used in other cases too
 2021-09-09 15:37:49 +02:00
Henrik Giesel
a9538ce6a7 Improve visuals of Tag component 2021-09-09 15:37:49 +02:00
Henrik Giesel
c48b861596 Save deletions via delete icon to db 2021-09-09 15:37:48 +02:00
Henrik Giesel
5575482e38 Save tags back to Python 2021-09-09 15:37:47 +02:00
Henrik Giesel
375a96e263 Set tags from Python 2021-09-09 15:37:47 +02:00
Henrik Giesel
a034c93eb7 Remove deleteActiveTag, fix appendEmptyTag 2021-09-09 15:37:47 +02:00
Henrik Giesel
39ffaf3427 Fix some deletion behavior 2021-09-09 15:37:47 +02:00
Henrik Giesel
ba64f50593 Make Autocomplete dismount along with TagInput on blur 2021-09-09 15:37:47 +02:00
Henrik Giesel
b4e84e8043 Implement on:autocomplete 2021-09-09 15:37:46 +02:00
Henrik Giesel
146a901d91 Don't highlight suggestion items 
Other suggestions menus don't do it either
 2021-09-09 15:37:46 +02:00
Henrik Giesel
9fd985760c Fix tagmove 2021-09-09 15:37:46 +02:00
Henrik Giesel
9c388a8b7e Introduce activeName so we can pass it to TagAutocomplete 2021-09-09 15:37:45 +02:00
Henrik Giesel
05d1c51d6b Export choice as autocompletionChoice from TagAutocomplete 2021-09-09 15:37:45 +02:00
Henrik Giesel
2e00dc09d6 Make tagunique a more general tagaccept 
* tagaccept includes what was previous done by on:blur
* on:blur in TagInput was in some cases not bubbled up to TagEditor for some reason
 2021-09-09 15:37:45 +02:00
Henrik Giesel
68bbc8d25d Use Autocomplete on TagInput again 2021-09-09 15:37:44 +02:00
Henrik Giesel
cda5e44786 Pass original to Autocomplete 2021-09-09 15:37:44 +02:00
Henrik Giesel
547e6f16c6 Fix TagBadge and TagSpacer + shortcut 2021-09-09 15:37:44 +02:00
Henrik Giesel
0acbf3e9eb Export blink as a function, works more reliably 2021-09-09 15:37:43 +02:00
Henrik Giesel
53c0d372f4 Fix behavior when simply entering a duplicate 2021-09-09 15:37:43 +02:00
Henrik Giesel
3857ac07d7 Implement tagsplit 2021-09-09 15:37:43 +02:00
Henrik Giesel
de10e55265 Fix tagjoinnext 2021-09-09 15:37:43 +02:00
Henrik Giesel
1487ed64c7 Fix tagjoinprevious 2021-09-09 15:37:43 +02:00
Henrik Giesel
bfeb419ba6 Fix tagmove 2021-09-09 15:37:42 +02:00
Henrik Giesel
36f455c0ee Fix TagBadge and TagSpacer 2021-09-09 15:37:42 +02:00
Henrik Giesel
96325a4910 Align tagenter tagdelete and tagunique 2021-09-09 15:37:42 +02:00
Henrik Giesel
754e49f9b8 Implement decideAfterBlur and activeAfterBlur 2021-09-09 15:37:42 +02:00
Henrik Giesel
2cdc0b308a Prefer focusing TagInput in onMount 2021-09-09 15:37:41 +02:00
Henrik Giesel
52a705e839 Completely decouple Tag from TagInput 2021-09-09 15:37:41 +02:00
Henrik Giesel
ea1e5b5840 Add .input to Tag interface 2021-09-09 15:37:41 +02:00
Henrik Giesel
e68f874c80 Remove special treatment of last tag 2021-09-09 15:37:41 +02:00
Henrik Giesel
e80e6ff34b Try to remove special handling of last tag / inputNew 2021-09-09 15:37:40 +02:00
Henrik Giesel
15ef6d51b3 Improve behavior when moving towards newInput 2021-09-09 15:37:40 +02:00
Henrik Giesel
796c759333 tagmove should act like tagjoin on empty inputs 2021-09-09 15:37:40 +02:00
Henrik Giesel
bde820569a Fix double delete on empty input 2021-09-09 15:37:40 +02:00
Henrik Giesel
2de2f03db8 Implement blink on duplicate detected 2021-09-09 15:37:39 +02:00
Henrik Giesel
11c6fe880b Add some visual for TagAutocomplete 2021-09-09 15:37:39 +02:00
Henrik Giesel
227c41b525 Minimize reflow upon clicking tag 2021-09-09 15:37:39 +02:00
Henrik Giesel
7696895a8e Implement tagmovenext fully 2021-09-09 15:37:39 +02:00
Henrik Giesel
428655a32f Almost implement tagmove 
* tagmovenext will start on the last position rather than first
 2021-09-09 15:37:38 +02:00
Henrik Giesel
fe35573308 Reimplement tagjoin with tick() 2021-09-09 15:37:38 +02:00
Henrik Giesel
180ef140f8 Start implemention tagmove 2021-09-09 15:37:38 +02:00
Henrik Giesel
4420a24363 Set caret correctly after tagjoin 2021-09-09 15:37:38 +02:00
Henrik Giesel
65e9a0f2ed Show Autocomplete on keydown, hide on blur 2021-09-09 15:37:38 +02:00
Henrik Giesel
c8ac822971 Adjust padding of TagInput a little 2021-09-09 15:37:37 +02:00
Henrik Giesel
281985480d Fix some WithDropdownMenu logic 2021-09-09 15:37:37 +02:00
Henrik Giesel
05120c79b0 Factor out ButtonToolbar from TagAutocomplete 2021-09-09 15:37:37 +02:00
Henrik Giesel
808d01c4fb Decouple TagInput from TagAutocomplete completely 2021-09-09 15:37:37 +02:00
Henrik Giesel
8d95503189 Add tabbable option to DropdownItem 2021-09-09 15:37:37 +02:00
Henrik Giesel
a5af3a9280 Fix issue with text showing below StickyBottom 2021-09-09 15:37:37 +02:00
Henrik Giesel
892f08c19a Make tags stand less out in dark mode 2021-09-09 15:37:36 +02:00
Henrik Giesel
6c6062cc58 Make styling of DropdownMenu easier by introducing dropdown-content 2021-09-09 15:37:36 +02:00
Henrik Giesel
1ba6909495 Decouple Autocomplete from TagInput: 
Allows to only have one autocompletion for all tags, rather than every
tag having its own
 2021-09-09 15:37:36 +02:00
Henrik Giesel
c5b10c1117 Remove dead code from TagAutocomplete 2021-09-09 15:37:36 +02:00
Henrik Giesel
22d5671594 Implement tagjoin events 2021-09-09 15:37:36 +02:00
Henrik Giesel
2993a7b744 Delete tag when update reveals its a duplicate 2021-09-09 15:37:35 +02:00
Henrik Giesel
473517c3b3 Enable keyed blocks in TagEditor for tags 2021-09-09 15:37:35 +02:00
Henrik Giesel
6e25a3d424 Rewrite paste behavior 2021-09-09 15:37:35 +02:00
Henrik Giesel
d705d049ce Delete when updating tagname to empty text 2021-09-09 15:37:35 +02:00
Henrik Giesel
dbf1472029 Connect Bootstrap dropdown with trigger via classes/props 2021-09-09 15:37:34 +02:00
Henrik Giesel
3ad86dfb33 Use our DropdownMenu component for TagAutocomplete 2021-09-09 15:37:34 +02:00
Henrik Giesel
50519ea5c8 Allow correctly adding tags 
+ Make taginput unfocusable via Tab => prefer Ctrl+Shift+T
 2021-09-09 15:37:34 +02:00
Henrik Giesel
ef8c46045e Make caret cursor more discoverable 2021-09-09 15:37:34 +02:00
Henrik Giesel
64a2ead2ca Remove TagInputEdit and TagInputNew 2021-09-09 15:37:34 +02:00
Henrik Giesel
f056851c1e Port Focus tags shortcut to webview 2021-09-09 15:37:34 +02:00
Henrik Giesel
f3df0fe305 Behave correctly upon Enter on TagInputEdit 2021-09-09 15:37:34 +02:00
Henrik Giesel
9418b1491b Create AddTagBadge component 2021-09-09 15:37:33 +02:00
Henrik Giesel
bfbe5057fa Make Tag icon an add tag icon 2021-09-09 15:37:33 +02:00
Henrik Giesel
8a48d26cca Adjust offsets and sizes to make tag input smaller 2021-09-09 15:37:33 +02:00
Henrik Giesel
77be86ec21 Enable tag delete icon 2021-09-09 15:37:33 +02:00
Henrik Giesel
392bdf6184 Port most components from first tageditor PR 2021-09-09 15:37:33 +02:00
Henrik Giesel
1026d26793 Display a tag-outline icon in the bottom left 2021-09-09 15:37:33 +02:00
Henrik Giesel
bb6db5bd95 Add Tag DeleteIcon 2021-09-09 15:37:33 +02:00