Damien Elmes
29c4869aef
remove deck protobuf from frontend
...
Like the previous change, avoid exposing the protobuf as a public API
for now. It requires more thought, and is probably better done with
either extra helper accessors like decks.name(), or via a native class.
2021-05-31 16:31:06 +10:00
RumovZ
c85ae24347
Make a new item the current item after refresh
2021-05-30 10:46:59 +02:00
RumovZ
985ce2466b
Skip saving search if it already exists
2021-05-30 10:11:40 +02:00
RumovZ
37fec02f88
Enable drop to create saved search
2021-05-30 09:30:22 +02:00
Damien Elmes
a894c720de
Merge pull request #1206 from RumovZ/fix-sidebar
...
Fix some sidebar issues
2021-05-29 10:33:52 +10:00
Damien Elmes
93459cc48f
Merge pull request #1200 from RumovZ/template-checks
...
Template checks
2021-05-29 10:28:06 +10:00
RumovZ
24b4f15038
Fix renaming of unused tag
...
Unused tags can't be renamed, but since the CollectionOp returns success
in any case, the provisionally renamed sidebar item needs to be reset.
2021-05-28 19:18:21 +02:00
RumovZ
2597038fe5
Prevent sidebar toolbar from folding
...
If there is little space, Qt replaces some tools of the toolbar with an
expandable menu indicated by an arrow. But this arrow is invisible in
night mode.
2021-05-28 18:09:44 +02:00
RumovZ
af50db9fd3
Fix restoring current sidebar element for cards
2021-05-28 17:46:46 +02:00
Damien Elmes
7caaf0c735
remove sticky setting from fields dialog
...
https://forums.ankiweb.net/t/anki-2-1-45-alpha/10061/60
2021-05-28 18:33:29 +10:00
Damien Elmes
a02890a84b
make update all toggle clearer
...
https://forums.ankiweb.net/t/anki-2-1-45-alpha/10061/59
+ remove background color; it did not look good in dark mode
2021-05-28 18:33:28 +10:00
Damien Elmes
aa7d2721c9
avoid bumping mtime when nothing has changed
...
+ update sync indicator after every op
+ skip mtime bump on undo/redo
2021-05-28 11:09:16 +10:00
RumovZ
935fbb6289
Use implicit failure handling and self as parent
2021-05-27 16:51:03 +02:00
Damien Elmes
6cc713cbe8
add v3 scheduler to prefs screen
2021-05-27 23:09:49 +10:00
Damien Elmes
4e95cac5c8
remove 'update later' button
2021-05-27 22:42:21 +10:00
Damien Elmes
83a1d99e22
fix remembered tags not being applied to next added note
...
https://forums.ankiweb.net/t/anki-2-1-45-alpha/10061/56
2021-05-27 13:18:34 +10:00
Damien Elmes
f26c7ed99e
ask user to confirm which deck they want when opening options in reviewer
...
Also fixes https://forums.ankiweb.net/t/anki-2-1-45-alpha/10061/57
2021-05-27 13:15:28 +10:00
Damien Elmes
7c5e974ae5
hook up some missing translations in deck options screen
2021-05-26 14:41:18 +10:00
Damien Elmes
57ec4cc7b5
change get_queued_cards() to no longer return congrats info
2021-05-26 12:59:45 +10:00
Damien Elmes
0026506543
update ts deps
...
- prettier's formatting has changed, so files needed to be reformatted
- dart is spitting out deprecation warnings like:
254 │ 2: $spacer / 2,
│ ^^^^^^^^^^^
╵
bazel-out/darwin-fastbuild/bin/ts/sass/bootstrap/_variables.scss 254:6 @import
ts/sass/button_mixins.scss 2:9 @use
ts/components/ColorPicker.svelte 2:5 root stylesheet
DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.
Recommendation: math.div($grid-gutter-width, 2)
2021-05-26 09:37:40 +10:00
RumovZ
db9594818a
Handle failure in CardLayout/accept()
2021-05-25 20:58:43 +02:00
Damien Elmes
5a8f534f00
always start in first sidebar mode
...
I didn't notice anyone objecting; let's see how this is received.
https://forums.ankiweb.net/t/anki-2-1-45-alpha/10061/35
2021-05-24 14:51:21 +10:00
Damien Elmes
adcdb422c5
config updates by the frontend now skip undo by default
2021-05-24 14:50:46 +10:00
Damien Elmes
47076b9ac5
Merge pull request #1188 from RumovZ/switch-color-2
...
Change switch color depending on state
2021-05-24 11:42:54 +10:00
Damien Elmes
54628c3ac7
make switch more legible in dark mode
2021-05-24 11:31:56 +10:00
Damien Elmes
a0eebb78ce
Merge pull request #1186 from RumovZ/ctx-actions
...
Update context action states after card op
2021-05-24 10:49:23 +10:00
RumovZ
ff76d50338
Remove browser.oneModelNotes()
2021-05-22 19:12:03 +02:00
RumovZ
0dca3ef548
Check notetype count in browser.onChangeModel()
2021-05-22 19:11:06 +02:00
RumovZ
cba5c2253a
Change switch color depending on state
...
Make knob overlap path.
2021-05-22 10:01:15 +02:00
RumovZ
29589fcf0d
Update context action states after card op
2021-05-22 08:35:47 +02:00
Damien Elmes
195c41cba3
Merge pull request #1185 from RumovZ/scrolling
...
Scroll pixels instead of columns horizontally
2021-05-22 10:59:09 +10:00
Damien Elmes
d7d226843e
improve type answer legibility
...
https://forums.ankiweb.net/t/accessibility-suggestion-correct-answer-text-contrast-in-dark-mode/10105
There's probably more that could be done here, but that can probably
wait for #1068
2021-05-22 10:31:29 +10:00
Damien Elmes
958c53d886
fix find&replace searching in incorrect field
2021-05-22 10:12:14 +10:00
RumovZ
d46fe913a5
Scroll pixels instead of columns horizontally
2021-05-21 18:59:53 +02:00
Damien Elmes
3d4cf26758
expose undoable config changes to frontend; refresh sidebar
...
The browser header handling still needs updating
2021-05-21 17:50:41 +10:00
Damien Elmes
99b7da49a9
report changed cards when changing deck/flag
...
+ fix repeated flag shortcut not toggling
2021-05-21 16:03:05 +10:00
Damien Elmes
398cdc8992
add night mode styling to type-in-the-answer box
...
https://forums.ankiweb.net/t/night-mode-does-not-affect-input-tags/10116
2021-05-20 19:14:12 +10:00
RumovZ
5a6ba1b0b9
Move flags into separate module
2021-05-20 10:26:18 +02:00
Damien Elmes
422584b814
fix error when opening and closing editor rapidly
2021-05-20 15:32:28 +10:00
Damien Elmes
d5f4860f9b
fix fields/cards font size & too-large toolbar on high DPI Windows
...
- enable default_css on editor again, so that the html element
is set to the system font size. If this is bringing in unwanted styling,
maybe we can come up with a different solution that just adjusts the
fonts
- make toolbar size relative to html font size, instead of hard-coding
it
2021-05-20 13:15:17 +10:00
Damien Elmes
055f2907ec
Merge pull request #1178 from RumovZ/flag-labels
...
Custom labels for flags
2021-05-20 11:59:55 +10:00
RumovZ
6fb2d30426
Remove redundant pylint exception
2021-05-19 19:44:49 +02:00
RumovZ
f960299345
Prefer looping over flags over exhaustive listing
2021-05-19 19:26:39 +02:00
RumovZ
b5fa7923e6
Use custom flag labels in reviewer
2021-05-19 19:18:49 +02:00
RumovZ
5fa68c885a
Use dataclass instead of tuple for loaded flags
2021-05-19 19:17:43 +02:00
abdo
bbb2f7158f
Strip Unicode isolation characters from title
2021-05-19 18:21:57 +03:00
Damien Elmes
df38788e07
move deck name into window title; v-center sticky bar
2021-05-19 19:34:15 +10:00
Damien Elmes
fdd162a7b9
simplify previous patch
...
The default 1 rem is fine, but we need to apply the default font size
to the html element instead of the body for the definition of rem to
update.
Fixes #1174
2021-05-19 19:06:20 +10:00
RumovZ
30736ddf75
Use custom flag labels for browser actions
2021-05-19 11:00:02 +02:00
RumovZ
9816227b5c
Make sidebar flags renamable
2021-05-19 10:04:40 +02:00
Damien Elmes
581480191a
show note about old options screen if any add-ons are installed
2021-05-19 16:20:25 +10:00
Damien Elmes
63f1a363af
use literal for ease type
2021-05-19 16:05:12 +10:00
Damien Elmes
9f3f6bab7d
enable redo support
...
Also:
- fix issues where the Undo action in the Browse screen was not
consistent with the main window. The existing hook signature has been
changed; from a snapshot of the add-on code from a few months ago, it
was not a hook that was being used by anyone.
- change the undo shortcut in the Browse window to match the main
window. It was different because undoing a change in the editing area
could accidentally trigger an undo of an operation, but the damage is
limited now that (most) operations can be redone. If it still proves to
be a problem, perhaps we should just always swallow ctrl+z when an
editing field is focused.
2021-05-19 15:18:39 +10:00
RumovZ
3b5e8e5041
Fix black workaround for format calls
2021-05-18 22:19:09 +02:00
Damien Elmes
fa47f6ec15
Merge pull request #1170 from RumovZ/fix-columns
...
Fix column issues
2021-05-18 09:24:15 +10:00
Damien Elmes
157f602624
fix detection of shift key at startup
...
Our regular helper doesn't appear to work during startup.
2021-05-18 09:21:02 +10:00
Damien Elmes
bd24005e08
PreviewDialog was missing from top level browser module
2021-05-18 09:10:28 +10:00
RumovZ
2290a1652d
Set column sizes and indicator after state change
2021-05-17 20:13:45 +02:00
RumovZ
9ceee90942
Block events when restoring headers
...
Restoring headers after switching states was triggering
_on_column_toggled(), leading to unexpected results.
2021-05-17 20:07:52 +02:00
RumovZ
02f86ec352
Make failed sort column change a no-op
...
The previous behaviour when a non-sortable column was clicked was to
trigger the sorting routine, which was usually a no-op, but would
reorder rows if the configured sort column was hidden.
2021-05-17 18:33:59 +02:00
Damien Elmes
9edac805ad
support card state mutator in test scheduler
...
Documentation to come
2021-05-17 16:59:02 +10:00
Damien Elmes
1a48622d77
experiment with learning count on deck list
2021-05-16 20:23:39 +10:00
Damien Elmes
390a8421aa
fix test scheduler undo + implement look-ahead
...
Instead of using a separate undo queue, the code now defers checking for
newly-due learning cards until the answering stage, and logs the updated
cutoff time as an undoable change, so that any newly-due learning cards
won't appear instead of a new/review card that was just undone.
Queue redo now uses a similar approach to undo, instead of rebuilding the
queues.
2021-05-14 22:16:53 +10:00
Damien Elmes
c41d5ca4bf
work around Windows issue on latest Black
...
Thanks Rumo!
d797900386
2021-05-13 20:15:51 +10:00
Damien Elmes
99081e422b
re-enable leech notification for test scheduler
2021-05-13 15:51:02 +10:00
Damien Elmes
dbbcb3e38c
expose new sorting options in test scheduler options; move things around
2021-05-13 15:23:16 +10:00
Damien Elmes
49a1580566
use new API for test scheduler
...
Avoids duplicate work, and is a step towards allowing the next
states to be modified by third-party code.
Also:
- fixed incorrect underlined count, due to reviews being labeled as
learning cards
- fixed reviewer not refreshing when undoing a test review, by splitting
up backend queue rebuilding from frontend reviewer refresh
- moved answering into a CollectionOp
2021-05-11 13:06:03 +10:00
Damien Elmes
3736e63a57
expose step counter and undone op changes in hook
2021-05-08 17:51:36 +10:00
Damien Elmes
4be5d08559
remove some unnecessary checkpoints
2021-05-08 17:04:05 +10:00
Damien Elmes
1918031399
update find_duplicates to use QueryOp/CollectionOp
2021-05-08 16:58:18 +10:00
Damien Elmes
f2db822c08
move query_op into operations/, and add the ability to show progress
2021-05-08 16:35:43 +10:00
Damien Elmes
b887032244
split browser dialogs into separate files
2021-05-08 15:08:45 +10:00
Damien Elmes
0b8733032d
the find_and_replace alias is not required
...
Was only added recently, so nothing should depend on it yet.
2021-05-08 14:34:57 +10:00
Damien Elmes
78a3536bfc
move "find duplicates" into separate file
...
As far as I'm aware, no add-ons were extending that screen, so I've
dropped the old context object and the export in browser/__init__.py
2021-05-08 14:33:43 +10:00
Damien Elmes
010c3da770
Merge pull request #1159 from hgiesel/newapproach
...
Prefer idiomatic Svelte features over dynamic components
2021-05-08 11:35:31 +10:00
Henrik Giesel
8b0c6ba5df
Check for id when inserting dynamic elements
...
* I'm not sure it behaved, if there were multiple elements
inserted by different add-ons into the same container
2021-05-07 16:50:17 +02:00
Henrik Giesel
6a804f6775
Use json.dumps instead of backticks in editor.py
2021-05-07 14:22:06 +02:00
Damien Elmes
7442eed41a
update docstrings for latest black
2021-05-07 18:12:56 +10:00
Damien Elmes
3d8b7d943c
fix find&replace
2021-05-07 14:02:40 +10:00
Henrik Giesel
de8abebcd1
Fix Preview Button after changing from f-string to normal string
2021-05-07 02:12:37 +02:00
Henrik Giesel
2112b419f9
Fix ButtonDropdown
2021-05-07 02:04:44 +02:00
Henrik Giesel
0f4d4eb5a9
Only initialize extension apis if necessary
2021-05-07 02:04:44 +02:00
Henrik Giesel
c9368ed98f
Add lefttopbtns as AddonButtons
2021-05-07 02:04:44 +02:00
Henrik Giesel
e80f43e8fc
Enable setting of PreviewButton and hiding of cloze button again
2021-05-07 02:04:42 +02:00
Henrik Giesel
6d6c798ca3
Simplify structure of EditorToolbar and ButtonGroup in editor HTML file
2021-05-07 02:03:55 +02:00
Damien Elmes
fc2d3ba07c
remove AnkiDroid timezone confirmation
...
By the time this update reaches stable, AnkiDroid 2.15 should already
be out.
2021-05-06 19:05:15 +10:00
Damien Elmes
2663c891eb
fix dmypy action
2021-05-05 15:54:41 +10:00
Damien Elmes
abab4826bb
support undo for (renamed) unbury_deck() action
2021-04-30 20:03:20 +10:00
Damien Elmes
248373ef30
undoing of notetype templates
2021-04-30 17:30:48 +10:00
Damien Elmes
9a46ad6352
undoing of notetype fields
...
- fix stale cache issue
- update add cards screen in response to op changes
2021-04-30 17:15:59 +10:00
Damien Elmes
b9417fc583
notetype rename+options undo
2021-04-30 16:09:44 +10:00
Damien Elmes
394fe86f8f
notetype removal undoable
2021-04-30 16:01:47 +10:00
Damien Elmes
ea758f0092
update GUI to allow notetype addition undo
...
- backend now updates current notetype as part of addition
- frontend no longer implicitly adds, so we can assign a new name and
add in a single operation
2021-04-30 15:58:08 +10:00
RumovZ
abd02d7891
Add separate no_arg_trigger decorator
2021-04-26 08:46:08 +02:00
Damien Elmes
f77983fc9f
Merge pull request #1154 from RumovZ/fix-skip-dec
...
Fix skip_if_selection_is_empty() for triggers
2021-04-26 09:21:42 +10:00
RumovZ
594fe303da
Remove some unnecessary lambdas
2021-04-25 19:51:57 +02:00
RumovZ
9900f73cee
Fix skip_if_selection_is_empty() for triggers
...
It seems to be enough if one decorator calls pyqtSlot(), but to avoid
problems in the future, let's have all decorators do that.
2021-04-25 19:50:56 +02:00
Henrik Giesel
268adf1d03
Move EditorToolbar API into EditorToolbar.svelte
2021-04-25 19:15:00 +02:00
Henrik Giesel
f5fba15435
Initialize editor toolbar via function, not web component
2021-04-25 18:32:01 +02:00
Damien Elmes
b7b329cf90
Merge pull request #1151 from RumovZ/no-sel-dec
...
Fix some problems with browser actions while selection is empty
2021-04-25 20:48:40 +10:00