langfingaz/anki
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
4,040 Commits 2 Branches 2 Tags 39 MiB
c95983ac1f
Commit Graph

4040 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
evandrocoan
3f8cc60abc Re-enabled the rust cargo index and registry caches because 
cargo was downloading them just for nothing.
https://github.com/ankitects/anki/pull 528
 2020-03-27 02:21:48 -03:00
Damien Elmes
84b84ae31c use add_card() 2020-03-27 15:11:07 +10:00
Damien Elmes
6b9378fb41 add (unused) add_card, and move sql to separate files 2020-03-27 14:48:25 +10:00
evandrocoan
9bd28f151f Disabled the caches of cargo registry, index and python wheels 2020-03-27 00:21:09 -03:00
Damien Elmes
82ed288dc5 add benchmark for vec cache 
test storage::sqlite::bench::bench_hash_cache ... bench:         399 ns/iter (+/- 27)
test storage::sqlite::bench::bench_no_cache   ... bench:       4,854 ns/iter (+/- 499)
test storage::sqlite::bench::bench_vec_cache  ... bench:           0 ns/iter (+/- 0)
 2020-03-27 09:59:48 +10:00
Damien Elmes
2f4e35d566 store cached statements in a vec instead of separate optionals 2020-03-27 09:51:19 +10:00
evandrocoan
76bf3f8a03 Created a fast build matrix for quickly running the Unit Tests 2020-03-26 19:43:16 -03:00
evandrocoan
b07454ca0c Merge remote-tracking branch 'danielelmes/master' into create_actions_for_windows_macos 2020-03-26 19:31:01 -03:00
Damien Elmes
369d2d89d9 update card in transaction 2020-03-27 07:58:25 +10:00
Arthur Milchior
0b633dbf40 Ensuring "setNote" is called only once during changing of note type 
Initially, I wanted to solve the bug reported on
https://github.com/Arthur-Milchior/anki-html-src-in-field/issues/1

After some research, I finally discovered that the trouble was that,
when we change the note type in add card, the method
`aqt.editor.Editor.loadNote` is called twice. In itself, it would not
be a problem, but given the way callback works, its call back is
called twice on the last version of the webview. Which means that
`gui_hooks.editor_did_load_note` is called twice, which breaks this
add-on.

The reason why loadNote is called twice is because `setNote` is called
twice in `aqt.modelchooser.onModelChange`. The first time through
`gui_hooks.current_note_type_did_change` which calls
`addcards.AddCards.onModelChange` which calls `loadNote`, the second
time through `self.mw.reset()` which calls
`gui_hooks.state_did_reset()` which calls `addcards.AddCards.onReset`
which calls `setAndFocusNote` which calls `setNote`.

I should note furthermore that currently,
`gui_hooks.current_note_type_did_change` is called only when the model
chooser change a model. And `addCards.onModelChange` is never called,
only added to the hook `gui_hooks.current_note_type_did_change`. So
removing the line of code removed in this commit will have no side
effect in Anki itself. It will only affect the fact that this method
is called twice.

I do not know of any add-on calling `onModelChange` or
`gui_hooks.current_note_type_did_change`, but it means little, so of
course, it may always mean an add-on will break because of this
change. No way of being sure.
 2020-03-26 21:26:13 +01:00
Arthur Milchior
c9496ef095 Ensure that focus, key and blur are treated as other commands 
The reason to do that is that I can then call blur/key from other
method in add-on.

More precisely, I expect to create a method which captures the blur
command, ask anki to execute the standard version of the command, and
then execute more code once the note contains the new field value.

I should note that the code executed during blur/key/focus itself
didn't change. It's only it's location which changed.
 2020-03-26 15:42:27 +01:00
Damien Elmes
fe327e32ca fix progress dialog preventing schema mod 
https://anki.tenderapp.com/discussions/beta-testing/1868-anki-2124-beta#comment_48183062

This is an ugly hack - in the future the calling code should be updated
to perform the check prior to starting the operation instead.
 2020-03-26 21:07:53 +10:00
Damien Elmes
7f16f436c3 handle mtime/usn bump in backend, and tweak integer sizes 2020-03-26 20:55:04 +10:00
Damien Elmes
7a56d18539 report invalid type/queue 2020-03-26 19:32:35 +10:00
Damien Elmes
13c7c82ae3 fix two cases where a float was being written into due 2020-03-26 19:05:18 +10:00
Damien Elmes
47504245dc update_card() 2020-03-26 18:54:20 +10:00
Damien Elmes
1acfe7d3cc tweak code for mypy 2020-03-26 17:47:53 +10:00
Damien Elmes
7ddaf93f7a use backend to get card 2020-03-26 17:47:43 +10:00
evandrocoan
1e40103325 Moved RSPY_TARGET_DIR and CARGO_TARGET_DIR to the top 2020-03-26 03:04:47 -03:00
evandrocoan
8b8be3e3f3 Fixed misspelling Mac OS with a space on the build matrix 2020-03-26 02:46:18 -03:00
evandrocoan
96d572c3cc Merged all workflows together using build matrixes 2020-03-26 02:11:34 -03:00
Damien Elmes
8abba00496 DeckID, CardID 2020-03-26 15:10:40 +10:00
Damien Elmes
f52e775354 NoteTypeID 2020-03-26 15:00:24 +10:00
Damien Elmes
4ec30e412a newtype NoteID 2020-03-26 14:42:43 +10:00
evandrocoan
e1252b785d Fixed checks.yml Mac OS gmake PATH being set on Ubuntu 2020-03-26 01:20:00 -03:00
Damien Elmes
5eed3d7f71 use a macro for newtype defs 2020-03-26 13:50:20 +10:00
Damien Elmes
39f916a23e usn newtype 2020-03-26 13:06:02 +10:00
Damien Elmes
eb89a2db3f use newtypes for distinguishing between second and millisecond stamps 2020-03-26 12:59:51 +10:00
evandrocoan
c8e2c25e83 Fix Mac OS checks.yml caches being rebuilt by stop using 
the CARGO_TARGET_DIR and CARGO_INDEX_DIR variables:
https://github.com/ankitects/anki/pull 528
 2020-03-25 22:42:37 -03:00
Damien Elmes
65b8988817 reduce the chances of add-ons preventing collections from loading 
https://anki.tenderapp.com/discussions/ankidesktop/39953-sync-fail-with-images#comment_48182205
 2020-03-26 09:53:15 +10:00
Damien Elmes
8c80f96314 high due numbers shouldn't force a full sync 2020-03-26 09:09:11 +10:00
evandrocoan
b94936a98d Update make to use the new .SHELLFLAGS feature 
https://github.com/ankitects/anki/pull 528
 2020-03-25 19:05:31 -03:00
evandrocoan
1965cdb2b8 Set to use ankitects/setup-protoc@master instead of the original 
repository with a `repo-token` until know whether it is safe to
pass the GitHub token around:
https://github.com/actions/virtual-environments/issues 602
 2020-03-25 19:05:31 -03:00
evandrocoan
b77462eb8a Fixed lower case of runs-on: macos-latest 
Accordingly to the documentation the name is lower case:
https://help.github.com/en/actions/reference/virtual-environments-for-github-hosted-runners
 2020-03-25 19:05:31 -03:00
evandrocoan
53b89adeeb Fix for indentation not using tabs on the make file 2020-03-25 19:05:31 -03:00
evandrocoan
eab11622fd Re-enabled the Makefile set -eo commands because by default 
Mac OS uses an old version of make which does not support
the .SHELLFLAGS feature.
 2020-03-25 19:05:31 -03:00
Arthur Milchior
9f4c4ea355 Explode onBridgeCmd 
This way, an add-on can catch a blur command, do its change and then
call self.blur
 2020-03-25 08:17:48 +01:00
evandrocoan
206e167f85 Set curl to run silently, added missing double quotes and removed 
trailing backslash on checks.yml
 2020-03-25 00:05:49 -03:00
evandrocoan
721453f923 Merge remote-tracking branch 'danielelmes/master' into create_actions_for_windows_macos 
# Conflicts:
#	.github/scripts/trailing-newlines.sh
#	.github/workflows/checks.yml
#	Makefile
#	pylib/Makefile
#	qt/Makefile
#	qt/tools/typecheck-setup.sh
#	rspy/Makefile
 2020-03-24 22:49:49 -03:00
evandrocoan
a0971628a6 Set to run first develop build and check rules 2020-03-24 22:28:46 -03:00
evandrocoan
d1337badab Merged mac_checks.yml and windows_checks.yml into checks.yml 2020-03-24 22:28:46 -03:00
evandrocoan
716989135c Renamed linux_checks.yml to checks.yml 2020-03-24 22:28:46 -03:00
evandrocoan
bcda7ecc29 Fixed bash call by bash using other bashes on the system PATH 2020-03-24 22:28:46 -03:00
evandrocoan
18aec3c713 Re-enabled the mac_checks.yml after fixing the rate limit issue 2020-03-24 22:28:46 -03:00
evandrocoan
136cd4da7c Fixed not all rust libraries being cached 2020-03-24 22:28:46 -03:00
Damien Elmes
beee1f10e0 possible CI fix 2020-03-25 09:45:50 +10:00
Damien Elmes
818b9193a8
Merge pull request #523 from Arthur-Milchior/hook_note_will_load 
Hook editor_note_will_load
 2020-03-25 09:43:16 +10:00
Damien Elmes
1ef984cc2a
Merge pull request #526 from Arthur-Milchior/field_with_space_are_empty 
strip to test whether field is empty
 2020-03-25 09:36:08 +10:00
Damien Elmes
01e9f889b7 add newline to mear clearly separate different ftl files 2020-03-25 08:53:42 +10:00
Damien Elmes
ea3c6cad42 don't error when -l passes in language without _ 2020-03-25 08:53:31 +10:00