Commit Graph

2276 Commits

Author SHA1 Message Date
Arthur Milchior
c14b9e2077 Creating now basic type without doing full sync
There is currently what I believe to be a small bug in anki. You can
clone a note type without doing a full sync, but you can't create
forwardReverse and forwardOptionalReverse note type without doing a
full sync. On the other hand you can clone, and even create any other
basic type without doing a full sync.

This commit simply wants to correct this.

The main trouble is that the method to create a copy of forwardReverse
and forwardOptionalReverse use a copy of the basic model, and add this
copy in the model manager BEFORE adding yet another template. This
commit corrects it by ensuring that the model is added only after all
templates are added, so that anki does not detect any change of a
template in the schema.

In order to do this, I created a method newBasicModel which creates
the basic model without adding it.

By the way, addBasicTypingModel could also use newBasicModel, and then
only change afmt. I didn't do it here because I believe that you want
the change to be minimal, and this correction would not add any
feature, only factorize the code.
2019-10-21 02:30:06 +02:00
Damien Elmes
e2475244d3
Merge pull request #338 from Aqueminivan/master
Added file counts when deleting media
2019-10-20 09:46:14 +10:00
Aqueminivan
cba7c8a57b Moved number inside ngettext() 2019-10-19 19:39:43 -04:00
Damien Elmes
c2a6c3e47a
Merge pull request #339 from Arthur-Milchior/correctDueOfNewSiblings
New cards of existing note take due value of NEW siblings
2019-10-20 08:22:15 +10:00
Aqueminivan
2b2afe899a Fixed code style issue (column width) 2019-10-19 18:10:59 -04:00
Aqueminivan
01f2fda214 Fixed translation issues for media counts 2019-10-19 18:03:59 -04:00
Arthur Milchior
3f45de87b3 New cards of existing note take due value of NEW siblings
Here is a bug, how to reproduce it, and why this is a fix.

This is a way to create a new note with a due card extremly high
without any add-on, just with basic anki.

Bug
===
Create a note type with three fields One, Two, and Three and three card
type One, Two and Three such that each card is generated when the
field of the same name is filled.

Create a note with fields One and Two filled only. Review card One and
click on good. Card one should goes in learning mode. Fill the field
Three. In the browser, you'll see that card Two and Three are new, but
card Two and Three's due value are distinct. More precisely, the due
value of card Three is equal to the due value of card One; except that
in card One it's interpreted as a timestamp, while in card Three it's
interpreted as a position in the list of new card.

You'll remark by the way that the due of card Three is extremly high,
potentially more than 1000000; which may explain why so many
collection has this bug.

Fix
===
Only consider due value of new cards.
2019-10-19 06:28:10 +02:00
Aqueminivan
d669659e88 Added file counts when deleting media 2019-10-18 03:51:54 -04:00
Damien Elmes
2e7b756000 bump version 2019-09-24 16:12:38 +10:00
Damien Elmes
084b7a1694 pin qtsvg
https://anki.tenderapp.com/discussions/ankidesktop/35990-32-bit-of-anki-missing-python-binding-pyqt5qtsvgpyd
2019-09-24 15:54:26 +10:00
Damien Elmes
6b784ae42e escape backslash in find&replace
https://anki.tenderapp.com/discussions/ankidesktop/35903-bug-find-and-replace-breaks-when-replacing-with-latexmathjax-commands
2019-09-24 15:46:26 +10:00
Damien Elmes
d46899943c fix negative due dates in filtered decks
https://anki.tenderapp.com/discussions/ankidesktop/35978-rebuilding-filtered-deck-on-experimental-v2-empties-deck-and-reschedules-to-the-year-1745

this means affected cards will not have the selected ordering applied,
but that seems preferable to the alternatives
2019-09-24 15:38:33 +10:00
Damien Elmes
571b711c4c tweak translation license 2019-09-24 15:36:06 +10:00
Damien Elmes
241b7ea005 use locales instead of two digit lang codes
and move away from launchpad
2019-09-23 21:18:03 +10:00
Damien Elmes
df3314ff79
Merge pull request #332 from Arthur-Milchior/sortEase
when sorting by easiness, put new card separately
2019-09-23 14:18:04 +10:00
Arthur Milchior
61d7c0b5d9 when sorting by easiness, put new card separately 2019-09-18 16:58:29 +02:00
Damien Elmes
5c4ff83b72 fix qtwebengineprocess leak in stats screen
https://anki.tenderapp.com/discussions/ankidesktop/35941-closing-stats-window-doesnt-end-its-extra-qt-process
2019-09-16 15:16:41 +10:00
Damien Elmes
d4aa146b4c
Merge pull request #330 from glutanimate/add-typing-module
Add "typing" to pinned modules
2019-09-07 13:01:26 +10:00
Glutanimate
e9b701ef05 Add "typing" to pinned modules 2019-09-06 17:25:30 +02:00
Damien Elmes
396d14e58f
Merge pull request #329 from aidanholm/fix-default-discard
Don't discard new card contents by default
2019-09-02 10:24:29 +10:00
Damien Elmes
98a866c2cb support multiple urls at once in editor 2019-09-02 10:17:04 +10:00
Damien Elmes
35964fa55c reduce editcurrent width constraint
https://anki.tenderapp.com/discussions/ankidesktop/35724-bug-edit-window-not-resizable
2019-09-02 09:52:04 +10:00
Aidan Holm
ac497eaf7c Don't discard new card contents by default 2019-09-01 13:09:05 +08:00
Damien Elmes
8b78d326f8
Merge pull request #328 from lovac42/clearUndoOnSchedConvert
clears undo before changing schedulers
2019-08-31 11:38:07 +10:00
Damien Elmes
a609633bb7
Merge pull request #327 from Blauelf/patch-1
Prevent non-integer ivl when importing from Mnemosyne
2019-08-31 11:34:54 +10:00
lovac42
9069d282a2 clears undo before changing schedulers 2019-08-30 20:55:38 -04:00
Damien Elmes
fb5deb9063 statsbg credit/link 2019-08-31 10:47:01 +10:00
Blauelf
672e19df85
Prevent non-integer ivl when importing from Mnemosyne
A reddit user had a few issues when importing from Mnemosyne, one of which was non-integer values interpreted as "v2 scheduler bug". I assume that's the line where they originated.
https://www.reddit.com/r/Anki/comments/cxcv27/what_just_happened_cards_with_v2_scheduler_bug/
2019-08-30 14:56:44 +02:00
Damien Elmes
8d5c0f4853 add decimal
https://anki.tenderapp.com/discussions/ankidesktop/35620-module-decimal-missing-in-binary-package-2115-linux-only
2019-08-26 10:04:42 +10:00
Damien Elmes
6d46676a76
Merge pull request #326 from lovac42/fix_cased_fieldNames
Fix case sensitive field names
2019-08-21 17:50:38 +10:00
lovac42
a4a47a0c94 rm unnecessary step 2019-08-20 23:31:04 -04:00
lovac42
0007c98e8d Fix case sensitive field names so that 'apple' and 'Apple' both show up in drop down list when performing a search and replace. 2019-08-20 22:28:45 -04:00
Damien Elmes
b0bf0adacf
Merge pull request #325 from MHordecki/format_exception
Use traceback.format_exception for debug error display.
2019-08-20 19:35:54 +10:00
Mike Hordecki
5d6ba06369 Use traceback.format_exception for debug error display. 2019-08-19 23:08:55 +02:00
Damien Elmes
1a1fc35428
Merge pull request #324 from MHordecki/software-opengl
Add support for OpenGL software rendering.
2019-08-18 20:18:03 +10:00
Damien Elmes
442df9d668
Merge pull request #323 from SebastienGllmt/patch-1
Allow disabling timeTicks
2019-08-17 18:50:44 +10:00
Damien Elmes
4dde7b13d0 ensure random distribution of due cards for a given day in v2 sched 2019-08-17 18:45:00 +10:00
Damien Elmes
888d8b5dee add progress dialog for media delete 2019-08-17 18:32:39 +10:00
Mike Hordecki
8617ec7250 Add support for OpenGL software rendering.
In some systems, the default Qt hardware renderer is buggy. There's a Qt
option for forcing software rendering. This commit adds support for a
new environment variable, ANKI_SOFTWAREOPENGL, that, when set, will
prompt Anki to force software OpenGL in Qt.
2019-08-16 23:18:28 +02:00
Sebastien Guillemot
a9641e50c6
Allow disabling timeTicks 2019-08-16 01:58:10 +10:00
Damien Elmes
c4eca03dd8 pin logging
https://anki.tenderapp.com/discussions/ankidesktop/35444-python-standard-library-availability-in-anki
2019-08-13 19:08:49 +10:00
Damien Elmes
1bb1aecd81
Merge pull request #320 from shanrauf/readme-dev-typo
Small README.development error
2019-08-03 09:11:58 +10:00
Shan Rauf
0e8ebee465 Fix readme.development typo 2019-07-29 02:10:34 -07:00
Damien Elmes
4c6b608736
Merge pull request #318 from wgreven/single-config-file-for-colors
Allow configuring Anki's color scheme using a single config file on Linux
2019-07-22 10:51:51 +10:00
Damien Elmes
e5194ad208 remove open backup folder link
https://anki.tenderapp.com/discussions/ankidesktop/35084-crash-while-trying-to-revert-to-a-backup
2019-07-22 10:49:22 +10:00
Wilco Greven
9b10e3f43e Set applicationName and desktopFileName before instantiating the application.
When these are set after instantiating the application Anki will load both
$XDG CONFIG HOME/.config/Ankirc and $XDG CONFIG HOME/.config/ankirc.
2019-07-20 13:10:59 +02:00
Damien Elmes
79a4f76422
Merge pull request #317 from wgreven/fix-window-icon-on-wayland
Show the correct window icon when running on Wayland
2019-07-19 08:37:50 +10:00
Wilco Greven
ffab5d31d4 Set the desktop file name.
Otherwise, on Wayland, Anki will look for python3.desktop This fixes the window icon.
2019-07-18 23:14:34 +02:00
Damien Elmes
b503da2648
Merge pull request #316 from vi3itor/master
Remove outdated pyqt mentions from README.development
2019-07-17 18:45:04 +10:00
Damien Elmes
4f819d06ec display a more helpful message when base folder not readable in startup 2019-07-17 17:23:22 +10:00