langfingaz/anki
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
4,678 Commits 1 Branch 1 Tag 37 MiB
b89811bfba
Commit Graph

966 Commits

Author SHA1 Message Date
evandrocoan
200bad3714 Explicitly close the importer file descriptor 
https://github.com/ankitects/anki/pull 613
 2020-05-18 15:54:20 -03:00
evandrocoan
efb62b9528 Add missing close file descriptors using context managers 2020-05-18 15:54:20 -03:00
Damien Elmes
31ceb5d730 simplify the migration popup 
Avoid presenting the user with a wall of text they may not understand,
default to proceeding, and quit if the user cancels.
 2020-05-18 20:15:59 +10:00
Damien Elmes
a53aac40f8
Merge pull request #610 from evandroforks/ask_confirmation_before_moving_anki_collection 
Ask user confirmation before moving the Anki directory
 2020-05-18 19:44:27 +10:00
Damien Elmes
e323a8f902
Merge pull request #619 from evandroforks/fix_empty_sound_tags 
Also fix legacy.py::anki.sound._soundReg accepting empty tags
 2020-05-18 19:31:22 +10:00
Damien Elmes
fe196bc1df
Merge pull request #620 from evandroforks/remove_unused_var 
Remove unused t = time.time() variable on qt/aqt/browser.py
 2020-05-18 19:20:08 +10:00
Damien Elmes
1fc951471c fix python3.7 lint issue 2020-05-18 18:08:57 +10:00
Damien Elmes
8bd5d756e2 bump version 2020-05-18 12:50:20 +10:00
Damien Elmes
252eb3a444 fix shared deck conf warning 2020-05-17 14:37:59 +10:00
Damien Elmes
8b57a61746 use deck tree for new/review count calculation 
- wins back the performance lost by the decks and dconf not being
in memory, and the overhead of serializing data for DB calls
- card counts are no longer capped to 1000
- learn counts are currently still calculated separately - can't merge
v1 counts without changing the existing behaviour
- partially rendering the tree may yield more savings
 2020-05-16 20:28:03 +10:00
Damien Elmes
8eada2b57d add find_deck_in_tree() 2020-05-16 13:05:20 +10:00
Damien Elmes
578b60c104 save profile stats to file instead of generating report 
Can use an external tool like snakeviz to query them after a run.
 2020-05-16 12:53:01 +10:00
Damien Elmes
f6767d1cff fix lint issues 2020-05-16 12:20:20 +10:00
Damien Elmes
0c340eba64 fix+speed up deck list from Filters button 
I don't think it makes much sense to keep these lists that largely
duplicate the sidebar functionality, but they remain for now.
 2020-05-16 11:54:08 +10:00
Damien Elmes
f2086fc2e3 switch to new deck tree in deck browser 
Saves us having to look up collapsed/filtered as we render, and gives
us type completion.
 2020-05-16 10:52:14 +10:00
Damien Elmes
75d3eebafe drop usage of nameMap in deckbrowser 
It was unnecessary, and being called multiple times as we recursed
downwards, slowing things down.
 2020-05-16 10:02:08 +10:00
Damien Elmes
83adfb60cf avoid duplicate reset in overview 2020-05-15 21:54:56 +10:00
Damien Elmes
964a69e54e handle default deck and filtered deck suppression in the backend 2020-05-15 21:21:10 +10:00
Damien Elmes
2ac33500eb fetch stock notetypes from backend 2020-05-15 17:08:24 +10:00
Damien Elmes
f650e5557f add back card deletion count 
cheaper to look up now that there's an index on notes.mid
 2020-05-15 15:28:07 +10:00
Damien Elmes
00db72e365 show (Deck) when card hasn't been added 2020-05-15 15:01:28 +10:00
Damien Elmes
ed52a4dc3f when previewing cards, use the default deck for now 
Replay code needs to be able to retrieve deck options. We should
probably use the current deck or pass it in in the future.
 2020-05-15 14:50:57 +10:00
Damien Elmes
68e1303880 update replay suppression in clayout 2020-05-15 14:26:00 +10:00
Damien Elmes
46c363d4aa track changes in fields dialog as well 
And avoid bumping schema until user actually saves, but warn at
start.
 2020-05-15 13:59:44 +10:00
Damien Elmes
f1c5c88c10 no longer need to check addNote's return value 2020-05-14 21:59:42 +10:00
Damien Elmes
24ffb6ab76 check for empty cloze cards when rendering as well 2020-05-14 21:56:45 +10:00
Damien Elmes
782911471b add "fill empty" checkbox 2020-05-14 20:58:45 +10:00
Damien Elmes
9a222e620a update Add Field button 2020-05-14 18:01:15 +10:00
Damien Elmes
c5d574e9f4 use group box instead of tabs in card layout screen 2020-05-14 17:26:40 +10:00
Damien Elmes
5167bb57be start reworking card layout screen 
- front/back/css shown in tabs
- front/back preview switchable; only one webview needs to be loaded
- dropdown to select cloze number in preview
- search box to search in front/back/css
 2020-05-14 15:24:29 +10:00
Damien Elmes
f23eb350e4 drop availOrds(), and use backend for getting cloze numbers 2020-05-14 12:14:00 +10:00
Damien Elmes
c601dcef24 remove obsolete preview code 2020-05-14 09:22:53 +10:00
Damien Elmes
6680cdf1d3 update the card layout screen 
- changes are now committed in bulk when closing the dialog,
and can be canceled
- it's not necessary to save the note to the database to preview it
- duplicate fields are now shown as duplicates in the top list
- redraw preview more quickly
- use + instead of _ when deduplicating names, as the latter is a
glob character
 2020-05-13 17:24:49 +10:00
Damien Elmes
12b8fe6147 don't hide static template text when card is empty 2020-05-13 11:17:44 +10:00
evandrocoan
3f517c71e4 Remove unused t = time.time() variable on qt/aqt/browser.py 2020-05-12 15:09:22 -03:00
evandrocoan
f8c6300e27 Also fix legacy.py::anki.sound._soundReg accepting empty tags 2020-05-12 12:43:35 -03:00
Damien Elmes
9317cee9ba handle scheduling preferences in the backend 2020-05-12 21:13:34 +10:00
Damien Elmes
70cc1699a6 rewrite DB check 
- notes with wrong field count are now recovered instead of
being deleted
- notes with missing note types are now recovered
- notes with missing cards are now recovered
- recover_missing_deck() still needs implementing
- checks required
 2020-05-12 21:13:34 +10:00
Damien Elmes
2413f286b1 bulk tag add/remove/update; canonify on note save 
also remove the tag list updated hook - we'll need a better solution in
the future than having the library code call back into the GUI code
 2020-05-12 21:13:34 +10:00
Damien Elmes
7bab99d873 support disabling unicode normalization in notes 2020-05-12 21:13:34 +10:00
Damien Elmes
05ca797ee6 add pep8 name for findReplace 2020-05-12 21:13:34 +10:00
Damien Elmes
29379a9a50 update extract-po-string to handle plurals again 2020-05-12 21:13:34 +10:00
Damien Elmes
1852e32183 update find&replace in browser 
sadly the UI still stutters on large selections - the calls
to get the selected rows from Qt are really slow.
 2020-05-12 21:13:34 +10:00
Damien Elmes
c51ca666c3 catch schema mod in background 
If the schema confirmation dialog is shown on a background thread it
will crash the app, so we convert this to an assertion error that gets
caught by the error handler. Code still needs to be updated to modify
the schema prior to moving to the background, but at least this way
it doesn't crash.
 2020-05-12 21:13:34 +10:00
Damien Elmes
6e6d9ee1a3 check untyped in clayout 2020-05-12 21:13:34 +10:00
Damien Elmes
9f585d4d38 remove an unused import 2020-05-12 21:13:34 +10:00
Damien Elmes
25f122bf5c update fields and models diags 
- field changes are now applied when user closes dialog with save
button, in bulk
- models diag now fetches note type and saves it as required, instead
of holding on top a copy that can grow stale as changes are made in
subdialogs
- both dialogs now perform operations in the backend
- note.model() now fetches the note type on the fly, instead of
holding on to a copy that may become stale
 2020-05-12 21:13:34 +10:00
Damien Elmes
f6931197d2 add helper to run background task with progress 2020-05-12 21:13:34 +10:00
Damien Elmes
36c1d1cf8c reuse existing use count in note types screen 2020-05-12 21:13:33 +10:00
Damien Elmes
ce104d16a3 mypy/isort fixes 2020-05-12 21:13:33 +10:00
Damien Elmes
238441f2d9 use the backend for the deck due tree 
- approx 3x faster on a large test deck
- counts are no longer capped to 1000 in the tree
 2020-05-12 21:13:33 +10:00
Damien Elmes
67421e02ec add browserCollapsed as part of tree build 2020-05-12 21:13:33 +10:00
Damien Elmes
a0160d7f1e fix mypy issues 2020-05-12 21:13:33 +10:00
Damien Elmes
a88bc1e836 speed up browser load by rendering deck tree in Rust and skipping counts 2020-05-12 21:13:33 +10:00
Damien Elmes
0bb80329e8 ensure collection doesn't get stuck open if loading fails 2020-05-12 21:13:33 +10:00
Damien Elmes
23586ffe90 catch template errors, and start on discarding changes to fields/cards 
This is only a first step - all the current methods that implicitly
save need to be updated.
 2020-05-12 21:13:33 +10:00
Damien Elmes
6e8860cafa hook the empty cards code up to the GUI 2020-05-12 21:13:33 +10:00
Damien Elmes
f637ac957d hook up new note and note type handling 
- notetypes are fetched from the DB as needed, and cached in Python
- handle note type changes in the backend. Multiple operations can now
be performed in one go, but this is not currently exposed in the GUI.
- extra methods to grab sorted note type names quickly, and fetch by
name
- col.models.save() without a provided notetype is now a no-op
- note loading/saving handled in the backend
- notes with no valid cards can now be added
- templates can now be deleted even if they would previously
orphan notes

a number of fixmes have been left in notes.py and models.py
 2020-05-12 21:13:33 +10:00
Damien Elmes
1ca7fb4a80 use quick check instead of full integrity check on collection close 2020-05-12 21:13:33 +10:00
Damien Elmes
85b28f13d2 avoid installing pyaudio on every run 2020-05-12 21:10:21 +10:00
Damien Elmes
436bdd6970
Merge pull request #611 from evandroforks/automatically_install_pyaudio_on_make_check 
Automatically install pyaudio when running make check
 2020-05-12 20:44:25 +10:00
Damien Elmes
74c97ad6d3 bump version 2020-05-11 19:28:17 +10:00
Damien Elmes
4e44694136 Revert "use isolation characters instead of direction markers in cloze handling" 
This reverts commit e838769d02.

Caused a regression:

https://anki.tenderapp.com/discussions/ankidesktop/41384-cloze-deletions-in-2125-and-2126
 2020-05-11 19:25:49 +10:00
evandrocoan
5f9dbf9b7d Set to restart Anki application after profile directory migration 
Ask user confirmation before moving the Anki directory
https://github.com/ankitects/anki/pull 610
 2020-05-10 18:30:58 -03:00
evandrocoan
4cf64519fb Automatically install pyaudio when running make check 2020-05-09 13:26:42 -03:00
Damien Elmes
7078415405 avoid renaming completer_, as add-ons depend on it 2020-05-08 18:17:57 +10:00
Damien Elmes
c02716ccd8 python formatting+lints 2020-05-08 17:30:27 +10:00
Damien Elmes
2a0d40e15d stats area grouping box fix 
https://anki.tenderapp.com/discussions/beta-testing/1928-cosmetic-issue
 2020-05-08 16:03:29 +10:00
Damien Elmes
4a26e2ba77 bundle socks 
https://anki.tenderapp.com/discussions/ankidesktop/39801-sync-error
 2020-05-08 15:26:19 +10:00
evandrocoan
9f5c69ee94 Keep an window open showing the migration is in progress 2020-05-07 15:03:43 -03:00
evandrocoan
453da45c99 Ask user confirmation before moving the Anki directory 
https://anki.tenderapp.com/discussions/ankidesktop/41245-unwanted-file-movingdeleting-behavior
 2020-05-07 14:59:19 -03:00
Damien Elmes
961833a137 avoid mention of pip 2020-05-05 16:30:22 +10:00
Damien Elmes
2f57c646e0 benchmark->profile, and remove from error branches 2020-05-05 16:28:49 +10:00
Damien Elmes
e7ebcc7c75
Merge pull request #605 from evandroforks/benchmark_option 
Created the --benchmark command line option
 2020-05-05 16:23:00 +10:00
Damien Elmes
16d0bf24b4
Merge pull request #608 from evandroforks/fix_missing_pyaudio_import 
Fix missing pyaudio blocking Anki from running
 2020-05-05 16:22:34 +10:00
evandrocoan
0006269c01 Used showWarning asking the user to install pyaudio 2020-05-05 00:00:48 -03:00
evandrocoan
338e904bd4 Created the ANKI_RUN_BENCHMARK environment variable replacing 
the command line argument.
 2020-05-04 23:46:13 -03:00
evandrocoan
2e11a596aa Fixed profiler word misspelling and stopped trimming the output 2020-05-04 23:15:23 -03:00
Damien Elmes
08f894735a
Merge pull request #607 from Arthur-Milchior/remove_a_try 
Simplify the copying of field contents when resetting
 2020-05-05 11:36:17 +10:00
Damien Elmes
b932333246 fix card layout screen on qt 5.9 regression (#592) 2020-05-05 11:26:13 +10:00
evandrocoan
b671c8e627 Fix missing pyaudio blocking Anki from running 
https://github.com/ankitects/anki/pull 606
Remove pyaudio as mandatory dependency
 2020-05-04 13:44:12 -03:00
Damien Elmes
5236e20a7a
Merge pull request #580 from Arthur-Milchior/debug_diag 
mw.debug_diag is the dialog and not the window
 2020-05-04 14:07:15 +10:00
Damien Elmes
9502fe790f
Merge pull request #584 from Arthur-Milchior/onModelchangeUsed 
On modelchange used
 2020-05-04 14:06:35 +10:00
Damien Elmes
6c20e5a7df
Merge pull request #585 from Arthur-Milchior/addButtonSaveNewFunction 
addButton always save function
 2020-05-04 13:58:46 +10:00
Damien Elmes
d98e3fa371
Merge pull request #606 from evandroforks/remove_pyaudio_as_dependency 
Remove pyaudio as mandatory dependency
 2020-05-04 13:37:19 +10:00
Damien Elmes
eec3fcf87a use qconnect everywhere, and fix some typing issues 
a step towards check_untyped_defs in aqt, but there's still 100+
issues to resolve
 2020-05-04 13:23:08 +10:00
Damien Elmes
164fdb37d5 fix saving searches in browser 2020-05-04 12:26:50 +10:00
evandrocoan
1e4748d45e Remove pyaudio as mandatory dependency 
Pyaudio on Windows is difficult to install and complicates things
when someone is using the wheels just for autocomletion on IDEs as
PyCharm:
https://anki.tenderapp.com/discussions/add-ons/44009-problems-with-code-completion
 2020-05-03 23:05:38 -03:00
evandrocoan
b63bfc83d8 Created the --benchmark command line option 
https://anki.tenderapp.com/discussions/ankidesktop/41106-card-audio-playback-changes-bug-in-212x
Based on the snippet: https://gist.github.com/evandrocoan/961d46e10424e53ba8946fac66e0efac
 2020-05-03 20:34:43 -03:00
Arthur Milchior
f2fbf667cd onModelChange: replacing try by if 2020-05-03 01:53:00 +02:00
Arthur Milchior
d427e1028b single try in onModelChange 2020-05-03 01:53:00 +02:00
Arthur Milchior
936bb31997 onModelChange save note 
I like the way onModelChange is done. Except that you forget to use
the note you computed.
 2020-05-03 01:53:00 +02:00
Damien Elmes
b337dda8df bump version 2020-05-02 10:22:00 +10:00
evandrocoan
a48fa4ad87 Add missing aqt and anki modules dependency requirements 2020-04-30 17:30:22 -03:00
Damien Elmes
9645b85df8 fix deck confs not deleting 
https://anki.tenderapp.com/discussions/ankidesktop/41044-bug-report-anki-2124-macos-deleting-unused-option-groups
 2020-04-30 08:10:29 +10:00
BlueGreenMagick
be6a5e2f13 Set tab width to 4 spaces 
setTabStopWidth is deprecated, and setTabStopDistance is preferred
It's not entirely accurate however, which you can see
when you compare 10 tabs and 40 spaces
 2020-04-29 11:34:09 +09:00
Damien Elmes
00cf4fc585 bump version 2020-04-28 08:57:56 +10:00
Arthur Milchior
3378daeca3 remove an useless asignment 
Because fields of new notes are empty by default
 2020-04-28 00:31:30 +02:00
Arthur Milchior
93d83e760b remove a try, for code clarity 2020-04-28 00:31:24 +02:00
Damien Elmes
0c8f6ced09 Revert "Merge pull request #583 from Arthur-Milchior/remove_a_try" 
This reverts commit e9ca61d1eb, reversing
changes made to abb80231a5.
 2020-04-28 07:38:23 +10:00
Arthur Milchior
e86817305a mw.debug_diag is the dialog and not the window 
This will allow, for example, for add-ons to do self.debugDiag.text
and access the debugger text. I see very little reason to have a
direct access to the dialog window.

I should note that self.debugDiag is never used anywhere in the code,
so I think it should be deleted; unless you've heard of some add-on
using it.
 2020-04-27 11:55:33 +02:00
Damien Elmes
e9ca61d1eb
Merge pull request #583 from Arthur-Milchior/remove_a_try 
Simplify the code slightly
 2020-04-27 19:12:00 +10:00
Damien Elmes
abb80231a5
Merge pull request #582 from evandroforks/fix_make_clean 
Fixed make clean rule not working on Windows
 2020-04-27 19:10:21 +10:00
Damien Elmes
5746302817
Merge pull request #581 from BlueGreenMagick/use-var-name 
use variable names
 2020-04-27 19:10:04 +10:00
Arthur Milchior
31164adaec addButton always save function 2020-04-26 17:01:47 +02:00
Arthur Milchior
e4a0ccc059 remove an useless asignment 
Because fields of new notes are empty by default
 2020-04-26 14:49:16 +02:00
Arthur Milchior
1771be8f1e remove a try, for code clarity 2020-04-26 14:49:11 +02:00
BlueGreenMagick
f23a361876 use variable names 2020-04-26 15:47:19 +09:00
evandrocoan
26480fb13c Fixed make clean rule not working on Windows 2020-04-26 03:02:02 -03:00
evandrocoan
06056236c0 Fixed build-mo-files not failing the build when msgmerge 
is not found:
https://github.com/ankitects/anki/runs/617116053?check_suite_focus=true#step:27:1244

The build was not falling because when you do `(commands)` in a
shell script, the `set -e` directive is not inherited. Then, either
do not start a new shell or just use an if to test the error condition.
 2020-04-25 05:17:24 -03:00
Damien Elmes
361959bdc4
Merge pull request #573 from evandroforks/printWidth100 
Set .prettierrc printWidth to 88 because the default is too short
 2020-04-23 20:01:58 +10:00
evandrocoan
51ec5d0fa9 Set .prettierrc printWidth to 88 because the default is too short 2020-04-22 23:11:03 -03:00
Damien Elmes
4b8cf631d5 add selectable flag while preserving link clicking 
https://anki.tenderapp.com/discussions/beta-testing/1920-config-can-copy-paste-but-cant-click-links-now
 2020-04-21 09:11:56 +10:00
Damien Elmes
ce589fb975 Revert "Merge pull request #562 from ijgnd/master" 
This reverts commit 4fb9dc734b, reversing
changes made to c8fb409a49.

https://anki.tenderapp.com/discussions/beta-testing/1920-config-can-copy-paste-but-cant-click-links-now
 2020-04-21 09:10:45 +10:00
Damien Elmes
683f664d85 fix deleting deck configs 2020-04-20 13:23:05 +10:00
Damien Elmes
335815ab9c fix renaming not updating dropdown 2020-04-20 13:17:55 +10:00
Damien Elmes
c023bdd78e fix adding deck configs 2020-04-20 13:15:23 +10:00
Damien Elmes
385dbf88c3
Merge pull request #569 from evandroforks/limit_error_message_size 
Also limit the size of the error message
 2020-04-20 11:14:53 +10:00
Damien Elmes
2939931004 split scheduling prefs into separate tab 
https://anki.tenderapp.com/discussions/ankidesktop/40610-windows-anki-everything-was-enlarged-to-150
https://anki.tenderapp.com/discussions/beta-testing/1916-preferences-screen-partly-invisible
 2020-04-20 11:11:00 +10:00
evandrocoan
9dda28def4 Also limit the size of the error message in case it is 
build by a concatenation of stack traces, i.e.,
```js
throw new Error(err + err.stack)
```
 2020-04-17 16:28:31 -03:00
evandrocoan
67a8af0cbf Limit the reviewer.ts stack size 
https://anki.tenderapp.com/discussions/beta-testing/1918-reliably-reproduced-bug-in-2124beta6#comment_48247959
 2020-04-17 03:53:15 -03:00
evandrocoan
38fabcef52 Cache webview.py console regex expression and disable multiline 2020-04-17 03:43:16 -03:00
Damien Elmes
aa562f490c fix delays caused by console.log regression in PR #560 
https://anki.tenderapp.com/discussions/beta-testing/1918-reliably-reproduced-bug-in-2124beta6
 2020-04-17 10:51:03 +10:00
Damien Elmes
394f7c630c
Merge pull request #560 from evandroforks/fix_javascript_console_output 
Fixed javaScriptConsoleMessage showing 'error on line'
 2020-04-16 10:15:56 +10:00
Damien Elmes
4fb9dc734b
Merge pull request #562 from ijgnd/master 
make help text selectable
 2020-04-16 10:14:02 +10:00
Damien Elmes
a7d5d27778 catch and report issues when downgrading 2020-04-16 10:11:16 +10:00
Damien Elmes
07343f6c9f show a clearer error if the schema is too new 
will hold off on making it translatable for now
 2020-04-16 09:47:34 +10:00
Damien Elmes
d24cb66be9 downgrade manually 
- A regular collection open/close no longer goes through the
upgrade/downgrade steps each time. This avoids wasted cycles, and will
become more important in the future when decks and note types are
split into separate tables.
- Added a downgrade button to the profiles screen to downgrade all
profiles and close the app.
- Downgrading is still automatic when exporting/doing a full sync.
 2020-04-16 09:00:49 +10:00
Damien Elmes
a6b676039b work around full sync on start closing the app 
This is just a temporary solution until the syncing code can be
reworked.

https://anki.tenderapp.com/discussions/ankidesktop/39761-anki-crashing-after-sync-and-download
 2020-04-16 08:10:17 +10:00
evandrocoan
2f174b40a6 Set to use a regular expression to remove the server name because 
it is less prone to break in future updates.
 2020-04-15 16:27:41 -03:00
evandrocoan
7061aac16d Set to javaScriptConsoleMessage output to stdout because it 
may raise error messages on the anki GUI.
 2020-04-15 16:06:45 -03:00
ijgnd
e745677145
make help text selectable 
This allows the user to copy e.g. values so that they don't have to retype them which might introduce typos.
 2020-04-15 18:59:04 +02:00
Damien Elmes
16be20e2fa don't write log files when exporting 2020-04-15 21:45:32 +10:00
Damien Elmes
65cfcf9226 pare back dark mode support 
Anki now solely relies on the night mode setting in the preferences
to decide whether to show in light or dark mode. Some users wanted
to run Anki in light mode while keeping the rest of their system dark,
and there were various display problems when dark mode was changed
after Anki started that couldn't be easily worked around.

NSRequiresAquaAppearance is set again, which means we can rely on
the interface appearing properly and not changing as the macOS theme
is changed.

Users who only use dark mode, and preferred the native look of widgets
in dark mode, can achieve the previous appearance by running the
following command in the terminal:

defaults write net.ankiweb.dtop NSRequiresAquaSystemAppearance -bool no

And the following in the debug console:

mw.pm.meta["dark_mode_widgets"] = True

This is hidden behind a debug console command because it requires the
user ensure their system is always set to the same light/dark mode
as Anki.
 2020-04-15 21:44:56 +10:00
Damien Elmes
dbedeef98d
Merge pull request #559 from evandroforks/show_full_javascript_stacktrace 
Set to show the JavaScript exception message and stacktrace
 2020-04-15 18:51:16 +10:00
Damien Elmes
75db74e2e5
Merge pull request #557 from simgunz/fix-button-not-highlighted 
Fix editor buttons not highlighted
 2020-04-15 18:50:36 +10:00
Damien Elmes
a552abe688 update if a compatible branch is found, even if mtime is wrong 
https://anki.tenderapp.com/discussions/ankiweb/4668-addon-auto-update-problems
 2020-04-15 18:47:04 +10:00
evandrocoan
16d7e89c7d Set to show the JavaScript exception message and stacktrace, when 
a exception is throw, showing the function and lines from where
the exception/error is coming from.
https://stackoverflow.com/questions/591857/how-can-i-get-a-javascript-stack-trace-when-i-throw-an-exception

Exception example:
Invalid HTML on card: Error: The media element is missing its 'src' attribute.
at http://127.0.0.1:50233/_anki/reviewer.js:246:23
at http://127.0.0.1:50233/_anki/reviewer.js:112:9
at Array.forEach ()
at setAnkiMedia (http://127.0.0.1:50233/_anki/reviewer.js:111:11)
at AnkiMediaQueue.setup (http://127.0.0.1:50233/_anki/reviewer.js:244:9)
at eval (eval at (http://127.0.0.1:50233/_anki/jquery.js:2:2651), :2:11)
at eval ()
at http://127.0.0.1:50233/_anki/jquery.js:2:2651
at Function.globalEval (http://127.0.0.1:50233/_anki/jquery.js:2:2662)
at Ha (http://127.0.0.1:50233/_anki/jquery.js:3:21262)
 2020-04-15 04:15:47 -03:00
evandrocoan
f3c561b6d9 Fixed javaScriptConsoleMessage showing 'error on line' for 
all lines. The new output format is:
JS info /_anki/reviewer.js:166 autoadd
JS error /_anki/reviewer.js:240 Uncaught (in promise) NotAllowedError: play() can only be initiated by a user gesture.
 2020-04-15 04:12:47 -03:00
Simone Gaiarin
5410d27aaa Fix editor buttons not highlighted 
The selector 'button.linkb' takes precedence on '.highlighted' because
it is more specific, so that '.highlighted' is never applied.
 2020-04-14 19:04:03 +02:00
Damien Elmes
351d8a309f move autoplay() into card 2020-04-13 09:04:30 +10:00
Damien Elmes
10eb947402 fix replay audio again, and decouple the code from the reviewer 2020-04-13 08:59:36 +10:00
Damien Elmes
e838769d02 use isolation characters instead of direction markers in cloze handling 
https://anki.tenderapp.com/discussions/ankidesktop/40443-improper-location-of-c1foo-on-ltr-text-in-an-rtl-cloze-field
 2020-04-13 08:34:17 +10:00
Damien Elmes
0c5f22f4ae avoid adjusting position if selected row is visible 
https://anki.tenderapp.com/discussions/beta-testing/1868-anki-2124-beta#comment_48227037
 2020-04-11 15:54:52 +10:00
Damien Elmes
698bf9c780
Merge pull request #550 from BlueGreenMagick/debugDiag-contextMenu 
add clear actions to context menu in debug console
 2020-04-11 14:19:46 +10:00
Damien Elmes
a068fcdc9f
Update main.py 2020-04-11 14:19:27 +10:00
Damien Elmes
8b3f0100e4 fix error when replaying audio in preview screen 2020-04-10 20:33:48 +10:00
Damien Elmes
c964be3961 make sure preview window is closed when browser closed 2020-04-10 20:32:48 +10:00
Damien Elmes
26f5b9250c grey out spinner if max=0 
https://anki.tenderapp.com/discussions/ankidesktop/32710-custom-study
 2020-04-10 20:32:48 +10:00
Damien Elmes
6776101601
Merge pull request #549 from BlueGreenMagick/debug-resizable 
Allow changing height of debug console text edit boxes
 2020-04-10 19:46:13 +10:00
BlueGreenMagick
653f5765b8 add clear actions to context menu in debug console 2020-04-10 15:45:25 +09:00
BlueGreenMagick
1452c2fd3c put debug textedits in a splitter 2020-04-10 13:50:09 +09:00
Damien Elmes
8f7ef6ed2c make sure progress stops when collection corrupt message shown 2020-04-09 14:19:20 +10:00
Damien Elmes
eff1b39e9f fix deck_browser_did_render hook 2020-04-09 13:40:19 +10:00
Damien Elmes
3851246d60
Merge pull request #542 from BlueGreenMagick/addcards-cloze-warning 
detect cloze cards with other filters
 2020-04-08 16:30:00 +10:00
Damien Elmes
cbb2ce6928
Merge pull request #545 from BlueGreenMagick/draggable-field-pos 
allow dragging fields to change its position
 2020-04-08 16:22:27 +10:00
Damien Elmes
61793f92b8 fix preview closing 
https://anki.tenderapp.com/discussions/beta-testing/1868-anki-2124-beta#comment_48228480
 2020-04-08 16:21:20 +10:00
Damien Elmes
55b99511c0 print exception on close 2020-04-08 10:05:33 +10:00
BlueGreenMagick
6b3d6bec55 allow dragging fields to change its position 2020-04-07 16:42:33 +09:00
BlueGreenMagick
aa86bc8088 use model type to detect cloze notes 2020-04-07 14:02:53 +09:00
Damien Elmes
6ecf2ffa2c
Merge pull request #543 from Arthur-Milchior/sort_according_to_path 
Sort according to path
 2020-04-07 14:44:53 +10:00
Damien Elmes
1122ab4791
Merge pull request #541 from BlueGreenMagick/tmpNote-cloze 
detect renamed cloze fields in note type preview
 2020-04-07 14:17:44 +10:00
Damien Elmes
16ab351bf8 avoid unnecessary work in 'make build' 2020-04-07 10:59:14 +10:00
BlueGreenMagick
12b69af9b2 detect renamed cloze fields in note type preview 
and cloze fields that is also other special field type
such as '{{cloze:hint:Text}}'
 2020-04-07 08:56:54 +09:00
Arthur Milchior
bda2935de1 _basename to basename, since it's not private in use 2020-04-06 23:51:50 +02:00
Arthur Milchior
5315b717c0 _basename used where possible 2020-04-06 23:51:42 +02:00
Arthur Milchior
69a9425cd0 replace _path by path (because it's not private here) 2020-04-06 23:50:43 +02:00
Arthur Milchior
266c2022b5 uses _path where possible 2020-04-06 23:50:37 +02:00
Arthur Milchior
5d55c4cda2 Sort decks according to their paths 
Currently it's sorted alphabetically. Because of this, "A::B" appears
between "A9" and "AA" in list of decks.
 2020-04-06 22:49:25 +02:00
Damien Elmes
676f4e74a8 store config in separate DB table 
- mtime is tracked on each key individually, which will allow
merging of config changes when syncing in the future
- added col.(get|set|remove)_config()
- in order to support existing code that was mutating returned
values (eg col.conf["something"]["another"] = 5), the returned list/dict
will be automatically wrapped so that when the value is dropped, it
will save the mutated item back to the DB if it's changed. Code that
is fetching lists/dicts from the config like so:

col.conf["foo"]["bar"] = baz
col.setMod()

will continue to work in most case, but should be gradually updated to:

conf = col.get_config("foo")
conf["bar"] = baz
col.set_config("foo", conf)
 2020-04-06 15:39:47 +10:00
Damien Elmes
8b76098bc7 omit period in steps when possible 2020-04-06 15:39:47 +10:00
Damien Elmes
7375a0389a add flag to skip downgrade on collection close 
Disabled for now; when enabled it will allow faster collection
open and close in the normal case, while continuing to downgrade
when exporting or doing a full sync.

Also, when downgrading is disabled, the journal mode is no longer
changed back to delete.
 2020-04-04 17:21:45 +10:00
Damien Elmes
ac4284b2de update tag handling 
- tag list stored in a separate DB table
- non-wildcard searches now do full unicode case folding
(eg tag:masse matches 'Maße')
- wildcard matches do simple unicode case folding
- some functions haven't been updated yet, so ascii folding will
continue to be used in some operations
 2020-04-03 19:34:46 +10:00
Damien Elmes
333d0735ff preserve mtime/usn when syncing deck config, and add snake_case names 2020-04-03 19:34:46 +10:00
Damien Elmes
2c99a4203f
Merge pull request #537 from Arthur-Milchior/add_card_did_init 
hook add_card_did_init
 2020-04-03 19:34:33 +10:00
Arthur Milchior
657fa9758b hook add_card_did_init 2020-04-03 11:03:08 +02:00
evandrocoan
4ad03fe4ba Fixed double python version check for python_requires=">=3.7" 2020-04-02 22:56:53 -03:00
evandrocoan
efe319ec95 Deprecated sdist wheels and pyqtwebengine as dependency 2020-04-02 22:56:48 -03:00
evandrocoan
274944e678 Set the minimum python version required by anki on qt/setup.py 2020-04-02 22:56:44 -03:00
evandrocoan
50e9780e66 Set to build a source distribution instead of build distribution 
for aqt on qt/Makefile, because .whl files are just zip simple
zip files and do not support dynamic versioning. Also, there is no
restriction for aqt to be shipped as source tarball because it does
not ship any binaries.
 2020-04-02 22:56:37 -03:00
evandrocoan
eb4b77728b Fixed setup.py installing pyqtwebengine on older versions of pyqt 2020-04-02 22:56:33 -03:00
evandrocoan
1962456821 Set to checks.yml install and import anki wheels 
# Conflicts:
#	.github/workflows/checks.yml
 2020-04-02 22:56:13 -03:00
Damien Elmes
6cf3b0ca18 add type checking to previewer 2020-04-03 09:13:33 +10:00
Damien Elmes
6049e15dac add missing license header 2020-04-03 09:05:32 +10:00
Damien Elmes
a359c27c25 use old name for preview dialog to avoid breaking add-ons 2020-04-03 09:00:18 +10:00
Damien Elmes
5f9c126caa fix some errors in the previewing code 2020-04-03 09:00:08 +10:00
Damien Elmes
342bb64092
Merge pull request #535 from evandroforks/upload_wheels_to_pypi 
Created the GitHub Actions step Upload to PyPi
 2020-04-03 08:40:17 +10:00
Damien Elmes
4790fec881 render() conflicts with Qt method 2020-04-03 08:29:35 +10:00
Damien Elmes
de79087620 be explicit that the method is a no-op 2020-04-03 08:27:56 +10:00
Damien Elmes
f5e0ad8fad tweak wording 2020-04-03 08:27:26 +10:00
Arthur Milchior
cd1fd6f9a2 snake case 2020-04-02 17:44:06 +02:00
Arthur Milchior
00d04cd6c9 Previewer is a QDialog 
As suggested by Glutanimate in https://github.com/ankitects/anki/pull/532#discussion_r401256921
 2020-04-02 17:44:06 +02:00
Arthur Milchior
6564f00748 Previewer: parent become private 
It seems parent is a method of QDialog, so it creates a typing problem
 2020-04-02 17:44:06 +02:00
Arthur Milchior
31f2f60757 Methods used by browser are not public 
As suggested by Glutanimate on https://github.com/ankitects/anki/pull/532#discussion_r401254100
 2020-04-02 17:44:06 +02:00
Arthur Milchior
0e21978577 remove the word preview from previewer variable 
As suggested by glutanimate https://github.com/ankitects/anki/pull/532#discussion_r401255290
 2020-04-02 17:44:06 +02:00
Arthur Milchior
92cec5c327 removing PreviewDialog dataclass 
It can be replaced by the previewer itself. As suggested by
Glutanimate https://github.com/ankitects/anki/pull/532#discussion_r401252970
 2020-04-02 17:44:06 +02:00
Arthur Milchior
c722b5bd2c PreviewerListCards can take cids and class 
This allow to avoid recomputing a card if it is known, while allowing
to compute it until it's actually displayed
 2020-04-02 17:44:06 +02:00
Arthur Milchior
b76ee6f8e5 ListCardsPreviewer 2020-04-02 17:44:06 +02:00
Arthur Milchior
c4a38c5e36 Split PreviewerBrowser into a hierarchy 
A part in common to see multiple cards. And a part specific for the browser
 2020-04-02 17:44:06 +02:00
Arthur Milchior
727b7fb6e5 split onPreview Prev/Next 2020-04-02 17:44:06 +02:00
Arthur Milchior
79dece3124 split _updatePreviewButtons 
This will allow to create a hierarchy in this class
 2020-04-02 17:44:06 +02:00
Arthur Milchior
f42c164999 add a class to preview a single card 2020-04-02 17:44:06 +02:00
Arthur Milchior
944e82211f Class PreviewerBrowser 
This let a previewer class which can be used to display a single card,
and a previewer for the browser
 2020-04-02 17:44:06 +02:00
Arthur Milchior
0a3d68a565 split = None 2020-04-02 17:44:06 +02:00
Arthur Milchior
6d98063ac3 vbox and bbox are attribute 2020-04-02 17:44:06 +02:00
Arthur Milchior
95e020f743 use card method 2020-04-02 17:44:06 +02:00
Arthur Milchior
179ba87ce4 previewer: create gui in a distinct function 2020-04-02 17:44:06 +02:00
Arthur Milchior
45ccd4aa3c move previewer to a different class. 
This uses exactly the same code, with one exception. In the previewer
`self` became `self.parent` in order to have action on the
browser. And in the browser, some `self` become `self.previewer` to
access the previewer. (Some function having an action on the previewer
starting from the browser now are separated in two. One version in the
previewer doing the same thing. One version in the browser, calling
the version in the previewer if it exists.)

Preview dialog now takes a QWidget in general, not necesarrily a
Browser. The parameter is called parent
 2020-04-02 17:44:06 +02:00
Damien Elmes
b5f0f459ce ignore row change events that arrive after browser closed 
https://anki.tenderapp.com/discussions/ankidesktop/40148-bug-when-suspending-cards
 2020-04-02 19:44:51 +10:00
evandrocoan
069cc11a86 Created the GitHub Actions step Upload to PyPi to run only on 
tagged releases of anki:
https://anki.tenderapp.com/discussions/ankidesktop/40025-anki-in-python-package-index
 2020-04-02 02:57:34 -03:00
Damien Elmes
05cc47a5d3 fix push-i18n-ftl 2020-04-01 18:20:31 +10:00
Damien Elmes
5392bd8e28 fix extract-po-string.py 2020-04-01 17:49:31 +10:00
Damien Elmes
634931cf9e tweak hook name 2020-04-01 17:13:08 +10:00
Damien Elmes
28380d4183
Merge pull request #534 from Arthur-Milchior/tags_hook 
hook tag_editor_received_a_key
 2020-04-01 17:10:31 +10:00
Damien Elmes
5fe747f14a left-align tags 
https://anki.tenderapp.com/discussions/ankidesktop/40068-tags-column-in-browser-is-centered
 2020-04-01 13:29:42 +10:00
Damien Elmes
c050833aba always position selection in center after search 
https://anki.tenderapp.com/discussions/beta-testing/1888-retaining-position-when-searching
 2020-04-01 11:01:20 +10:00
Damien Elmes
c9da4bc1a6 allow aborting a media sync while http req in flight 
The progress handling code needs a rethink, as we now have two separate
ways to flag that the media sync should abort. In the future, it may
make sense to switch to polling the backend for progress, instead of
passing a callback in.
 2020-04-01 09:49:25 +10:00
Arthur Milchior
4b34e71030 hook tag_editor_received_a_key 
I expect it to be useful for add-ons such as
https://github.com/fonol/anki-search-inside-add-card which interact
with the tag line
 2020-03-31 15:05:41 +02:00
zjosua
bfdb5d01b5 Use double quotes in taglimit queries 2020-03-30 10:12:47 +02:00
Damien Elmes
ef79f7d676
Merge pull request #531 from Arthur-Milchior/browser_will_show_context_menu 
hook browser_header_will_show_context_menu
 2020-03-28 14:50:02 +10:00
Damien Elmes
47bd6264bd Revert "Merge pull request #527 from Arthur-Milchior/explode_on_bridge_cmd" 
This reverts commit 2264fe3f66, reversing
changes made to 84b84ae31c.

Causes a traceback when opening the add screen, clicking on Type,
and choosing a note type.

  File "/Users/dae/Work/code/dtop/qt/aqt/webview.py", line 31, in cmd
    return json.dumps(self.onCmd(str))
  File "/Users/dae/Work/code/dtop/qt/aqt/webview.py", line 97, in _onCmd
    return self._onBridgeCmd(str)
  File "/Users/dae/Work/code/dtop/qt/aqt/webview.py", line 500, in _onBridgeCmd
    return self.onBridgeCmd(cmd)
  File "/Users/dae/Work/code/dtop/qt/aqt/editor.py", line 374, in onBridgeCmd
    self._links[cmd](self, *args)  # type: ignore
  File "/Users/dae/Work/code/dtop/qt/aqt/editor.py", line 404, in onBlur
    if gui_hooks.editor_did_unfocus_field(False, self.note, int(ord)):
TypeError: int() argument must be a string, a bytes-like object or a number, not 'NoneType'
 2020-03-28 13:35:05 +10:00
Arthur Milchior
4bb49d404e hook browser_header_will_show_context_menu 2020-03-27 23:06:22 +01:00
Damien Elmes
d81c725b46
Merge pull request #529 from Arthur-Milchior/load_note_once_on_note_type_change 
Ensuring "setNote" is called only once during changing of note type
 2020-03-27 15:28:49 +10:00
Damien Elmes
f6219b59ac
Merge pull request #528 from evandroforks/create_actions_for_windows_macos 
Create actions for Windows and Mac OS
 2020-03-27 15:26:22 +10:00
Damien Elmes
2264fe3f66
Merge pull request #527 from Arthur-Milchior/explode_on_bridge_cmd 
Explode on bridge cmd
 2020-03-27 15:22:14 +10:00
evandrocoan
b07454ca0c Merge remote-tracking branch 'danielelmes/master' into create_actions_for_windows_macos 2020-03-26 19:31:01 -03:00
Arthur Milchior
0b633dbf40 Ensuring "setNote" is called only once during changing of note type 
Initially, I wanted to solve the bug reported on
https://github.com/Arthur-Milchior/anki-html-src-in-field/issues/1

After some research, I finally discovered that the trouble was that,
when we change the note type in add card, the method
`aqt.editor.Editor.loadNote` is called twice. In itself, it would not
be a problem, but given the way callback works, its call back is
called twice on the last version of the webview. Which means that
`gui_hooks.editor_did_load_note` is called twice, which breaks this
add-on.

The reason why loadNote is called twice is because `setNote` is called
twice in `aqt.modelchooser.onModelChange`. The first time through
`gui_hooks.current_note_type_did_change` which calls
`addcards.AddCards.onModelChange` which calls `loadNote`, the second
time through `self.mw.reset()` which calls
`gui_hooks.state_did_reset()` which calls `addcards.AddCards.onReset`
which calls `setAndFocusNote` which calls `setNote`.

I should note furthermore that currently,
`gui_hooks.current_note_type_did_change` is called only when the model
chooser change a model. And `addCards.onModelChange` is never called,
only added to the hook `gui_hooks.current_note_type_did_change`. So
removing the line of code removed in this commit will have no side
effect in Anki itself. It will only affect the fact that this method
is called twice.

I do not know of any add-on calling `onModelChange` or
`gui_hooks.current_note_type_did_change`, but it means little, so of
course, it may always mean an add-on will break because of this
change. No way of being sure.
 2020-03-26 21:26:13 +01:00
Arthur Milchior
c9496ef095 Ensure that focus, key and blur are treated as other commands 
The reason to do that is that I can then call blur/key from other
method in add-on.

More precisely, I expect to create a method which captures the blur
command, ask anki to execute the standard version of the command, and
then execute more code once the note contains the new field value.

I should note that the code executed during blur/key/focus itself
didn't change. It's only it's location which changed.
 2020-03-26 15:42:27 +01:00
Damien Elmes
fe327e32ca fix progress dialog preventing schema mod 
https://anki.tenderapp.com/discussions/beta-testing/1868-anki-2124-beta#comment_48183062

This is an ugly hack - in the future the calling code should be updated
to perform the check prior to starting the operation instead.
 2020-03-26 21:07:53 +10:00
Damien Elmes
65b8988817 reduce the chances of add-ons preventing collections from loading 
https://anki.tenderapp.com/discussions/ankidesktop/39953-sync-fail-with-images#comment_48182205
 2020-03-26 09:53:15 +10:00
Arthur Milchior
9f4c4ea355 Explode onBridgeCmd 
This way, an add-on can catch a blur command, do its change and then
call self.blur
 2020-03-25 08:17:48 +01:00
evandrocoan
721453f923 Merge remote-tracking branch 'danielelmes/master' into create_actions_for_windows_macos 
# Conflicts:
#	.github/scripts/trailing-newlines.sh
#	.github/workflows/checks.yml
#	Makefile
#	pylib/Makefile
#	qt/Makefile
#	qt/tools/typecheck-setup.sh
#	rspy/Makefile
 2020-03-24 22:49:49 -03:00
Damien Elmes
818b9193a8
Merge pull request #523 from Arthur-Milchior/hook_note_will_load 
Hook editor_note_will_load
 2020-03-25 09:43:16 +10:00
Arthur Milchior
c1a8c413b0 remove space in fields 2020-03-24 12:26:48 +01:00
Arthur Milchior
3799b8504f strip to test whether field is empty 2020-03-24 11:55:55 +01:00
Arthur Milchior
31f18e3c94 Hook editor_note_will_load 
A current problem I have is that there is nothing similar to hook
inside of javascript. It seems that it would be easier to be able to
add other methods in javascript and call them in loadNote. Currently I
simply redefined loadNote, which is far from perfect
 2020-03-24 10:17:01 +01:00
Damien Elmes
6143a7e218
Merge pull request #525 from Hk-tang/change-to-more-pythonic 
Change not not to bool
 2020-03-24 16:01:15 +10:00
Damien Elmes
a51dba7255
Merge pull request #524 from Arthur-Milchior/indet_html 
Ident html in editor
 2020-03-24 16:00:57 +10:00
Damien Elmes
483d50cba8
Merge pull request #522 from Arthur-Milchior/editor_did_init 
editor_did_init
 2020-03-24 15:52:50 +10:00
evandrocoan
f908566252 Created .github/workflows/mac_checks.yml 2020-03-24 00:31:46 -03:00
evandrocoan
20c9837770 Created the .github/workflows/windows.yml 
# Conflicts:
#	.github/scripts/trailing-newlines.sh
#	Makefile
#	qt/tools/typecheck-setup.sh
#	react/Makefile
#	rspy/Makefile
#	svelte/Makefile
#	tslib/Makefile
 2020-03-23 19:51:03 -03:00
evandrocoan
6c8b005cab Deprecated eval usage on qt/tools/typecheck-setup.sh 2020-03-23 18:54:24 -03:00
evandrocoan
b1b3e5b87c Merge remote-tracking branch 'danielelmes/master' into fix_tests_on_windows 
# Conflicts:
#	.github/scripts/trailing-newlines.sh
 2020-03-23 18:44:11 -03:00
Hk-tang
521b0e9e14 Change not not to bool 2020-03-23 11:16:39 -06:00
Arthur Milchior
0c39c4f106 add an id to name tab 2020-03-23 16:52:24 +01:00
Damien Elmes
b1a8107aa1 formatting 2020-03-23 19:54:01 +10:00
Damien Elmes
84eaf43525 reduce the chances of a race condition in mplayer code 
Not perfect, it may still happen.

https://anki.tenderapp.com/discussions/ankidesktop/39832-an-error-occurred-audio
 2020-03-23 19:15:32 +10:00
Damien Elmes
f889616ef1 don't pop up network errors for media sync 
log them instead
 2020-03-23 19:06:13 +10:00
Damien Elmes
f429986246 fix collection_did_load() not being called, and remove dead code 
https://anki.tenderapp.com/discussions/ankidesktop/39765-_colloadingstate-is-never-run-thus-collection_did_load-hook-is-never-triggered
 2020-03-23 18:57:23 +10:00
Damien Elmes
7d94465256 cache dark mode value so UI doesn't break when it changes 
https://anki.tenderapp.com/discussions/ankidesktop/39550-cant-deactivate-night-mode-on-2121-for-mac
 2020-03-23 18:39:37 +10:00