langfingaz/anki
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
6,833 Commits 1 Branch 1 Tag 37 MiB
9c456dd7b0
Commit Graph

6833 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Damien Elmes
5ff5a6f2e6
Merge pull request #1069 from Arthur-Milchior/Emptying_field_lead_to_proper_message 
Emptying field lead to proper message
 2021-03-15 13:17:05 +10:00
Arthur Milchior
9661684ca3 If a template name contains only quote, show relevant error message 
This is for the sake of the consistency with the last commit
 2021-03-14 02:10:48 +01:00
Arthur Milchior
dd48b2dff0 Return meaningful message if a field is empty after normalizing 
This correct the probably rare bug as follow:

I got a note type with a field whose name is "\".

When I made any change to this note type, even unrelated, I get a message stating that there is an empty field. This is
strange because I can see it to be false. Investigating show that "\" is normalized to empty field. This ensure that
it's shown
 2021-03-14 02:10:32 +01:00
RumovZ
35fa58730c Improve grouping of sidebar methods 2021-03-13 09:45:06 +01:00
RumovZ
53665f0cf4 Use same constraints for deleting by key press ... 
... as for deleting via context menu, i.e., delete key does nothing if
not all selected items are of the same type.
 2021-03-13 09:31:56 +01:00
Arthur Milchior
80db5dc7d5 update is executable 
Without this change, I can't just do `./update.py` and need to do `python3 update.py`
 2021-03-13 07:35:36 +01:00
Damien Elmes
1ab085dfab ensure fields normalized before checksumming 
https://forums.ankiweb.net/t/python-checksum-rust-checksum/8195
 2021-03-13 10:23:32 +10:00
Damien Elmes
bd959731d7
Merge pull request #1067 from RumovZ/regex-err 
Fix regex error formatting and search error escaping
 2021-03-13 10:16:10 +10:00
RumovZ
e033f21767 Fix markdown escaping in search errors 2021-03-12 20:32:38 +01:00
RumovZ
2078a094f4 Fix formatting of invalid regex error 
Preserve whitespace, special characters and use monospace font.
 2021-03-12 20:31:23 +01:00
Damien Elmes
28994458e9 add indexes to graves table to speed up undo 2021-03-12 18:59:24 +10:00
Damien Elmes
44dc3f494c avoid hanging UI when undoing in browse screen 2021-03-12 18:54:08 +10:00
Damien Elmes
57a05a2ae3 undo in background, and show progress window 2021-03-12 17:54:56 +10:00
Damien Elmes
d92f1499ff experiment with perform_op() wrapper 
Fixes #1065, and gives us similar functionality to #1066
 2021-03-12 17:54:13 +10:00
Damien Elmes
2ffc055487 'change deck' now undoable 2021-03-12 16:27:57 +10:00
Damien Elmes
7b7d7e8330 consume original card when updating 2021-03-12 16:20:58 +10:00
Damien Elmes
24762261d9 make 'forget card' undoable; remove checkpoint() in set_due_date 2021-03-12 16:13:50 +10:00
Damien Elmes
9ba02b5ca6 fix set due date not remembering default in browse screen 2021-03-12 15:47:11 +10:00
Damien Elmes
6e0e17b2b9 Revert "Merge pull request #1066 from RumovZ/editor-save-dec" 
This reverts commit a0c47243b6, reversing
changes made to 0ab87b7339.

@RumoVZ this broke a bunch of operations like 'select notes' and
'set due date'. When the triggered signal is connected to a function,
PyQt looks at the function signature to decide what arguments to pass
it. The wrapper was using *args, so PyQt passes in an extra argument,
which the underlying function didn't expect.

I tried settting __signature__ on the wrapper, but PyQT seems to
ignore it, so we may either need to check all of the existing calls
and add the ignored extra arguments, or create a separate wrapper for
such cases.
 2021-03-12 15:44:19 +10:00
Damien Elmes
3b067c7a66 limit initial sort selection to new cards 
https://github.com/ankidroid/Anki-Android/issues/8172
 2021-03-12 14:58:19 +10:00
Damien Elmes
c1316bb65f 'set due date' now undoable 2021-03-12 14:50:31 +10:00
Damien Elmes
ec8adf7371 move old scheduler files into scheduler/ 
Includes a hack that should allow existing imports to continue to work;
if this breaks things for you, please let me know.
 2021-03-12 14:43:45 +10:00
Damien Elmes
ad973bb701 split out common scheduler code into base.py, use scheduler/ dir 
Also move the legacy aliases into a separate file
 2021-03-12 14:07:52 +10:00
Damien Elmes
a0c47243b6
Merge pull request #1066 from RumovZ/editor-save-dec 
Add decorators for calling editor.saveNow()
 2021-03-12 09:23:18 +10:00
RumovZ
538afd94bc Add decorator to save editor in sidebar 2021-03-11 22:25:18 +01:00
RumovZ
9bf93573da Add decorator to save editor in browser 2021-03-11 22:24:24 +01:00
Damien Elmes
0ab87b7339 enable deck removal undo again 2021-03-11 22:24:12 +10:00
Damien Elmes
71789eb51a
Merge pull request #1044 from RumovZ/sidebar-tools 
Add sidebar modes for different click behaviour
 2021-03-11 21:57:53 +10:00
RumovZ
f4c2fe6485 Merge branch 'master' into sidebar-tools 2021-03-11 12:08:32 +01:00
RumovZ
dad92e1e22 Annotate decks.rem as deprecated 2021-03-11 11:26:35 +01:00
Damien Elmes
e20c5ed9c5 deck drag&drop undo 2021-03-11 20:02:16 +10:00
RumovZ
c11a394753 Remove prompt when deleting from deckbrowser 2021-03-11 10:28:23 +01:00
Damien Elmes
984e2c2666 add a separate 'rename deck' method 2021-03-11 19:24:54 +10:00
RumovZ
5d93832713 Run background tasks with progress 2021-03-11 10:04:58 +01:00
RumovZ
f1dd010489 Remove deck remove prompt but show card count 2021-03-11 09:52:11 +01:00
RumovZ
3219bb2539 Remove prompt when deleting saved searches 2021-03-11 09:20:41 +01:00
RumovZ
337ef0ae21 Show count of affected notes after tag renaming 2021-03-11 09:17:22 +01:00
RumovZ
186a0202ea Show tooltip instead of prompt for removing tags 2021-03-11 09:14:50 +01:00
Damien Elmes
4bd120cc4b split out remaining rpc methods 
@david-allison-1 note this also changes the method index to start at
0 instead of 1
 2021-03-11 17:04:32 +10:00
Damien Elmes
378b116977 split out stats, media and search 2021-03-11 16:16:40 +10:00
Damien Elmes
cd14987812 split out tags, deck config and card rendering 2021-03-11 16:05:06 +10:00
Damien Elmes
1b8d6c6e85 split out sync, notetypes and config code 2021-03-11 15:47:31 +10:00
Damien Elmes
5df684fa6b rework backend codegen to support multiple services; split out sched 
Rust requires all methods of impl Trait to be in a single file, which
means we had a giant backend/mod.rs covering all exposed methods. By
using separate service definitions for the separate areas, and updating
the code generation, we can split it into more manageable chunks -
this commit starts with the scheduling code.

In the long run, we'll probably want to split up the protobuf file into
multiple files as well.

Also dropped want_release_gil() from rsbridge, and the associated method
enum. While it allows us to skip the thread save/restore and mutex unlock/
lock, it looks to only be buying about 2.5% extra performance in the
best case (tested with timeit+format_timespan), and the majority of
the backend methods deal with I/O, and thus were already releasing the
GIL.
 2021-03-11 14:51:29 +10:00
Damien Elmes
060293c8f5
Merge pull request #1064 from BlueGreenMagick/fix-sidebar-click 
Clicking the expander icon should not trigger click event
 2021-03-11 10:19:55 +10:00
bluegreenmagick
38ae2f2b06 Clicking the expander icon should not trigger click event 
Expander icon does not change currentIndex
 2021-03-11 09:04:24 +09:00
Damien Elmes
763800ad9a
Merge pull request #1063 from hgiesel/edithtmlfix 
Fix bug with initially enabled toolbar in browser
 2021-03-11 10:02:41 +10:00
RumovZ
8e9331e424 Fix repainting in case of tag renaming exception 2021-03-10 21:50:46 +01:00
Henrik Giesel
76102db2a9 Fix bug with initially enabled toolbar in browser 2021-03-10 19:28:08 +01:00
RumovZ
bc7043c384 Store name prefix of sidebar items 2021-03-10 16:38:29 +01:00
RumovZ
e1db8e1da1 Borrow dids in remove_decks_and_child_decks 2021-03-10 15:56:54 +01:00