Commit Graph

105 Commits

Author SHA1 Message Date
Damien Elmes
60aa75226b update translations 2021-10-01 20:48:20 +10:00
Damien Elmes
a3d9f90af5 update to latest rules_nodejs & switch to ts_project
ts_library() is deprecated and will presumably be dropped from a
future rules_nodejs, and it wasn't working with the jest tests
after updating, so we switch over to ts_project().

There are some downsides:

- It's a bit slower, as the worker mode doesn't appear to function
at the moment.
- Getting it working with a mix of source files and generated files
was quite tricky, especially as things behave differently on Windows,
and differently when editing with VS Code. Solved with a small patch
to the rules, and a wrapper script that copies everything into the
bin folder first. To keep VS Code working correctly as well, the built
files are symlinked into the source folder.
- TS libraries are not implicitly linked to node_modules, so they
can't be imported with an absolute name like "lib/proto" - we need
to use relative paths like "../lib/proto" instead. Adjusting "paths"
in tsconfig.json makes it work for TS compilation, but then it fails
at the esbuild stage. We could resolve it by wrapping the TS
libraries in a subsequent js_library() call, but that has the downside
of losing the transient dependencies, meaning they need to be listed
again.  Alternatively we might be able to solve it in the future by
adjusting esbuild, but for now the paths have been made relative to
keep things simple.

Upsides:

- Along with updates to the Svelte tooling, Svelte typing has improved.
All exports made in a Svelte file are now visible to other files that
import them, and we no longer rebuild the Svelte files when TS files
are updated, as the Svelte files do no type checking themselves, and
are just a simple transpilation. Svelte-check now works on Windows again,
and there should be no errors when editing in VS Code after you've
built the project. The only downside seems to be that cmd+clicking
on a Svelte imports jumps to the .d.ts file instead of the original now;
presumably they'll fix that in a future plugin update.
- Each subfolder now has its own tsconfig.json, and tsc can be called
directly for testing purposes (but beware it will place build products
in the source tree): ts/node_modules/.bin/tsc -b ts
- We can drop the custom esbuild_toolchain, as it's included in the
latest rules_nodejs.

Other changes:

- "image_module_support" is moved into lib/, and imported with
<reference types=...>
- Images are now imported directly from their npm package; the
extra copy step has been removed.

Windows users may need to use "bazel clean" before building this,
due to old files lying around in the build folder.
2021-10-01 12:52:53 +10:00
Damien Elmes
2ea7a06234 update translations 2021-09-13 14:58:03 +10:00
Damien Elmes
9f0929db32 update translations 2021-09-08 19:19:53 +10:00
Damien Elmes
31b0729ee1 update translations 2021-09-06 18:31:36 +10:00
Damien Elmes
3077a1f98a update translations 2021-08-25 11:21:21 +10:00
Damien Elmes
8417cde5c9 update translations 2021-08-22 15:32:46 +10:00
Damien Elmes
d34ee84844 update translations 2021-08-19 20:26:43 +10:00
Damien Elmes
ead71a8895 update translations 2021-07-30 18:28:19 +10:00
Damien Elmes
c1ec0fb191 update translations 2021-07-30 10:27:08 +10:00
Damien Elmes
a6fbb1227a update translations 2021-07-27 13:03:13 +10:00
Damien Elmes
49f7e0c083 update translations 2021-07-24 21:47:41 +10:00
Damien Elmes
99e3ad7690 update translations 2021-07-17 18:30:19 +10:00
Damien Elmes
60f6fcccdc update translations 2021-07-13 16:12:29 +10:00
Damien Elmes
a69ed9054d update translations 2021-07-13 13:32:33 +10:00
Damien Elmes
6ffa744096 update translations 2021-07-04 21:41:34 +10:00
Damien Elmes
90fdcebcc8 update translations 2021-06-29 13:17:03 +10:00
Damien Elmes
6b730fab9b update translations 2021-06-24 14:48:48 +10:00
Damien Elmes
d1a49ef777 update translations 2021-06-21 22:37:33 +10:00
Damien Elmes
2bfb0c9286 update to latest rules_rust
- bumps rust version to 1.53
- drops support for incremental building, which is currently
disabled in stable Rust releases due to bugs. 'cargo check' can still
be used to quickly check things compile
2021-06-21 13:09:36 +10:00
Damien Elmes
108af51abe switch to latest rules_pip
Closes #1245
2021-06-21 13:09:36 +10:00
Damien Elmes
0b43b1f641 update translations 2021-06-08 15:40:09 +10:00
Damien Elmes
760ce5de5e update translations 2021-06-08 14:07:52 +10:00
Damien Elmes
20276b6c48 update translations 2021-06-04 20:08:14 +10:00
Damien Elmes
c7e4efd17b yet another esbuild update for arm64 2021-06-01 10:11:37 +10:00
Damien Elmes
8f5c2eb0a3 another update for esbuild arm64 2021-05-31 22:23:45 +10:00
Damien Elmes
8d60bfee2c update esbuild-toolchain for arm64 2021-05-29 10:14:23 +10:00
Damien Elmes
6afd65d5eb update translations 2021-05-26 14:41:39 +10:00
Damien Elmes
cdc40c1ce4 update rules_nodejs 2021-05-26 09:12:23 +10:00
Damien Elmes
aeba725d3e update translations 2021-05-08 19:16:22 +10:00
Damien Elmes
f6a1a35113 update translations 2021-04-25 22:06:05 +10:00
Damien Elmes
42c466223e bump rules_nodejs version 2021-04-23 11:11:47 +10:00
Damien Elmes
5449198649 update translations 2021-04-20 21:41:10 +10:00
Damien Elmes
13d415f8e3 move esbuild into separate repo
Most of our changes have been upstreamed, but the toolchain change
probably won't be merged soon, and a separate git repo will make it
easier to track upstream changes.

@hgiesel output_css=True will need to be changed to output_css="foo.css"
instead
2021-04-15 10:53:49 +10:00
Damien Elmes
a8da8faa30 update rules_nodejs 2021-04-15 09:47:18 +10:00
Damien Elmes
1cc63f9267 update to latest rules_rust incremental compilation 2021-04-09 12:48:24 +10:00
Damien Elmes
605ec7898f switch to new upstream rules_nodejs release 2021-04-08 11:56:09 +10:00
Damien Elmes
9ce129efbc update rules_nodejs for public toolchain fix 2021-04-07 18:28:53 +10:00
Damien Elmes
4975f47ea3 update to latest esbuild 2021-04-07 14:54:40 +10:00
Damien Elmes
6f7a4bf29e update rules_rust with worker refactor
If you were using the optional Rust worker support, please see the
change to development.md
2021-03-30 17:24:51 +10:00
Damien Elmes
5160d0c418 update rules_rust for worker fix 2021-03-27 22:47:43 +10:00
Damien Elmes
89d249b3b6 update to the latest rules_rust + security framework update 2021-03-27 19:28:19 +10:00
Damien Elmes
74a10ce73b update translations 2021-03-27 15:59:21 +10:00
Damien Elmes
5a968f93ce update translations 2021-03-27 15:55:30 +10:00
Damien Elmes
a581c082f6 switch from rollup to esbuild
brings the 2+ second bundle on a module like the graphs down to 90ms
2021-03-21 16:06:36 +10:00
Damien Elmes
ea7611d8cc vendor Svelte rules
The separate repo made it difficult to update the rules, and made things
more complicated than they needed to be.
2021-03-20 15:04:19 +10:00
Damien Elmes
58a154c58f Revert "update Svelte"
This reverts commit 0ca9a6b009.

Unfortunately this is breaking the Windows build. It doesn't seem
to break other platforms, so I'm wondering if maybe it's the Windows
path name or some Windows-specific handling in rules_nodejs that is
to blame:

(08:31:03) ERROR: C:/buildkite-agent/builds/win-ci/ankitects/anki-ci/ts/graphs/BUILD.bazel:21:15:
Svelte ts/graphs/FutureDue.svelte.mjs failed: (Exit 1): bash.exe failed: error executing command C:/msys64/usr/bin/bash.exe -c ... (remaining 1 argument(s) skipped)
Error [ERR_REQUIRE_ESM]: Must use import to load ES Module: C:\bazel\ankici\base\external\build_bazel_rules_svelte_deps\node_modules\svelte\compiler.mjs
    at Object.Module._extensions..mjs (internal/modules/cjs/loader.js:1007:9)
    at Module.load (internal/modules/cjs/loader.js:812:32)
    at Function.Module._load (internal/modules/cjs/loader.js:724:14)
    at Module.require (internal/modules/cjs/loader.js:849:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at Object.<anonymous> (C:\bazel\ankici\base\external\build_bazel_rules_svelte\internal\svelte.js:10:16)
    at Module._compile (internal/modules/cjs/loader.js:956:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:973:10)
    at Module.load (internal/modules/cjs/loader.js:812:32)
    at Function.Module._load (internal/modules/cjs/loader.js:724:14)
2021-03-20 10:56:20 +10:00
Damien Elmes
1e57a753da update rules_nodejs 2021-03-20 10:54:18 +10:00
Damien Elmes
0ca9a6b009 update Svelte 2021-03-20 08:29:45 +10:00
Damien Elmes
bb65d7bfda update translations 2021-03-10 12:04:34 +10:00