Henrik Giesel
83d5d72777
Generalize inListItem to getAnchorElement
2021-04-20 13:44:43 +02:00
Henrik Giesel
cd33e1b05f
Add CSS for making empty paragraph elements visible
2021-04-20 13:44:43 +02:00
Damien Elmes
6b8c069900
Merge pull request #1139 from hgiesel/toolbarfixes
...
Fix ButtonDropdown not hiding when closed
2021-04-20 19:54:51 +10:00
Damien Elmes
55277aa90a
implement deck config saving on JS end
2021-04-20 19:50:05 +10:00
Damien Elmes
094c272294
allow postrequest to send a binary body; fix WithGraphData
...
As far as I can tell, the existing code was transforming the encoded
protobuf data into UTF8, and we're just lucky it wasn't causing problems
with the small message we were sending.
2021-04-20 17:47:52 +10:00
Damien Elmes
10b7ab2c6d
include sourcemaps for pages/* in dev builds
2021-04-20 17:33:46 +10:00
Damien Elmes
4d1cedc8b2
implement deck config updating
2021-04-20 14:57:44 +10:00
Henrik Giesel
b35f5cdae0
Hide ButtonDropdown when closed
...
Otherwise ul.{svelte-class} in ButtonGroup has higher priority then .show from Bootstrap
2021-04-19 14:47:10 +02:00
Damien Elmes
3abe6168aa
tweak deckconfig top area formatting
...
I suspect there's a better way to ensure selector and save button are
shown on the same line on both large and small widths; PRs are welcome.
2021-04-18 17:33:12 +10:00
Damien Elmes
76eb119870
add schema change prompt to removal, tweak return struct
2021-04-18 17:33:12 +10:00
Damien Elmes
6e3eff9f44
move daily limits into separate section; add extra warning+tweak formatting
2021-04-18 00:04:02 +10:00
Damien Elmes
460ff354da
apply spinbox limits on each keystroke
2021-04-18 00:03:02 +10:00
Damien Elmes
4e63de0625
avoid showing the strings twice
...
While it can help to show the link between the settings, having multiple
sections change at once feels a bit over the top
2021-04-17 22:56:55 +10:00
Damien Elmes
328f1af8db
add text to describe deckconfig warnings
2021-04-17 22:53:47 +10:00
Damien Elmes
c24cfc041e
update config automatically, and update parent limits at same time
2021-04-17 21:44:33 +10:00
Damien Elmes
633e93904a
add some unit tests to deckconfig
2021-04-17 21:00:10 +10:00
Damien Elmes
25c52444b5
add a hack to avoid Long.js in Jest tests
2021-04-17 17:05:48 +10:00
Damien Elmes
377ba1471e
support es6 imports in Jest tests
...
Switching to lodash-es caused Jest to fail. The standard Jest workflow
would be to transpile things with Bazel, but we can do it faster by
bundling with esbuild.
the log in lib.test.ts has revealed numbers are being set as Long instead
of JS numbers, and the published workaround for it is not working :-(
2021-04-17 16:38:45 +10:00
Damien Elmes
8cf8c901fe
fix parent limit handling
...
We can't calculate it on the backend, as adjusting a config may alter
the parent limit.
Also fix hidden deck name and missing separator.
2021-04-17 12:53:59 +10:00
Damien Elmes
f869148d5e
Merge pull request #1134 from hgiesel/formatblock
...
Add block formatting options to Editor
2021-04-17 09:40:52 +10:00
Henrik Giesel
b195c9f2d5
Satisfy svelte_check
2021-04-16 19:00:36 +02:00
Henrik Giesel
d66d229d15
Color ButtonDropdown background in var(--bg-color) regardless of theme
2021-04-16 18:36:54 +02:00
Henrik Giesel
caa052e37e
Make clearer which parts of ButtonGroup css are theming related
2021-04-16 18:24:43 +02:00
Henrik Giesel
b60f9cd05d
Change style for Dropdown{Menu,Item} to match Button{Group,Dropdown}
2021-04-16 18:14:09 +02:00
Henrik Giesel
f2e313664c
Adjust ButtonDropdown for night mode
2021-04-16 17:14:47 +02:00
Henrik Giesel
21dced4ae8
Mark indent / outdent as non activatable
2021-04-16 16:11:53 +02:00
Henrik Giesel
3eab17ed0f
Add Fluent translations
2021-04-16 16:08:00 +02:00
Damien Elmes
d158450e89
add macro for invoking Jest
2021-04-16 23:46:31 +10:00
Damien Elmes
c3fc07ac20
more experimental updates to deck config screen
...
- try out bootstrap modals - they're not perfect, but let's see how
they go for now. Won't be hard to switch to bridge commands if required.
- handle adding/renaming/removing
- add a class to manage the state
2021-04-16 23:29:21 +10:00
Henrik Giesel
48cc9c602f
Add justify and indentation menu
2021-04-16 15:26:49 +02:00
Damien Elmes
a6ed8e90ce
support passing @types/... into svelte-check
2021-04-16 23:18:33 +10:00
Damien Elmes
03f3dfa3d9
switch to full lodash library
...
Individual packages are going away in v5, and we can rely on tree
shaking to only get what we need.
2021-04-16 20:14:17 +10:00
Damien Elmes
7165d06bf2
Merge pull request #1131 from glutanimate/fix-asyncreactivedata-typo
...
Fix minor typo
2021-04-16 11:58:58 +10:00
Henrik Giesel
5414d9f826
Add ol and ul buttons, rename previous format to formatInline
2021-04-16 03:46:37 +02:00
Henrik Giesel
4a8a051999
Satisfy ./script/svelte-check
2021-04-16 03:10:39 +02:00
Henrik Giesel
7d32d909ba
Remove unnecessary comments / dead code
2021-04-16 02:51:03 +02:00
Damien Elmes
a32bb47b9b
quiet esbuild output and format file
2021-04-16 10:27:09 +10:00
Henrik Giesel
0f01e421be
Solve the race conditions of button insertion by operating on promises in EditorToolbar
2021-04-16 02:04:38 +02:00
Henrik Giesel
ccc48bd1d7
Abandon btn-secondary and btn-light in favor our own definitions btn-night and btn-day
2021-04-15 18:35:46 +02:00
Glutanimate
7afe62a4d1
Fix minor typo
2021-04-15 18:30:53 +02:00
Henrik Giesel
304a7f2f77
Make fields square again
...
This was an experiment, to adjust the field border-radius to the
buttons, but I think it looks cleaner if the fields are square
2021-04-15 16:44:07 +02:00
Henrik Giesel
b0885ef0cd
Add license headers
2021-04-15 15:59:52 +02:00
Henrik Giesel
bd4fe7cc93
Use bootstrap types for editor-toolbar svelte_check
2021-04-15 15:51:56 +02:00
Henrik Giesel
fb8a2f4dc8
Experimental: Add bootstrap to svelte_check dependencies
2021-04-15 15:47:02 +02:00
Henrik Giesel
449d28596e
Pass svelte_check for editor-toolbar
2021-04-15 15:33:47 +02:00
Henrik Giesel
82f6e19955
Add Latex formatting options to menu
...
* Format shortcuts in monospace font and increase padding a little bit
2021-04-15 15:20:37 +02:00
Henrik Giesel
12c0a26dc9
Satisfy prettier
2021-04-15 14:58:13 +02:00
Henrik Giesel
f9565cbb80
Use new bootstrap library paths
2021-04-15 14:04:41 +02:00
Henrik Giesel
d07086da19
Use new bootstrap dep
2021-04-15 13:30:19 +02:00
Henrik Giesel
58a85d8386
Add shortcut labels for mathjax menu
2021-04-15 13:09:51 +02:00
Henrik Giesel
5225ef31b3
Explicitly name file in output_css for esbuild
2021-04-15 13:09:51 +02:00
Henrik Giesel
60515f579e
Make editor-toolbar pass eslint
2021-04-15 13:09:51 +02:00
Henrik Giesel
b0fab9c967
Fix most of svelte-check issues for editor-toolbar
2021-04-15 13:09:51 +02:00
Henrik Giesel
efc867815a
Pass the svelte check for graphs
2021-04-15 13:09:50 +02:00
Henrik Giesel
e3a3ca3f25
Inline GraphData/GraphPreferences getters/setters into WithGraphData
2021-04-15 13:09:50 +02:00
Henrik Giesel
13decbe608
Generalize ts/graphs/preferences to ts/sveltelib/preferences
2021-04-15 13:09:50 +02:00
Henrik Giesel
b696635afc
Style light mode button bar with borders
...
- whereas night mode toolbar has no visible borders
2021-04-15 13:09:50 +02:00
Henrik Giesel
e732eca097
Use padding for extended colorpicker background "border"
2021-04-15 13:09:50 +02:00
Henrik Giesel
dd530dcdc8
Give light mode effects on hover/active/focus as well
2021-04-15 13:09:50 +02:00
Henrik Giesel
8760bd9ac6
Add theming support for DropdownItem and DropdownMenu
2021-04-15 13:09:50 +02:00
Henrik Giesel
49daa2dd01
Improve looks of color picker button
2021-04-15 13:09:50 +02:00
Henrik Giesel
02c8893fc9
Update CSS for ColorPicker and forecolor button
2021-04-15 13:09:50 +02:00
Henrik Giesel
9f740f307d
Switch from core to base CSS for editor view
2021-04-15 13:09:50 +02:00
Henrik Giesel
0133652d04
Correctly check for night mode
2021-04-15 13:09:50 +02:00
Henrik Giesel
d6d4269aaf
Rely more heavily on bootstrap provided types for editor-toolbar
2021-04-15 13:09:50 +02:00
Henrik Giesel
e6996ae5d3
Make mdi also use renamed pkg_from_name
2021-04-15 13:09:50 +02:00
Henrik Giesel
443cef6b15
Add buttons_mixins.scss for sharing SCSS across components
2021-04-15 13:09:50 +02:00
Henrik Giesel
00d8d869f4
Also add Bootstrap buttons.scss
2021-04-15 13:09:50 +02:00
Henrik Giesel
8f7c32fcf9
Include Dropdown directly from bootstrap, required installing popperjs
2021-04-15 13:09:50 +02:00
Henrik Giesel
38cc0dfce5
Use compile_sass and add flag to make editor-toolbar compile again
2021-04-15 13:09:50 +02:00
Henrik Giesel
1eafa7d9d0
Remove $$restProps and make explicit dropdown support in buttons
...
* Currently LabelButton, CommandIconButtton, and IconButton support dropdowns
2021-04-15 13:09:50 +02:00
Henrik Giesel
920b740c8f
Add RawButton and hook old python hooks up to it
2021-04-15 13:09:50 +02:00
Henrik Giesel
432e0a5079
Introduce ToolbarItem as a better base type instead of DynamicSvelteComponent
2021-04-15 13:09:50 +02:00
Henrik Giesel
b364ae5542
Switch from lazy loading of properties to wrapping the buttons in a function
2021-04-15 13:09:50 +02:00
Henrik Giesel
d6ad5084f1
Add a button / buttonGroup insertion API
2021-04-15 13:09:50 +02:00
Henrik Giesel
8fd21661b4
Fix sticky toolbar which was broken when introducing var(--toolbar-size)
2021-04-15 13:09:50 +02:00
Henrik Giesel
eceb98f8e6
Show/Hide Cloze button depending on whether cloze type
2021-04-15 13:09:50 +02:00
Henrik Giesel
fe4ba87490
Move cloze logic and wrapping logic editor-toolbar
2021-04-15 13:09:50 +02:00
Henrik Giesel
cbf72c0f05
Make buttons and button groups easily toggleable through hidden web component
2021-04-15 13:09:50 +02:00
Henrik Giesel
4c273caedb
Remove props property in favor of $$restProps
2021-04-15 13:09:50 +02:00
Henrik Giesel
f88b9d64d3
Get rid of types.d.ts in favor of DynamicSvelteComponent
2021-04-15 13:09:50 +02:00
Henrik Giesel
86c57d5b75
Pass button groups as actual button groups, not arrays
2021-04-15 13:09:50 +02:00
Henrik Giesel
d3e1bfa841
Pass wraps more similiar to how size is passed via CSS variables
2021-04-15 13:09:50 +02:00
Henrik Giesel
59884df70b
Make wraps a passable prop to EditorToolbar
...
Can be set to nowrap via document.getElementByID("editorToolbar").component.$set({ wraps: false })
2021-04-15 13:09:50 +02:00
Henrik Giesel
bf33397855
Give clearer type names to dynamicComponent
2021-04-15 13:09:50 +02:00
Henrik Giesel
a2d37206ea
Rename title to tooltip across editor toolbar components
2021-04-15 13:09:50 +02:00
Henrik Giesel
8e1092d2c4
Rename types.ts to types.d.ts
2021-04-15 13:09:50 +02:00
Henrik Giesel
120e1452e3
Change overflow of button groups to overflow-y auto
...
Avoids erratic creation of scrollbars
2021-04-15 13:09:50 +02:00
Henrik Giesel
c7590c8ef1
Use dynamicComponent instead of withLazyProps
2021-04-15 13:09:50 +02:00
Henrik Giesel
28201670ee
Move enabled/disabled logic to EditorToolbar
2021-04-15 13:09:50 +02:00
Henrik Giesel
2046b00c38
Fix clicking the bold button immediately showing the updated button state
...
- rather than only after typing
2021-04-15 13:09:49 +02:00
Henrik Giesel
bb64f73c1a
Support building as external repo
2021-04-15 13:09:49 +02:00
Henrik Giesel
10952de3c5
Remove lazyProperties -> we use withLazyProperties instead
2021-04-15 13:09:49 +02:00
Henrik Giesel
37ed3e8209
Fix some code quality issues
2021-04-15 13:09:49 +02:00
Henrik Giesel
96feba7a3e
Pass in buttons and menus directly as stores
2021-04-15 13:09:49 +02:00
Henrik Giesel
8b906100c0
Make --toolbar-size a parameter
2021-04-15 13:09:49 +02:00
Henrik Giesel
9cbab08b00
Add ButtonDropdown for dropdowns like the MathJax dropdown on AnkiMobile
2021-04-15 13:09:49 +02:00
Henrik Giesel
6953389798
Add exports for add-ons
2021-04-15 13:09:49 +02:00
Henrik Giesel
45992b68cd
Make it easier to update buttons and menus
2021-04-15 13:09:49 +02:00
Henrik Giesel
7f42b38e7a
Add labels and titles to all buttons
2021-04-15 13:09:49 +02:00
Henrik Giesel
216b93c060
Add titles to buttons with lazyProperties
2021-04-15 13:09:49 +02:00
Henrik Giesel
4e6d5d9adb
Move logic from index.ts to their individual files
2021-04-15 13:09:49 +02:00
Henrik Giesel
3ddbc1e6c3
Add first lazily loaded i18n strings
2021-04-15 13:09:49 +02:00
Henrik Giesel
9b68a5c2c3
Give select an effect on :hover
2021-04-15 13:09:49 +02:00
Henrik Giesel
5f498e6142
Make select display inline-block
2021-04-15 13:09:49 +02:00
Henrik Giesel
fb668c56e6
Make Toolbar resizable through a single CSS variable --toolbar-size
2021-04-15 13:09:49 +02:00
Henrik Giesel
f526b51ea2
Add SelectButton
2021-04-15 13:09:49 +02:00
Henrik Giesel
fa900e1565
Add dropdown menu to mathjax button
2021-04-15 13:09:49 +02:00
Henrik Giesel
391f64f648
Make it so you can include DropdownMenus on all kinds of buttons
2021-04-15 13:09:49 +02:00
Henrik Giesel
5eb07d3fc7
WIP: Turn DropdownMenu into a _decorator_ usable with all other button types
2021-04-15 13:09:49 +02:00
Henrik Giesel
a820059b8f
Utilize enableButtons disableButtons from Svelte component
2021-04-15 13:09:49 +02:00
Henrik Giesel
9340d20c20
Display .active:active as :hover buttons
2021-04-15 13:09:49 +02:00
Henrik Giesel
4280bf28f8
Add active shadow on ColorPicker
2021-04-15 13:09:49 +02:00
Henrik Giesel
e25583d7ff
Move display:flex from outer div to ButtonGroup ul
2021-04-15 13:09:49 +02:00
Henrik Giesel
7f5e9b1b33
Add negative tabindex
2021-04-15 13:09:49 +02:00
Henrik Giesel
b5b9c79f1c
Add mathjaxButton and htmlButton instead of more button
2021-04-15 13:09:49 +02:00
Henrik Giesel
77de6c0288
Make icons slightly smaller, so they are the same size as before
2021-04-15 13:09:49 +02:00
Henrik Giesel
12021228a5
Make all buttons functional
2021-04-15 13:09:49 +02:00
Henrik Giesel
2f808fe60c
Move initialization logic from EditorToolbar to index.ts
2021-04-15 13:09:49 +02:00
Henrik Giesel
bf433f13be
Simplify General Toolbar structure
2021-04-15 13:09:49 +02:00
Henrik Giesel
773f431bb8
Merge buttons to one OuterButtonGroup
...
- keeping up the concept of left / right buttons might not be necessary anymore
- This might make it easier to display them on mobile, and simplifies the logic
2021-04-15 13:09:49 +02:00
Henrik Giesel
8c931af17c
Make all Leaf buttons 30px high and give same vertical-align
2021-04-15 13:09:49 +02:00
Henrik Giesel
0269c97b2e
Rename IconButtonInner to InnerButton, as it does not necessarily contain an Icon
2021-04-15 13:09:49 +02:00
Henrik Giesel
a12e39a15f
Add hover and active effects
2021-04-15 13:09:49 +02:00
Henrik Giesel
b26c4294ec
Display ButtonGroups inline-block
2021-04-15 13:09:49 +02:00
Henrik Giesel
9563da37d3
Add ButtonGroup for grouping of toolbar items
2021-04-15 13:09:49 +02:00
Henrik Giesel
ccb7c5d68a
Add CommandIconButton functionality
2021-04-15 13:09:49 +02:00
Henrik Giesel
0963d53e0c
Add color.ts for foreground color and color picker
2021-04-15 13:09:49 +02:00
Henrik Giesel
fee78d2570
Add remaining icons for toolbar
2021-04-15 13:09:49 +02:00
Henrik Giesel
a0a9619722
Include icons directly in ts lib
2021-04-15 13:09:49 +02:00
Henrik Giesel
7787a7827f
First implementation
2021-04-15 13:09:48 +02:00
Henrik Giesel
de77e40e4d
Add ts/editor-toolbar
2021-04-15 13:09:48 +02:00
Damien Elmes
6f3e682c9f
move bootstrap into ts/sass
2021-04-15 16:10:01 +10:00
Damien Elmes
b0206ec1bf
support external building of sass; node_modules->ts/bootstrap
2021-04-15 15:59:17 +10:00
Damien Elmes
6cee43631a
allow passing sass deps to svelte compile/check
2021-04-15 14:27:53 +10:00
Damien Elmes
2d417b1160
update other ts deps
2021-04-15 10:59:29 +10:00
Damien Elmes
121e8db22a
remove unused esbuild package, and update rules_nodejs packages
2021-04-15 10:57:19 +10:00
Damien Elmes
13d415f8e3
move esbuild into separate repo
...
Most of our changes have been upstreamed, but the toolchain change
probably won't be merged soon, and a separate git repo will make it
easier to track upstream changes.
@hgiesel output_css=True will need to be changed to output_css="foo.css"
instead
2021-04-15 10:53:49 +10:00
Damien Elmes
b9b1fe81b1
fix initial ease not being updated
2021-04-14 23:01:03 +10:00
Damien Elmes
7f738c11a2
deck config prototype work in progress
...
Still in the early stages, and not hooked up yet.
2021-04-14 22:33:10 +10:00
Damien Elmes
e6306bb29d
Merge pull request #1128 from hgiesel/webviewcss3
...
Remove unnecessary exports from sass/BUILD.bazel
2021-04-14 21:28:25 +10:00
Damien Elmes
646b58a1a9
experiment with making bootstrap scss available as a library
...
This will allow us to import the local sass lib, then use something
like the following in our sass:
@import "ts/bootstrap/functions";
@import "ts/bootstrap/variables";
@import "ts/bootstrap/mixins";
@import "ts/bootstrap/helpers";
@import "ts/bootstrap/dropdown";
@import "ts/bootstrap/forms";
@import "ts/bootstrap/buttons";
@import "ts/bootstrap/button-group";
I'm currently trialing it out on a prototype reimplementation of the
deck options screen. Unfortunately bootstrap don't seem to support the
@use syntax, so we need to @import everything
2021-04-14 21:27:34 +10:00
Henrik Giesel
a9439eaf02
Remove unnecessary exports from sass/BUILD.bazel
...
I think these were just part of an unsuccessful experiment
Partially reverses cfb9ed267f
2021-04-14 12:31:42 +02:00
Damien Elmes
cca9195ea5
run prettier on some sass files
2021-04-14 18:22:33 +10:00
Damien Elmes
c49d6ce49f
run black/isort on Python scripts
2021-04-14 18:22:02 +10:00
Damien Elmes
7b2b4528b3
Merge pull request #1125 from hgiesel/scrollbarcorner
...
Color Scrollbar bottom right corner
2021-04-14 12:43:34 +10:00
Henrik Giesel
f891a98087
Color in the Scrollbar corner at the bottom right into the appropriate color
2021-04-13 21:41:15 +02:00
Henrik Giesel
cfb9ed267f
Create explicit dependencies for the congrats,editor,graphs scss files
2021-04-13 19:47:03 +02:00
Henrik Giesel
a76f1d64ad
Move compile_sass.bzl to /ts + Remove core.css from data/web (unused?)
2021-04-13 19:47:03 +02:00
Henrik Giesel
ffd159f9a0
Declare dependencies in data/web/css
2021-04-13 19:47:03 +02:00
Henrik Giesel
85808e4cbf
Make h1 explicitly bold in Graph.svelte
2021-04-13 19:47:03 +02:00
Henrik Giesel
8f0f8f9af8
Use graphs-base and congrats-base
2021-04-13 19:47:03 +02:00
Henrik Giesel
fee6ee7319
Do not include webview.css for editor
2021-04-13 19:47:03 +02:00
Henrik Giesel
825509ba0c
Move card_counts and split off fusion_vars
2021-04-13 19:47:03 +02:00
Henrik Giesel
fbc21f0090
Add base.scss
2021-04-13 19:47:03 +02:00
Damien Elmes
62423bd041
add missing copyright headers to *.svelte
2021-04-13 19:02:41 +10:00
Damien Elmes
e520e8df02
add missing copyright headers to *.ts
2021-04-13 18:57:08 +10:00
Damien Elmes
26ac64526c
disable Jest tests on Windows again
...
It looks like the templated_args change only masked the error last time;
Jest seems broken on Windows with both the patched .24 version, latest
stable, and the new beta version too, presumably because symlinks are
being handled differently on Windows somehow. It might be possible to
hack around the issue by patching the following file, but I'm not sure:
https://github.com/facebook/jest/blob/master/packages/jest-haste-map/src/crawlers/node.ts
2021-04-12 15:39:46 +10:00
Damien Elmes
9440898e60
add naturalWholeUnit() and basic tests to lib/time.ts
...
naturalWholeUnit() is not currently used
2021-04-12 14:42:06 +10:00
Damien Elmes
829b99e5b2
force number in protobuf generation
...
Anki's object IDs and millisecond timestamps fit within MAX_SAFE_INTEGER.
2021-04-12 14:33:20 +10:00
Damien Elmes
6e4cdc52a6
stop Svelte warnings from failing the build
...
+ check for them at test time
2021-04-12 14:28:09 +10:00
Damien Elmes
94330fc0eb
fix jest
...
- templated_args was missing --node_modules= prefix, and was causing
tests to pass unconditionally
- update to beta of jest 27, which introduces an option to fix the
symlink handling, and is approx twice as fast to start up
2021-04-12 09:43:31 +10:00
Damien Elmes
c1c14419a2
switch esbuild to a toolchain
2021-04-07 15:19:23 +10:00
Damien Elmes
4975f47ea3
update to latest esbuild
2021-04-07 14:54:40 +10:00
abdo
09985ce57f
Fix graph labels display in RTL layout
2021-04-02 06:25:38 +03:00
Damien Elmes
ddcb2adf71
add docstring to forEditorField
2021-03-29 18:13:45 +10:00
Damien Elmes
0e4bcbd69b
Merge pull request #1101 from Arthur-Milchior/TS_type
...
NF: add type ts
2021-03-29 18:09:56 +10:00
Damien Elmes
f1780e6e24
move loader arg into esbuild() invocation
...
upstream.bzl should be kept as close to upstream as possible, so that
it's easier to send changes upstream and pull in future changes
2021-03-29 17:59:06 +10:00
Arthur Milchior
a114f36b4c
NF: add type ts
2021-03-28 23:59:16 +02:00
Henrik Giesel
922ee56ce8
Add copy_bootstrap_icons macro
2021-03-28 18:50:37 +02:00
Henrik Giesel
7dcb3ae678
Include pin-angle icon via inline SVG
2021-03-28 16:15:30 +02:00
Damien Elmes
dbfbcc36c6
define file extension in .d.ts so typescript doesn't complain
2021-03-28 16:15:28 +02:00
Henrik Giesel
3a44ffe2bb
Unsuccessfully try to add text loader for .svg files
2021-03-28 16:14:52 +02:00
Henrik Giesel
bbea9ac9d7
Remove bootstrap-icons from css folder
2021-03-28 16:14:52 +02:00
Damien Elmes
0d49b3eabb
move back to latest Jest
...
Patch is no longer required after previous change
2021-03-28 21:44:55 +10:00
Damien Elmes
493557aee7
fix Jest on Windows
2021-03-28 20:59:51 +10:00
Damien Elmes
f46f4cbf17
Revert "disable Jest tests on Windows for now"
...
This reverts commit 36022844bb
.
2021-03-28 20:59:31 +10:00
Damien Elmes
36022844bb
disable Jest tests on Windows for now
2021-03-28 20:34:10 +10:00
Damien Elmes
c891f45ed9
add Jest for TS unit tests
...
@hgiesel the reason no files were being found is because Jest ignores
symlinks by default. The Bazel example includes a patch we can use
to work around it, and Jest plan to add symlink support in a future
update.
https://github.com/bazelbuild/rules_nodejs/blob/stable/examples/jest/patches/jest-haste-map%2B24.9.0.patch
https://github.com/facebook/jest/pull/9351
2021-03-28 19:41:20 +10:00
Henrik Giesel
05ea624f85
Utilize ts/tsconfig.js from ts/{editor,html-filter}
2021-03-28 19:41:20 +10:00
Henrik Giesel
fb9461508e
No need to explicitly import from index
2021-03-28 19:41:20 +10:00
Henrik Giesel
35beebcfa6
Satisfy formatter
2021-03-28 19:41:20 +10:00
Henrik Giesel
861c723ec0
Avoid using outerHTML + Fix regression
2021-03-28 19:41:20 +10:00
Henrik Giesel
f9259621a6
Change filter logic in html-filter/element: predicate true, means it stays in
2021-03-28 19:41:20 +10:00
Henrik Giesel
519aea2ea8
Move html-filter into its own directory
2021-03-28 19:41:20 +10:00
Henrik Giesel
730dfdd527
Insert break statements into switch
2021-03-28 19:41:20 +10:00
Henrik Giesel
39aa549ac9
Create htmlFilter{Node,Styling} for better separation of concerns
2021-03-28 19:41:20 +10:00
Henrik Giesel
d3d3720b39
Put filterElement logic completely into its own file
2021-03-28 19:41:20 +10:00
Henrik Giesel
1d4d7fabec
Move most of tags allowed to its own file
2021-03-28 19:41:20 +10:00
Henrik Giesel
592d73c344
Refactor htmlFilter to use function declarations
2021-03-28 19:41:20 +10:00
Damien Elmes
76127126a6
use relative link to sass file
...
links relative to workspace root break when invoked from an external
repo
2021-03-28 12:37:21 +10:00
Damien Elmes
f3a3bb5467
add links to pending PRs
2021-03-28 12:32:40 +10:00
Damien Elmes
559d1a4793
fix(esbuild): files not being found when building external repo
...
An esbuild rule that ran fine in a local repo (eg bazel build //:my_esbuild_rule)
fails when built externally (eg bazel build @other_workspace//:my_esbuild_rule).
By prepending the workspace root to the bin path, the resulting base
URL works correctly in both local and remote repo invocations, allowing
esbuild output to be consumed by a different repo.
This change fixes remote repos in Bazel 4.0.0. 3.7.0 seems to require a
workspace_root.replace("external/", "") call first in order
to get the correct location. So while this patch should not break anything
that was not already broken, it only fixes/adds support for remote repos
in 4.0+.
2021-03-28 11:30:15 +10:00
Damien Elmes
08fd7a4747
add esbuild/helpers.bzl in from upstream
2021-03-28 11:12:23 +10:00
Damien Elmes
b23642d568
update $(location ...) in esbuild inject lines
2021-03-28 09:35:46 +10:00
Damien Elmes
944528d462
support expanding locations in esbuild arguments
2021-03-28 09:35:27 +10:00
Damien Elmes
fd324d4711
update TS deps
2021-03-27 15:02:02 +10:00
Damien Elmes
d2eb5c32f4
remove obsolete comment
2021-03-26 21:47:23 +10:00
Damien Elmes
b57e9be46f
allow js to request specific i18n modules
...
Brings the payload on the congrats page with a non-English language
down from about 150k to 15k
2021-03-26 21:43:36 +10:00
Damien Elmes
8920a6f9ea
fix handling of variables that don't match ts naming style
2021-03-26 21:34:24 +10:00
Damien Elmes
c039845c16
use singleton + free functions for i18n in ts
...
This allows for tree shaking, and reduces the congrats page from 150k
with the old enum solution to about 80k.
2021-03-26 20:38:44 +10:00
Damien Elmes
0de7ab87a5
drop legacy enum from ts/
2021-03-26 19:26:35 +10:00
Damien Elmes
2e704660d6
update remaining TR references in ts/
2021-03-26 19:24:48 +10:00
Damien Elmes
1ca25c563f
update most no-arg TR references in *.svelte
2021-03-26 19:13:30 +10:00
Damien Elmes
cd4572c3dd
update TR references with args in *.svelte
2021-03-26 19:13:30 +10:00
Damien Elmes
df93ed0b15
update TR references with args in *.ts; fix average answer time
2021-03-26 19:10:39 +10:00
Damien Elmes
b435658acb
convert no-arg TR references to method invocations in *.ts
2021-03-26 19:10:27 +10:00
Damien Elmes
264b9204c0
generate ts methods for translations
2021-03-26 18:11:58 +10:00
Damien Elmes
9aece2a7b8
rework translation handling
...
Instead of generating a fluent.proto file with a giant enum, create
a .json file representing the translations that downstream consumers
can use for code generation.
This enables the generation of a separate method for each translation,
with a docstring that shows the actual text, and any required arguments
listed in the function signature.
The codebase is still using the old enum for now; updating it will need
to come in future commits, and the old enum will need to be kept
around, as add-ons are referencing it.
Other changes:
- move translation code into a separate crate
- store the translations on a per-file/module basis, which will allow
us to avoid sending 1000+ strings on each JS page load in the future
- drop the undocumented support for external .ftl files, that we weren't
using
- duplicate strings in translation files are now checked for at build
time
- fix i18n test failing when run outside Bazel
- drop slog dependency in i18n module
2021-03-26 09:41:32 +10:00
Henrik Giesel
7655f14859
Satisfy svelte_check
2021-03-22 15:41:43 +01:00
Henrik Giesel
a418d36c7f
Add type signatures to asyncReactive
2021-03-22 15:30:35 +01:00
Henrik Giesel
6ec721d550
Satisfy formatter
2021-03-22 15:25:49 +01:00
Henrik Giesel
4cd60da7b8
Fix asyncReactive detection of loading
...
- Removed `success` store as it wouldn't work
- We should check for a value in error instead
2021-03-22 15:23:48 +01:00
Henrik Giesel
e23b1b77b7
Partially revert "Make sure RangeBox does not trigger update on stores on creation"
...
This reverts commit 15b19e44b9
.
2021-03-22 15:11:36 +01:00
Henrik Giesel
9bbdc616c4
Remove assignment to preferencesPromise: getPreferences will only be called once
2021-03-22 04:03:52 +01:00
Henrik Giesel
10b8a1c3cb
Move async and asyncReactive to sveltelib
...
- sveltelib is a lib for component-agnostic svelte utils
2021-03-22 03:06:53 +01:00
Henrik Giesel
3c5233297a
Avoid duplicate initial fetching with asyncReactive
2021-03-22 02:58:19 +01:00
Henrik Giesel
15b19e44b9
Make sure RangeBox does not trigger update on stores on creation
2021-03-22 02:50:16 +01:00
Henrik Giesel
0bbe38ebde
Create search and days writable in GraphsPage to allow browserSearch to work
2021-03-22 02:44:08 +01:00
Henrik Giesel
9a864120b2
Fix syntax error introduced by rebase
2021-03-22 01:44:07 +01:00
Henrik Giesel
7dc74004ae
Create BrowserSearch component, because we cannot read from stores within slotted content
2021-03-22 01:42:23 +01:00
Henrik Giesel
6d546b0bca
Remove pending, and resort to checking for value
...
- once value is set, it won't be unset
2021-03-22 01:42:23 +01:00
Henrik Giesel
b3851172ba
Use preferencesPromise, as refreshing is handled over stores
2021-03-22 01:42:23 +01:00
Henrik Giesel
3363c574c9
Use $-assignments instead of store.set
2021-03-22 01:42:23 +01:00
Henrik Giesel
dd2e180f9b
Rename search and days to initialSearch and intitialDays in GraphsPage
2021-03-22 01:42:23 +01:00
Henrik Giesel
672eb20321
Get it to work, if you change the input
...
- there's still an issue on initial load
2021-03-22 01:42:23 +01:00
Henrik Giesel
3f37153558
Compiles with WithGraphData
2021-03-22 01:42:23 +01:00
Henrik Giesel
c107090906
Move Graph-specific html from GraphsPage to Graph.svelte
2021-03-22 01:42:21 +01:00
Henrik Giesel
36e14cd525
Add WithGraphData
2021-03-22 01:40:51 +01:00
Henrik Giesel
e11b31c29d
Rename asyncRefresh to asyncReactive
2021-03-22 01:40:51 +01:00
Henrik Giesel
75a8b7d318
Improve implementation of asyncRefresh
2021-03-22 01:40:51 +01:00
Henrik Giesel
a9c16a3cd8
Add (probably non-working) asyncRefresh
2021-03-22 01:40:51 +01:00
Henrik Giesel
f82a02bd2e
Add Svelte async hook
2021-03-22 01:40:51 +01:00
Henrik Giesel
5b9981e04a
Add comment where to find global styles
2021-03-21 16:04:38 +01:00
Henrik Giesel
af307a6c4a
Move ticks.scss directly into Graph.svelte
2021-03-21 15:59:11 +01:00
Damien Elmes
7d8f19e6e4
merge in Henrik's TS/Svelte refactor with some changes
...
- The previous commits moved the majority of the remaining global css
into components; move the remaining @emotion/css references into
ticks.scss and the styling of the Graph.svelte. This is not as elegant
as the emotion solution, but builds a whole lot faster, and most of
our styling can be scoped to a component anyway.
- Leave the .html files in ts/ for now. AnkiMobile uses them, and
AnkiDroid likely will in the future too. In the long run we'll likely
move to loading the JS into an existing page instead of loading a
separate page, but at that point we can just exclude the .html file from
copy_files_into_group() without affecting other clients.
Closes #1074
2021-03-21 23:01:18 +10:00
Damien Elmes
95ccfc1ed3
move some cumulative-overlay-specific styling out of shared css
2021-03-21 20:18:05 +10:00
Damien Elmes
9dc6e059f2
add HoverColumns.svelte for hoverzone styling
2021-03-21 19:58:39 +10:00
Damien Elmes
7bc41366e8
add CumulativeOverlay.svelte for area styling
2021-03-21 19:50:35 +10:00
Damien Elmes
6e12348cfd
add Tooltip.svelte so we can encapsulating styling
2021-03-21 19:35:38 +10:00
Damien Elmes
dbe5d43ba0
bundle all Svelte css into separate file
...
- svelte compilation outputs a separate .css file for each component
- compilation also adds an "import foo.css" to the top of each generated
.mjs file
- when the .mjs files are bundled into app.js, esbuild creates an app.css
as well
- graphs.scss was renamed to graphs_shared.scss and imported in the
top level GraphsPage. Henrik's style refactoring would be a better path
forward, but I needed to make this change for now, as the filenames were
conflicting.
2021-03-21 16:06:36 +10:00
Damien Elmes
1e14384d88
add support for declaring css output in esbuild call
2021-03-21 16:06:36 +10:00
Damien Elmes
860ae5464c
add upstream esbuild impl so we can add css output support
...
Taken from 4a26898023/packages/esbuild/esbuild.bzl
2021-03-21 16:06:36 +10:00
Damien Elmes
a581c082f6
switch from rollup to esbuild
...
brings the 2+ second bundle on a module like the graphs down to 90ms
2021-03-21 16:06:36 +10:00
Damien Elmes
5403f704d0
ESM import issue on Windows came back again
...
Not sure if I just missed this in the previous change, or whether
the patch_resolver change broke things again.
Previous issue:
e60eb27184
2021-03-21 16:06:07 +10:00
Damien Elmes
e857aa2ea9
output embedded Svelte css into separate .css file for bundling
2021-03-21 16:06:01 +10:00
Damien Elmes
2658d9992e
fixes for Svelte compilation
...
- enable resolver patch on worker binary to ensure js imports work
on subsequent worker requests
- cache ts library content, and use unified interface for cache
- prepare for separate css outputs
2021-03-21 16:05:46 +10:00
Damien Elmes
e0b85865f4
avoid temporary .ts file due to lack of sandbox on Windows
...
Just a quick hack for now to store it in memory, as the temp file
conflicts on Windows due to the lack of a sandbox, and we don't really
have a need to write it to the filesystem anyway.
2021-03-21 00:17:09 +10:00
Damien Elmes
aabcc8a7db
use ts language service for much faster Svelte compiles
2021-03-20 23:49:10 +10:00
Damien Elmes
554081cee3
convert svelte worker to ts
...
Should make it easier to maintain, and ironically it also fixes
the issue with .mjs files from this morning.
2021-03-20 23:13:27 +10:00