Commit Graph

77 Commits

Author SHA1 Message Date
Damien Elmes
4a2f39e8f4 Revert "Remove <br> from empty fields."
This reverts commit 4ca2220117.

The above commit caused a regression with RTL text:
https://anki.tenderapp.com/discussions/ankidesktop/33592-bugs-in-add-box
2019-04-16 18:58:59 +10:00
Damien Elmes
7120607dfe avoid highlighting/tabbing to top bar 2019-04-10 15:16:22 +10:00
Damien Elmes
8dbebe3583 fix fields appearing under editor buttons
https://anki.tenderapp.com/discussions/ankidesktop/33096-editor-buttons-in-additional-rows-overlap-fields-only-when-scrolled-down
2019-04-09 16:29:56 +10:00
Damien Elmes
372d5ed6e8 update copyright and clarify licenses 2019-02-05 14:01:33 +10:00
Damien Elmes
dd01561537 fire saveField("key") when webview loses focus
fixes the following reported issue, caused by currentField
being sent to None:

1. Start from the main view.
2. Click Add
3. In the Add window, change deck
4. In the Choose Deck window, add a new deck, give a random name
5. Back in the Add window, call "Edit HTML"
6. Anki displays an error

This change will mean the editFocusLost hook will not fire when
switching between windows, which is probably an improvement.
2019-02-05 10:46:47 +10:00
Damien Elmes
de38313071 make sure we save field in all blur cases
https://anki.tenderapp.com/discussions/ankidesktop/32268-changes-in-editcurrent-and-addcards-not-taking-effect-when-using-mouse-rather-than-hotkey
2019-01-29 09:51:54 +10:00
David Lönnhager
4ca2220117 Remove <br> from empty fields. 2019-01-19 19:36:55 +01:00
Damien Elmes
2c30ad9593 fix editor buttons overlapping field content
https://anki.tenderapp.com/discussions/ankidesktop/31235-editor-second-row-for-buttons-feature-request
2018-12-03 09:54:51 +10:00
Damien Elmes
09ff23dc70 filter font and background from all html elems in int. paste
https://anki.tenderapp.com/discussions/ankidesktop/30806-font-size-attribute-added-when-copying-text-inside-anki
2018-11-12 15:46:12 +10:00
Damien Elmes
5e5d35e9c1 change purple flag to orange 2018-11-01 14:58:41 +10:00
Damien Elmes
2866248314 add small extra margin to answer button
fixes scrollbar in Japanese mode due to half width counts + full width
times on following screen

https://anki.tenderapp.com/discussions/ankidesktop/29948-214-bugs
2018-09-28 17:52:10 +10:00
Damien Elmes
49096da7f8 enter/space should use selected answer button
https://anki.tenderapp.com/discussions/ankidesktop/29882-selecting-a-button-and-enter-or-space-always-chooses-good
2018-09-24 14:24:17 +10:00
Damien Elmes
b5785f7ec8 add a small margin between buttons during review 2018-09-07 15:51:21 +10:00
Damien Elmes
d1a09d5ed1 ignore title in html paste
https://anki.tenderapp.com/discussions/ankidesktop/29375-paste
2018-08-29 18:49:22 +10:00
Damien Elmes
c3f3a996c5 fix changes made in Windows IME not being saved
https://anki.tenderapp.com/discussions/ankidesktop/28727-last-japanese-edit-in-a-field-doesnt-take-unless-enter-is-pressed-an-extra-time
2018-07-23 12:23:38 +10:00
Damien Elmes
e1338e8733 don't collapse whitespace in extended paste mode
for pre tags
2018-06-15 11:36:12 +10:00
Damien Elmes
46a540e22f sync field contents before applying cloze deletion
based on a patch by dlon:

https://github.com/dae/anki/pull/236
2018-05-28 13:40:35 +10:00
Damien Elmes
cb68be7a1b Revert "Revert "workaround for some drags not being accepted""
This reverts commit e7046ba398.

Without this change, dragging images from Google searches doesn't work on the
latest Chrome (tested on macOS).
2018-05-01 13:24:08 +10:00
Damien Elmes
844778636c preserve cursor position when switching to another window
https://anki.tenderapp.com/discussions/beta-testing/1043-anki-21-beta-37-if-switch-from-another-program-to-continue-editing-the-cursor-will-move-to-the-bottom
2018-04-30 15:26:54 +10:00
Damien Elmes
38178e5281 catch attempts to save field contents to wrong note 2018-04-30 15:15:20 +10:00
Damien Elmes
e7046ba398 Revert "workaround for some drags not being accepted"
This reverts commit 99009be1ca.

didn't fix user's problem, and has introduced issues with the cursor
disappearing
2018-02-05 11:27:14 +10:00
Damien Elmes
99009be1ca workaround for some drags not being accepted
https://anki.tenderapp.com/discussions/ankidesktop/26688-drag-and-drop-not-always-working
2018-01-30 11:06:46 +10:00
Damien Elmes
15df699479 preserve ordered lists 2018-01-27 15:26:41 +10:00
Damien Elmes
fc79f74e46 bigger margins in reviewer 2017-12-28 20:15:11 +10:00
Damien Elmes
3e05002421 don't make the body margin depend on text size 2017-12-24 22:26:55 +10:00
Damien Elmes
fccfdef73d add a flag to keep editor buttons enabled when no field selected 2017-12-08 21:06:16 +10:00
Damien Elmes
fcccf12ba6 night mode 2017-12-04 12:20:56 +10:00
Damien Elmes
b85cc4321b move overflow-wrap into body, apply to editor too 2017-11-29 16:19:34 +10:00
Damien Elmes
eda1849c33 force break word when it hits the reviewer margin 2017-11-28 09:52:56 +10:00
Damien Elmes
8233021419 fix drag&drop failing to save again
I'm guessing the move to qt 5.9.2 caused this regression
2017-10-27 18:06:21 +10:00
Damien Elmes
6fc7fbc8f2 remove unwanted whitespace in paste filter
libreoffice adds newlines to exported HTML which interfere with cloze
deletion
2017-10-26 16:36:34 +10:00
Damien Elmes
a4d32a1200 fix hang on internal paste due to shadowed var 2017-10-26 11:45:05 +10:00
Damien Elmes
b22548dd4f fix arg name 2017-10-26 11:44:51 +10:00
Damien Elmes
1d3e5787a2 separate basic and extended paste modes
- basic mode is the default, and includes only HTML elements that can be
added/edited easily with the default editor
- extended mode is enabled by holding down shift and includes a bunch of
other HTML elements
2017-10-25 20:20:28 +10:00
Damien Elmes
554ff3d8d2 drop experimental prewrap mode
- pasting in prewrap mode had been broken for a while and nobody noticed
- needs changes to export code and cloze handling code to deal with the
newlines
- newline rewriting in filterNode() is likely fragile
- may revisit post 2.1
2017-10-25 19:18:00 +10:00
Damien Elmes
4dbb87e4c1 filter out background and font settings in internal paste
should fix
https://anki.tenderapp.com/discussions/beta-testing/842-issue-when-copy-pasting-add-edit-and-browse-windows
and
https://anki.tenderapp.com/discussions/beta-testing/840-copy-paste-in-anki-editor-causes-copied-text-to-include-redundant-tags-which-is-deterimental-to-ux-when-using-night-mode-addon

this change will of course prevent these attributes from being copied
when they were manually included in the field instead of implicitly set
on the parent - I don't see a good way to distinguish between the two
cases
2017-10-25 17:51:22 +10:00
Damien Elmes
48405c0ee7 fix shift+tab on osx again
presumably broke in upgrade to qt 5.9.2
2017-10-25 16:54:24 +10:00
Damien Elmes
d02901fb7a delay setting q/a if previous operation is still running
fixes incorrect formatting when undoing previous review then immediately
hitting enter
2017-10-24 17:09:22 +10:00
Damien Elmes
324f3716ae ignore tex environments/refs outside of math tags 2017-09-13 13:08:43 +10:00
Damien Elmes
e166b2204d Revert "use inline-block so enter inserts br tags"
This reverts commit fa498626a0.

works for empty fields, but picks up existing separator on existing content
2017-09-13 11:31:24 +10:00
Damien Elmes
fa498626a0 use inline-block so enter inserts br tags 2017-09-13 11:23:09 +10:00
Damien Elmes
4990b2f8eb mathjax tweaks
- drop support for $$ in favour of separate opening and closing tags
- add shortcuts to add mathjax
- don't highlight any clozes in blue if field contains mathjax chars
2017-09-08 19:20:37 +10:00
Damien Elmes
a7ed7fa4e3 fix cutting and copying between fields
the shortcut keys are handled by webengine on platforms other than
osx, so rather than messing with an event filter we catch the cut and
copy events in js and send a signal back
2017-09-02 13:48:03 +10:00
Damien Elmes
a96ddfc3fd allow templates and add-ons to hook into reviewer updated/shown
eg

from anki.hooks import addHook

def prepare(q):
    return q + """
<script>
onUpdateHook.push(function () {
    window.scrollTo(0, 2000);
})
</script>"""

addHook('prepareQuestion', prepare)
2017-08-28 14:54:22 +10:00
Damien Elmes
db5d23d9dc catch exceptions when setting HTML
thanks to Alicia for the original solution:
dee4c98e9b
2017-08-17 20:02:28 +10:00
Damien Elmes
53fb3b0e8c only macs seem to require the shift+tab fix 2017-08-16 21:51:57 +10:00
Damien Elmes
4467b7c991 restore marking support
maybe multiple mark types would make sense in the future, but for now
let's stick to what will work in the older clients
2017-08-16 20:30:29 +10:00
Damien Elmes
d0389e138e Merge pull request #197 from techdavid/fix-bottom-drag-default
Fix decks being moved to the default deck when dragged to the bottom
2017-08-15 21:21:52 +10:00
Damien Elmes
a16aa73d6e switch to svg images for better hidpi rendering 2017-08-15 13:54:58 +10:00
David Bailey
06add3ee07 Fix decks being moved to the default deck when dragged to the bottom
Previously ontoDeckId was undefined if a deck was moved to the bottom, resulting in it being moved to the default deck, instead of being made a top-level deck.
2017-08-14 22:58:14 +01:00