Commit Graph

2052 Commits

Author SHA1 Message Date
Damien Elmes
7e2305ac0c fix encoding error when setting up profile
https://anki.tenderapp.com/discussions/ankidesktop/30926-error-when-choosing-ukrainian-as-the-interface-language
2018-11-27 12:55:24 +10:00
Damien Elmes
d58dcd7d2e
Merge pull request #263 from Arthur-Milchior/exporter
Using cardIds in AnkiExporter
2018-11-27 08:12:58 +10:00
Damien Elmes
a8e7c0c31b
Merge pull request #264 from dlon/close-deck-chooser
Close deck chooser without changing the deck
2018-11-27 07:55:50 +10:00
David Lönnhager
5744ab01e4 Use escape to close the deck chooser without switching to the selected deck 2018-11-26 18:06:29 +01:00
Arthur Milchior
112b287548 Using cardIds in AnkiExporter 2018-11-26 10:47:26 +01:00
Damien Elmes
39b77951c3
Merge pull request #262 from Arthur-Milchior/NewOrder
Change order of new cards
2018-11-25 13:52:17 +10:00
Arthur-Milchior
8e0077335a Change order of new cards
This commit corrects the following bug:

* Create a note N in an empty deck D of type basic (reverse), with
only some back, no front. Only card 2 will be generated.
* Edit the note, add a front. Card 1 will be generated.
* In the main window, try to learn deck D. In anki, currently, you'll
  see Card 2 first. According to the manual (and to my common sens),
  it should be Card 1 first.

This commit correct this bug, and ensure that new cards are seen
according to their order, and not to their creation date.
2018-11-20 21:50:36 +01:00
Damien Elmes
98adddde6f fix importing unit test
dupes no longer incremented for updated notes
2018-11-18 15:27:37 +10:00
Damien Elmes
e4af18cf66 catch wrong objects in add-on conf
based on patch from Arthur: https://github.com/dae/anki/pull/261/files
2018-11-18 15:22:31 +10:00
Damien Elmes
204ed5c18a fix font hack 2018-11-15 14:04:08 +10:00
Damien Elmes
beaca57129 be more verbose in importing dialog
Many users seem to get confused when duplicates are not imported,
so we list out what's being skipped now to help the users to be able
to search for the content.
2018-11-14 16:58:47 +10:00
Damien Elmes
66bbb76e98 bump version 2018-11-13 11:30:27 +10:00
Damien Elmes
9396d74bf6
Merge pull request #260 from zandimna/patch-1
Change the order of elements on the window title
2018-11-13 11:10:51 +10:00
zandimna
3b70c6ff26
Change the order of elements on the window title
The application name typically comes at the end of the title. As such, many tools grabs the final string as the application name. What Anki does currently causes the profile name to be grabbed, producing unexpected results.
2018-11-12 20:23:47 +08:00
Damien Elmes
6e95d9a398 catch maxpath error in mediasrv
https://anki.tenderapp.com/discussions/ankidesktop/30729-valueerror-in-ospathisdir-call-in-mediasrvpy-for-elements-with-long-strings-as-src
2018-11-12 19:35:23 +10:00
Damien Elmes
7f85218b5a paste links as anchors if shift held down 2018-11-12 16:39:24 +10:00
Damien Elmes
ed411b0cc9 add hack for font name consistency issue
https://anki.tenderapp.com/discussions/ankidesktop/30785-bug-font-not-applying-to-japanese-characters
2018-11-12 16:30:11 +10:00
Damien Elmes
09ff23dc70 filter font and background from all html elems in int. paste
https://anki.tenderapp.com/discussions/ankidesktop/30806-font-size-attribute-added-when-copying-text-inside-anki
2018-11-12 15:46:12 +10:00
Damien Elmes
d3c0ea46e2 normalize search text
https://anki.tenderapp.com/discussions/ankidesktop/30614-diacritics-changed-on-card-save-anki-21
2018-11-12 12:43:54 +10:00
Damien Elmes
fea23177e8 skip scroll if the number of cards has not changed
The scrolling behaviour is useful when cards are deleted, but
annoying in other cases such as when changing flags.
2018-11-12 12:26:23 +10:00
Damien Elmes
6609dfda7b prevent hiding of shortcuts in browser context menu 2018-11-12 12:13:58 +10:00
Damien Elmes
4acce5f96b checkmark on flags in browser 2018-11-12 12:10:50 +10:00
Damien Elmes
8ac5cc8dff prevent qt from hiding shortcuts in reviewer context 2018-11-12 12:02:51 +10:00
Damien Elmes
4b19e47b3f show checkmark on current flag in reviewer context menu 2018-11-12 12:01:54 +10:00
Damien Elmes
a3eb44d950 toggle flags in reviewer 2018-11-12 11:58:36 +10:00
Damien Elmes
d2765eadd5 toggle flags instead of using separate clear action in browser 2018-11-12 11:55:37 +10:00
Damien Elmes
997cc95fc7 use a semi transparent, neutral selection in browser
As the base colour of rows is now visible, actions like flagging
now provide immediate feedback about what they've changed.
2018-11-12 11:02:01 +10:00
Damien Elmes
9c85376b3e improve handling of invalid deck trees
- move checking code out of the schedulers and into the deck manager
- ensure we can fix the problem in one loop - the previous recursive
approach could lead to stack overflows if the top level of a large
deck tree was missing. this was also the cause of the sqlite
'interrupted' error that some users were seeing
2018-11-09 15:04:35 +10:00
Damien Elmes
5e5d35e9c1 change purple flag to orange 2018-11-01 14:58:41 +10:00
Damien Elmes
a9f9df5109 Revert "workaround bottom toolbar issue on macOS/qt5.12"
This reverts commit 5e3f35a32c.

underlying issue should be fixed in qt5.12beta3
2018-10-29 21:08:16 +10:00
Damien Elmes
3126611ecf display warning when profile corrupted 2018-10-29 21:06:33 +10:00
Damien Elmes
eef0b92374 correctly load prefs file modified in more recent qt 2018-10-29 21:06:11 +10:00
Damien Elmes
3c994ce257 Revert "increase db timeout"
This reverts commit 71053fcea9.

did not seem to help
2018-10-28 14:17:43 +10:00
Damien Elmes
e18bd4d67d work around existing instance not responding quickly
on a slow computer the first instance may have set up the local
server but not yet started the main loop, so when a user double clicks
on the icon twice, the second instance was timing out and opening
another window, then giving locked database errors

to work around this, increase the timeout, and tell the user the
existing instance is not responding instead of creating a new instance

https://anki.tenderapp.com/discussions/ankidesktop/30306-error
https://anki.tenderapp.com/discussions/ankidesktop/30550-im-sorry
2018-10-28 14:17:16 +10:00
Damien Elmes
2483e9c89e sidebar now visible by default 2018-10-28 12:24:54 +10:00
Damien Elmes
a4edc57dc5 run latex commands without bundled libs
https://anki.tenderapp.com/discussions/ankidesktop/30531-latex-wont-generate-svgs-automatically-but-will-generate-pngs
2018-10-28 11:41:43 +10:00
Damien Elmes
b4f4e65c55 simplify about sizing 2018-10-25 15:47:17 +10:00
Damien Elmes
1fd7c244be Revert "fix about dialog collapsed on qt 5.11/12"
This reverts commit edb3b176a8.

causes a lot of flickering on startup - will just move to
static sizing instead, as there is a scrollbar anyway
2018-10-25 15:43:17 +10:00
Damien Elmes
5e3f35a32c workaround bottom toolbar issue on macOS/qt5.12 2018-10-25 15:34:27 +10:00
Damien Elmes
edb3b176a8 fix about dialog collapsed on qt 5.11/12
the new approach doesn't seem to work properly on qt 5.9, so just
revert to a static size on that platform
2018-10-25 15:25:47 +10:00
Damien Elmes
1490dc7390 bump version 2018-10-25 14:52:49 +10:00
Damien Elmes
3cb073878a allow startup on qt5.12+
an intermittent issue with the webview on macOS, but otherwise
appears ok in initial tests
2018-10-25 14:48:08 +10:00
Damien Elmes
098434ff38 we can use the old undo shortcut on 5.11
webviews no longer propagate the captured shortcut
2018-10-23 18:40:58 +10:00
Damien Elmes
68a398f8d6 fix black flash on stats load on osx/qt5.11 2018-10-23 17:09:16 +10:00
Damien Elmes
0c1c7a1ca3 fix other clickable anchors 2018-10-23 17:05:47 +10:00
Damien Elmes
14f4107dfd deal with onclick handlers that don't return false
Because <base> is set to the media server URL, <a href='#' ...> causes
a page transition from the current setHtml() page data. Previous Qt
versions allowed us to just ignore the request, but now returning False
in acceptNavigationRequest() causes the subsequent page navigation to
be rejected as well, resulting in no visible change when clicking on a
deck in the deck list.

To deal with this, Anki will now warn when such navigation requests
come in, as the anchors need to be updated to return false. pycmd()
has been updated to return false to make returning in onclick easier.

Also use QUrl.matches() instead of converting the potentially long
URL to a string.
2018-10-23 16:47:01 +10:00
Damien Elmes
fa9a54db98 allow the initial setHtml() request to proceed
Qt 5.11 appears to call acceptNavigationRequest() for the initial
page load now.
2018-10-23 16:11:08 +10:00
Damien Elmes
1af556cb8d delay event filter installation
Qt 5.11 doesn't initialize the focusProxy until
a page has been loaded.
2018-10-23 16:06:56 +10:00
Damien Elmes
63f2ccdb3a allow startup on qt 5.11 2018-10-23 16:03:27 +10:00
Damien Elmes
5ecd01cc99 support new sip module location
qt has moved sip into a submodule
2018-10-23 16:02:59 +10:00