langfingaz/anki
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
10,334 Commits 1 Branch 1 Tag 37 MiB
3727781522
Commit Graph

1840 Commits

Author SHA1 Message Date
Henrik Giesel
c63e0abd68
Fix prettier after moving node_modules to repo dir (#1413) 2021-10-09 10:13:14 +10:00
Henrik Giesel
dec0fbe845
Refactor i18n (#1405) 
Merging note: the typing changes were fixed in a separate PR.

* Put rootDirs into subprojects

- typings do not work for any ts or svelte files
- if we set the 'rootDirs' in ts/tsconfig.json to '../bazel-bin/ts' and then inherit
  them from e.g. editor, the root will be changed to '../../bazel-bin/ts',
  however editor needs look in '../../bazel-bin/ts/editor' instead.

* Rename i18n and i18n_helpers to i18n-generated and i18n

- This way, we can restrict the awkwardness of importing files outside
  the ts directory within lib

* Fix missing typing of i18n and backend_proto by adding back symlinks

* Split up i18n-generated into i18n-{translate,modules}

* Change i18n from singleton to functions

* Revert "Put rootDirs into subprojects"

This partially reverts commit e1d4292ce3979e7b7ee21bf3951b8a462d45c29c.

It seems like this might not be necessary after all.
However some other change made on this branch seems to have fixed
the .svelte.d.ts imports

* Introduce i18n-bundles to remove circular import

There was a circular import i18n.ts <-> i18n-translate.ts

* Create own directory for i18n

* Move lib/i18n/translate to lib/translate

* This restores tree shaking

* Update tsconfig libs and module

* es2018-2020 have wide support on all modern browsers including

* Switch bundles and langs inside i18n to variables again

* Add missing copyright header

* Rename translate.ts to ftl.ts

* Remove the symlinks again

I added them to fix to have completion for tr, however this would have
also have meant to abandon the tree shaking.
As we want to have tree shaking, it's also not necessary to have the
symlinks anymore

* Revert "Update tsconfig libs and module"

This reverts commit 0a96776a475e9901c1f9f3407c726d1d002fb9ef.

* move withCollapsedWhitespace back to i18n/utils

* Add back /ts as in rootDirs
 2021-10-07 23:31:49 +10:00
Damien Elmes
79ceb89637 svelte needs its shims to generate prop typing 
I erroneously removed them near the end of the ts_project work, and
didn't realise the properties had broken.
 2021-10-07 21:33:21 +10:00
Damien Elmes
1aaf8fce1e fix invalid arg to ButtonGroup revealed by typing fix 2021-10-07 21:33:15 +10:00
Damien Elmes
46b80ca773 move node_modules into root folder [action required] 
Recommend removing ts/node_modules folder before attempting to
build after this update.

This moves ts/node_modules into the root of the project to work around
https://github.com/ankitects/anki/pull/1405#issuecomment-936213861

Also fixes the sass errors shown when running scripts/svelte-check
 2021-10-07 11:42:27 +10:00
Damien Elmes
046c6c55d3 use extra rootDir in tsconfig instead of symlinks 
The nice thing about the symlink approach is that it allowed tsc -b
to function without any changes to the tsconfig.json file, but it meant
there were extra links we had to maintain. So instead, we just add an
extra rootDirs entry, and add two commented-out lines that can be
uncommented when wanting to build with tsc directly.
 2021-10-01 18:36:52 +10:00
Damien Elmes
e9d71bfbe4 yarn upgrade --latest 
bootstrap still held back
 2021-10-01 12:52:53 +10:00
Damien Elmes
a3d9f90af5 update to latest rules_nodejs & switch to ts_project 
ts_library() is deprecated and will presumably be dropped from a
future rules_nodejs, and it wasn't working with the jest tests
after updating, so we switch over to ts_project().

There are some downsides:

- It's a bit slower, as the worker mode doesn't appear to function
at the moment.
- Getting it working with a mix of source files and generated files
was quite tricky, especially as things behave differently on Windows,
and differently when editing with VS Code. Solved with a small patch
to the rules, and a wrapper script that copies everything into the
bin folder first. To keep VS Code working correctly as well, the built
files are symlinked into the source folder.
- TS libraries are not implicitly linked to node_modules, so they
can't be imported with an absolute name like "lib/proto" - we need
to use relative paths like "../lib/proto" instead. Adjusting "paths"
in tsconfig.json makes it work for TS compilation, but then it fails
at the esbuild stage. We could resolve it by wrapping the TS
libraries in a subsequent js_library() call, but that has the downside
of losing the transient dependencies, meaning they need to be listed
again.  Alternatively we might be able to solve it in the future by
adjusting esbuild, but for now the paths have been made relative to
keep things simple.

Upsides:

- Along with updates to the Svelte tooling, Svelte typing has improved.
All exports made in a Svelte file are now visible to other files that
import them, and we no longer rebuild the Svelte files when TS files
are updated, as the Svelte files do no type checking themselves, and
are just a simple transpilation. Svelte-check now works on Windows again,
and there should be no errors when editing in VS Code after you've
built the project. The only downside seems to be that cmd+clicking
on a Svelte imports jumps to the .d.ts file instead of the original now;
presumably they'll fix that in a future plugin update.
- Each subfolder now has its own tsconfig.json, and tsc can be called
directly for testing purposes (but beware it will place build products
in the source tree): ts/node_modules/.bin/tsc -b ts
- We can drop the custom esbuild_toolchain, as it's included in the
latest rules_nodejs.

Other changes:

- "image_module_support" is moved into lib/, and imported with
<reference types=...>
- Images are now imported directly from their npm package; the
extra copy step has been removed.

Windows users may need to use "bazel clean" before building this,
due to old files lying around in the build folder.
 2021-10-01 12:52:53 +10:00
Damien Elmes
e46ca4ee54 update svelte-check 
Invoking from scripts/svelte-check is currently broken due to sass
imports - it appears to have been broken some time back.
 2021-09-29 12:27:27 +10:00
Damien Elmes
604247482d handle changed aria-expanded typing 2021-09-29 12:20:27 +10:00
Damien Elmes
d44b49294b make 'for' argument optional in TooltipLabel 
The latest svelte-check has revealed we were not passing 'for' in
when we should have been. This is a quick hack to get the tests passing
again, but a better approach that actually makes this accessible again
would be good in the future.
 2021-09-29 12:20:03 +10:00
Damien Elmes
04ba24cb54 silence execCommand deprecation warnings for now 2021-09-29 11:36:37 +10:00
Damien Elmes
e660e0a3e5 update svelte2tsx 
We can now use the typings from the Svelte library instead of the
svelte2tsx shims
 2021-09-25 11:07:31 +10:00
Damien Elmes
dc20300794 update to TypeScript 4.4.x 2021-09-23 09:53:37 +10:00
Damien Elmes
82f1cda09a fixes for TypeScript 4.4.x 
closes #1386
 2021-09-23 09:52:21 +10:00
Damien Elmes
94c4f99343 update ts deps 
typescript and bootstrap have been pinned for now:

https://github.com/ankitects/anki/issues/1386
https://github.com/ankitects/anki/issues/1385

hint failures for svelte-check have also been temporarily turned
off, due to it now complaining about document.execCommand():

Hint: The signature '(commandId: string, showUI?: boolean, value?: string): boolean' of 'document.execCommand' is deprecated. (ts)
    const wrapWithForecolor = (color: string) => () => {
        document.execCommand("forecolor", false, color);
    };

Will follow up in #1377
 2021-09-22 23:21:39 +10:00
Henrik Giesel
3f1da03615 Allow for explicit any 2021-09-17 21:30:32 +02:00
Henrik Giesel
51c0cedaf5 Make HandleSelection perfectly size when first activating 2021-09-17 21:23:04 +02:00
Henrik Giesel
06d1ec6af4 Fix missizing of HandleSelection when first moving from empty to Mathjax 2021-09-17 20:54:37 +02:00
Henrik Giesel
88fd31a099 Ugly fix: do not execute moveCursorPastPostfix when front includes "anki-mathjax" 2021-09-17 20:12:11 +02:00
Henrik Giesel
c30ba6a3f6 Add ChangeTimer.prototype.fireImmediately 
so Mathjax is saved when exiting editor prematurely
 2021-09-16 14:47:05 +02:00
Henrik Giesel
a1dde7c966 Wrap Mathjax compilation into try/catch 2021-09-16 14:31:20 +02:00
Henrik Giesel
60690e0557 Rename StickyBar and StickyBottom to StickyHeader and StickyFooter 2021-09-15 23:15:55 +02:00
Henrik Giesel
896b40c873 Remove now unused import in TagEditor 2021-09-15 22:59:47 +02:00
Henrik Giesel
9f56d51811 Fix suggestions not showing when typing space in a TagInput 2021-09-15 22:54:53 +02:00
Henrik Giesel
b502ceedca Make the ImageHandle and MathjaxHandle dropdowns perfectly touch the HandleSelection 2021-09-15 22:26:32 +02:00
Henrik Giesel
1f09402066 Stop propagation for paste in MathjaxHandle editor 2021-09-15 22:14:38 +02:00
Henrik Giesel
97647e7b24 Prevent hiding handles by clicking on handles 2021-09-15 17:56:56 +02:00
Henrik Giesel
9001b597da Remove style attribute after remove float property if not styling left 2021-09-15 17:36:48 +02:00
Henrik Giesel
9b7ea75399 Always correctly update MathjaxHandle position 2021-09-15 17:05:43 +02:00
Henrik Giesel
ce9674f824 Correctly pass down dropdownObject... 2021-09-15 16:16:42 +02:00
Henrik Giesel
7c6f6533c1 Using dropdownApi is much less faulty than using dropdownObject 
- Update MathjaxSelection and Dropdown more reliably
 2021-09-15 15:52:56 +02:00
Henrik Giesel
c227c7dc39 Make StickyBottom actually stick and make editor fullsize + flexbox 2021-09-15 15:21:37 +02:00
Henrik Giesel
c46f39c88e Import saveField from editor/saving.ts 2021-09-15 14:09:25 +02:00
Henrik Giesel
54b6491ce3 Remove duplicate outline:none 2021-09-15 13:46:07 +02:00
Henrik Giesel
71bdeeba39 Apply specific CSS to Mathjax CodeMirror 2021-09-15 13:46:04 +02:00
Henrik Giesel
219557afda Satisfy eslint 2021-09-15 13:45:20 +02:00
Henrik Giesel
ec9b43d3ab Use editorfield instead of editor-field 2021-09-15 13:45:20 +02:00
Henrik Giesel
c8c9c64ea5 Vertically center inline Mathjax 2021-09-15 13:45:20 +02:00
Henrik Giesel
c02973a85d Generalize accesing anki-mathjax from image in MathjaxHandle 2021-09-15 13:45:20 +02:00
Henrik Giesel
b6bea18b22 Add copyright header to saving.ts 2021-09-15 13:45:20 +02:00
Henrik Giesel
09819d4e7d Satisfy eslint 2021-09-15 13:45:19 +02:00
Henrik Giesel
e269fe73da Define CodeMirror in external codeMirror.ts 2021-09-15 13:45:19 +02:00
Henrik Giesel
e71aed7146 Correctly import CodeMirror 2021-09-15 13:45:19 +02:00
Henrik Giesel
a3fef552bd Include codemirror libs for svelte 2021-09-15 13:45:19 +02:00
Henrik Giesel
c663785264 Satisfy eslint 2021-09-15 13:45:19 +02:00
Henrik Giesel
111d34c17b Remove empty constructor 2021-09-15 13:45:19 +02:00
Henrik Giesel
e06ff2ae3c Focus on mount when using Mathjax shortcuts 2021-09-15 13:45:17 +02:00
Henrik Giesel
af556c391d Fix alignment of empty icon 2021-09-15 13:43:37 +02:00
Henrik Giesel
de056fbd89 Change Wrap commands / shortcuts to use anki-mathjax 2021-09-15 13:42:36 +02:00
Henrik Giesel
c3f56ad5cd Refactor editable/mathjax.ts 2021-09-15 13:33:25 +02:00
Henrik Giesel
45d0cc49e6 Set fixed fontSizef or mathjax in editor for now 2021-09-15 13:33:25 +02:00
Henrik Giesel
b5900da0b4 Set color of Mathjax depending on nightMode 2021-09-15 13:33:24 +02:00
Henrik Giesel
6856850a0f Wrap Mathjax buttons into toolbar 2021-09-15 13:33:24 +02:00
Henrik Giesel
f76cf24e9d Move wrap to lib to allow editable to use it 2021-09-15 13:33:24 +02:00
Henrik Giesel
b6dfbcbc20 Move setting inCodable to false into codable 2021-09-15 13:33:23 +02:00
Henrik Giesel
1e94f7f16f Display Mathjax error as title (tooltip) 2021-09-15 13:33:23 +02:00
Henrik Giesel
8fa6d0045d Show title on mathjax image 2021-09-15 13:33:22 +02:00
Henrik Giesel
fca31465b4 Display error Mathjax correctly 2021-09-15 13:33:22 +02:00
Henrik Giesel
c88223e069 Show math icon if Mathjax is empty 2021-09-15 13:33:22 +02:00
Henrik Giesel
7ba85a2fbe Disallow draggin of mathjax + only ever have one handle active 2021-09-15 13:33:21 +02:00
Henrik Giesel
9ef4bb15c6 Fix return behavior on Mathjax decorated element 2021-09-15 13:33:21 +02:00
Henrik Giesel
4576ce8cc3 Watch for childList instead of subtree 2021-09-15 13:33:21 +02:00
Henrik Giesel
b361bcc69f Display Mathjax editor and buttons at the same time 2021-09-15 13:33:20 +02:00
Henrik Giesel
b06b5e9151 Generalize ChangeTimer and use it in Mathjax editor 2021-09-15 13:33:20 +02:00
Henrik Giesel
cb762b880e Add ResizeObserver for MathjaxHandle 2021-09-15 13:33:20 +02:00
Henrik Giesel
7168cbf99a Update editor when editing Mathjax 2021-09-15 13:33:19 +02:00
Henrik Giesel
701f260c3f Wait for stylesheets to load before setting field content 2021-09-15 13:33:19 +02:00
Henrik Giesel
ea01183bfd Move elements inserted into decorated component no matter the position 2021-09-15 13:33:19 +02:00
Henrik Giesel
8ddb0bc6ed Fix some cases where Mathjax whitespace formatting is destroyed 2021-09-15 13:33:19 +02:00
Henrik Giesel
1185593fee Use CodeMirror for Mathjax Editor 2021-09-15 13:33:18 +02:00
Henrik Giesel
882a2710a9 Autoupdate mathjax image 
* propably should use changeTimer here
 2021-09-15 13:33:18 +02:00
Henrik Giesel
ce2dbaafb9 Fix focus issues with Mathjax editor 2021-09-15 13:33:18 +02:00
Henrik Giesel
0f92664d4a First implementation of MathjaxHandleEditor 
+ use manual focus highlighting on editing-area
 2021-09-15 13:33:17 +02:00
Henrik Giesel
df24682b2a Make Mathjax menu also a floating dropdown menu like ImageHandle 2021-09-15 13:33:17 +02:00
Henrik Giesel
241d5cdd13 Fix MathJax overlay after rebase 2021-09-15 13:33:17 +02:00
Henrik Giesel
ed4621de9e Add InlineBlock buttons to mathjax components 2021-09-15 13:33:12 +02:00
Henrik Giesel
f9a3c513ce Add HandleControl to MathjaxHandle 2021-09-15 13:32:33 +02:00
Henrik Giesel
a37460dbbe Display Mathjax handle when clicking mathjax 2021-09-15 13:32:33 +02:00
Henrik Giesel
922461ea47 Rename showImageHandle to showHandles 2021-09-15 13:32:33 +02:00
Henrik Giesel
6a1fae53df Formalize "Decorated components API" 2021-09-15 13:32:32 +02:00
Henrik Giesel
9fb0ce973b Implement moveNodesInsertedBeforeEndToAfterEnd 
This will prevent the user typing into the decorated elements
by accident because they place cursor behind it
 2021-09-15 13:32:32 +02:00
Henrik Giesel
d7e0f77439 Unify anki-mathjax-* to just anki-mathjax 2021-09-15 13:32:32 +02:00
Henrik Giesel
6b14afda27 Add MathjaxHandle 2021-09-15 13:32:32 +02:00
Henrik Giesel
14aaa10bf3 Implement latex highlighting for Latex in codable 2021-09-15 13:32:32 +02:00
Henrik Giesel
6953ea9703 Use margin:auto instead of text-align:center for mathjax-block 2021-09-15 13:32:31 +02:00
Henrik Giesel
167370fcb7 Do not start ImageHandle for images with [data-anki] 2021-09-15 13:32:31 +02:00
Henrik Giesel
7950078e2b Nicely portray mathjax with right color + alignment in Editor 2021-09-15 13:32:31 +02:00
Henrik Giesel
b0378690c0 Enable edit mode for mathjax blocks 2021-09-15 13:32:31 +02:00
Henrik Giesel
cd36fe2518 Correctly include editable css 2021-09-15 13:32:31 +02:00
Henrik Giesel
1465d3a848 Survive to Codable and back 2021-09-15 13:32:31 +02:00
Henrik Giesel
b0b2ae3ece Transform to mathjax components for fieldHTML 2021-09-15 13:32:31 +02:00
Henrik Giesel
5129aca66f Implement MathjaxBlock 2021-09-15 13:32:30 +02:00
Henrik Giesel
9b2378c3d2 Introduce editable module 2021-09-15 13:32:30 +02:00
Henrik Giesel
dd280038a8 Prevent tooltip expanding body tag in editor 2021-09-15 02:24:09 +02:00
Henrik Giesel
a6504e3f47 Do not stop showing suggestions when entering double colon for separator 2021-09-15 02:02:19 +02:00
Damien Elmes
c9d3e5462e bikeshedding: amount -> match_limit 
+ convert from u32 in backend method
 2021-09-12 11:57:49 +10:00
Henrik Giesel
e85c93f3e7 Cap tag suggestions at 500 2021-09-10 01:13:50 +02:00
Henrik Giesel
1fd7fe4391 Fix crosshair not showing on main text of Tag when in select mode 2021-09-09 22:31:16 +02:00
Henrik Giesel
95058ba23f Introduce TagEditMode as a wrapper around TagWithTooltip 2021-09-09 21:47:07 +02:00
Henrik Giesel
0fdd2d9c52 Only hide DeleteBadge when hovering on tag 2021-09-09 20:16:52 +02:00
Henrik Giesel
69c6265111 Align suggestions with start of tag 2021-09-09 19:03:06 +02:00
Henrik Giesel
4029a608bc Only show tag tooltip on hover, not focus 2021-09-09 18:36:29 +02:00
Henrik Giesel
9b20ca2da4 Scroll suggestion tag into view 2021-09-09 18:32:58 +02:00
Henrik Giesel
75ed24b7ea Do not use overflow-x on ButtonToolbar 
* Fixes deck-options dropdown not showing.
  It seems like it's no longer necessary
 2021-09-09 17:50:02 +02:00
Henrik Giesel
63c00db502 Fix Tag SPACER 2021-09-09 17:28:00 +02:00
Henrik Giesel
4fc3e059be Bubble up some functionality from Tag to TagWithTooltip and TagDeleteBadge 2021-09-09 17:18:47 +02:00
Henrik Giesel
fd89f296dd Remove unused import 2021-09-09 15:38:12 +02:00
Henrik Giesel
8fd4412dbe Fix bug where sometimes Autocomplete menu would not show even though suggestions exist 2021-09-09 15:38:11 +02:00
Henrik Giesel
8d8a559f73 Use noSuggestions 2021-09-09 15:38:11 +02:00
Henrik Giesel
60b1d65351 Update Autocomplete position when suggestion selection makes it move to the next row 2021-09-09 15:38:10 +02:00
Henrik Giesel
7bdf9aaf00 Set disabled class on TagInput from WithAutocomplete 2021-09-09 15:38:10 +02:00
Henrik Giesel
eb3bc08420 Explicitly not support dropleft/dropright 
We'll deal with it when we have a use case
 2021-09-09 15:38:09 +02:00
Henrik Giesel
18b838a173 Correctly place dropdown and only update if there's activeInput 2021-09-09 15:38:09 +02:00
Henrik Giesel
9e1f2aa262 Take most recent input as basis for suggestions 2021-09-09 15:38:09 +02:00
Damien Elmes
4da1c77220 add basic tag completion to backend 
Matches should arrive in alphabetical order. Currently results are not
capped (JS should be able to handle ~1k tags without too much hassle),
and no reordering based on match location is done. Matches are substring
based, and multiple can be provided, eg "foo::bar" will match
"foof::baz::abbar".

This is not hooked up properly on the frontend at the moment -
updateSuggestions() seems to be missing the most recently typed character,
and is not updating the list of completions half the time.
 2021-09-09 15:38:08 +02:00
Henrik Giesel
c5d507461a Decrease tag margins 2021-09-09 15:38:08 +02:00
Henrik Giesel
fc09212365 Add bottom padding to selected tag badge as well 2021-09-09 15:38:07 +02:00
Henrik Giesel
b628e9df75 Use new style highlight for selected tags 2021-09-09 15:38:07 +02:00
Henrik Giesel
9d73e928a6 Add slight padding around add tag icon 2021-09-09 15:38:07 +02:00
Henrik Giesel
088420dff2 Add a zero-width tag to prevent resizing when adding tag 2021-09-09 15:38:06 +02:00
Henrik Giesel
5156ed62c3 Un-reverse TagEditor autocompletion navigation 2021-09-09 15:38:06 +02:00
Henrik Giesel
b8a5b5d685 Decrease padding of AutocompleteItem 2021-09-09 15:38:06 +02:00
Henrik Giesel
f79e2aca92 Adjust border radius of tags to fit new fields 2021-09-09 15:38:05 +02:00
Henrik Giesel
96cbca8fb6 Update to use shortened SCSS paths for some components 2021-09-09 15:38:05 +02:00
Henrik Giesel
647a2a3e59 Satisfy formatter 2021-09-09 15:38:04 +02:00
Henrik Giesel
8ee6ccf853 Rename tagEditor tag-editor.ts 2021-09-09 15:38:04 +02:00
Henrik Giesel
b49112a910 Refer to ./ instead of components/ from within components 2021-09-09 15:38:04 +02:00
Henrik Giesel
f5b58442ce Fix ts/components:svelte_check 2021-09-09 15:38:03 +02:00
Henrik Giesel
a0970e8515 Add scrollbar_lib to components 2021-09-09 15:38:03 +02:00
Henrik Giesel
8bcb0635ba Fix eslint 2021-09-09 15:38:02 +02:00
Henrik Giesel
ef539bcb37 Fix colon insertion behavior 2021-09-09 15:38:02 +02:00
Henrik Giesel
85691fada2 Replace delim char with colons on copying tags 2021-09-09 15:38:02 +02:00
Henrik Giesel
46e607a777 Fix TagSpacer 2021-09-09 15:38:01 +02:00
Henrik Giesel
04b75859cc Implement nowrap mode 2021-09-09 15:38:01 +02:00
Henrik Giesel
28b1c09cda Implement TagWithTooltip 2021-09-09 15:38:00 +02:00
Henrik Giesel
7058d14d25 Move WithTooltip to components 2021-09-09 15:38:00 +02:00
Henrik Giesel
3de1d6e604 Use Unicode delimiter character 2021-09-09 15:38:00 +02:00
Henrik Giesel
6ccf75a077 Improve space behavior 2021-09-09 15:37:59 +02:00
Henrik Giesel
ab429ec413 Improve enter behavior 2021-09-09 15:37:59 +02:00
Henrik Giesel
5f1bcb691e Split when no autocomplete item is selected 2021-09-09 15:37:59 +02:00
Henrik Giesel
a27720d703 Add tag shorting behavior 2021-09-09 15:37:58 +02:00
Henrik Giesel
ffb1f3bff2 Space out Sticky Bottom with Spacer component 2021-09-09 15:37:58 +02:00
Henrik Giesel
821c65d4ad Deselect on clicking delete icon 2021-09-09 15:37:58 +02:00
Henrik Giesel
6e53ea8a6d Add small horizontal margin so selected highlight can show 2021-09-09 15:37:57 +02:00
Henrik Giesel
280a724957 Special handling of Backspace/Delete etc. for displaying shortcuts 2021-09-09 15:37:57 +02:00
Henrik Giesel
6d21c16250 Add select all shortcut 
+ Remove addEventListener for Ctrl+C/V/A
  It seems like they're really not necessary
 2021-09-09 15:37:57 +02:00
Henrik Giesel
d40e0df11b Position stickyBottom fixed 2021-09-09 15:37:56 +02:00
Henrik Giesel
d15d6d1584 Improve positioning of tag editor badges 2021-09-09 15:37:56 +02:00
Henrik Giesel
16e6da893b Fix after rebase 2021-09-09 15:37:56 +02:00
Henrik Giesel
5a988f72fa Improve paste behavior 2021-09-09 15:37:55 +02:00
Henrik Giesel
cdc4fd0ef8 Do not update/activate Autocomplete on Control+C,A,V 2021-09-09 15:37:55 +02:00
Henrik Giesel
63dc42cff6 Do not open autocomplete on clicking input 2021-09-09 15:37:55 +02:00
Henrik Giesel
95806c5176 Allow clicking on suggestion items 2021-09-09 15:37:54 +02:00
Henrik Giesel
2dff6cf4be Pass activeName to Tag as well 2021-09-09 15:37:54 +02:00
Henrik Giesel
9499bc1505 Adjust position so tags do not even move a single pixel when going into editing 2021-09-09 15:37:54 +02:00
Henrik Giesel
6642a11482 Adjust paddings a bit more 2021-09-09 15:37:54 +02:00
Henrik Giesel
f2cd23ff22 Center delete icon without padding/margin 2021-09-09 15:37:53 +02:00
Henrik Giesel
201773e7c6 Fix autocomplete dropdown 
+ find a different solution for making tags and tag inputs same size
 2021-09-09 15:37:53 +02:00
Henrik Giesel
3dff89fda5 Switch WithAutocomplete to WithDropdown and fix SelectedTagBadge 2021-09-09 15:37:53 +02:00
Henrik Giesel
874a315f83 Add SelectedTagBadge to offer context items for selected tags 2021-09-09 15:37:53 +02:00
Henrik Giesel
00de99880b Implement selectRange 2021-09-09 15:37:52 +02:00
Henrik Giesel
376f543680 Make automatic deselect when leaving tag editor 2021-09-09 15:37:52 +02:00
Henrik Giesel
080b80e3ce Make tags selectable 2021-09-09 15:37:52 +02:00
Henrik Giesel
0ff0e87dbc Implement controlPressed and shiftPressed 2021-09-09 15:37:52 +02:00
Henrik Giesel
4601ebb347 Create lib/keys.ts 2021-09-09 15:37:52 +02:00
Henrik Giesel
5c2911c053 First steps toward tag selection 2021-09-09 15:37:51 +02:00
Henrik Giesel
d3191d7ecb Implement autocomplete hiding on empty activeInput + remove logging 2021-09-09 15:37:51 +02:00
Henrik Giesel
392326b863 Fix behavior when autocompletion shows 2021-09-09 15:37:51 +02:00
Henrik Giesel
54c1f54ab0 Fix join behavior and exclude Backspace/Delete from printable character 2021-09-09 15:37:51 +02:00
Henrik Giesel
e876a374e2 Disable toggle on clicking element (toggle) for WithAutocomplete 2021-09-09 15:37:51 +02:00
Henrik Giesel
bb166392b1 Improve no reflow a little bit 2021-09-09 15:37:51 +02:00
Henrik Giesel
85567fddd9 Fix autocomplete showing on arrow keys and height resize on no tags 2021-09-09 15:37:50 +02:00
Henrik Giesel
a29d21f4fd Implement accepting suggestions via Enter 2021-09-09 15:37:50 +02:00
Henrik Giesel
b93646209a Introduce AutocompleteItem 
* needs too much custom styling / behavior to be done with DropdownItem
 2021-09-09 15:37:50 +02:00
Henrik Giesel
b2d2cb8715 suggestions -> suggestionsPromise, so it works with external APIs 2021-09-09 15:37:50 +02:00
Henrik Giesel
a515a9899b Don't allow Enter/Tab/Arrows for Autocomplete, if not active 
Don't show Autocomplete, if there are no items available
 2021-09-09 15:37:49 +02:00
Henrik Giesel
bbef2ab6b4 Have WithAutocomplete export its API 
allows it to be used in more contexts
 2021-09-09 15:37:49 +02:00
Henrik Giesel
ed1f19048d Rename TagAutocomplete to WithAutocomplete 
It's general enough to be used in other cases too
 2021-09-09 15:37:49 +02:00
Henrik Giesel
a9538ce6a7 Improve visuals of Tag component 2021-09-09 15:37:49 +02:00
Henrik Giesel
c48b861596 Save deletions via delete icon to db 2021-09-09 15:37:48 +02:00
Henrik Giesel
5575482e38 Save tags back to Python 2021-09-09 15:37:47 +02:00
Henrik Giesel
375a96e263 Set tags from Python 2021-09-09 15:37:47 +02:00
Henrik Giesel
a034c93eb7 Remove deleteActiveTag, fix appendEmptyTag 2021-09-09 15:37:47 +02:00
Henrik Giesel
39ffaf3427 Fix some deletion behavior 2021-09-09 15:37:47 +02:00
Henrik Giesel
ba64f50593 Make Autocomplete dismount along with TagInput on blur 2021-09-09 15:37:47 +02:00
Henrik Giesel
b4e84e8043 Implement on:autocomplete 2021-09-09 15:37:46 +02:00
Henrik Giesel
146a901d91 Don't highlight suggestion items 
Other suggestions menus don't do it either
 2021-09-09 15:37:46 +02:00
Henrik Giesel
9fd985760c Fix tagmove 2021-09-09 15:37:46 +02:00
Henrik Giesel
9c388a8b7e Introduce activeName so we can pass it to TagAutocomplete 2021-09-09 15:37:45 +02:00
Henrik Giesel
05d1c51d6b Export choice as autocompletionChoice from TagAutocomplete 2021-09-09 15:37:45 +02:00
Henrik Giesel
2e00dc09d6 Make tagunique a more general tagaccept 
* tagaccept includes what was previous done by on:blur
* on:blur in TagInput was in some cases not bubbled up to TagEditor for some reason
 2021-09-09 15:37:45 +02:00
Henrik Giesel
68bbc8d25d Use Autocomplete on TagInput again 2021-09-09 15:37:44 +02:00
Henrik Giesel
cda5e44786 Pass original to Autocomplete 2021-09-09 15:37:44 +02:00
Henrik Giesel
547e6f16c6 Fix TagBadge and TagSpacer + shortcut 2021-09-09 15:37:44 +02:00
Henrik Giesel
0acbf3e9eb Export blink as a function, works more reliably 2021-09-09 15:37:43 +02:00
Henrik Giesel
53c0d372f4 Fix behavior when simply entering a duplicate 2021-09-09 15:37:43 +02:00
Henrik Giesel
3857ac07d7 Implement tagsplit 2021-09-09 15:37:43 +02:00
Henrik Giesel
de10e55265 Fix tagjoinnext 2021-09-09 15:37:43 +02:00
Henrik Giesel
1487ed64c7 Fix tagjoinprevious 2021-09-09 15:37:43 +02:00
Henrik Giesel
bfeb419ba6 Fix tagmove 2021-09-09 15:37:42 +02:00
Henrik Giesel
36f455c0ee Fix TagBadge and TagSpacer 2021-09-09 15:37:42 +02:00
Henrik Giesel
96325a4910 Align tagenter tagdelete and tagunique 2021-09-09 15:37:42 +02:00
Henrik Giesel
754e49f9b8 Implement decideAfterBlur and activeAfterBlur 2021-09-09 15:37:42 +02:00
Henrik Giesel
2cdc0b308a Prefer focusing TagInput in onMount 2021-09-09 15:37:41 +02:00
Henrik Giesel
52a705e839 Completely decouple Tag from TagInput 2021-09-09 15:37:41 +02:00
Henrik Giesel
ea1e5b5840 Add .input to Tag interface 2021-09-09 15:37:41 +02:00
Henrik Giesel
e68f874c80 Remove special treatment of last tag 2021-09-09 15:37:41 +02:00
Henrik Giesel
e80e6ff34b Try to remove special handling of last tag / inputNew 2021-09-09 15:37:40 +02:00
Henrik Giesel
15ef6d51b3 Improve behavior when moving towards newInput 2021-09-09 15:37:40 +02:00
Henrik Giesel
796c759333 tagmove should act like tagjoin on empty inputs 2021-09-09 15:37:40 +02:00
Henrik Giesel
bde820569a Fix double delete on empty input 2021-09-09 15:37:40 +02:00
Henrik Giesel
2de2f03db8 Implement blink on duplicate detected 2021-09-09 15:37:39 +02:00
Henrik Giesel
11c6fe880b Add some visual for TagAutocomplete 2021-09-09 15:37:39 +02:00
Henrik Giesel
227c41b525 Minimize reflow upon clicking tag 2021-09-09 15:37:39 +02:00
Henrik Giesel
7696895a8e Implement tagmovenext fully 2021-09-09 15:37:39 +02:00
Henrik Giesel
428655a32f Almost implement tagmove 
* tagmovenext will start on the last position rather than first
 2021-09-09 15:37:38 +02:00
Henrik Giesel
fe35573308 Reimplement tagjoin with tick() 2021-09-09 15:37:38 +02:00
Henrik Giesel
180ef140f8 Start implemention tagmove 2021-09-09 15:37:38 +02:00
Henrik Giesel
4420a24363 Set caret correctly after tagjoin 2021-09-09 15:37:38 +02:00
Henrik Giesel
65e9a0f2ed Show Autocomplete on keydown, hide on blur 2021-09-09 15:37:38 +02:00
Henrik Giesel
c8ac822971 Adjust padding of TagInput a little 2021-09-09 15:37:37 +02:00
Henrik Giesel
281985480d Fix some WithDropdownMenu logic 2021-09-09 15:37:37 +02:00
Henrik Giesel
05120c79b0 Factor out ButtonToolbar from TagAutocomplete 2021-09-09 15:37:37 +02:00
Henrik Giesel
808d01c4fb Decouple TagInput from TagAutocomplete completely 2021-09-09 15:37:37 +02:00
Henrik Giesel
8d95503189 Add tabbable option to DropdownItem 2021-09-09 15:37:37 +02:00
Henrik Giesel
a5af3a9280 Fix issue with text showing below StickyBottom 2021-09-09 15:37:37 +02:00
Henrik Giesel
892f08c19a Make tags stand less out in dark mode 2021-09-09 15:37:36 +02:00
Henrik Giesel
6c6062cc58 Make styling of DropdownMenu easier by introducing dropdown-content 2021-09-09 15:37:36 +02:00
Henrik Giesel
1ba6909495 Decouple Autocomplete from TagInput: 
Allows to only have one autocompletion for all tags, rather than every
tag having its own
 2021-09-09 15:37:36 +02:00
Henrik Giesel
c5b10c1117 Remove dead code from TagAutocomplete 2021-09-09 15:37:36 +02:00
Henrik Giesel
22d5671594 Implement tagjoin events 2021-09-09 15:37:36 +02:00
Henrik Giesel
2993a7b744 Delete tag when update reveals its a duplicate 2021-09-09 15:37:35 +02:00
Henrik Giesel
473517c3b3 Enable keyed blocks in TagEditor for tags 2021-09-09 15:37:35 +02:00
Henrik Giesel
6e25a3d424 Rewrite paste behavior 2021-09-09 15:37:35 +02:00
Henrik Giesel
d705d049ce Delete when updating tagname to empty text 2021-09-09 15:37:35 +02:00
Henrik Giesel
dbf1472029 Connect Bootstrap dropdown with trigger via classes/props 2021-09-09 15:37:34 +02:00
Henrik Giesel
3ad86dfb33 Use our DropdownMenu component for TagAutocomplete 2021-09-09 15:37:34 +02:00
Henrik Giesel
50519ea5c8 Allow correctly adding tags 
+ Make taginput unfocusable via Tab => prefer Ctrl+Shift+T
 2021-09-09 15:37:34 +02:00
Henrik Giesel
ef8c46045e Make caret cursor more discoverable 2021-09-09 15:37:34 +02:00
Henrik Giesel
64a2ead2ca Remove TagInputEdit and TagInputNew 2021-09-09 15:37:34 +02:00
Henrik Giesel
f056851c1e Port Focus tags shortcut to webview 2021-09-09 15:37:34 +02:00
Henrik Giesel
f3df0fe305 Behave correctly upon Enter on TagInputEdit 2021-09-09 15:37:34 +02:00
Henrik Giesel
9418b1491b Create AddTagBadge component 2021-09-09 15:37:33 +02:00
Henrik Giesel
bfbe5057fa Make Tag icon an add tag icon 2021-09-09 15:37:33 +02:00
Henrik Giesel
8a48d26cca Adjust offsets and sizes to make tag input smaller 2021-09-09 15:37:33 +02:00
Henrik Giesel
77be86ec21 Enable tag delete icon 2021-09-09 15:37:33 +02:00
Henrik Giesel
392bdf6184 Port most components from first tageditor PR 2021-09-09 15:37:33 +02:00
Henrik Giesel
1026d26793 Display a tag-outline icon in the bottom left 2021-09-09 15:37:33 +02:00
Henrik Giesel
bb6db5bd95 Add Tag DeleteIcon 2021-09-09 15:37:33 +02:00
Henrik Giesel
0e858d87d4 Add Tag.svelte 2021-09-09 15:37:33 +02:00
Henrik Giesel
f9b320e105 Mount TagEditor 2021-09-09 15:37:33 +02:00
Damien Elmes
4ba30279ac
Merge pull request #1357 from hgiesel/preventstickybubble 
Prevent sticky bubble
 2021-09-08 19:02:00 +10:00
Henrik Giesel
a826895f0b However bubble up when clicking on label container itself 2021-09-07 15:02:59 +02:00
Henrik Giesel
9cbcfa1bbf Put sticky tooltip on icon, not label container 2021-09-07 14:33:15 +02:00
Henrik Giesel
7370c92a0b Prevent sticky bubbling and saveField before toggling sticky 2021-09-07 14:33:05 +02:00
Damien Elmes
a961013961 fix case of fields table 2021-09-07 10:22:22 +10:00
Damien Elmes
996f4c637f remove recursive symlink 
https://github.com/ankitects/anki/pull/1332#issuecomment-913572914
 2021-09-06 21:26:30 +10:00
Henrik Giesel
f5ab78825a Fix Float buttons in rtl 2021-09-06 21:15:37 +10:00
Henrik Giesel
bbf03a6b93 Fix ButtonDropdown disappearing when mouseupping on HandleBackground 2021-09-06 21:15:37 +10:00
Henrik Giesel
add6d86ae6 Fix Tab not moving caret to end 2021-09-06 21:15:37 +10:00
Henrik Giesel
5cf2c6196d Make clicking on labelcontainer move focus to field 2021-09-06 21:15:37 +10:00
Henrik Giesel
59123a2d5f Decrease margin of the pin icon on the right 2021-09-06 21:15:37 +10:00
Henrik Giesel
2d342ddfe3 Have a uniform border-radius for buttons and fields 2021-09-06 21:15:37 +10:00
Henrik Giesel
1a79e9aac9 Add a dashed border around pictures when image-editing 2021-09-06 21:15:37 +10:00
Henrik Giesel
af7f2c06df Make focus highlight artificial and based on :focus-within 2021-09-06 21:15:37 +10:00
Henrik Giesel
c3253e8596 Remove comma 2021-09-06 21:15:37 +10:00
Henrik Giesel
18f63ef17e Prevent overflow of sizeDimensions or image handle buttons 2021-09-06 21:15:37 +10:00
Henrik Giesel
cc2641095f Fix automatic positioning of ButtonDropdown after changing float property 2021-09-06 21:15:37 +10:00
Henrik Giesel
3579b6a3b6 Introduce WithImageConstrained 2021-09-06 21:15:37 +10:00
Henrik Giesel
017b6f9ff1 Parameterize overlay handle offsets 2021-09-06 21:15:37 +10:00
Henrik Giesel
f2f93ef67e Move more logic into HandleSelection 2021-09-06 21:15:37 +10:00
Henrik Giesel
96fd1f5b77 Remove unused import tick 2021-09-06 21:15:37 +10:00
Henrik Giesel
24b4f5e6e9 Implement HandleLabel 2021-09-06 21:15:37 +10:00
Henrik Giesel
1c99d163d1 Implement HandleBackground 2021-09-06 21:15:37 +10:00
Henrik Giesel
40c62c8c41 Remove unused nightMode from ImageHandle 2021-09-06 21:15:37 +10:00
Henrik Giesel
73d56df610 Introduce HandleControl 2021-09-06 21:15:37 +10:00
Henrik Giesel
18ed6597f5 Introduce HandleSelection.svelte 2021-09-06 21:15:37 +10:00
Henrik Giesel
e003a08c83 Change SizeSelect.images back to const: no reactivity needed here 2021-09-06 21:15:37 +10:00
Henrik Giesel
1eb84b5d64 Also check for sizeSelect.includes 2021-09-06 21:15:37 +10:00
Henrik Giesel
7cd0ced35b Make images in SizeSelect variable again 2021-09-06 21:15:37 +10:00
Henrik Giesel
386e2740e6 Only allow ImageHandle on valid pictures (determined in SizeSelect) 2021-09-06 21:15:37 +10:00
Henrik Giesel
899434c682 Fix resetting image-handle-bg on no activeImage 2021-09-06 21:15:37 +10:00
Henrik Giesel
a8ffdc2d7f Set max-width of images in the reviewer to 100% 2021-09-06 21:15:37 +10:00
Henrik Giesel
bae09a4743 Make first adjustment of size dimensions wait for setting of dimensions label 2021-09-06 21:15:37 +10:00
Henrik Giesel
5f1ed707ff Better algorithmus for minimum resize + prevent overflow of dimensions 2021-09-06 21:15:37 +10:00
Henrik Giesel
083d173469 Constrain with proportions in SizeSelect 2021-09-06 21:15:37 +10:00
Henrik Giesel
2f94208381 Show custom dimensions again 2021-09-06 21:15:37 +10:00
Henrik Giesel
13f5819f48 Detect active status again 2021-09-06 21:15:37 +10:00
Henrik Giesel
69f1c353df Implement new resizing algorithm 
* resizes against the original parameters
 2021-09-06 21:15:37 +10:00
Henrik Giesel
d3e46e9da4 Manage CSSStyleSheet from within SizeSelect where each image has one rule 2021-09-06 21:15:37 +10:00
Henrik Giesel
e581d593d3 Hide Float icons when width too small + Avoid too small resizing 2021-09-06 21:15:37 +10:00
Henrik Giesel
f379e18e6f Revert "During resizing, make the smaller dimension decide the new dimensions" 
This reverts commit 5bad9a913ce7b4a4cc58106936203fddec37d6da.

The previous behavior was the one you can observe in most graphical editors:
The bigger dimension (width or height) will decide the size, not the smaller one.
 2021-09-06 21:15:37 +10:00
Henrik Giesel
64a68743bd During resizing, make the smaller dimension decide the new dimensions 2021-09-06 21:15:37 +10:00
Henrik Giesel
f9000de16c Reset height, so it defaults to "auto" 
* This allows more flexible dynamic resizing for the image in the (p)reviewer
 2021-09-06 21:15:37 +10:00
Henrik Giesel
b07c46f88f Add margin to other side of dimensions 2021-09-06 21:15:37 +10:00
Henrik Giesel
5e80ef3562 Do not allow for resizing when in constrained mode 2021-09-06 21:15:37 +10:00
Henrik Giesel
4142fa2aa2 Don't show same dimensions twice if there are no custom dimensions 2021-09-06 21:15:37 +10:00
Henrik Giesel
92ed342547 Change position of float buttons and dimension 
* So we can show dimensions at lower image sizes
 2021-09-06 21:15:37 +10:00
Henrik Giesel
1472dc854c Deal with case where no style.{width,height} is set for size dimensions 2021-09-06 21:15:37 +10:00
Henrik Giesel
be3aaa1519 Dispaly "actualHeight / actualWidth" even in constrained mode 2021-09-06 21:15:37 +10:00
Henrik Giesel
4da68e3583 Turn off no-explicit-warning for editing-area 2021-09-06 21:15:36 +10:00
Henrik Giesel
d22aa72964 Use ResizeObserver to resize overlay if necessary 2021-09-06 21:15:36 +10:00
Henrik Giesel
30e0894ad9 Reset image handle on keydown and blur 2021-09-06 21:15:36 +10:00
Henrik Giesel
c6e56e0465 Better RTL support 2021-09-06 21:15:36 +10:00
Henrik Giesel
def2333605 Move selector / active logic up to ImageHandle 2021-09-06 21:15:36 +10:00
Henrik Giesel
a09187007d Do not use width/height auto important to avoid enlarging smaller images 2021-09-06 21:15:36 +10:00
Henrik Giesel
a1df49b11e Implement Maximum image size mechanism 2021-09-06 21:15:36 +10:00
Henrik Giesel
8a8cd4ee38 Add float tooltips 2021-09-06 21:15:36 +10:00
Henrik Giesel
f902e91ebd Allow SW resize 2021-09-06 21:15:36 +10:00
Henrik Giesel
b3c921b86c Bind to style properties instead of events 2021-09-06 21:15:36 +10:00
Henrik Giesel
8429d00081 Add functionality to set float of image 2021-09-06 21:15:36 +10:00
Henrik Giesel
49da806d91 Image resizes preserves ratio 2021-09-06 21:15:36 +10:00
Henrik Giesel
1756bca212 Add image-handle-dimensions to show dimensions directly on image 2021-09-06 21:15:36 +10:00
Henrik Giesel
0b06891771 First implementation of ImageHandle 2021-09-06 21:15:36 +10:00
Damien Elmes
41c4be2f54 Introduce editable-container 
Contains the shadow root, and references to the styles.
Is ignorant of Editable.
Is necessary, so our we editable.scss does not need to contain
information about Codable, ImageHandle or all those other things which
have nothing to do with Editable
 2021-09-06 21:15:36 +10:00
Damien Elmes
6909a095d5
Merge pull request #1332 from hgiesel/svelteexportcontext 
Shorten CSS references for `@import` or `@use`
 2021-09-06 21:10:27 +10:00
Henrik Giesel
03818b7c45 Disallow setting, deleting or defining properties on packages 2021-09-03 00:52:39 +02:00
Henrik Giesel
516007518c Add ts/sass/anki, a symlink to ts/sass for add-ons 2021-09-03 00:18:17 +02:00
Henrik Giesel
677a33f585 Fix for svelte_check 2021-09-02 23:37:17 +02:00
Henrik Giesel
8ff8186aab Uniformly shorten SCSS imports/uses 2021-09-02 23:37:17 +02:00
Henrik Giesel
4a2d2a75c1 Directly include CSS from bootstrap and codemirror packages 2021-09-02 23:37:16 +02:00
Henrik Giesel
4737a99809 Add source for block level elements 2021-09-02 22:31:25 +10:00
Henrik Giesel
1363a40273 Remove special treatment of empty anki-editable 2021-09-02 22:31:25 +10:00
Henrik Giesel
01a283bb99 Check for non-existence of block tags instead of exclusive existence of inline tags in editable 2021-09-02 22:31:25 +10:00
Damien Elmes
cb5cb006a9
Merge pull request #1350 from hgiesel/exportshortcuts 
Implement register-package and export some packages
 2021-09-02 22:23:12 +10:00
Damien Elmes
d210a21787
Merge pull request #1351 from hgiesel/fontisinline 
Add FONT as an inline tag
 2021-09-02 22:22:19 +10:00
Damien Elmes
b9d9343f51 don't allow | in generic family 2021-09-02 21:05:17 +10:00
Henrik Giesel
cc8ee65eaf Add FONT as an inline tag 2021-08-31 13:59:07 +02:00
Henrik Giesel
6e0f7c3d53 Implement register-package and export some packages 
Exported packages are:
* anki/packages
* anki/shortcuts
* anki/bridgecommand
 2021-08-30 14:41:40 +02:00
Damien Elmes
ab8e53f66e fix incorrect calendar day labels 
https://forums.ankiweb.net/t/day-of-the-week-legend-on-heatmap/9450/7
 2021-08-24 12:17:35 +10:00
Damien Elmes
1dd3583b43
Merge pull request #1340 from hgiesel/exportinternal 
Export Svelte internals
 2021-08-24 10:42:17 +10:00
Damien Elmes
12ea482c87 expose require() instead of the svelte global 
- Means add-on authors should not need to inject any code in their build
- Should be more flexible - we can export multiple libraries if we wish,
and don't have to worry about require() being clobbered by old add-ons.
 2021-08-24 10:22:07 +10:00
Henrik Giesel
fdf8321253 Rename cross-unit to export-internal 2021-08-23 23:45:50 +02:00
Henrik Giesel
c69232921a Update Svelte to 3.42.2 2021-08-23 23:38:16 +02:00
Henrik Giesel
fea4f17107 Export WithShortcut 2021-08-23 21:23:04 +02:00
Henrik Giesel
1495fdf311 Export svelte_internal as library on window object 
Closes https://github.com/ankitects/anki/issues/1328.
 2021-08-23 21:16:15 +02:00
Damien Elmes
1b2d57d956 add note about interday learning cards being fetched preferentially 
+ priority->order
 2021-08-22 15:32:46 +10:00
Damien Elmes
05124eecf7 adding options to sort by ascending/descending ease 2021-08-22 15:32:46 +10:00
Damien Elmes
ce4dcab9e4
Merge pull request #1335 from hikaru-y/fix-editor-fontfamily 
Quote font family names
 2021-08-20 14:39:29 +10:00
Damien Elmes
131c8b72f8 add options to v3 to preserve new card gather order 
Allows cards to be presented in deck order when gather priority is set
to 'deck'.
 2021-08-20 12:03:32 +10:00
hikaru-y
20085c9bc4 Quote font family names, except for generic families 
Fixes https://forums.ankiweb.net/t/font-script-is-not-changing-in-the-anki-windows/12465
 2021-08-20 04:31:11 +09:00
Damien Elmes
767241ed46 put reviews at bottom of reviews graph 
https://forums.ankiweb.net/t/new-reviews-graph-design-is-worse-than-it-was-in-2-1-40/9807
 2021-08-19 21:43:00 +10:00
Damien Elmes
48c121e4f3 filtered decks w/ scheduling disabled in v3 now log reviews 2021-08-19 20:25:29 +10:00
Damien Elmes
0671e7e712 fix mutateNextCardStates being exported into global namespace 
https://forums.ankiweb.net/t/v3-custom-scheduler-not-working/12441
 2021-08-19 10:21:04 +10:00
hikaru-y
207e4253f1 Use <template> element instead of Range.createContextualFragment() 
https://forums.ankiweb.net/t/audio-in-back-template-is-played-on-front-template-on-desktop-2-1-46/12399

Unlike when using <template> element, if a DocumentFragment is created
using Range.createContextualFragment(), <audio>/<video> elements
with `aotoplay` will play immediately even before they are inserted into
the actual document, which will cause audio or video on the answer side
to be played on the question side.
 2021-08-18 00:04:02 +09:00
Damien Elmes
c20716660f fix inverted 'skip question when replaying answer' option 
I'd intended to add a new string but overlooked it.

https://forums.ankiweb.net/t/bug-always-include-question-side-when-replaying-audio/12273/2
 2021-08-15 16:15:14 +10:00
Damien Elmes
5b1c409b19 use alphanumeric keyboard in SpinBoxFloat 
https://forums.ankiweb.net/t/error-setting-hard-interval-on-ios/12105/3
 2021-08-09 14:15:16 +10:00
Henrik Giesel
73a6d2bd40 Satisfy eslint 2021-08-03 06:12:04 +02:00
Henrik Giesel
b6aa59f2c7 Add tooltip for Toggly sticky icon 2021-08-03 06:02:29 +02:00
Henrik Giesel
d7232212a8 Increase inactive opacity a little for better discoverability 2021-08-03 05:52:57 +02:00
Henrik Giesel
357a6c5cc6 Add toggle sticky shortcuts F9 and Shift+F9 2021-08-03 05:52:07 +02:00
Damien Elmes
87f9bd8021
Merge pull request #1320 from hgiesel/colorpickerplus 
Remember last text and highlight color again
 2021-08-03 09:07:46 +10:00
Henrik Giesel
4db7cebf62 Remember last text and highlight color again 2021-08-02 23:12:00 +02:00
Damien Elmes
c6c9721c53 update congrats screen periodically; automatically move back to study 2021-08-02 16:05:18 +10:00
Damien Elmes
070f57fcc5 don't hide learning count on congrats screen when learning is overdue 
The v3 scheduler will delay the final card from being shown twice in
a row, but the overdue case was being treated the same as the no-learning
case, leading to the message being hidden.
 2021-08-02 15:57:09 +10:00
Damien Elmes
141a96e221 fix inability to map fields from larger to smaller notetype 
We were using the new item count instead of the old one.

https://forums.ankiweb.net/t/issue-changing-note-type-on-2-1-45/11822
 2021-07-31 18:30:50 +10:00
Henrik Giesel
ed496c097f Install Ctrl+Shfit+V paste only on Apple platforms 2021-07-31 03:43:10 +02:00
Henrik Giesel
61e38a8bc9 Remove registerShortcut for Ctrl+C/V/A/X from editor/index.ts 2021-07-30 22:28:40 +02:00
Damien Elmes
355e66e83c export jQuery, not just $ 
https://github.com/ankitects/anki/pull/1314#issuecomment-889597619
 2021-07-30 18:30:37 +10:00
Damien Elmes
a99f6a8514
Merge pull request #1314 from hgiesel/fixjqueryreviewer 
Export jquery correctly
 2021-07-29 23:26:05 +10:00
Henrik Giesel
7353bca606 Export jquery correctly 2021-07-29 15:18:51 +02:00
Damien Elmes
9c1c298426
Merge pull request #1312 from hgiesel/smalleditorrefactors 
Use :host instead of :host-context
 2021-07-28 13:19:04 +10:00
Damien Elmes
07c2c7ff62 show warning when trying to indent plain text 
https://forums.ankiweb.net/t/2-1-45-release-candidate/11362/55
 2021-07-28 12:18:04 +10:00
Damien Elmes
f3b8022a4c add reviewer_extras.js back 2021-07-27 15:13:39 +10:00
Henrik Giesel
e9928f9126 Use :host instead of :host-context 2021-07-26 16:06:50 +02:00
Henrik Giesel
95c8f5a12a Use event object in createShortcut, fix F8 for highlight 2021-07-26 06:15:30 +02:00
Henrik Giesel
66faa4ec25 Rename to text color and text color highlight 2021-07-26 05:28:28 +02:00
Henrik Giesel
b3a7a4ac3d Use new for-loop 2021-07-19 01:34:14 +02:00
Henrik Giesel
eb4550d2d5 Catch hook errors in two ways: 
- try/catch for catching synchronous errors
- Promise.allSettled will allow for rejected promises without fast-failing other promises
 2021-07-19 01:23:41 +02:00
Damien Elmes
033856c422 expose _queueAction 
https://github.com/ankitects/anki/pull/1292#issuecomment-881795577
 2021-07-17 12:12:07 +10:00
Damien Elmes
1209cd115a css_browser_selector was logging to the console 2021-07-17 09:25:05 +10:00
Damien Elmes
4861495b49 keep _updateQA exposed for now, as some add-ons use it 2021-07-17 09:11:05 +10:00
Henrik Giesel
1c1181b9e0 Allow any in reviewer/index.ts 2021-07-16 17:28:31 +02:00
Henrik Giesel
f52df75bc2 Add back opacity change 2021-07-16 17:26:04 +02:00
Henrik Giesel
272f2f7d1a Revert to MathJax through script tag 2021-07-16 16:56:57 +02:00
Henrik Giesel
a616d0dfbc Add copyright header 2021-07-16 16:56:57 +02:00
Henrik Giesel
d41530f4cc Satisfy formatter 2021-07-16 16:56:57 +02:00
Henrik Giesel
ac3577455d Satisfy eslint 2021-07-16 16:56:56 +02:00
Henrik Giesel
ddf3adfc8e Remove protobuf important from reiewer (no longer necessary (?)) 2021-07-16 16:56:56 +02:00
Henrik Giesel
d6393ba996 Do not set opacity to 0 in reviewer 2021-07-16 16:56:56 +02:00
Henrik Giesel
05771b7598 Include MathJax over ts/reviewer 2021-07-16 16:56:56 +02:00
Henrik Giesel
c016f0c8d0 Simplify some reviewer code 2021-07-16 16:56:56 +02:00
Henrik Giesel
ee1a1c35fb Create reviewer/images.ts 2021-07-16 16:56:56 +02:00
Henrik Giesel
5cbb582d0b Export jquery via ts/reviewer 2021-07-16 16:56:56 +02:00
Henrik Giesel
68ac505d81 Include css-browser-selector via ts/reviewer 2021-07-16 16:56:56 +02:00
Henrik Giesel
afa8f8a6f0 Export getTypedAnswer 2021-07-16 16:56:56 +02:00
Henrik Giesel
af12756980 Move reviewer to ts/reviewer 2021-07-16 16:56:55 +02:00
Damien Elmes
f458add147 add note about display order using current deck 2021-07-13 15:58:06 +10:00
Damien Elmes
c9ad563f93 move bury options below display order 
Causes the timer settings to appear at the bottom left, which is a bit neater.
 2021-07-13 15:45:08 +10:00
Damien Elmes
0b9fbd9050
Merge pull request #1286 from ankitects/proto 
Split backend.proto into multiple files
 2021-07-11 19:53:04 +10:00
Damien Elmes
372a28be29 rename workspace 
I'd forgotten that Bazel "helpfully" adds __init__.py files into folders
that match the workspace name, breaking imports.
 2021-07-10 23:58:53 +10:00
Damien Elmes
185e9acd22 split out remaining tags, stats, media and rendering 2021-07-10 23:16:18 +10:00
Damien Elmes
35b059ecdb split out sync, search, scheduler & config 2021-07-10 21:33:12 +10:00
Damien Elmes
9e0a295ab9 split out decks, deckconfig, notes, notetypes 2021-07-10 20:44:22 +10:00
Damien Elmes
18851ace47 split out cards and collection 2021-07-10 19:52:31 +10:00
Damien Elmes
616db33c0e refactor protobuf handling for split/import 
In order to split backend.proto into a more manageable size, the protobuf
handling needed to be updated. This took more time than I would have
liked, as each language handles protobuf differently:

- The Python Protobuf code ignores "package" directives, and relies
solely on how the files are laid out on disk. While it would have been
nice to keep the generated files in a private subpackage, Protobuf gets
confused if the files are located in a location that does not match
their original .proto layout, so the old approach of storing them in
_backend/ will not work. They now clutter up pylib/anki instead. I'm
rather annoyed by that, but alternatives seem to be having to add an extra
level to the Protobuf path, making the other languages suffer, or trying
to hack around the issue by munging sys.modules.
- Protobufjs fails to expose packages if they don't start with a capital
letter, despite the fact that lowercase packages are the norm in most
languages :-( This required a patch to fix.
- Rust was the easiest, as Prost is relatively straightforward compared
to Google's tools.

The Protobuf files are now stored in /proto/anki, with a separate package
for each file. I've split backend.proto into a few files as a test, but
the majority of that work is still to come.

The Python Protobuf building is a bit of a hack at the moment, hard-coding
"proto" as the top level folder, but it seems to get the job done for now.

Also changed the workspace name, as there seems to be a number of Bazel
repos moving away from the more awkward reverse DNS naming style.
 2021-07-10 19:17:05 +10:00
Damien Elmes
1d4b58419e add workaround for protobufjs requiring uppercase package names 
I mourn the time lost trying to track this down :-(

https://github.com/protobufjs/protobuf.js/issues/1014

We can't patch the minified file in dist without essentially duplicating
it, so this change also switches from the external file to including
the src file as part of the bundle.
 2021-07-10 15:24:01 +10:00
abdo
e2cff97349 Tweak deck options tooltips for RTL languages 2021-07-10 00:45:10 +03:00
Damien Elmes
80b98e0db8 move protobuf into separate folder in preparation for multiple files 2021-07-09 21:02:40 +10:00
hikaru-y
91f68d7665 Set lineWiseCopyCut option to false 
Fixes https://forums.ankiweb.net/t/anki-2-1-45-beta/10664/103
Related: https://github.com/codemirror/CodeMirror/issues/3169
 2021-07-08 01:19:19 +09:00
Damien Elmes
7141f795fb
Merge pull request #1280 from hgiesel/addonimprov2 
Export via components for Deck Options
 2021-07-07 09:53:05 +10:00
Damien Elmes
f326000b29
Merge pull request #1279 from hgiesel/addonimprov 
Remove disabled / Export via Components
 2021-07-07 09:31:00 +10:00
Henrik Giesel
794b9f30dc Export editor globals under anki namespace 2021-07-06 03:48:33 +02:00
Henrik Giesel
ca4d4424e6 Don't use containers components within Container 
- dynamic componets will be placed outside of the inner container
 2021-07-06 03:43:40 +02:00
Henrik Giesel
2ed2a7baca Export under anki.components 2021-07-06 03:36:02 +02:00
Henrik Giesel
70d74605fa Remove WithShortcut for now - it does not work 2021-07-05 22:32:19 +02:00
Henrik Giesel
adfe6597a5 disabledKey => fieldFocusedKey 2021-07-05 18:15:03 +02:00
Henrik Giesel
9cc0d0a01c Fix issues with sometimes cause assignment of wrong position value 2021-07-05 17:17:58 +02:00
Henrik Giesel
59c5ecd4fc Use Components.svelte instead of exporting from EditorToolbar.svelte 2021-07-05 16:19:03 +02:00
Damien Elmes
46708f536d add comment about the use of linear-gradient 
Otherwise one of us is likely to return to the code in a few years,
think it could be made simpler, and then break things again. :-)
 2021-07-05 11:09:22 +10:00
hikaru-y
7c5031ab28 Prevent #dupe bgcolor from being carried over when copying text 
use 'background-image' instead of 'background-color'
to prevent the background-color from being carried over
when copying text to another field in day mode
 2021-07-05 04:11:03 +09:00
Damien Elmes
581c3e2486
Merge pull request #1273 from hgiesel/macshortcuts 
Execute Ctrl+C/V/X/A via execCommand in editor
 2021-07-04 16:02:52 +10:00
Henrik Giesel
7f7e5c2702 Execute Ctrl+C/V/X/A through execCommand in editor (so we can customize it) 2021-07-03 01:48:49 +02:00
Henrik Giesel
f0e870f1ae Allow non-null assertion in focus-handlers 2021-07-03 01:14:59 +02:00
Henrik Giesel
d11d66ee79 Move selection into editable, if it's not there after focus 2021-07-03 01:00:52 +02:00
Damien Elmes
c01c4b642b
Merge pull request #1266 from hgiesel/renamelib 
More uniform file naming
 2021-07-02 09:31:52 +10:00
Henrik Giesel
24af5bada3 More uniform file naming 
kebap-case for .ts, .scss, .html, and directories
 2021-07-01 12:24:16 +02:00
Henrik Giesel
982afca625 Use better cloze button icon 2021-07-01 11:46:39 +02:00
Henrik Giesel
6493adf7ca Refactor WithDropdown to be more versatile and cause less bugs 2021-06-30 14:01:33 +02:00
Damien Elmes
8b55e8610b unpin bootstrap now that 5.0.1 is out 
63437f5cde
 2021-06-29 11:25:14 +10:00
Damien Elmes
fa070d9da3
Merge pull request #1262 from hgiesel/visibledeckpreset 
Make input in TextInputModal in dark mode visible
 2021-06-29 11:24:21 +10:00
Henrik Giesel
f4f70c514c Make input in TextInputModal in dark mode visible 2021-06-29 03:20:15 +02:00
Damien Elmes
9d1a755fdc use css columns instead of grid 
Alternative approach to #1255

thanks to Hikaru and Henrik for the margin fix, and Matthias for
the initial idea and prototypes!
 2021-06-29 11:19:56 +10:00
Damien Elmes
18843e711d disable cloze&math buttons in html mode 
Following on from 8a07d3161d
Keeping them active seems to encourage users to experiment:
https://forums.ankiweb.net/t/cloze-deleting-html-svg/11011
 2021-06-25 10:31:47 +10:00
Henrik Giesel
4252898c78 Make Codable abstract more over its textarea v codemirror when using fieldHTML 2021-06-24 19:55:50 +02:00
Henrik Giesel
96e4e90a61 Make EditingArea intialize this.fieldHTML, not Editable.fieldHTML 2021-06-24 19:15:07 +02:00
Damien Elmes
e387c1f6f1 mobile fixes for js field 
Without the overflow change, the page viewport gets messed up.
And for some reason specifying the font size as 1rem does not work;
it needs to be explicitly set to 16px to prevent zoom in.
 2021-06-24 18:06:22 +10:00
Damien Elmes
d94c878ce3 disable smart quotes and capitalization in js field 
+ use bootstrap styling
 2021-06-24 18:00:06 +10:00
Damien Elmes
0b697f5161 expose scheduler js option in deck config 2021-06-24 14:38:10 +10:00
Damien Elmes
943f2b0287 gear -> revert icon 
https://forums.ankiweb.net/t/anki-2-1-45-beta/10664/30
 2021-06-24 13:07:03 +10:00
Damien Elmes
1c0e0853b0
Merge pull request #1248 from ankitects/revert-on-right 
Move deck options revert button to right; hide when inactive
 2021-06-24 13:01:57 +10:00
Henrik Giesel
cedbc35850 Adapt use of createDropdown for editor buttons 2021-06-22 17:31:06 +02:00
Damien Elmes
a7cf5cb5eb move revert button to the right 
With a confirmation step now, accidental taps when scrolling shouldn't
be an issue, and it leaves more room for the text.
 2021-06-22 09:41:31 +10:00
Damien Elmes
cde63469dc hide revert button when not active 2021-06-22 09:38:28 +10:00
Damien Elmes
c840b8dbb2 fix svelte-check error by tweaking formatting 
🤷
 2021-06-22 09:27:37 +10:00
Henrik Giesel
08402a2d72 Have swithes be blue when checked in night mode 2021-06-21 22:37:37 +02:00
Henrik Giesel
214c585518 Replace dash with underscore for night_mode_lib 2021-06-21 21:51:15 +02:00
Henrik Giesel
13970425bf Add night_mode_lib as SCSS target 2021-06-21 21:44:23 +02:00
Henrik Giesel
8a2ac57cc5 Always show spinning reverse icon on mobile 2021-06-21 21:35:20 +02:00
Henrik Giesel
e5978d7ffe Remove use of bootstrap-dark.night-mode for deckoptions 
The CSS for the Switch component had a conflict regarding background color
Also generally it makes sense to put the CSS into the components
 2021-06-21 21:16:40 +02:00
Henrik Giesel
e8a6add60b Position Revert/Gear button on the left of the label 
+ Make the reverse arrow spin
 2021-06-21 20:48:33 +02:00
Henrik Giesel
4e4683a122 Make gear button show dropdown menu 2021-06-21 20:24:15 +02:00
Henrik Giesel
48b7ae3cd0 Revert button with gear icon, that shows revert dropdown item 2021-06-21 19:11:10 +02:00
Henrik Giesel
292ba665af Associate Switch labels with their respective switches 2021-06-21 18:15:41 +02:00
Henrik Giesel
909502bb0a Put tooltip only on the info badge 2021-06-21 17:48:18 +02:00
Damien Elmes
f92bf490ab remove explicit line-height 
It was causing text in dropdowns to be slightly truncated
(eg "Tag Only")
 2021-06-21 17:02:48 +02:00
Damien Elmes
ecfa01072b remove left pad on switches 2021-06-21 17:02:48 +02:00
Damien Elmes
207e0126a0 decrease margins in deck options top sticky bar 2021-06-21 17:02:48 +02:00
Henrik Giesel
131d29ae05 Add g-1 class to DeckoptionsPage. Include transitions.scss 
* Modal misbehaved before
 2021-06-21 17:02:48 +02:00
Henrik Giesel
abca240de7 Disable RevertButton tooltip on touch devices 
The tooltip will show after you clicked Revert. There's no sensible way
to show the tooltip, without also triggering the functionality
 2021-06-21 17:02:48 +02:00
Henrik Giesel
98c57ce3f8 Make TriggerType an input argument for WithTooltip 2021-06-21 17:02:48 +02:00
Henrik Giesel
62b4b4c12c Increase padding on tooltips + Remove erroneous closing angle bracket 2021-06-21 17:02:48 +02:00
Henrik Giesel
728e2e682b Implement Switch and SwitchRow 2021-06-21 17:02:48 +02:00
Henrik Giesel
9a00ef5a81 Properly dispose of tooltip resources when unmounting 2021-06-21 17:02:48 +02:00
Henrik Giesel
97692e4c28 Reverse RevertButton being on the right side 2021-06-21 17:02:48 +02:00
Henrik Giesel
3227346f53 Alternative solution to markdown tooltips creating bottom margin 2021-06-21 17:02:48 +02:00
Henrik Giesel
3232712748 Update RevertButton to use Badge and WithTooltip 2021-06-21 17:02:48 +02:00
Henrik Giesel
a035679171 Add a tooltip showing delay of a quarter second 2021-06-21 17:02:48 +02:00
Henrik Giesel
880546c895 Add back info circles, remove underlines 2021-06-21 17:02:48 +02:00
Henrik Giesel
44562c3250 Update NotetypeSelector to use Item instead of ButtonToolbarItem 2021-06-21 17:02:48 +02:00
Henrik Giesel
d45e6445cf Fix tooltip regression 2021-06-21 17:02:48 +02:00
Henrik Giesel
af53ccfb36 Have decimal keyboard for SpinBoxFloat 2021-06-21 17:02:48 +02:00
Henrik Giesel
0c49f6c08b Have numeric keyboard for SpinBox 2021-06-21 17:02:48 +02:00
Henrik Giesel
4d7bdbce1f Switch Revert button and input element position 2021-06-21 17:02:48 +02:00
Henrik Giesel
67e0b67d17 Implement WithTooltip 2021-06-21 17:02:48 +02:00
Henrik Giesel
11c5476ae3 Wrap label and HelpPopup into span 
Avoids HelpPopup in a differnt column upon label wrapping
 2021-06-21 17:02:48 +02:00
Henrik Giesel
21ab484f21 Make revert button horizontal padding smaller 2021-06-21 17:02:48 +02:00
Henrik Giesel
99e7a3c436 Have colors inherit for badges 2021-06-21 17:02:48 +02:00
Henrik Giesel
dba85e7755 Add down-arrow SASS function 2021-06-21 17:02:48 +02:00
Henrik Giesel
65f0e7a4ea Use custom down arrow for both SelectButton and EnumSelector 2021-06-21 17:02:48 +02:00
Henrik Giesel
8d32528e8d Put Col types into col.ts 2021-06-21 17:02:48 +02:00
Henrik Giesel
894c84f4d3 Fix formatting 2021-06-21 17:02:48 +02:00
Henrik Giesel
e030e6f656 Rename SectionItem to just Item and use across option sections 2021-06-21 17:02:46 +02:00
Henrik Giesel
f895919435 Import API from all option sections 2021-06-21 17:01:45 +02:00
Henrik Giesel
2728b5fa63 Add Container.svelte 2021-06-21 17:01:45 +02:00
Henrik Giesel
cf9bba0807 Remove SCSS from ConfigEditor 2021-06-21 17:01:45 +02:00
Henrik Giesel
1bb59198dd Implement CheckBoxRow and SpinBoxFloatRow 2021-06-21 17:01:45 +02:00
Henrik Giesel
5fa850703f Implement EnumSelectorRow and StepsInputRow 2021-06-21 17:01:45 +02:00
Henrik Giesel
bc6907ef8d Implement SpinBoxRow 2021-06-21 17:01:45 +02:00
Henrik Giesel
46b5f6ba65 Add breakpoint for Bury EnumSelector 2021-06-21 17:01:44 +02:00
Henrik Giesel
2e921b95c6 Use Row and Col in favor of ConfigEntry 2021-06-21 17:01:44 +02:00
Henrik Giesel
77ea7f5e6f Remove ConfigEntryFull 2021-06-21 17:01:44 +02:00
Henrik Giesel
6e06f4afd4 Factor RevertButton out of components 2021-06-21 17:01:44 +02:00
Henrik Giesel
c87123a9b1 Change margin and gutters off rows 2021-06-21 17:01:44 +02:00
Henrik Giesel
2d24003e6c Move the remaining Options to new ConfigEntry layout 2021-06-21 17:01:44 +02:00
Henrik Giesel
d099b00918 Update DailyLimits and NewOptions to new format 2021-06-21 17:01:44 +02:00
Henrik Giesel
2a318f4695 Wrap input and revert button into one col 2021-06-21 17:01:44 +02:00
Henrik Giesel
17b39b8ef8 Introduce TitledContainer 2021-06-21 17:01:44 +02:00
Henrik Giesel
70c8b8940d Allow for gutters between rows 2021-06-21 17:01:44 +02:00
Henrik Giesel
da8fdb7719 Vertically align text + Remove bottom margin from alerts 2021-06-21 17:01:44 +02:00
Henrik Giesel
c586107fea Turn icons into Bootstrap badges in deckoptions 2021-06-21 17:01:44 +02:00
Henrik Giesel
23f65f1a95 Start using Bootstrap grid for deckoptions 2021-06-21 17:01:44 +02:00
Henrik Giesel
282de21675 Use Bootstrap containers instead of CSS in base for deckoptions 2021-06-21 17:01:44 +02:00
Henrik Giesel
7dacd9b72f Add container scss to deckoptions-base 2021-06-21 17:01:44 +02:00
Henrik Giesel
b99b12f157 Make API argument required in ConfigEditor 2021-06-21 17:01:44 +02:00
Henrik Giesel
c49ad009d0 Add Section and SectionItem for the deckoptions 2021-06-21 17:01:44 +02:00
Henrik Giesel
da076aa48e Generalize ButtonToolbarItem to SectionItem 2021-06-21 17:01:42 +02:00
Damien Elmes
c6c3b8af4d
Merge pull request #1244 from hgiesel/colorpickersetcolor 
Make Color Pickers also format with colors
 2021-06-20 15:58:58 +10:00
Damien Elmes
c79f8ba88f in/out -> request/response 
The saved characters weren't worth the increased difficulty when
reading, and the fact that we were deviating from protobuf norms.
 2021-06-20 15:49:20 +10:00