RumovZ
ca57cb964c
Format
2021-10-18 09:01:25 +02:00
RumovZ
b6104fa10b
Use language that mypy understands
2021-10-18 09:01:25 +02:00
RumovZ
bbba21126f
Improve clarity in card info code a tiny little bit
2021-10-18 09:01:25 +02:00
RumovZ
ec02a4218e
Keep Card Info Dialog open even if no card is set
2021-10-18 09:01:24 +02:00
RumovZ
5062024974
Move update logic into CardInfo.svelte
2021-10-18 09:01:24 +02:00
RumovZ
1d63253b4f
Make window titles more user-friendly
2021-10-18 09:01:23 +02:00
RumovZ
7eec241c82
Add utility func for setting window icon
2021-10-18 09:01:23 +02:00
RumovZ
f0d7e6f4d1
Use updating card infos in browser and reviewer
2021-10-18 09:01:23 +02:00
RumovZ
13024fcccc
Add update handler for Card Info Dialog
2021-10-18 09:01:22 +02:00
RumovZ
859b1d1a39
Make Card Info Dialog non-modal
2021-10-18 09:01:22 +02:00
Damien Elmes
e58646909f
get PyQt working directly with ./run on macOS
...
It's no longer necessary to copy everything into bazel-copy, and you
can safely remove that folder.
2021-10-16 18:07:29 +10:00
Damien Elmes
d0feffde74
avoid pulling qt5 in unless requested
2021-10-16 16:54:34 +10:00
Damien Elmes
281f1b2bf9
build all the UI files in one go
...
On macOS, the overhead of importing PyQt for each file far exceeds
any gains we get from incremental recompilation.
2021-10-16 09:20:20 +10:00
Damien Elmes
2c17105a35
use string replacements to generate Qt5 forms
...
They are mostly compatible, and this means a Qt5 install is not required
as part of the build process.
2021-10-16 08:59:09 +10:00
Damien Elmes
4a8e2bdc2d
download wheels using rules_python
2021-10-15 16:02:26 +10:00
Damien Elmes
819ec40a3e
update rules_python
2021-10-15 15:07:31 +10:00
Damien Elmes
b10aebc8b8
use separate header state for each Qt version
...
https://forums.ankiweb.net/t/new-toolkit-and-packaging-test-windows/14081/15
2021-10-15 13:15:38 +10:00
Damien Elmes
52642d693b
drop PyAudio support
...
I do not recall anyone reporting that it worked better than the Qt
implementation for them, and the lack of recent wheels on PyPI is a pain.
We can always add it back in the future if enough people come out of
the woodwork to report they were using it.
2021-10-15 13:15:16 +10:00
Damien Elmes
7962c8107f
qt recording support for qt6
...
+ fix inefficient bytes concatenation
2021-10-15 12:57:19 +10:00
Damien Elmes
2e9b4b3454
hide the video driver selection in qt6
2021-10-15 12:57:19 +10:00
Damien Elmes
e2c8dc92c1
fix placeholder text color on win/lin
2021-10-15 12:57:19 +10:00
Damien Elmes
58d17a51f3
fix incorrect web background color being picked up in qt6+win/lin
2021-10-15 12:57:19 +10:00
Damien Elmes
0d246c9e0b
update wheel definitions to require Python 3.9; make PyQt optional
...
While we do require PyQt, it's not possible to declare that we require
either 5 or 6, and so we need to mark it as optional. Instead, we
provide optional dependencies, so the user can e.g. 'pip install aqt[qt6]'
2021-10-15 12:57:19 +10:00
Damien Elmes
36fdc607c6
add run-qt5 script to run with 5.x
2021-10-15 12:57:19 +10:00
Damien Elmes
a7812dedc0
switch to new-style PyQt scoped enums and Qt6
...
The enum changes should work on PyQt 5.x, and are required in PyQt 6.x.
They are not supported by the PyQt5 typings however, so we need to run
our tests with PyQt6.
2021-10-15 12:57:19 +10:00
Damien Elmes
b0272f0336
generate pyqt6 forms
2021-10-15 12:57:19 +10:00
Damien Elmes
dfcefaebe3
miscellaneous pyqt6 compat fixes
...
- add a few gates for qt5-specific behaviour
- prepare for some changes to the typings in qt6
- map pickled Qt5 ByteArrays to Qt6 when running Qt6
2021-10-15 12:57:19 +10:00
Damien Elmes
4d0a915610
move QtAudioInputRecorder into separate PyQt5-only file
...
New API required for PyQt6.
2021-10-15 10:47:53 +10:00
Damien Elmes
1701937cba
expose pyqt6 packages - not yet used
2021-10-15 10:47:53 +10:00
Damien Elmes
2a3072191f
avoid importing directly from PyQt5 where possible
2021-10-15 10:47:53 +10:00
Damien Elmes
5f19d39f15
add ready-research to about screen
2021-10-14 21:02:44 +10:00
evandrocoan
2a12d44b34
Increased max visible items from clayout_top.ui ( #1425 )
...
10 is too small for big decks.
2021-10-14 19:36:04 +10:00
Damien Elmes
e8c5802a96
pass sole arg to cardStats as a dictionary
...
Easier to extend in the future, or (de)serialize in a strongly-typed
language.
2021-10-14 19:28:51 +10:00
RumovZ
3672b0fe73
Switch CardInfoDialog to ts page ( #1414 )
...
* Only collect card stats on the backend ...
... instead of rendering an HTML string using askama.
* Add ts page Card Info
* Update test for new `col.card_stats()`
* Remove obsolete CardStats code
* Use new ts page in `CardInfoDialog`
* Align start and end instead of left and right
Curiously, `text-align: start` does not work for `th` tags if assigned
via classes.
* Adopt ts refactorings after rebase
#1405 and #1409
* Clean up `ts/card-info/BUILD.bazel`
* Port card info logic from Rust to TS
* Move repeated field to the top
https://github.com/ankitects/anki/pull/1414#discussion_r725402730
* Convert pseudo classes to interfaces
* CardInfoPage -> CardInfo
* Make revlog in card info optional
* Add legacy support for old card stats
* Check for undefined instead of falsy
* Make Revlog separate component
* drop askama dependency (dae)
* Fix nightmode for legacy card stats
2021-10-14 19:22:47 +10:00
zhangsn
7c74f7805b
add new hook: add_cards_did_change_deck ( #1420 )
...
* add new hook which will be executed after the user selects a new different deck when adding cards.
* Update qt/aqt/deckchooser.py
2021-10-12 17:55:21 +10:00
Damien Elmes
a403b957cc
fix error in webview __del__ on shutdown
2021-10-12 17:07:07 +10:00
Damien Elmes
4e405f1cc3
remove unused locale_dir
2021-10-12 16:27:57 +10:00
Damien Elmes
d9bff1e8ce
provide root_path to flask
...
Flask tries to look up root_path using __file__, which may not be
available. It's used for static file hosting and templates, neither
of which we use.
2021-10-12 16:27:57 +10:00
Damien Elmes
c01ced6ecb
remove unused moduleDir
2021-10-12 16:27:57 +10:00
Damien Elmes
d33c66e195
change setHtml() to serve content via media server
...
- fixes https://forums.ankiweb.net/t/deck-list-is-blank/2241/2
- fixes the security warnings on Qt 6, by ensuring our pages and
resources are coming from the same origin
2021-10-12 16:27:03 +10:00
Damien Elmes
4b5004c472
refactor mediasrv request processing
...
_redirectWebExports was doing more than it was originally intended for,
and it was difficult to follow.
2021-10-12 16:22:09 +10:00
Damien Elmes
70dbd06be3
add qtmajor qualification to version checks; update outdated min ver
2021-10-12 16:20:33 +10:00
Damien Elmes
46a1cc575c
update a deprecated API call in clayout
2021-10-12 16:20:12 +10:00
Damien Elmes
974378f2be
remove old unused build_ui.sh
2021-10-12 16:19:27 +10:00
Damien Elmes
b85ee30c70
stop migrating from old folder locations
...
Closes #1390
2021-10-12 16:18:31 +10:00
Damien Elmes
c39a5e17e8
Revert "Merge pull request #610 from evandroforks/ask_confirmation_before_moving_anki_collection"
...
This reverts commit a53aac40f8
, reversing
changes made to e323a8f902
.
Migration is about to be dropped (#1390 ), and the references to modules
like QtGui complicate a PyQt5/6 shim.
2021-10-12 16:18:24 +10:00
Damien Elmes
aaceeec25a
Revert "Allow copying of images using context menu"
...
This reverts commit d5b3927d0b
.
This approach no longer appears to work in Qt6. There is a
QWebEngineView.lastContextMenuRequest() that may work, though whether
onCopy() qualifies as "during contextMenuEvent" is not clear.
https://doc.qt.io/qt-6/qwebengineview.html#lastContextMenuRequest
2021-10-12 16:18:24 +10:00
Damien Elmes
aabf693bb8
Revert "Allow <audio> to play without user interaction in accordance to autoplay setting"
...
This reverts commit 54f51da944
.
This breaks in the PyQt6 upgrade. There are no globals anymore, only
page profiles - but the code should probably be modifying a specific
webview instead of globals anyway.
2021-10-12 16:18:24 +10:00
Damien Elmes
69c196b409
.exec_() -> .exec()
...
The former is not supported in PyQt6
2021-10-12 16:17:37 +10:00
Damien Elmes
e9d0e672cf
update runtime Python version check
2021-10-12 16:17:23 +10:00
Damien Elmes
e357dbf6b3
use Qt search path instead of resource system
...
Means URLs like :/icons/foo.jpg should become icons:foo.jpg
This is part of the prep work for a PyQt6 update. PyQt6 has dropped
pyrcc, so we can longer generate the icons_qrc.py file we did previously.
Qt Designer expects us to use the resource system, so we continue to
generate the icons.qrc file to make editing the UI files easier. But at
runtime, we no longer use that file.
2021-10-12 16:17:08 +10:00
Abdo
ebe7125e81
Fix deck change after toggling sticky fields ( #1415 )
2021-10-09 10:26:10 +10:00
Henrik Giesel
c64bac57a6
Put sass into repo directory ( #1409 )
...
Fix Sass build
2021-10-09 10:25:03 +10:00
Damien Elmes
3814385e41
add trailing newline to profiles readme
...
closes #1407
2021-10-07 13:31:44 +10:00
Ren Tatsumoto
48f8427592
Keep the list of duplicates up-to-date before tagging ( #1404 )
...
* keep the list of dupes up-to-date before tagging
* get rid of a redundant parameter
* unnecessary lambda
2021-10-07 12:49:41 +10:00
Damien Elmes
b9251290ca
run pyupgrade over codebase [python upgrade required]
...
This adds Python 3.9 and 3.10 typing syntax to files that import
attributions from __future___. Python 3.9 should be able to cope with
the 3.10 syntax, but Python 3.8 will no longer work.
On Windows/Mac, install the latest Python 3.9 version from python.org.
There are currently no orjson wheels for Python 3.10 on Windows/Mac,
which will break the build unless you have Rust installed separately.
On Linux, modern distros should have Python 3.9 available already. If
you're on an older distro, you'll need to build Python from source first.
2021-10-04 15:05:48 +10:00
Damien Elmes
e9c7b2287f
bump minimum Python to 3.9
2021-10-04 15:05:15 +10:00
Damien Elmes
5dc385c9b7
fix pylinthome warning
2021-10-03 12:23:52 +10:00
Damien Elmes
daf2e0a78f
fix profile save not working on Python 3.10
2021-10-03 12:23:37 +10:00
Damien Elmes
7c70d26fe7
update Python deps
2021-10-02 23:52:23 +10:00
Damien Elmes
553ce808e5
add missing encoding argument to open calls
2021-10-02 23:51:50 +10:00
Damien Elmes
9a103b3716
use extra variable in stdHtml() to work around a pylint crash
2021-10-02 22:47:13 +10:00
Damien Elmes
0000a3b302
Merge pull request #1402 from RumovZ/row-changed
...
Connect `currentChanged()` and add legacy alias for `onRowChanged()`
2021-10-02 09:06:05 +10:00
RumovZ
c146f33faa
Add legacy alias browser.onRowChanged()
2021-10-01 18:36:12 +02:00
RumovZ
3a5d86c344
React to currentChanged()
signal
...
Decouples changes of the current element and changes of the selection.
Introduces `browser.current_card` which has previously been amalgamated
with the previewer card `browser.card`.
2021-10-01 16:40:25 +02:00
Damien Elmes
812bf76b96
Merge pull request #1399 from abdnh/addon-homepage-manifest-prop
...
Add the homepage property to manifest.json
2021-10-01 21:52:00 +10:00
Abdo
3822568667
Add the homepage property to manifest.json
2021-10-01 14:40:36 +03:00
Damien Elmes
a174c41801
Merge pull request #1397 from RumovZ/column-tooltips
...
Add tooltips for some browser columns
2021-10-01 19:12:59 +10:00
Damien Elmes
7a81a1c7b6
Merge pull request #1400 from RumovZ/revert-hide-completer
...
Remove workaround for Qt completer bug
2021-10-01 15:30:37 +10:00
Damien Elmes
ee99578c06
Merge pull request #1392 from RumovZ/missing-row-handling
...
Handle missing rows consistently and speed up selections
2021-10-01 14:24:04 +10:00
Damien Elmes
a3d9f90af5
update to latest rules_nodejs & switch to ts_project
...
ts_library() is deprecated and will presumably be dropped from a
future rules_nodejs, and it wasn't working with the jest tests
after updating, so we switch over to ts_project().
There are some downsides:
- It's a bit slower, as the worker mode doesn't appear to function
at the moment.
- Getting it working with a mix of source files and generated files
was quite tricky, especially as things behave differently on Windows,
and differently when editing with VS Code. Solved with a small patch
to the rules, and a wrapper script that copies everything into the
bin folder first. To keep VS Code working correctly as well, the built
files are symlinked into the source folder.
- TS libraries are not implicitly linked to node_modules, so they
can't be imported with an absolute name like "lib/proto" - we need
to use relative paths like "../lib/proto" instead. Adjusting "paths"
in tsconfig.json makes it work for TS compilation, but then it fails
at the esbuild stage. We could resolve it by wrapping the TS
libraries in a subsequent js_library() call, but that has the downside
of losing the transient dependencies, meaning they need to be listed
again. Alternatively we might be able to solve it in the future by
adjusting esbuild, but for now the paths have been made relative to
keep things simple.
Upsides:
- Along with updates to the Svelte tooling, Svelte typing has improved.
All exports made in a Svelte file are now visible to other files that
import them, and we no longer rebuild the Svelte files when TS files
are updated, as the Svelte files do no type checking themselves, and
are just a simple transpilation. Svelte-check now works on Windows again,
and there should be no errors when editing in VS Code after you've
built the project. The only downside seems to be that cmd+clicking
on a Svelte imports jumps to the .d.ts file instead of the original now;
presumably they'll fix that in a future plugin update.
- Each subfolder now has its own tsconfig.json, and tsc can be called
directly for testing purposes (but beware it will place build products
in the source tree): ts/node_modules/.bin/tsc -b ts
- We can drop the custom esbuild_toolchain, as it's included in the
latest rules_nodejs.
Other changes:
- "image_module_support" is moved into lib/, and imported with
<reference types=...>
- Images are now imported directly from their npm package; the
extra copy step has been removed.
Windows users may need to use "bazel clean" before building this,
due to old files lying around in the build folder.
2021-10-01 12:52:53 +10:00
RumovZ
e5cf649d6a
Remove workaround for Qt completer bug
...
Reverts #803 .
2021-09-30 17:56:37 +02:00
RumovZ
ee2ecd0700
Add tooltips for some browser columns
2021-09-30 13:15:09 +02:00
RumovZ
326cf0f77f
Remove redundant call to len_columns()
2021-09-28 12:11:20 +02:00
RumovZ
72f6f9a47a
Tweak comment
...
Co-authored-by: Damien Elmes <dae@users.noreply.github.com>
2021-09-28 11:48:35 +02:00
RumovZ
46ffbb936d
Speed up to_row_of_unselected_note()
...
Skip rows between selected rows and return fetched note ids.
2021-09-28 11:47:13 +02:00
RumovZ
a592c5b3a9
Cache selectionModel().selectedRows()
2021-09-28 11:45:22 +02:00
RumovZ
eac8972a28
Calculate len_selection
depending on modifiers
...
If no modifiers are pressed, a single row has probably been clicked and
`selectedRows()` is fast, while a lot of rows might have been deselcted.
2021-09-28 10:22:20 +02:00
RumovZ
287854d014
Prefer selectionModel().reset()
over .clear()
...
The latter triggers `selectionChanged()` unreliably, probably due to the
aggregation of chronologically close events, causing problems in
tracking `_len_selection`. `reset()` never emits signals.
2021-09-28 10:19:33 +02:00
Damien Elmes
2a2469e7a2
Revert "Revert "Merge pull request #1364 from evandroforks/fix_unclosed_python_file""
...
This reverts commit a2ac197fd786b31880c8334735b4a2d6bd76b0bd.
Looks like it wasn't the cause of the previously reported problem:
https://forums.ankiweb.net/t/2-1-48-tts-problem/13587/2
2021-09-27 18:43:16 +10:00
Damien Elmes
96798f018a
Merge pull request #1382 from RumovZ/tags-from-sidebar
...
Tags from sidebar
2021-09-27 18:41:32 +10:00
Damien Elmes
339fd159aa
Merge pull request #1388 from lolilolicon/patch-1
...
Quote $PREFIX properly for paths with spaces
2021-09-27 18:39:25 +10:00
RumovZ
f89811870e
Calculate number of selected rows manually
...
`len(self._view.selectionModel().selectedRows())` is slow for large
selections, because Qt queries flags() for every selected cell, so we
calculate the number of selected rows ourselves.
2021-09-27 10:15:53 +02:00
RumovZ
18f0d026b5
Switch to new row before deleting notes
...
The table now properly deselects deleted rows, but that takes effort and
it's more convenient to have a selected row after deleting.
2021-09-25 17:28:38 +02:00
RumovZ
f54f15cd44
Handle deleted or restored rows
...
- Cache the result of 'table.len_selection()'
- Update this cache manually when a row was deleted or restored
- Emit 'dataChanged()' after such a change to fix flags not updating
correctly to the shortcut in 'model.flags()'
- Remove/retsore focus if the current element was deleted/restored
2021-09-25 17:16:53 +02:00
RumovZ
3a8c494544
Only check flags of cached rows
...
Speeds up the selection process (esp. Ctrl+A) by avoiding to fetch rows.
Co-authored-by: BlueGreenMagick <BlueGreenMagick@users.noreply.github.com>
2021-09-25 15:32:22 +02:00
RumovZ
73ec0a2b2e
Add callbacks to row fetching routine
...
Called when a row is detected that has been deleted or restored.
2021-09-25 15:27:19 +02:00
RumovZ
2b5bf23bbd
Check 'index.isValid()' in 'table.model'
2021-09-25 15:21:06 +02:00
Soren Bjornstad
67f9fc519e
Add hook after selecting a new note type in the add window
2021-09-24 21:54:33 -05:00
lolilolicon
ae7693a8a7
Quote $PREFIX properly for paths with spaces
2021-09-23 01:24:52 +00:00
lolilolicon
383cd44119
Quote $PREFIX properly for paths with spaces
2021-09-23 01:20:53 +00:00
hikaru-y
fc232eb0f7
Fix memory leak in previewer
...
Related thread:
https://forums.ankiweb.net/t/high-memory-usage-over-time-on-2-1-44/13544/
2021-09-22 17:21:08 +09:00
RumovZ
75f210a66c
Enable adding/removing tags from the sidebar ...
...
... to selected notes.
2021-09-21 11:48:43 +02:00
Damien Elmes
d091a547a4
Merge pull request #1375 from RumovZ/disable-actions
...
Disable unusable browser actions on row change
2021-09-21 18:38:30 +10:00
Damien Elmes
81a8fe039b
Merge pull request #1379 from BlueGreenMagick/dont-fill-empty-on-add-cards
...
set CardLayout fill_empty=False for add cards editor
2021-09-21 15:08:54 +10:00
Damien Elmes
1ceb9965ad
add hidden option to disable tooltips in browse screen
...
https://forums.ankiweb.net/t/browser-text-pop-up-when-hovering-over-card-poll/13254
2021-09-21 15:03:37 +10:00
Damien Elmes
9720592519
temporary fix for error on deleting ( #1374 )
2021-09-20 22:02:44 +10:00
Damien Elmes
66fc9cdbd8
add startup message about forcing Wayland
2021-09-20 21:42:16 +10:00
Damien Elmes
cdad1efdcf
Revert "Merge pull request #1364 from evandroforks/fix_unclosed_python_file"
...
This reverts commit c05475a49e54ed7a56bc635e5e5528334d4ba6ac.
Revert "possible fix for reported audio issues"
This reverts commit f00f7f099f
.
Reverting in case https://forums.ankiweb.net/t/2-1-48-release-candidate/13268/10
is related to this change. If the issue persists, we'll know this was
not the cause.
2021-09-20 21:39:15 +10:00
bluegreenmagick
f3db3fa768
set CardLayout fill_empty=False for add cards editor
...
Card layout view functions as a previewer in add cards dialog
so displaying accurately is more important than having placeholders.
Especially for card layouts using conditional-not fields {{^Field}}
card layout is rendered badly.
2021-09-20 18:34:49 +09:00
RumovZ
94b261f1ef
Simplify sidebar context menu separators
...
Qt can collapse consecutive menu separators, so no need to check if a
subroutine has actually added any actions to the menu.
2021-09-19 18:33:36 +02:00
RumovZ
40bad0f65d
Disable unusable browser actions on row change
2021-09-17 16:16:34 +02:00
Damien Elmes
f00f7f099f
possible fix for reported audio issues
...
https://forums.ankiweb.net/t/2-1-48-release-candidate/13268/6
This is the only area of the sound code that has changed since 2.1.47
2021-09-16 10:27:37 +10:00
Henrik Giesel
c227c7dc39
Make StickyBottom actually stick and make editor fullsize + flexbox
2021-09-15 15:21:37 +02:00
Henrik Giesel
cd36fe2518
Correctly include editable css
2021-09-15 13:32:31 +02:00
Henrik Giesel
9b2378c3d2
Introduce editable module
2021-09-15 13:32:30 +02:00
Damien Elmes
9daf037c0b
Merge pull request #1264 from hgiesel/tageditor2
...
Svelte Tag Editor v2
2021-09-15 20:21:16 +10:00
evandrocoan
7e32e4efd5
Fix previous card attribute not initialized
2021-09-13 23:16:25 -03:00
Damien Elmes
926f0c7929
disable wayland again, but allow enabling it
...
Will add an entry to the known issues page.
2021-09-14 09:53:23 +10:00
Damien Elmes
18bd821a1f
preserve focus on notetype change
...
Closes #1360
2021-09-13 15:31:24 +10:00
Damien Elmes
806fb0f102
allow wayland again
...
See #1368
2021-09-13 15:18:32 +10:00
Damien Elmes
b877026248
don't check state of current card when repositioning
...
closes #1365
2021-09-13 14:56:53 +10:00
Damien Elmes
bbd7d057d8
Merge pull request #1358 from evandroforks/lastcardinfo
...
Add option to reveal previous card's info
2021-09-13 12:06:10 +10:00
evandrocoan
c7cff516e4
Add clone stdin to another _process deletion
2021-09-09 18:36:21 -03:00
Henrik Giesel
ae225f9569
Remove hiding Qt autocompleter from AddCards
2021-09-09 15:38:10 +02:00
Damien Elmes
4da1c77220
add basic tag completion to backend
...
Matches should arrive in alphabetical order. Currently results are not
capped (JS should be able to handle ~1k tags without too much hassle),
and no reordering based on match location is done. Matches are substring
based, and multiple can be provided, eg "foo::bar" will match
"foof::baz::abbar".
This is not hooked up properly on the frontend at the moment -
updateSuggestions() seems to be missing the most recently typed character,
and is not updating the list of completions half the time.
2021-09-09 15:38:08 +02:00
Henrik Giesel
5505925e64
Remove Python TagEdit from Editor view
2021-09-09 15:37:48 +02:00
Henrik Giesel
5575482e38
Save tags back to Python
2021-09-09 15:37:47 +02:00
Henrik Giesel
375a96e263
Set tags from Python
2021-09-09 15:37:47 +02:00
Henrik Giesel
f056851c1e
Port Focus tags shortcut to webview
2021-09-09 15:37:34 +02:00
Henrik Giesel
1026d26793
Display a tag-outline icon in the bottom left
2021-09-09 15:37:33 +02:00
evandrocoan
23891918cb
Use Alt+i for previous/last card info because Ctrl+i could
...
easily confuse a user that Ctrl+i is for the current card.
Ctrl was first added because it is easier to press,
at least for me, then, I press first using Ctrl and if
not available go to Alt.
2021-09-08 21:26:48 -03:00
evandrocoan
133e22dbe4
Fix ResourceWarning: unclosed file <_io.BufferedWriter name=5>
...
https://forums.ankiweb.net/t/aqt-sound-py-resourcewarning-unclosed-file-io-bufferedwriter-name-5/13070
2021-09-08 21:02:12 -03:00
evandrocoan
e295c4ccfb
Fix #1355
2021-09-07 23:53:47 -03:00
Ren Tatsumoto
de974f94db
avoid possible performance hit
2021-09-05 16:10:34 +03:00
Ren Tatsumoto
7451ad68b1
fix test complaints
2021-09-05 15:04:24 +03:00
Ren Tatsumoto
9ff37d9baa
Add a hook for modifiying pasted MIME data
2021-09-05 13:52:54 +03:00
Damien Elmes
1ae45c5445
quote fonts added via the Add Field dialog
2021-09-02 21:05:16 +10:00
Damien Elmes
ab20f215b1
Merge pull request #1349 from RumovZ/rename-with-parents
...
Disable 'Rename with Parents' for top-level items
2021-08-30 22:27:44 +10:00
RumovZ
d044360ff9
Disable 'Rename with Parents' for top-level items
2021-08-30 11:10:14 +02:00
RumovZ
3c53a961a3
Reset flags when loading a profile...
...
... not only on startup.
2021-08-30 11:07:40 +02:00
Damien Elmes
dc156f3471
Merge pull request #1344 from glutanimate/add-dialog-manager-hooks
...
Add a hook for subscribing to dialog creation / opening
2021-08-29 11:36:11 +10:00
Damien Elmes
395119bafe
Merge pull request #1345 from hgiesel/windowsfocus
...
Use different artificial reviewer button highlight for Windows
2021-08-29 11:35:32 +10:00
Damien Elmes
e4f8ba000e
more checks for package name
...
Follows up #1343
2021-08-29 11:23:47 +10:00
Henrik Giesel
3b90b27095
Use different artificial reviewer button highlight for Windows
2021-08-28 21:30:07 +02:00
Glutanimate
5eac3b9061
Add a hook for subscribing to dialog creation / opening
2021-08-28 20:37:31 +02:00
bluegreenmagick
20424a7ef7
Fix bug when add-on package string is ""
...
which deleted the entire add-on folder
2021-08-27 21:49:55 +09:00
Damien Elmes
94a0355389
avoid spurious warning in addcards startup
2021-08-20 11:37:23 +10:00
Damien Elmes
886ce15f27
mark old editing code as deprecated
...
https://forums.ankiweb.net/t/emacs-style-shortcuts-with-ctrl-t-in-the-editor-in-45/12280/6
2021-08-20 11:37:11 +10:00
Damien Elmes
f6ae0b73be
show v3 scheduler in error info
2021-08-20 10:47:41 +10:00
Damien Elmes
79cf49f38d
fix default deck being shown in deck options deck prompt
2021-08-19 12:33:36 +10:00
Damien Elmes
d92913eb8c
preferences update needs to be a collection op
...
- fixes https://forums.ankiweb.net/t/v3-bug-card-modified-without-updating-queue/12418
- fixes undo menu not updating after closing preferences screen
2021-08-19 10:47:55 +10:00
Damien Elmes
b9d42af423
add a small .wait() after terminating player process
...
Avoids python3.8/subprocess.py:942:
ResourceWarning: subprocess 90387 is still running
_warn("subprocess %s is still running" % self.pid,
2021-08-19 10:33:56 +10:00
Damien Elmes
79fbf9ad3e
Merge pull request #1333 from kelciour/mpv-property-list-timeout
...
A possible fix for "mpv timed out, restarting"
2021-08-18 16:39:50 +10:00
Damien Elmes
273be14fd3
Merge pull request #1331 from hikaru-y/fix-fragment-autoplay
...
Fix <audio>/<video> with 'autoplay' issue
2021-08-18 16:37:14 +10:00
Damien Elmes
5296bf0a00
shift timebox check to post-answer
...
- should prevent non-review actions from triggering display
- should prevent next card's audio from playing before diag. dismissed
- the timer hack should no longer be required, as the webview will
have already been loaded
https://forums.ankiweb.net/t/timebox-pop-up-suddenly-appears-when-daily-cutoff-hour-rolls-over-even-when-not-in-the-reviewer/12385
2021-08-18 16:25:23 +10:00
Damien Elmes
546d32cfda
ctrl+alt+n for forget
...
https://forums.ankiweb.net/t/anki-2-1-44-make-cards-new/12247/7
2021-08-18 15:32:45 +10:00
Damien Elmes
40c1a86a25
add symlink to generated icons.qrc
...
Otherwise Qt Designer tries to remove the reference.
2021-08-18 15:32:45 +10:00
kelciour
fae816e68e
A possible fix for "mpv timed out, restarting"
...
https://forums.ankiweb.net/t/anki-wont-open-mpv-timed-out/7579/6
2021-08-18 00:47:04 +03:00
hikaru-y
dd9528aa73
Silence 'link preload' warning on the first card
...
Due to 207e425
, a harmless warning about 'link preload' will be output
to the console on the first card.
2021-08-18 02:25:51 +09:00
Arthur Milchior
7568eda031
Add Card history: keep & instead of replacing them by underline
2021-08-15 06:32:03 +02:00
Damien Elmes
57f3d300bb
fix deprecation warning in modelchooser.py
2021-08-04 12:05:11 +10:00
Damien Elmes
5de3918dbf
fix notetype selection in import screen
...
Accidental rename in "PEP8 cards.py"
2021-08-04 12:01:28 +10:00
Damien Elmes
fc931c3edb
fix redo menu item showing undo text
2021-08-04 10:28:45 +10:00
Henrik Giesel
357a6c5cc6
Add toggle sticky shortcuts F9 and Shift+F9
2021-08-03 05:52:07 +02:00
Damien Elmes
87f9bd8021
Merge pull request #1320 from hgiesel/colorpickerplus
...
Remember last text and highlight color again
2021-08-03 09:07:46 +10:00
Henrik Giesel
4db7cebf62
Remember last text and highlight color again
2021-08-02 23:12:00 +02:00
Damien Elmes
528343b417
Merge pull request #1319 from abdnh/sidebar-scroll-center
...
Use PositionAtCenter for sidebar scrolling
2021-08-02 18:35:38 +10:00
Damien Elmes
f0b8b10314
Merge pull request #1311 from hikaru-y/flag-mark-icons-in-previewer
...
Show flag and mark icons in previewer
2021-08-02 18:33:36 +10:00
abdo
ad6f5c7404
Use PositionAtCenter for sidebar scrolling
2021-08-02 10:57:54 +03:00
Damien Elmes
c6c9721c53
update congrats screen periodically; automatically move back to study
2021-08-02 16:05:18 +10:00
Damien Elmes
d077d9509a
fix study deck->add deck->cancel
2021-07-30 11:35:55 +10:00
Damien Elmes
68dddfe93b
prevent hiding of sidebar
...
https://forums.ankiweb.net/t/browser-format-issues/11504/10
2021-07-28 11:14:09 +10:00
hikaru-y
80e15ff6aa
Show flag and mark icons in previewer
2021-07-26 20:13:42 +09:00
Damien Elmes
03e76d522a
reload card if there are registered hooks
...
https://forums.ankiweb.net/t/2-1-45-release-candidate/11362/54
2021-07-26 20:48:30 +10:00
Damien Elmes
4e133e7d8a
Merge pull request #1303 from Arthur-Milchior/paste_post_hook
...
Add a hook to execute after pasting in a field
2021-07-26 11:01:29 +10:00
RumovZ
a7315732f6
Prevent DeckChooser from setting filtered deck
2021-07-25 08:54:39 +02:00
Arthur Milchior
3dbe44217b
Add a hook to execute after pasting in a field
...
I expect to use it to ensure that images are resizable after they get pasted in a field
2021-07-25 01:53:25 +02:00
Damien Elmes
e7189f4af5
fix ugly js confirm box
...
https://forums.ankiweb.net/t/2-1-45-release-candidate/11362/2
2021-07-24 22:04:06 +10:00
Damien Elmes
cd9f8d883c
clarify deck description message
...
+ drop the reference to overview screen
2021-07-24 21:45:09 +10:00
Damien Elmes
7043e6f6f3
drop traceback in importing error message
2021-07-24 20:05:32 +10:00
Damien Elmes
e1f9d0fc1b
fix Python lints
2021-07-23 20:22:32 +10:00
RumovZ
f2f19e8b45
Remove native HelpPage enum
...
Also remove oneof from pb enum and handle strs in Python.
2021-07-22 16:32:49 +02:00
RumovZ
d8d69a3810
Switch frontend to use backend links
2021-07-22 10:07:13 +02:00
RumovZ
0d45df8551
Fix browser search completer
...
Adding an empty entry at the top fixes
https://forums.ankiweb.net/t/anki-2-1-45-beta/10664/45
and allows for scrolling back to an empty line.
2021-07-17 12:23:19 +02:00
Damien Elmes
cba0735c59
Merge pull request #1297 from hgiesel/browsershortcuts
...
Allow Using Ctrl+Shift+P from Browser when focusing Qt components
2021-07-17 15:18:36 +10:00
Henrik Giesel
22e735266e
Remove unnecessary lambda
2021-07-17 04:17:28 +02:00
Henrik Giesel
fb56576e36
Allow Using Ctrl+Shift+P from Browser when focusing Qt components
2021-07-17 03:39:27 +02:00
Damien Elmes
ce5f9bb9b0
Merge pull request #1292 from hgiesel/reviewerplus
...
Move reviewer to ts/reviewer v2
2021-07-17 09:10:14 +10:00
hikaru-y
16a1eb05a2
Revert "Follow-up to #1271 (Preload answer images)"
2021-07-16 23:57:49 +09:00
Henrik Giesel
272f2f7d1a
Revert to MathJax through script tag
2021-07-16 16:56:57 +02:00
Henrik Giesel
ddf3adfc8e
Remove protobuf important from reiewer (no longer necessary (?))
2021-07-16 16:56:56 +02:00
Henrik Giesel
05771b7598
Include MathJax over ts/reviewer
2021-07-16 16:56:56 +02:00
Henrik Giesel
5cbb582d0b
Export jquery via ts/reviewer
2021-07-16 16:56:56 +02:00
Henrik Giesel
68ac505d81
Include css-browser-selector via ts/reviewer
2021-07-16 16:56:56 +02:00
Henrik Giesel
f203562c58
Include protobuf in clayout and browser (p)reviewer
2021-07-16 16:56:56 +02:00
Henrik Giesel
afa8f8a6f0
Export getTypedAnswer
2021-07-16 16:56:56 +02:00
Henrik Giesel
af12756980
Move reviewer to ts/reviewer
2021-07-16 16:56:55 +02:00
Damien Elmes
87185d5365
Merge pull request #1288 from evandroforks/clayout_next_card_shortcut
...
Created shortcut to switch between card types on clayout.py
2021-07-16 10:51:40 +10:00
Damien Elmes
96e6e216a7
Merge pull request #1293 from RumovZ/find-and-replace
...
Find & Replace
2021-07-16 10:47:16 +10:00
Damien Elmes
e97c381a6f
Revert "stop (un)escaping media filenames"
...
This was flawed - while non-Latin text is now acceptable
in an IRI, we still need to be concerned with reserved characters
such as spaces, and Anki unfortunately has been storing the filenames
in unencoded form in the DB, meaning we must encode them at display
time. We won't be able to move away from this until existing notes
are rewritten, and it will probably require breaking compatibility with
older clients.
https://en.wikipedia.org/wiki/Internationalized_Resource_Identifier
This reverts commit 14110add55
.
2021-07-16 10:37:59 +10:00
evandrocoan
85c236a417
Created shortcut to switch between card types on clayout.py
...
editor window (F3 and F4) because it should be simple to use them
single hand and together with Ctrl+1, 2 and 3 combos.
2021-07-15 20:51:08 -03:00
RumovZ
9f777ad009
Remove redundant QueryOp in rename_deck()
2021-07-15 08:56:47 +02:00
Damien Elmes
33afe8aa32
support numpad enter in type answer
...
https://forums.ankiweb.net/t/anki-2-1-45-beta/10664/149
regression introduced in f4f0298378
2021-07-15 14:46:39 +10:00
RumovZ
3a1f8d4241
Remove unused name prefix of sidebar templates
2021-07-13 16:41:50 +02:00
RumovZ
eab51dce40
Add sidebar actions
...
- Find & Replace for notetype fields
- Rename with Parents for decks and tags
2021-07-13 16:34:02 +02:00
RumovZ
a5193339e7
Rework Find & Replace dialog:
...
- Add option to affect whole collection
- Allow to open without selection
- Add parameter for presetting field
2021-07-13 16:33:45 +02:00
Damien Elmes
780a254ac8
Merge pull request #1291 from RumovZ/addon-cols
...
Show key of unknown browser columns
2021-07-13 13:35:54 +10:00
RumovZ
51af0ba7d4
Show key of unknown browser columns
2021-07-12 19:03:51 +02:00
RumovZ
e24f562f8c
Add mock browser model to support legacy resetting
2021-07-12 12:36:26 +02:00