Commit Graph

840 Commits

Author SHA1 Message Date
Damien Elmes
147c9a02e1 fix star to top right 2015-08-11 19:02:59 +10:00
Damien Elmes
70b7dd88ca Merge pull request #106 from hssm/fav-tree-rebuild
Rebuild browser tree without reconnecting signals
2015-07-03 18:48:00 +10:00
Houssam Salem
98d98ad363 Rebuild browser tree without reconnecting signals
Fixes a bug where adding or removing a saved search triggers
multiple click events on tree items.
2015-06-30 21:41:16 +10:00
Damien Elmes
c38b267b2d if we detect a schema change, we must make sure not to update cards
fixes https://anki.tenderapp.com/discussions/ankidesktop/13226-bug-endless-error-report-in-browser
2015-05-30 13:05:22 +10:00
Damien Elmes
a27847de58 DEV->ANKIDEV 2015-05-19 14:26:33 +10:00
Damien Elmes
7131b15953 Merge pull request #102 from chkr-private/preferences-fixes
RFC: avoid exception on exit
2015-04-29 20:20:31 +10:00
Christian Krause
a65c20b3ad Avoid exception on exit
Closing anki when the preferences dialog
is open will cause an exception since
self.mw.col in Preferences is not available
anymore.

Avoid the exception by checking self.mw.col
again on accept().
2015-04-26 12:31:54 +02:00
Damien Elmes
9c2dcf1ee7 bump version 2015-03-25 01:12:50 +11:00
Damien Elmes
b0f7ddfefb don't bump mod time when moving cards into/out of a filtered deck
fixes the following:
- create a filtered deck and sync it
- review cards in the filtered deck and delete it
- sync again

The filtered deck deletion was bumping the mod time on cards at the
start of the sync, preventing the reviews from being synced from the
other side, leading to lost reviews and sanity check errors.
2015-03-19 15:35:04 +11:00
Damien Elmes
b5ab140e7b Merge pull request #100 from flimzy/media
Recognize a couple new media formats.
2015-03-17 13:36:26 +11:00
Jonathan Hall
6f77eed9bf Recognize a couple new media formats.
Adding 'webp' was necessary for Anki to recognize WebP images
(https://developers.google.com/speed/webp/?csw=1) as images rather than
audio.  The addition of the audio formats was incidental, as it appears Anki
assumes audio files if a file is not an image file.
2015-03-15 17:33:48 -05:00
Damien Elmes
a0bad7da45 update media url 2015-03-13 17:06:34 +11:00
Damien Elmes
cdb1cb06a0 prevent sync error being shown twice when aborting 2015-03-13 16:03:52 +11:00
Damien Elmes
67c86e8f5e make sure sync msg is saved before we abort sync 2015-03-12 12:51:05 +11:00
Damien Elmes
7024fed002 fix cont=False handling in sync 2015-03-02 21:09:12 +11:00
Damien Elmes
0262da2700 catch corrupt add-on downloads 2015-01-05 11:49:29 +10:00
Damien Elmes
360ef43460 Merge pull request #98 from ttempe/bug-in-browser
Avoid calling checkValid on an empty note
2015-01-01 10:50:31 +10:00
Thomas TEMPÉ
3d81ef2c68 Avoid calling checkValid on an empty note
Fix error message when editFocusLost is called after editor destruction

https://anki.tenderapp.com/discussions/ankidesktop/11175-bug-in-browser-revealed-by-add-on?unresolve=true
To reproduce:
1. Install the attached add-on. (All it does is register a function on the editFocusLost hook, and set the flag to 1 to signify that a field has been updated).
2. Run Anki. Enter the Browse window. Press Enter to display your deck.
3. Select one card.
4. Click inside one of the fields for that card. Now, when you leave that field, the editFocusLost hook will be called.
5. Now, select 2 notes from the browser, with your mouse, without clicking anywhere else before.

You will observe this error message:

Traceback (most recent call last):
File "aqt/progress.pyc", line 69, in handler 
File "aqt/editor.pyc", line 467, in onUpdate 
File "aqt/editor.pyc", line 572, in checkValid AttributeError: 'NoneType' object has no attribute 'fields'
2014-12-31 22:36:12 +08:00
Damien Elmes
b1ecdba42f Merge pull request #97 from corpulentcoffee/rename-field-fix
Use alternate pattern match during field changes
2014-12-30 12:26:38 +10:00
Dave Shifflett
643ec35449 Use alternate pattern match during field changes
When a user renames or deletes a field, Anki tries to go through the
user's templates to substitute occurrences of that field name with its
new name or remove the field.

However, if the user has multiple Mustache placeholders on a single
line, this does not work as intended because the leading (.*) capture
group grabs the text in-between the two (or more) Mustache placeholders.

Examples:

    {{#Flag}}
        ...
    {{/Flag}}{{^Flag}}
        ...
    {{/Flag}}

or

    {{Front}} {{#Flag}}...{{/Flag}}

or

    {{Front}} Hello. {{Victim}}
2014-12-29 20:09:09 -06:00
Damien Elmes
11ea5d5686 add powershell link to readme.dev 2014-11-29 16:49:30 +09:00
Houssam Salem
6e20bf7013 Load saved searches list in sorted order 2014-11-11 10:13:29 +11:00
Damien Elmes
e294469521 cont should be checked befoer any further processing 2014-11-06 16:56:16 +09:00
Damien Elmes
6e7e08ebd0 be explicit about modSchema()'s check flag
- remove gui code that adds exceptions for syncing
- use check=False for all syncing and upgrade code
2014-11-03 16:28:12 +09:00
Soren I. Bjornstad
519bf5fec7 fix inconsistency in default note type names
The value used internally was changed at some point and the text that
was added to the GUI was not.
2014-10-23 14:28:26 -05:00
Soren I. Bjornstad
44425ab9d5 Merge branch 'master' of https://github.com/dae/anki 2014-10-23 14:23:14 -05:00
Damien Elmes
acfbc41576 bump version 2014-10-19 17:00:26 +09:00
Damien Elmes
3d5d852708 reduce sync chunk size 2014-10-19 16:58:26 +09:00
Damien Elmes
08e5caef87 bump version 2014-10-18 16:10:12 +09:00
Damien Elmes
1f178b869f remove backspace to delete shortcut on macs
too many people activating it accidentally
2014-10-10 17:59:18 +09:00
Damien Elmes
77dfd63f1e comment out high-dpi+transparent latex example 2014-10-09 18:12:25 +09:00
Damien Elmes
47c3bb0796 make sure we set usn when pulling in dconf from apkg 2014-10-08 12:54:30 +09:00
Houssam Salem
9eaacf8977 Bump mod time when editing saved searches
Fixes saved searches not getting synced when modified.
2014-10-05 20:37:09 +11:00
Soren I. Bjornstad
9ec91724bf catch more invalid zip file errors 2014-09-27 10:19:43 -05:00
Soren I. Bjornstad
a430803774 Merge branch 'master' of https://github.com/dae/anki 2014-09-27 10:18:10 -05:00
Damien Elmes
ba7abb53e2 make sure we save note type after fixing ad bug 2014-09-27 10:32:21 +09:00
Damien Elmes
6b65cfc08f disable embedded fonts on osx 2014-09-27 10:26:14 +09:00
Soren I. Bjornstad
dd0e6f2a65 add {{Subdeck}} special field
If the deck is a several levels into a tree, it can be needlessly
verbose to list them.
2014-09-23 10:03:19 -05:00
Damien Elmes
f3fd5fb2fe bump version 2014-09-21 16:30:45 +09:00
Damien Elmes
d46bbabae7 add class=latex to latex img tags 2014-09-19 18:00:11 +09:00
Damien Elmes
5bb09ed77a don't add <br> tags when importing html
fixes #1098
2014-09-15 15:24:50 +09:00
Damien Elmes
ece78a7d11 allow all ankiwebview instances to take focus
the canFocus/canCopy separate variables was silly, as we ended up
with text that could be copied from the context menu but not with
a shortcut key. also we default to allowing focus now, since that's
the more sensible default. fixes copy issues with card info dialog and
some addons
2014-09-15 15:04:14 +09:00
Damien Elmes
70db1035b1 catch another ssl error 2014-09-01 21:06:41 +09:00
Damien Elmes
8420fa02d1 Merge branch 'master' of https://github.com/sobjornstad/anki 2014-09-01 15:03:00 +09:00
Soren I. Bjornstad
a0e736ef39 accept Ctrl-Enter to close the edit current dialog
Esc already works, but since the Add dialog accepts it it's nice to have
as well.
2014-08-31 14:41:08 -05:00
Damien Elmes
b61833d9b4 Merge branch 'master' of github.com:dae/anki 2014-08-28 17:02:50 +09:00
Damien Elmes
024b74d4f9 Merge pull request #91 from Derbeth/master
allow better translations of added cards statistics
2014-08-28 17:02:38 +09:00
Derbeth
d2b1d187da allow better translations of added cards statistics 2014-08-28 08:16:12 +02:00
Damien Elmes
3ce77fd25e Merge branch 'master' of github.com:dae/anki 2014-08-28 09:40:14 +09:00
Damien Elmes
9955ff6530 Merge pull request #90 from Derbeth/master
Allow better translations of '1 note deleted' browser tooltip
2014-08-28 09:39:59 +09:00