Damien Elmes
2b8bbda55f
when focusing current card, position at top
...
trying out the changes mentioned on
https://github.com/ankitects/anki/pull/1222#discussion_r648051997
2021-06-09 21:01:29 +10:00
Damien Elmes
c5e56a5fe8
ensure current card centered even if it was already visible
...
Otherwise if a user reviews a card while keeping Browse open, the
card may not be centered if it was already in view.
2021-06-08 16:22:56 +10:00
Damien Elmes
5bd2dc65ed
add card info action to reviewer; move note actions together
2021-06-08 14:23:23 +10:00
Damien Elmes
afaaa763ec
don't wait before scrolling to current card
...
https://github.com/ankitects/anki/pull/1222#discussion_r647017566
2021-06-08 12:54:05 +10:00
Damien Elmes
6878d4ca24
fix preferences screen indiscriminately triggering queue rebuild
2021-06-08 12:11:31 +10:00
Damien Elmes
1479957538
fix note changes triggering a queue rebuild
2021-06-08 12:09:35 +10:00
Damien Elmes
df600c094a
Merge pull request #1222 from RumovZ/browser-card
...
Change handling of browser's card parameter
2021-06-08 09:32:43 +10:00
Damien Elmes
0c69854b71
Merge pull request #1221 from kelciour/audio-pause-fix
...
Audio pause fix
2021-06-08 09:23:11 +10:00
RumovZ
8a9c9829e8
Change handling of browser's card parameter
...
If a search is provided execute it, else search for current deck.
Then try to select and scroll to the provided card.
2021-06-07 16:42:17 +02:00
kelciour
63dc301ef0
use 'cycle' command to toggle pause
2021-06-07 01:54:07 +03:00
kelciour
f1d1301fe6
workaround for audio tracks get clipped at the end
2021-06-07 01:45:59 +03:00
kelciour
c352314ed8
fix audio is paused unusual
...
closes #1164
2021-06-07 01:09:44 +03:00
Damien Elmes
e3ce9d05c7
add Rescheduled to Today section of sidebar
...
https://forums.ankiweb.net/t/anki-2-1-45-alpha/10061/105
2021-06-05 12:55:07 +10:00
Damien Elmes
f5fbad2c20
fix CSV import ignoring selected deck
...
This is a stop-gap - once the importing code is refactored, we
should pass in the desired deck directly.
https://forums.ankiweb.net/t/anki-2-1-45-alpha/10061/102
2021-06-04 20:37:45 +10:00
Damien Elmes
8555a977cb
Merge pull request #1218 from cherryblossom000/help-links
...
fix documentation links
2021-06-04 15:44:16 +10:00
Damien Elmes
5d477d7e11
another workaround for timeboxing issue
2021-06-04 15:25:30 +10:00
Damien Elmes
cff8069ef9
remove 'flag ' prefix from flag names
2021-06-04 15:03:17 +10:00
cherryblossom
92fe68abfe
fix documentation links
2021-06-03 16:51:03 +10:00
Damien Elmes
6e724ea480
make sure install.sh is run from the correct folder
...
https://forums.ankiweb.net/t/upgrade-doesnt-work-free-disk-space-is-written-full/10500/2
2021-06-03 10:50:32 +10:00
Damien Elmes
be9bbf2157
catch all recording errors; mention permission
...
https://forums.ankiweb.net/t/i-have-an-error-when-i-try-to-record-of-audio/10483
2021-06-02 12:20:40 +10:00
Damien Elmes
578b1b0552
Merge pull request #1213 from RumovZ/new-flags
...
Add pink, turquoise and purple flags
2021-06-02 11:22:26 +10:00
Damien Elmes
0f5627bb7a
limit custom study to 100 tags
...
The hard limit from sqlite may be larger, but things slow down as more
tags are selected.
https://forums.ankiweb.net/t/unable-to-create-custom-test/10467
There are a number of things that could be improved here:
- we should show a live count so users are aware of the limit
- we should be filling in the parent tags when they're not explicitly
listed on a card
- we should reconsider disabling the 'tags to include' by default
It may make sense to defer these changes until we can move this screen
into Svelte/handle the processing in the backend.
2021-06-02 11:15:39 +10:00
Damien Elmes
6e992752ca
prevent error storm when browser table encounters panic
2021-06-02 11:15:39 +10:00
Damien Elmes
a53c130177
close Anki after a panic occurs
...
Once the mutex has been poisoned the app is unusable, and users were
struggling to close it. This also ensures we'll receive the original
error report, instead of the follow-up poison errors that don't tell us
what caused the issue.
https://forums.ankiweb.net/t/error-message-keeps-popping-up/10494
2021-06-02 11:15:39 +10:00
RumovZ
daa696e703
Tweak flag colors
2021-06-01 18:14:54 +02:00
RumovZ
5e7a47fdc7
Rename violet to pink
2021-06-01 18:14:43 +02:00
Damien Elmes
70d20dfbec
Merge pull request #1209 from RumovZ/drop-saved-search
...
Drag & drop for saved search
2021-06-01 17:50:55 +10:00
Damien Elmes
479e19844b
fix incorrect platform specifier
...
It should have been isLin, but we don't even need to check it -
the env var alone should suffice.
2021-06-01 17:41:15 +10:00
Damien Elmes
b9f8cdb8bc
try to fall back to xcb if wayland forced on packaged build
...
https://forums.ankiweb.net/t/anki-doesnt-start-under-wayland-linux/10409/5
2021-06-01 17:38:35 +10:00
Damien Elmes
595e23189b
handle ctrl+numpad enter on Windows
...
https://forums.ankiweb.net/t/ctrl-enter-with-the-number-pad-doesnt-work/10323/5
2021-06-01 16:25:12 +10:00
Damien Elmes
e124f935a5
fix timebox causing crash
...
When a modal was created with another window as its parent, the other
window was being returned, when it was the current window that we
actually wanted. This caused nextCard() to be called again when it
presented the timebox modal, leading to a stack overflow.
https://forums.ankiweb.net/t/anki-2-1-45-alpha/10061/71
2021-06-01 15:35:18 +10:00
Damien Elmes
688f22b4c8
require reposition to start at 0; cap maximum
...
https://forums.ankiweb.net/t/unable-to-reposition-cards-to-negative-start-position/10370/2
2021-06-01 10:09:24 +10:00
RumovZ
c97c6c6e98
Add violet, turquoise and purple flags
2021-05-31 12:03:30 +02:00
Damien Elmes
29c4869aef
remove deck protobuf from frontend
...
Like the previous change, avoid exposing the protobuf as a public API
for now. It requires more thought, and is probably better done with
either extra helper accessors like decks.name(), or via a native class.
2021-05-31 16:31:06 +10:00
RumovZ
c85ae24347
Make a new item the current item after refresh
2021-05-30 10:46:59 +02:00
RumovZ
985ce2466b
Skip saving search if it already exists
2021-05-30 10:11:40 +02:00
RumovZ
37fec02f88
Enable drop to create saved search
2021-05-30 09:30:22 +02:00
Damien Elmes
a894c720de
Merge pull request #1206 from RumovZ/fix-sidebar
...
Fix some sidebar issues
2021-05-29 10:33:52 +10:00
Damien Elmes
93459cc48f
Merge pull request #1200 from RumovZ/template-checks
...
Template checks
2021-05-29 10:28:06 +10:00
RumovZ
24b4f15038
Fix renaming of unused tag
...
Unused tags can't be renamed, but since the CollectionOp returns success
in any case, the provisionally renamed sidebar item needs to be reset.
2021-05-28 19:18:21 +02:00
RumovZ
2597038fe5
Prevent sidebar toolbar from folding
...
If there is little space, Qt replaces some tools of the toolbar with an
expandable menu indicated by an arrow. But this arrow is invisible in
night mode.
2021-05-28 18:09:44 +02:00
RumovZ
af50db9fd3
Fix restoring current sidebar element for cards
2021-05-28 17:46:46 +02:00
Damien Elmes
7caaf0c735
remove sticky setting from fields dialog
...
https://forums.ankiweb.net/t/anki-2-1-45-alpha/10061/60
2021-05-28 18:33:29 +10:00
Damien Elmes
a02890a84b
make update all toggle clearer
...
https://forums.ankiweb.net/t/anki-2-1-45-alpha/10061/59
+ remove background color; it did not look good in dark mode
2021-05-28 18:33:28 +10:00
Damien Elmes
aa7d2721c9
avoid bumping mtime when nothing has changed
...
+ update sync indicator after every op
+ skip mtime bump on undo/redo
2021-05-28 11:09:16 +10:00
RumovZ
935fbb6289
Use implicit failure handling and self as parent
2021-05-27 16:51:03 +02:00
Damien Elmes
6cc713cbe8
add v3 scheduler to prefs screen
2021-05-27 23:09:49 +10:00
Damien Elmes
4e95cac5c8
remove 'update later' button
2021-05-27 22:42:21 +10:00
Damien Elmes
83a1d99e22
fix remembered tags not being applied to next added note
...
https://forums.ankiweb.net/t/anki-2-1-45-alpha/10061/56
2021-05-27 13:18:34 +10:00
Damien Elmes
f26c7ed99e
ask user to confirm which deck they want when opening options in reviewer
...
Also fixes https://forums.ankiweb.net/t/anki-2-1-45-alpha/10061/57
2021-05-27 13:15:28 +10:00
Damien Elmes
7c5e974ae5
hook up some missing translations in deck options screen
2021-05-26 14:41:18 +10:00
Damien Elmes
57ec4cc7b5
change get_queued_cards() to no longer return congrats info
2021-05-26 12:59:45 +10:00
Damien Elmes
0026506543
update ts deps
...
- prettier's formatting has changed, so files needed to be reformatted
- dart is spitting out deprecation warnings like:
254 │ 2: $spacer / 2,
│ ^^^^^^^^^^^
╵
bazel-out/darwin-fastbuild/bin/ts/sass/bootstrap/_variables.scss 254:6 @import
ts/sass/button_mixins.scss 2:9 @use
ts/components/ColorPicker.svelte 2:5 root stylesheet
DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.
Recommendation: math.div($grid-gutter-width, 2)
2021-05-26 09:37:40 +10:00
RumovZ
db9594818a
Handle failure in CardLayout/accept()
2021-05-25 20:58:43 +02:00
Damien Elmes
5a8f534f00
always start in first sidebar mode
...
I didn't notice anyone objecting; let's see how this is received.
https://forums.ankiweb.net/t/anki-2-1-45-alpha/10061/35
2021-05-24 14:51:21 +10:00
Damien Elmes
adcdb422c5
config updates by the frontend now skip undo by default
2021-05-24 14:50:46 +10:00
Damien Elmes
47076b9ac5
Merge pull request #1188 from RumovZ/switch-color-2
...
Change switch color depending on state
2021-05-24 11:42:54 +10:00
Damien Elmes
54628c3ac7
make switch more legible in dark mode
2021-05-24 11:31:56 +10:00
Damien Elmes
a0eebb78ce
Merge pull request #1186 from RumovZ/ctx-actions
...
Update context action states after card op
2021-05-24 10:49:23 +10:00
RumovZ
ff76d50338
Remove browser.oneModelNotes()
2021-05-22 19:12:03 +02:00
RumovZ
0dca3ef548
Check notetype count in browser.onChangeModel()
2021-05-22 19:11:06 +02:00
RumovZ
cba5c2253a
Change switch color depending on state
...
Make knob overlap path.
2021-05-22 10:01:15 +02:00
RumovZ
29589fcf0d
Update context action states after card op
2021-05-22 08:35:47 +02:00
Damien Elmes
195c41cba3
Merge pull request #1185 from RumovZ/scrolling
...
Scroll pixels instead of columns horizontally
2021-05-22 10:59:09 +10:00
Damien Elmes
d7d226843e
improve type answer legibility
...
https://forums.ankiweb.net/t/accessibility-suggestion-correct-answer-text-contrast-in-dark-mode/10105
There's probably more that could be done here, but that can probably
wait for #1068
2021-05-22 10:31:29 +10:00
Damien Elmes
958c53d886
fix find&replace searching in incorrect field
2021-05-22 10:12:14 +10:00
RumovZ
d46fe913a5
Scroll pixels instead of columns horizontally
2021-05-21 18:59:53 +02:00
Damien Elmes
3d4cf26758
expose undoable config changes to frontend; refresh sidebar
...
The browser header handling still needs updating
2021-05-21 17:50:41 +10:00
Damien Elmes
99b7da49a9
report changed cards when changing deck/flag
...
+ fix repeated flag shortcut not toggling
2021-05-21 16:03:05 +10:00
Damien Elmes
398cdc8992
add night mode styling to type-in-the-answer box
...
https://forums.ankiweb.net/t/night-mode-does-not-affect-input-tags/10116
2021-05-20 19:14:12 +10:00
RumovZ
5a6ba1b0b9
Move flags into separate module
2021-05-20 10:26:18 +02:00
Damien Elmes
422584b814
fix error when opening and closing editor rapidly
2021-05-20 15:32:28 +10:00
Damien Elmes
d5f4860f9b
fix fields/cards font size & too-large toolbar on high DPI Windows
...
- enable default_css on editor again, so that the html element
is set to the system font size. If this is bringing in unwanted styling,
maybe we can come up with a different solution that just adjusts the
fonts
- make toolbar size relative to html font size, instead of hard-coding
it
2021-05-20 13:15:17 +10:00
Damien Elmes
055f2907ec
Merge pull request #1178 from RumovZ/flag-labels
...
Custom labels for flags
2021-05-20 11:59:55 +10:00
RumovZ
6fb2d30426
Remove redundant pylint exception
2021-05-19 19:44:49 +02:00
RumovZ
f960299345
Prefer looping over flags over exhaustive listing
2021-05-19 19:26:39 +02:00
RumovZ
b5fa7923e6
Use custom flag labels in reviewer
2021-05-19 19:18:49 +02:00
RumovZ
5fa68c885a
Use dataclass instead of tuple for loaded flags
2021-05-19 19:17:43 +02:00
abdo
bbb2f7158f
Strip Unicode isolation characters from title
2021-05-19 18:21:57 +03:00
Damien Elmes
df38788e07
move deck name into window title; v-center sticky bar
2021-05-19 19:34:15 +10:00
Damien Elmes
fdd162a7b9
simplify previous patch
...
The default 1 rem is fine, but we need to apply the default font size
to the html element instead of the body for the definition of rem to
update.
Fixes #1174
2021-05-19 19:06:20 +10:00
RumovZ
30736ddf75
Use custom flag labels for browser actions
2021-05-19 11:00:02 +02:00
RumovZ
9816227b5c
Make sidebar flags renamable
2021-05-19 10:04:40 +02:00
Damien Elmes
581480191a
show note about old options screen if any add-ons are installed
2021-05-19 16:20:25 +10:00
Damien Elmes
63f1a363af
use literal for ease type
2021-05-19 16:05:12 +10:00
Damien Elmes
9f3f6bab7d
enable redo support
...
Also:
- fix issues where the Undo action in the Browse screen was not
consistent with the main window. The existing hook signature has been
changed; from a snapshot of the add-on code from a few months ago, it
was not a hook that was being used by anyone.
- change the undo shortcut in the Browse window to match the main
window. It was different because undoing a change in the editing area
could accidentally trigger an undo of an operation, but the damage is
limited now that (most) operations can be redone. If it still proves to
be a problem, perhaps we should just always swallow ctrl+z when an
editing field is focused.
2021-05-19 15:18:39 +10:00
RumovZ
3b5e8e5041
Fix black workaround for format calls
2021-05-18 22:19:09 +02:00
Damien Elmes
fa47f6ec15
Merge pull request #1170 from RumovZ/fix-columns
...
Fix column issues
2021-05-18 09:24:15 +10:00
Damien Elmes
157f602624
fix detection of shift key at startup
...
Our regular helper doesn't appear to work during startup.
2021-05-18 09:21:02 +10:00
Damien Elmes
bd24005e08
PreviewDialog was missing from top level browser module
2021-05-18 09:10:28 +10:00
RumovZ
2290a1652d
Set column sizes and indicator after state change
2021-05-17 20:13:45 +02:00
RumovZ
9ceee90942
Block events when restoring headers
...
Restoring headers after switching states was triggering
_on_column_toggled(), leading to unexpected results.
2021-05-17 20:07:52 +02:00
RumovZ
02f86ec352
Make failed sort column change a no-op
...
The previous behaviour when a non-sortable column was clicked was to
trigger the sorting routine, which was usually a no-op, but would
reorder rows if the configured sort column was hidden.
2021-05-17 18:33:59 +02:00
Damien Elmes
9edac805ad
support card state mutator in test scheduler
...
Documentation to come
2021-05-17 16:59:02 +10:00
Damien Elmes
1a48622d77
experiment with learning count on deck list
2021-05-16 20:23:39 +10:00
Damien Elmes
390a8421aa
fix test scheduler undo + implement look-ahead
...
Instead of using a separate undo queue, the code now defers checking for
newly-due learning cards until the answering stage, and logs the updated
cutoff time as an undoable change, so that any newly-due learning cards
won't appear instead of a new/review card that was just undone.
Queue redo now uses a similar approach to undo, instead of rebuilding the
queues.
2021-05-14 22:16:53 +10:00
Damien Elmes
c41d5ca4bf
work around Windows issue on latest Black
...
Thanks Rumo!
d797900386
2021-05-13 20:15:51 +10:00
Damien Elmes
99081e422b
re-enable leech notification for test scheduler
2021-05-13 15:51:02 +10:00
Damien Elmes
dbbcb3e38c
expose new sorting options in test scheduler options; move things around
2021-05-13 15:23:16 +10:00
Damien Elmes
49a1580566
use new API for test scheduler
...
Avoids duplicate work, and is a step towards allowing the next
states to be modified by third-party code.
Also:
- fixed incorrect underlined count, due to reviews being labeled as
learning cards
- fixed reviewer not refreshing when undoing a test review, by splitting
up backend queue rebuilding from frontend reviewer refresh
- moved answering into a CollectionOp
2021-05-11 13:06:03 +10:00