Merge pull request #794 from abdnh/tagedit-enter-fix

Don't apply suggestion when no suggestion list is shown in tagedit
This commit is contained in:
Damien Elmes 2020-10-21 21:19:05 +10:00 committed by GitHub
commit f947a65ac5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -56,7 +56,10 @@ class TagEdit(QLineEdit):
if not self.completer.setCurrentRow(cur_row + 1): if not self.completer.setCurrentRow(cur_row + 1):
self.completer.setCurrentRow(0) self.completer.setCurrentRow(0)
return return
if evt.key() in (Qt.Key_Enter, Qt.Key_Return): if (
evt.key() in (Qt.Key_Enter, Qt.Key_Return)
and self.completer.popup().isVisible()
):
# apply first completion if no suggestion selected # apply first completion if no suggestion selected
selected_row = self.completer.popup().currentIndex().row() selected_row = self.completer.popup().currentIndex().row()
if selected_row == -1: if selected_row == -1: