langfingaz/anki
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

avoid string concatenation

Browse Source
This commit is contained in:
ANH 2020-07-24 08:12:46 +03:00
parent ea99c7afac
commit e122534ba4
1 changed files with 10 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
qt/aqt/editor.py
View File

@ -1091,23 +1091,23 @@ class EditorWebView(AnkiWebView):
return None return None
txt = mime.text() txt = mime.text()
processed = '' processed = []
lines = txt.split("\n") lines = txt.split("\n")
for line in lines: for line in lines:
for token in re.split('(\S+)', line): for token in re.split("(\S+)", line):
# inlined data in base64? # inlined data in base64?
if token.startswith("data:image/"): if token.startswith("data:image/"):
processed += self.editor.inlinedImageToLink(token) processed.append(self.editor.inlinedImageToLink(token))
elif self.editor.isURL(token): elif self.editor.isURL(token):
# if the user is pasting an image or sound link, convert it to local # if the user is pasting an image or sound link, convert it to local
link = self.editor.urlToLink(token) link = self.editor.urlToLink(token)
if link: if link:
processed += link processed.append(link)
else: else:
# not media; add it as a normal link # not media; add it as a normal link
link = '<a href="{}">{}</a>'.format(token, html.escape(token)) link = '<a href="{}">{}</a>'.format(token, html.escape(token))
processed += link processed.append(link)
else: else:
token = html.escape(token).replace("\t", " " * 4) token = html.escape(token).replace("\t", " " * 4)
# if there's more than one consecutive space, # if there's more than one consecutive space,
@ -1115,11 +1115,12 @@ class EditorWebView(AnkiWebView):
def repl(match): def repl(match):
return match.group(1).replace(" ", "&nbsp;") + " " return match.group(1).replace(" ", "&nbsp;") + " "
token = re.sub(" ( +)", repl, token) token = re.sub(" ( +)", repl, token)
processed += token processed.append(token)
processed += "<br>" processed.append("<br>")
# return without last <br> # remove last <br>
return processed[:-4] processed.pop()
return "".join(processed)
def _processHtml(self, mime: QMimeData) -> Tuple[Optional[str], bool]: def _processHtml(self, mime: QMimeData) -> Tuple[Optional[str], bool]:
if not mime.hasHtml(): if not mime.hasHtml():