langfingaz/anki
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

change _on_click_current to _on_click_index

Browse Source 
fix bug where clicking on a blank space below sidebar item
would still trigger currentIndex item's click event
This commit is contained in:
bluegreenmagick 2021-02-20 22:58:02 +09:00
parent ab790c1d14
commit d6eac551b1
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
qt/aqt/sidebar.py
View File

@ -442,11 +442,13 @@ class SidebarTreeView(QTreeView):
def mouseReleaseEvent(self, event: QMouseEvent) -> None:
super().mouseReleaseEvent(event)
if event.button() == Qt.LeftButton:
self._on_click_current()
idx = self.indexAt(event.pos())
self._on_click_index(idx)
def keyPressEvent(self, event: QKeyEvent) -> None:
if event.key() in (Qt.Key_Return, Qt.Key_Enter):
self._on_click_current()
idx = self.currentIndex()
self._on_click_index(idx)
else:
super().keyPressEvent(event)
@ -516,8 +518,7 @@ class SidebarTreeView(QTreeView):
self.browser.editor.saveNow(on_save)
return True
def _on_click_current(self) -> None:
idx = self.currentIndex()
def _on_click_index(self, idx: QModelIndex) -> None:
if item := self.model().item_for_index(idx):
if item.on_click:
item.on_click()