From 9b0729970ef25d7e99da24a08fc5cbc7d8c6556c Mon Sep 17 00:00:00 2001 From: Damien Elmes Date: Mon, 23 May 2022 15:41:32 +1000 Subject: [PATCH] Fix deck options sticky bar at top disappearing on scroll Issue was introduced in https://github.com/ankitects/anki/pull/1470/commits/7922f182966cc9426391aaa748d2da4b7b018a0b when the styling was moved into base.scss. From what I can tell, there are two locations where the current styling is required: - the editor, to ensure the tags are shown at the bottom - the change notetype screen, which requires this styling for a sticky bar at top I'm no CSS guru, so if someone thinks this could be solved in a better way, please submit a follow-up PR. Closes #1782 --- sass/base.scss | 5 ----- ts/change-notetype/change-notetype-base.scss | 4 ++++ ts/editor/editor-base.scss | 4 ++++ 3 files changed, 8 insertions(+), 5 deletions(-) diff --git a/sass/base.scss b/sass/base.scss index e2f649a43..6d3e13062 100644 --- a/sass/base.scss +++ b/sass/base.scss @@ -32,11 +32,6 @@ $utilities: ( flex-basis: 75%; } -html, -body { - height: 100%; -} - * { overscroll-behavior: none; } diff --git a/ts/change-notetype/change-notetype-base.scss b/ts/change-notetype/change-notetype-base.scss index 4172fdd13..c1dea6e4e 100644 --- a/ts/change-notetype/change-notetype-base.scss +++ b/ts/change-notetype/change-notetype-base.scss @@ -23,6 +23,10 @@ html { overflow-x: hidden; } +html, body { + height: 100%; +} + #main { padding: 0.5em 0.5em 1em 0.5em; height: 100vh; diff --git a/ts/editor/editor-base.scss b/ts/editor/editor-base.scss index 1e942aa3e..acc334257 100644 --- a/ts/editor/editor-base.scss +++ b/ts/editor/editor-base.scss @@ -12,3 +12,7 @@ $btn-disabled-opacity: 0.4; html { overflow: hidden; } + +html, body { + height: 100%; +}