From 892c9f6da83eb9af087b33c7a9a7c6ad792b18fd Mon Sep 17 00:00:00 2001 From: Henrik Giesel Date: Tue, 13 Sep 2022 06:11:47 +0200 Subject: [PATCH] Fix/autofix empty div (#2066) * Remove empty divs in rich text input * Refactor inline content detection * Fix formatting --- ts/editor/rich-text-input/transform.ts | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/ts/editor/rich-text-input/transform.ts b/ts/editor/rich-text-input/transform.ts index 33ce0afb8..a49bf432e 100644 --- a/ts/editor/rich-text-input/transform.ts +++ b/ts/editor/rich-text-input/transform.ts @@ -19,7 +19,7 @@ function adjustInputHTML(html: string): string { function adjustInputFragment(fragment: DocumentFragment): void { if (nodeContainsInlineContent(fragment)) { - fragment.appendChild(document.createElement("br")); + fragment.append(document.createElement("br")); } } @@ -35,12 +35,16 @@ export function storedToFragment(storedHTML: string): DocumentFragment { function adjustOutputFragment(fragment: DocumentFragment): void { if ( - fragment.hasChildNodes() && - nodeIsElement(fragment.lastChild!) && nodeContainsInlineContent(fragment) && - fragment.lastChild!.tagName === "BR" + fragment.lastChild && + nodeIsElement(fragment.lastChild) && + fragment.lastChild.tagName === "BR" ) { - fragment.lastChild!.remove(); + fragment.lastChild.remove(); + } + + for (const divElement of fragment.querySelectorAll("div:empty")) { + divElement.remove(); } }