langfingaz/anki
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

skip revlog with time = 0 when calc recall cost (#2870)

Browse Source 
* skip revlog with time = 0 when calc recall cost

* Update retention.rs
This commit is contained in:
Jarrett Ye 2023-12-05 11:08:34 +08:00 committed by GitHub
parent a5bdb28849
commit 80c5f2d491
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
rslib/src/scheduler/fsrs/retention.rs
View File

@ -121,7 +121,11 @@ impl Collection {
let mut arr = default; let mut arr = default;
revlogs revlogs
.iter() .iter()
.filter(|r| r.review_kind == RevlogReviewKind::Review && r.button_chosen > 0) .filter(|r| {
r.review_kind == RevlogReviewKind::Review
&& r.button_chosen > 0
&& r.taken_millis > 0
})
.sorted_by(|a, b| a.button_chosen.cmp(&b.button_chosen)) .sorted_by(|a, b| a.button_chosen.cmp(&b.button_chosen))
.group_by(|r| r.button_chosen) .group_by(|r| r.button_chosen)
.into_iter() .into_iter()
@ -139,10 +143,15 @@ impl Collection {
let learn_cost = { let learn_cost = {
let revlogs_filter = revlogs let revlogs_filter = revlogs
.iter() .iter()
.filter(|r| r.review_kind == RevlogReviewKind::Learning && r.button_chosen >= 1) .filter(|r| {
r.review_kind == RevlogReviewKind::Learning
&& r.button_chosen >= 1
&& r.taken_millis > 0
})
.map(|r| r.taken_millis); .map(|r| r.taken_millis);
if total_first > 0.0 { let length = revlogs_filter.clone().count() as f64;
revlogs_filter.sum::<u32>() as f64 / total_first / 1000.0 if length > 0.0 {
revlogs_filter.sum::<u32>() as f64 / length / 1000.0
} else { } else {
return Err(AnkiError::FsrsInsufficientData); return Err(AnkiError::FsrsInsufficientData);
} }