Revert to blanking out missed chars in provided text
Quite a few users seem surprised to have missed characters appear in their input text
This commit is contained in:
parent
2c952cf3af
commit
321402a6d0
@ -71,8 +71,9 @@ impl DiffContext {
|
|||||||
provided.push(DiffToken::bad(self.slice_provided(&opcode)));
|
provided.push(DiffToken::bad(self.slice_provided(&opcode)));
|
||||||
}
|
}
|
||||||
"insert" => {
|
"insert" => {
|
||||||
provided.push(DiffToken::missing(self.slice_expected(&opcode)));
|
let expected_str = self.slice_expected(&opcode);
|
||||||
expected.push(DiffToken::missing(self.slice_expected(&opcode)));
|
provided.push(DiffToken::missing("-".repeat(expected_str.len())));
|
||||||
|
expected.push(DiffToken::missing(expected_str));
|
||||||
}
|
}
|
||||||
"replace" => {
|
"replace" => {
|
||||||
provided.push(DiffToken::bad(self.slice_provided(&opcode)));
|
provided.push(DiffToken::bad(self.slice_provided(&opcode)));
|
||||||
@ -217,9 +218,9 @@ mod test {
|
|||||||
good(" ahora q"),
|
good(" ahora q"),
|
||||||
bad("e"),
|
bad("e"),
|
||||||
good(" vamos"),
|
good(" vamos"),
|
||||||
missing(" "),
|
missing("-"),
|
||||||
good("a hacer"),
|
good("a hacer"),
|
||||||
missing("?"),
|
missing("-"),
|
||||||
]
|
]
|
||||||
);
|
);
|
||||||
assert_eq!(
|
assert_eq!(
|
||||||
@ -248,7 +249,7 @@ mod test {
|
|||||||
let ctx = DiffContext::new("1", "23");
|
let ctx = DiffContext::new("1", "23");
|
||||||
assert_eq!(ctx.to_tokens().provided, &[bad("23")]);
|
assert_eq!(ctx.to_tokens().provided, &[bad("23")]);
|
||||||
let ctx = DiffContext::new("12", "1");
|
let ctx = DiffContext::new("12", "1");
|
||||||
assert_eq!(ctx.to_tokens().provided, &[good("1"), missing("2"),]);
|
assert_eq!(ctx.to_tokens().provided, &[good("1"), missing("-"),]);
|
||||||
}
|
}
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
|
Loading…
Reference in New Issue
Block a user