langfingaz/anki
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix preview not updating on edit

Browse Source 
https://forums.ankiweb.net/t/modification-and-preview/1331
This commit is contained in:
Damien Elmes 2020-07-24 11:57:22 +10:00
parent 796696afde
commit 26426cb11e
2 changed files with 20 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
qt/aqt/browser.py
View File

@ -881,10 +881,10 @@ QTableView {{ gridline-color: {grid} }}
self.singleCard = True self.singleCard = True
self._updateFlagsMenu() self._updateFlagsMenu()
gui_hooks.browser_did_change_row(self) gui_hooks.browser_did_change_row(self)
self._renderPreview(True)
def refreshCurrentCard(self, note: Note) -> None: def refreshCurrentCard(self, note: Note) -> None:
self.model.refreshNote(note) self.model.refreshNote(note)
self._renderPreview()
def onLoadNote(self, editor): def onLoadNote(self, editor):
self.refreshCurrentCard(editor.note) self.refreshCurrentCard(editor.note)
@ -1513,9 +1513,9 @@ where id in %s"""
self._previewer = PreviewDialog(self, self.mw, self._on_preview_closed) self._previewer = PreviewDialog(self, self.mw, self._on_preview_closed)
self._previewer.open() self._previewer.open()
def _renderPreview(self, cardChanged=False): def _renderPreview(self):
if self._previewer: if self._previewer:
self._previewer.render_card(cardChanged) self._previewer.render_card()
def _cleanup_preview(self): def _cleanup_preview(self):
if self._previewer: if self._previewer:

20
qt/aqt/previewer.py
View File

@ -50,12 +50,15 @@ class Previewer(QDialog):
def card(self) -> Optional[Card]: def card(self) -> Optional[Card]:
raise NotImplementedError raise NotImplementedError
def card_changed(self) -> bool:
raise NotImplementedError
def open(self): def open(self):
self._state = "question" self._state = "question"
self._last_state = None self._last_state = None
self._create_gui() self._create_gui()
self._setup_web_view() self._setup_web_view()
self.render_card(True) self.render_card()
self.show() self.show()
def _create_gui(self): def _create_gui(self):
@ -124,11 +127,11 @@ class Previewer(QDialog):
if cmd.startswith("play:"): if cmd.startswith("play:"):
play_clicked_audio(cmd, self.card()) play_clicked_audio(cmd, self.card())
def render_card(self, cardChanged=False): def render_card(self):
self.cancel_timer() self.cancel_timer()
# Keep track of whether render() has ever been called # Keep track of whether render() has ever been called
# with cardChanged=True since the last successful render # with cardChanged=True since the last successful render
self._card_changed |= cardChanged self._card_changed |= self.card_changed()
# avoid rendering in quick succession # avoid rendering in quick succession
elap_ms = int((time.time() - self._last_render) * 1000) elap_ms = int((time.time() - self._last_render) * 1000)
delay = 300 delay = 300
@ -277,12 +280,23 @@ class MultiCardPreviewer(Previewer):
class BrowserPreviewer(MultiCardPreviewer): class BrowserPreviewer(MultiCardPreviewer):
_last_card_id = 0
def card(self) -> Optional[Card]: def card(self) -> Optional[Card]:
if self._parent.singleCard: if self._parent.singleCard:
return self._parent.card return self._parent.card
else: else:
return None return None
def card_changed(self) -> bool:
c = self.card()
if not c:
return True
else:
changed = c.id != self._last_card_id
self._last_card_id = c.id
return changed
def _on_finished(self, ok): def _on_finished(self, ok):
super()._on_finished(ok) super()._on_finished(ok)
self._parent.form.previewButton.setChecked(False) self._parent.form.previewButton.setChecked(False)