From e46421c7c988c60bf8b398edcd618a78c35afd7e Mon Sep 17 00:00:00 2001 From: evandrocoan Date: Mon, 20 Apr 2020 19:14:18 -0300 Subject: [PATCH] Fixed ripgrep not installing on ubuntu anymore https://github.com/BurntSushi/ripgrep#installation https://github.com/BurntSushi/ripgrep/issues/1232 N.B. Various snaps for ripgrep on Ubuntu are also available, but none of them seem to work right and generate a number of very strange bug reports that I don't know how to fix and don't have the time to fix. Therefore, it is no longer a recommended installation option.) --- .github/scripts/trailing-newlines.sh | 2 +- .github/workflows/checks.yml | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/.github/scripts/trailing-newlines.sh b/.github/scripts/trailing-newlines.sh index ff8c71dfe..ef17c5afd 100755 --- a/.github/scripts/trailing-newlines.sh +++ b/.github/scripts/trailing-newlines.sh @@ -4,7 +4,7 @@ set -eu -o pipefail ${SHELLFLAGS} # Checking version to force it fail the build if rg is not installed. # Because `set -e` does not work inside the subshell $() -rg --version > /dev/null 2>&1 +rg --version > /dev/null 2>&1 || echo "Error: ripgrep is not installed!" files=$(rg -l '[^\n]\z' -g '!*.{png,svg,scss,json,sql}' || true) diff --git a/.github/workflows/checks.yml b/.github/workflows/checks.yml index e42bae4cf..221803852 100644 --- a/.github/workflows/checks.yml +++ b/.github/workflows/checks.yml @@ -203,7 +203,10 @@ jobs: set -x sudo apt update sudo apt install portaudio19-dev gettext - sudo snap install ripgrep --classic + # https://github.com/BurntSushi/ripgrep/issues/1232 + # sudo apt-get install ripgrep + curl -LO https://github.com/BurntSushi/ripgrep/releases/download/11.0.2/ripgrep_11.0.2_amd64.deb + sudo dpkg -i ripgrep_11.0.2_amd64.deb - name: Set up brew ripgrep, pyaudio, gettext if: matrix.os == 'macos-latest'