langfingaz/anki
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix RTL text display being off + Update PlainTextInput RTL on save (#1448)

Browse Source
This commit is contained in:
Henrik Giesel 2021-10-23 03:06:15 +02:00 committed by GitHub
parent 3cdb3d72c1
commit 02409d083b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 17 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
sass/base.scss
View File

@ -39,3 +39,7 @@ button {
/* override transition for instant hover response */
transition: color 0.15s ease-in-out, box-shadow 0.15s ease-in-out !important;
}
pre, code, kbd, samp {
unicode-bidi: normal !important;
}

15
ts/editor/CodeMirror.svelte
View File

@ -11,14 +11,22 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
</script>
<script lang="typescript">
import { createEventDispatcher } from "svelte";
import { createEventDispatcher, getContext } from "svelte";
import type { Writable } from "svelte/store";
import storeSubscribe from "../sveltelib/store-subscribe";
import { directionKey } from "../lib/context-keys";
export let configuration: CodeMirror.EditorConfiguration;
export let code: Writable<string>;
const direction = getContext<Writable<"ltr" | "rtl">>(directionKey);
const defaultConfiguration = {
direction: $direction,
rtlMoveVisually: true,
};
let codeMirror: CodeMirror.EditorFromTextArea;
$: codeMirror?.setOption("direction", $direction);
function setValue(content: string): void {
codeMirror.setValue(content);
@ -28,7 +36,10 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
const dispatch = createEventDispatcher();
function openCodeMirror(textarea: HTMLTextAreaElement): void {
codeMirror = CodeMirrorLib.fromTextArea(textarea, configuration);
codeMirror = CodeMirrorLib.fromTextArea(textarea, {
...defaultConfiguration,
...configuration,
});
// TODO passing in the tabindex option does not do anything: bug?
codeMirror.getInputField().tabIndex = 0;