langfingaz/anki
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
f6ecddef5f
anki/proto/protobuf.bzl

76 lines
2.5 KiB
Python
Raw Normal View History

use protobuf binaries to reduce initial compile times
2020-12-23 08:10:37 +01:00
"""
Replace @com_google_protobuf with a platform binary.
Avoids the long initial compile, but will fail if anything depends on the protobuf library.
"""
load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
load("@bazel_tools//tools/build_defs/repo:utils.bzl", "maybe")
def _impl(rctx):
rctx.file("BUILD.bazel", """
alias(
name = "protoc",
actual = select({
rename workspace I'd forgotten that Bazel "helpfully" adds __init__.py files into folders that match the workspace name, breaking imports.
2021-07-10 15:58:53 +02:00
"@ankidesktop//platforms:windows_x86_64": "@protoc_bin_windows//:bin/protoc.exe",
use x86 binaries for clang format/protobuf on Mac
2021-10-15 15:20:43 +02:00
"@ankidesktop//platforms:macos_arm64": "@protoc_bin_macos//:bin/protoc",
rename workspace I'd forgotten that Bazel "helpfully" adds __init__.py files into folders that match the workspace name, breaking imports.
2021-07-10 15:58:53 +02:00
"@ankidesktop//platforms:macos_x86_64": "@protoc_bin_macos//:bin/protoc",
"@ankidesktop//platforms:linux_x86_64": "@protoc_bin_linux_x86_64//:bin/protoc",
"@ankidesktop//platforms:linux_arm64": "@protoc_bin_linux_arm64//:bin/protoc"
use protobuf binaries to reduce initial compile times
2020-12-23 08:10:37 +01:00
}),
visibility = ["//visibility:public"]
)
""")
_setup_protoc = repository_rule(
implementation = _impl,
set local=False for python/protoc/clang Suspect this will fix these repos being unnecessarily restarted on changes to the workspace.
2021-11-01 02:36:44 +01:00
local = False,
use protobuf binaries to reduce initial compile times
2020-12-23 08:10:37 +01:00
attrs = {},
)
def setup_protobuf_binary(name):
maybe(
http_archive,
name = "protoc_bin_macos",
urls = [
Add support for proto3 optional scalars Protobuf 3.15 introduced support for marking scalar fields like uint32 as optional, and all of our tooling appears to support it now. This allows us to use simple optional/null checks in our Rust/ TypeScript code, without having to resort to an inner message. I had to apply a minor patch to protobufjs to get this working with the json-module output; this has also been submitted upstream: https://github.com/protobufjs/protobuf.js/pull/1693 I've modified CardStatsResponse as an example of the new syntax. One thing to note: while the Rust and TypeScript bindings use optional/ null fields, as that is the norm in those languages, Google's Python bindings are not very Pythonic. Referencing an optional field that is missing will yield the default value, and a separate HasField() call is required, eg: ``` >>> from anki.stats_pb2 import CardStatsResponse as R ... msg = R.FromString(b"") ... print(msg.first_review) ... print(msg.HasField("first_review")) 0 False ```
2022-02-27 04:13:28 +01:00
"https://github.com/protocolbuffers/protobuf/releases/download/v3.19.4/protoc-3.19.4-osx-x86_64.zip",
use protobuf binaries to reduce initial compile times
2020-12-23 08:10:37 +01:00
],
Add support for proto3 optional scalars Protobuf 3.15 introduced support for marking scalar fields like uint32 as optional, and all of our tooling appears to support it now. This allows us to use simple optional/null checks in our Rust/ TypeScript code, without having to resort to an inner message. I had to apply a minor patch to protobufjs to get this working with the json-module output; this has also been submitted upstream: https://github.com/protobufjs/protobuf.js/pull/1693 I've modified CardStatsResponse as an example of the new syntax. One thing to note: while the Rust and TypeScript bindings use optional/ null fields, as that is the norm in those languages, Google's Python bindings are not very Pythonic. Referencing an optional field that is missing will yield the default value, and a separate HasField() call is required, eg: ``` >>> from anki.stats_pb2 import CardStatsResponse as R ... msg = R.FromString(b"") ... print(msg.first_review) ... print(msg.HasField("first_review")) 0 False ```
2022-02-27 04:13:28 +01:00
sha256 = "d8b55cf1e887917dd43c447d77bd5bd213faff1e18ac3a176b35558d86f7ffff",
use protobuf binaries to reduce initial compile times
2020-12-23 08:10:37 +01:00
build_file_content = """exports_files(["bin/protoc"])""",
)
maybe(
http_archive,
add cpu qualifier to Linux protobuf Just to make the following change a little more clear.
2020-12-29 09:38:50 +01:00
name = "protoc_bin_linux_x86_64",
use protobuf binaries to reduce initial compile times
2020-12-23 08:10:37 +01:00
urls = [
Add support for proto3 optional scalars Protobuf 3.15 introduced support for marking scalar fields like uint32 as optional, and all of our tooling appears to support it now. This allows us to use simple optional/null checks in our Rust/ TypeScript code, without having to resort to an inner message. I had to apply a minor patch to protobufjs to get this working with the json-module output; this has also been submitted upstream: https://github.com/protobufjs/protobuf.js/pull/1693 I've modified CardStatsResponse as an example of the new syntax. One thing to note: while the Rust and TypeScript bindings use optional/ null fields, as that is the norm in those languages, Google's Python bindings are not very Pythonic. Referencing an optional field that is missing will yield the default value, and a separate HasField() call is required, eg: ``` >>> from anki.stats_pb2 import CardStatsResponse as R ... msg = R.FromString(b"") ... print(msg.first_review) ... print(msg.HasField("first_review")) 0 False ```
2022-02-27 04:13:28 +01:00
"https://github.com/protocolbuffers/protobuf/releases/download/v3.19.4/protoc-3.19.4-linux-x86_64.zip",
use protobuf binaries to reduce initial compile times
2020-12-23 08:10:37 +01:00
],
Add support for proto3 optional scalars Protobuf 3.15 introduced support for marking scalar fields like uint32 as optional, and all of our tooling appears to support it now. This allows us to use simple optional/null checks in our Rust/ TypeScript code, without having to resort to an inner message. I had to apply a minor patch to protobufjs to get this working with the json-module output; this has also been submitted upstream: https://github.com/protobufjs/protobuf.js/pull/1693 I've modified CardStatsResponse as an example of the new syntax. One thing to note: while the Rust and TypeScript bindings use optional/ null fields, as that is the norm in those languages, Google's Python bindings are not very Pythonic. Referencing an optional field that is missing will yield the default value, and a separate HasField() call is required, eg: ``` >>> from anki.stats_pb2 import CardStatsResponse as R ... msg = R.FromString(b"") ... print(msg.first_review) ... print(msg.HasField("first_review")) 0 False ```
2022-02-27 04:13:28 +01:00
sha256 = "058d29255a08f8661c8096c92961f3676218704cbd516d3916ec468e139cbd87",
use protobuf binaries to reduce initial compile times
2020-12-23 08:10:37 +01:00
build_file_content = """exports_files(["bin/protoc"])""",
)
add linux_arm64 platform
2020-12-29 09:40:04 +01:00
maybe(
http_archive,
name = "protoc_bin_linux_arm64",
urls = [
Add support for proto3 optional scalars Protobuf 3.15 introduced support for marking scalar fields like uint32 as optional, and all of our tooling appears to support it now. This allows us to use simple optional/null checks in our Rust/ TypeScript code, without having to resort to an inner message. I had to apply a minor patch to protobufjs to get this working with the json-module output; this has also been submitted upstream: https://github.com/protobufjs/protobuf.js/pull/1693 I've modified CardStatsResponse as an example of the new syntax. One thing to note: while the Rust and TypeScript bindings use optional/ null fields, as that is the norm in those languages, Google's Python bindings are not very Pythonic. Referencing an optional field that is missing will yield the default value, and a separate HasField() call is required, eg: ``` >>> from anki.stats_pb2 import CardStatsResponse as R ... msg = R.FromString(b"") ... print(msg.first_review) ... print(msg.HasField("first_review")) 0 False ```
2022-02-27 04:13:28 +01:00
"https://github.com/protocolbuffers/protobuf/releases/download/v3.19.4/protoc-3.19.4-linux-aarch_64.zip",
add linux_arm64 platform
2020-12-29 09:40:04 +01:00
],
Add support for proto3 optional scalars Protobuf 3.15 introduced support for marking scalar fields like uint32 as optional, and all of our tooling appears to support it now. This allows us to use simple optional/null checks in our Rust/ TypeScript code, without having to resort to an inner message. I had to apply a minor patch to protobufjs to get this working with the json-module output; this has also been submitted upstream: https://github.com/protobufjs/protobuf.js/pull/1693 I've modified CardStatsResponse as an example of the new syntax. One thing to note: while the Rust and TypeScript bindings use optional/ null fields, as that is the norm in those languages, Google's Python bindings are not very Pythonic. Referencing an optional field that is missing will yield the default value, and a separate HasField() call is required, eg: ``` >>> from anki.stats_pb2 import CardStatsResponse as R ... msg = R.FromString(b"") ... print(msg.first_review) ... print(msg.HasField("first_review")) 0 False ```
2022-02-27 04:13:28 +01:00
sha256 = "95584939e733bdd6ffb8245616b2071f565cd4c28163b6c21c8f936a9ee20861",
add linux_arm64 platform
2020-12-29 09:40:04 +01:00
build_file_content = """exports_files(["bin/protoc"])""",
)
use protobuf binaries to reduce initial compile times
2020-12-23 08:10:37 +01:00
maybe(
http_archive,
name = "protoc_bin_windows",
urls = [
Add support for proto3 optional scalars Protobuf 3.15 introduced support for marking scalar fields like uint32 as optional, and all of our tooling appears to support it now. This allows us to use simple optional/null checks in our Rust/ TypeScript code, without having to resort to an inner message. I had to apply a minor patch to protobufjs to get this working with the json-module output; this has also been submitted upstream: https://github.com/protobufjs/protobuf.js/pull/1693 I've modified CardStatsResponse as an example of the new syntax. One thing to note: while the Rust and TypeScript bindings use optional/ null fields, as that is the norm in those languages, Google's Python bindings are not very Pythonic. Referencing an optional field that is missing will yield the default value, and a separate HasField() call is required, eg: ``` >>> from anki.stats_pb2 import CardStatsResponse as R ... msg = R.FromString(b"") ... print(msg.first_review) ... print(msg.HasField("first_review")) 0 False ```
2022-02-27 04:13:28 +01:00
"https://github.com/protocolbuffers/protobuf/releases/download/v3.19.4/protoc-3.19.4-win64.zip",
use protobuf binaries to reduce initial compile times
2020-12-23 08:10:37 +01:00
],
Add support for proto3 optional scalars Protobuf 3.15 introduced support for marking scalar fields like uint32 as optional, and all of our tooling appears to support it now. This allows us to use simple optional/null checks in our Rust/ TypeScript code, without having to resort to an inner message. I had to apply a minor patch to protobufjs to get this working with the json-module output; this has also been submitted upstream: https://github.com/protobufjs/protobuf.js/pull/1693 I've modified CardStatsResponse as an example of the new syntax. One thing to note: while the Rust and TypeScript bindings use optional/ null fields, as that is the norm in those languages, Google's Python bindings are not very Pythonic. Referencing an optional field that is missing will yield the default value, and a separate HasField() call is required, eg: ``` >>> from anki.stats_pb2 import CardStatsResponse as R ... msg = R.FromString(b"") ... print(msg.first_review) ... print(msg.HasField("first_review")) 0 False ```
2022-02-27 04:13:28 +01:00
sha256 = "828d2bdfe410e988cfc46462bcabd34ffdda8cc172867989ec647eadc55b03b5",
use protobuf binaries to reduce initial compile times
2020-12-23 08:10:37 +01:00
build_file_content = """exports_files(["bin/protoc.exe"])""",
)
if not native.existing_rule(name):
_setup_protoc(
name = name,
)
Reference in New Issue Copy Permalink