langfingaz/anki
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
dee7860f08
anki/qt/aqt/taglimit.py

96 lines
3.3 KiB
Python
Raw Normal View History

update copyright and clarify licenses
2019-02-05 04:59:03 +01:00
# Copyright: Ankitects Pty Ltd and contributors
# License: GNU AGPL, version 3 or later; http://www.gnu.org/copyleft/agpl.html
run pyupgrade over codebase [python upgrade required] This adds Python 3.9 and 3.10 typing syntax to files that import attributions from __future___. Python 3.9 should be able to cope with the 3.10 syntax, but Python 3.8 will no longer work. On Windows/Mac, install the latest Python 3.9 version from python.org. There are currently no orjson wheels for Python 3.10 on Windows/Mac, which will break the build unless you have Rust installed separately. On Linux, modern distros should have Python 3.9 available already. If you're on an older distro, you'll need to build Python from source first.
2021-10-03 10:59:42 +02:00
Backend Custom Study (#1600) * Implement custom study on backend * Switch frontend to backend custom study * Skip typecheck for new pb classes * Build tag search string on backend Also fixes escaping of special characters in tag names. * `cram.cards` -> `cram.card_limit` * Assign more meaningful names in `TagLimit` * Broaden rustfmt glob * Use `invalid_input()` helper * Assign `FilteredDeckForUpdate` to temp var * Implement `SearchBuilder` * Rewrite `custom_study()` with `SearchBuilder` * Replace match macros with `SearchBuilder` * Remove `into_nodes_list` & `concatenate_searches`
2022-01-20 05:25:22 +01:00
from __future__ import annotations
Move custom study tag and limit gathering+saving into the backend Ideally this would have been in beta 6 :-) No add-ons appear to be using customstudy.py/taglimit.py though, so it should hopefully not be disruptive. In the earlier custom study changes, we didn't get around to addressing issue #1136. Now instead of trying to determine the maximum increase to allow (which doesn't work correctly with nested decks), we just present the total available to the user again, and let them decide. There's plenty of room for improvement here still, but further work here might be better done once we look into decoupling deck limits from deck presets. Tags and available cards are fetched prior to showing the dialog now, and will show a progress dialog if things take a while. Tags are stored in an aux var now, so they don't inflate the deck object size.
2022-03-10 07:06:55 +01:00
from typing import Sequence
merged libanki and ankiqt into single distro
2012-12-21 08:51:59 +01:00
import aqt
Import submodules directly (#1662) * Use submodule imports in aqt * Use submodule imports in pylib * More submodule imports in pylib These required removing some direct imports to get rid of import cycles.
2022-02-13 04:40:47 +01:00
import aqt.customstudy
import aqt.forms
limit custom study to 100 tags The hard limit from sqlite may be larger, but things slow down as more tags are selected. https://forums.ankiweb.net/t/unable-to-create-custom-test/10467 There are a number of things that could be improved here: - we should show a live count so users are aware of the limit - we should be filling in the parent tags when they're not explicitly listed on a card - we should reconsider disabling the 'tags to include' by default It may make sense to defer these changes until we can move this screen into Svelte/handle the processing in the backend.
2021-06-02 03:01:30 +02:00
from anki.lang import with_collapsed_whitespace
Move custom study tag and limit gathering+saving into the backend Ideally this would have been in beta 6 :-) No add-ons appear to be using customstudy.py/taglimit.py though, so it should hopefully not be disruptive. In the earlier custom study changes, we didn't get around to addressing issue #1136. Now instead of trying to determine the maximum increase to allow (which doesn't work correctly with nested decks), we just present the total available to the user again, and let them decide. There's plenty of room for improvement here still, but further work here might be better done once we look into decoupling deck limits from deck presets. Tags and available cards are fetched prior to showing the dialog now, and will show a progress dialog if things take a while. Tags are stored in an aux var now, so they don't inflate the deck object size.
2022-03-10 07:06:55 +01:00
from anki.scheduler.base import CustomStudyDefaults
merged libanki and ankiqt into single distro
2012-12-21 08:51:59 +01:00
from aqt.qt import *
limit custom study to 100 tags The hard limit from sqlite may be larger, but things slow down as more tags are selected. https://forums.ankiweb.net/t/unable-to-create-custom-test/10467 There are a number of things that could be improved here: - we should show a live count so users are aware of the limit - we should be filling in the parent tags when they're not explicitly listed on a card - we should reconsider disabling the 'tags to include' by default It may make sense to defer these changes until we can move this screen into Svelte/handle the processing in the backend.
2021-06-02 03:01:30 +02:00
from aqt.utils import disable_help_button, restoreGeom, saveGeom, showWarning, tr
use isort to tidy up imports
2019-12-20 10:19:03 +01:00
merged libanki and ankiqt into single distro
2012-12-21 08:51:59 +01:00
class TagLimit(QDialog):
Move custom study tag and limit gathering+saving into the backend Ideally this would have been in beta 6 :-) No add-ons appear to be using customstudy.py/taglimit.py though, so it should hopefully not be disruptive. In the earlier custom study changes, we didn't get around to addressing issue #1136. Now instead of trying to determine the maximum increase to allow (which doesn't work correctly with nested decks), we just present the total available to the user again, and let them decide. There's plenty of room for improvement here still, but further work here might be better done once we look into decoupling deck limits from deck presets. Tags and available cards are fetched prior to showing the dialog now, and will show a progress dialog if things take a while. Tags are stored in an aux var now, so they don't inflate the deck object size.
2022-03-10 07:06:55 +01:00
def __init__(
self,
parent: QWidget,
tags: Sequence[CustomStudyDefaults.Tag],
on_success: Callable[[list[str], list[str]], None],
) -> None:
"Ask user to select tags. on_success() will be called with selected included and excluded tags."
switch to new-style PyQt scoped enums and Qt6 The enum changes should work on PyQt 5.x, and are required in PyQt 6.x. They are not supported by the PyQt5 typings however, so we need to run our tests with PyQt6.
2021-10-05 05:53:01 +02:00
QDialog.__init__(self, parent, Qt.WindowType.Window)
Move custom study tag and limit gathering+saving into the backend Ideally this would have been in beta 6 :-) No add-ons appear to be using customstudy.py/taglimit.py though, so it should hopefully not be disruptive. In the earlier custom study changes, we didn't get around to addressing issue #1136. Now instead of trying to determine the maximum increase to allow (which doesn't work correctly with nested decks), we just present the total available to the user again, and let them decide. There's plenty of room for improvement here still, but further work here might be better done once we look into decoupling deck limits from deck presets. Tags and available cards are fetched prior to showing the dialog now, and will show a progress dialog if things take a while. Tags are stored in an aux var now, so they don't inflate the deck object size.
2022-03-10 07:06:55 +01:00
self.tags = tags
self.form = aqt.forms.taglimit.Ui_Dialog()
self.form.setupUi(self)
self.on_success = on_success
convert setWindowFlags call into helper, and fix invalid variables "type: ignore" was masking the invalid references to self in places like showText()
2021-01-07 05:24:49 +01:00
disable_help_button(self)
apply black to all files
2019-12-23 01:34:10 +01:00
s = QShortcut(
switch to new-style PyQt scoped enums and Qt6 The enum changes should work on PyQt 5.x, and are required in PyQt 6.x. They are not supported by the PyQt5 typings however, so we need to run our tests with PyQt6.
2021-10-05 05:53:01 +02:00
QKeySequence("ctrl+d"),
Move custom study tag and limit gathering+saving into the backend Ideally this would have been in beta 6 :-) No add-ons appear to be using customstudy.py/taglimit.py though, so it should hopefully not be disruptive. In the earlier custom study changes, we didn't get around to addressing issue #1136. Now instead of trying to determine the maximum increase to allow (which doesn't work correctly with nested decks), we just present the total available to the user again, and let them decide. There's plenty of room for improvement here still, but further work here might be better done once we look into decoupling deck limits from deck presets. Tags and available cards are fetched prior to showing the dialog now, and will show a progress dialog if things take a while. Tags are stored in an aux var now, so they don't inflate the deck object size.
2022-03-10 07:06:55 +01:00
self.form.activeList,
switch to new-style PyQt scoped enums and Qt6 The enum changes should work on PyQt 5.x, and are required in PyQt 6.x. They are not supported by the PyQt5 typings however, so we need to run our tests with PyQt6.
2021-10-05 05:53:01 +02:00
context=Qt.ShortcutContext.WidgetShortcut,
apply black to all files
2019-12-23 01:34:10 +01:00
)
Move custom study tag and limit gathering+saving into the backend Ideally this would have been in beta 6 :-) No add-ons appear to be using customstudy.py/taglimit.py though, so it should hopefully not be disruptive. In the earlier custom study changes, we didn't get around to addressing issue #1136. Now instead of trying to determine the maximum increase to allow (which doesn't work correctly with nested decks), we just present the total available to the user again, and let them decide. There's plenty of room for improvement here still, but further work here might be better done once we look into decoupling deck limits from deck presets. Tags and available cards are fetched prior to showing the dialog now, and will show a progress dialog if things take a while. Tags are stored in an aux var now, so they don't inflate the deck object size.
2022-03-10 07:06:55 +01:00
qconnect(s.activated, self.form.activeList.clearSelection)
apply black to all files
2019-12-23 01:34:10 +01:00
s = QShortcut(
switch to new-style PyQt scoped enums and Qt6 The enum changes should work on PyQt 5.x, and are required in PyQt 6.x. They are not supported by the PyQt5 typings however, so we need to run our tests with PyQt6.
2021-10-05 05:53:01 +02:00
QKeySequence("ctrl+d"),
Move custom study tag and limit gathering+saving into the backend Ideally this would have been in beta 6 :-) No add-ons appear to be using customstudy.py/taglimit.py though, so it should hopefully not be disruptive. In the earlier custom study changes, we didn't get around to addressing issue #1136. Now instead of trying to determine the maximum increase to allow (which doesn't work correctly with nested decks), we just present the total available to the user again, and let them decide. There's plenty of room for improvement here still, but further work here might be better done once we look into decoupling deck limits from deck presets. Tags and available cards are fetched prior to showing the dialog now, and will show a progress dialog if things take a while. Tags are stored in an aux var now, so they don't inflate the deck object size.
2022-03-10 07:06:55 +01:00
self.form.inactiveList,
switch to new-style PyQt scoped enums and Qt6 The enum changes should work on PyQt 5.x, and are required in PyQt 6.x. They are not supported by the PyQt5 typings however, so we need to run our tests with PyQt6.
2021-10-05 05:53:01 +02:00
context=Qt.ShortcutContext.WidgetShortcut,
apply black to all files
2019-12-23 01:34:10 +01:00
)
Move custom study tag and limit gathering+saving into the backend Ideally this would have been in beta 6 :-) No add-ons appear to be using customstudy.py/taglimit.py though, so it should hopefully not be disruptive. In the earlier custom study changes, we didn't get around to addressing issue #1136. Now instead of trying to determine the maximum increase to allow (which doesn't work correctly with nested decks), we just present the total available to the user again, and let them decide. There's plenty of room for improvement here still, but further work here might be better done once we look into decoupling deck limits from deck presets. Tags and available cards are fetched prior to showing the dialog now, and will show a progress dialog if things take a while. Tags are stored in an aux var now, so they don't inflate the deck object size.
2022-03-10 07:06:55 +01:00
qconnect(s.activated, self.form.inactiveList.clearSelection)
self.build_tag_lists()
merged libanki and ankiqt into single distro
2012-12-21 08:51:59 +01:00
restoreGeom(self, "tagLimit")
Move custom study tag and limit gathering+saving into the backend Ideally this would have been in beta 6 :-) No add-ons appear to be using customstudy.py/taglimit.py though, so it should hopefully not be disruptive. In the earlier custom study changes, we didn't get around to addressing issue #1136. Now instead of trying to determine the maximum increase to allow (which doesn't work correctly with nested decks), we just present the total available to the user again, and let them decide. There's plenty of room for improvement here still, but further work here might be better done once we look into decoupling deck limits from deck presets. Tags and available cards are fetched prior to showing the dialog now, and will show a progress dialog if things take a while. Tags are stored in an aux var now, so they don't inflate the deck object size.
2022-03-10 07:06:55 +01:00
self.open()
def build_tag_lists(self) -> None:
def add_tag(tag: str, select: bool, list: QListWidget) -> None:
item = QListWidgetItem(tag.replace("_", " "))
list.addItem(item)
if select:
idx = list.indexFromItem(item)
list.selectionModel().select(
idx, QItemSelectionModel.SelectionFlag.Select
)
had_included_tag = False
for tag in self.tags:
if tag.include:
had_included_tag = True
add_tag(tag.name, tag.include, self.form.activeList)
add_tag(tag.name, tag.exclude, self.form.inactiveList)
merged libanki and ankiqt into single distro
2012-12-21 08:51:59 +01:00
Move custom study tag and limit gathering+saving into the backend Ideally this would have been in beta 6 :-) No add-ons appear to be using customstudy.py/taglimit.py though, so it should hopefully not be disruptive. In the earlier custom study changes, we didn't get around to addressing issue #1136. Now instead of trying to determine the maximum increase to allow (which doesn't work correctly with nested decks), we just present the total available to the user again, and let them decide. There's plenty of room for improvement here still, but further work here might be better done once we look into decoupling deck limits from deck presets. Tags and available cards are fetched prior to showing the dialog now, and will show a progress dialog if things take a while. Tags are stored in an aux var now, so they don't inflate the deck object size.
2022-03-10 07:06:55 +01:00
if had_included_tag:
self.form.activeCheck.setChecked(True)
merged libanki and ankiqt into single distro
2012-12-21 08:51:59 +01:00
add a bunch of return types
2021-02-01 14:28:21 +01:00
def reject(self) -> None:
merged libanki and ankiqt into single distro
2012-12-21 08:51:59 +01:00
QDialog.reject(self)
add types to various other files Mainly automated with MonkeyType
2021-02-01 13:08:56 +01:00
def accept(self) -> None:
Move custom study tag and limit gathering+saving into the backend Ideally this would have been in beta 6 :-) No add-ons appear to be using customstudy.py/taglimit.py though, so it should hopefully not be disruptive. In the earlier custom study changes, we didn't get around to addressing issue #1136. Now instead of trying to determine the maximum increase to allow (which doesn't work correctly with nested decks), we just present the total available to the user again, and let them decide. There's plenty of room for improvement here still, but further work here might be better done once we look into decoupling deck limits from deck presets. Tags and available cards are fetched prior to showing the dialog now, and will show a progress dialog if things take a while. Tags are stored in an aux var now, so they don't inflate the deck object size.
2022-03-10 07:06:55 +01:00
include_tags = []
exclude_tags = []
want_active = self.form.activeCheck.isChecked()
for c, tag in enumerate(self.tags):
merged libanki and ankiqt into single distro
2012-12-21 08:51:59 +01:00
# active
Move custom study tag and limit gathering+saving into the backend Ideally this would have been in beta 6 :-) No add-ons appear to be using customstudy.py/taglimit.py though, so it should hopefully not be disruptive. In the earlier custom study changes, we didn't get around to addressing issue #1136. Now instead of trying to determine the maximum increase to allow (which doesn't work correctly with nested decks), we just present the total available to the user again, and let them decide. There's plenty of room for improvement here still, but further work here might be better done once we look into decoupling deck limits from deck presets. Tags and available cards are fetched prior to showing the dialog now, and will show a progress dialog if things take a while. Tags are stored in an aux var now, so they don't inflate the deck object size.
2022-03-10 07:06:55 +01:00
if want_active:
item = self.form.activeList.item(c)
idx = self.form.activeList.indexFromItem(item)
if self.form.activeList.selectionModel().isSelected(idx):
include_tags.append(tag.name)
merged libanki and ankiqt into single distro
2012-12-21 08:51:59 +01:00
# inactive
Move custom study tag and limit gathering+saving into the backend Ideally this would have been in beta 6 :-) No add-ons appear to be using customstudy.py/taglimit.py though, so it should hopefully not be disruptive. In the earlier custom study changes, we didn't get around to addressing issue #1136. Now instead of trying to determine the maximum increase to allow (which doesn't work correctly with nested decks), we just present the total available to the user again, and let them decide. There's plenty of room for improvement here still, but further work here might be better done once we look into decoupling deck limits from deck presets. Tags and available cards are fetched prior to showing the dialog now, and will show a progress dialog if things take a while. Tags are stored in an aux var now, so they don't inflate the deck object size.
2022-03-10 07:06:55 +01:00
item = self.form.inactiveList.item(c)
idx = self.form.inactiveList.indexFromItem(item)
if self.form.inactiveList.selectionModel().isSelected(idx):
exclude_tags.append(tag.name)
Backend Custom Study (#1600) * Implement custom study on backend * Switch frontend to backend custom study * Skip typecheck for new pb classes * Build tag search string on backend Also fixes escaping of special characters in tag names. * `cram.cards` -> `cram.card_limit` * Assign more meaningful names in `TagLimit` * Broaden rustfmt glob * Use `invalid_input()` helper * Assign `FilteredDeckForUpdate` to temp var * Implement `SearchBuilder` * Rewrite `custom_study()` with `SearchBuilder` * Replace match macros with `SearchBuilder` * Remove `into_nodes_list` & `concatenate_searches`
2022-01-20 05:25:22 +01:00
if (len(include_tags) + len(exclude_tags)) > 100:
limit custom study to 100 tags The hard limit from sqlite may be larger, but things slow down as more tags are selected. https://forums.ankiweb.net/t/unable-to-create-custom-test/10467 There are a number of things that could be improved here: - we should show a live count so users are aware of the limit - we should be filling in the parent tags when they're not explicitly listed on a card - we should reconsider disabling the 'tags to include' by default It may make sense to defer these changes until we can move this screen into Svelte/handle the processing in the backend.
2021-06-02 03:01:30 +02:00
showWarning(with_collapsed_whitespace(tr.errors_100_tags_max()))
return
Backend Custom Study (#1600) * Implement custom study on backend * Switch frontend to backend custom study * Skip typecheck for new pb classes * Build tag search string on backend Also fixes escaping of special characters in tag names. * `cram.cards` -> `cram.card_limit` * Assign more meaningful names in `TagLimit` * Broaden rustfmt glob * Use `invalid_input()` helper * Assign `FilteredDeckForUpdate` to temp var * Implement `SearchBuilder` * Rewrite `custom_study()` with `SearchBuilder` * Replace match macros with `SearchBuilder` * Remove `into_nodes_list` & `concatenate_searches`
2022-01-20 05:25:22 +01:00
merged libanki and ankiqt into single distro
2012-12-21 08:51:59 +01:00
saveGeom(self, "tagLimit")
QDialog.accept(self)
Move custom study tag and limit gathering+saving into the backend Ideally this would have been in beta 6 :-) No add-ons appear to be using customstudy.py/taglimit.py though, so it should hopefully not be disruptive. In the earlier custom study changes, we didn't get around to addressing issue #1136. Now instead of trying to determine the maximum increase to allow (which doesn't work correctly with nested decks), we just present the total available to the user again, and let them decide. There's plenty of room for improvement here still, but further work here might be better done once we look into decoupling deck limits from deck presets. Tags and available cards are fetched prior to showing the dialog now, and will show a progress dialog if things take a while. Tags are stored in an aux var now, so they don't inflate the deck object size.
2022-03-10 07:06:55 +01:00
self.on_success(include_tags, exclude_tags)
Reference in New Issue Copy Permalink