langfingaz/anki
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
dd939beafe
anki/pylib/.pylintrc

67 lines
1.1 KiB
INI
Raw Normal View History

rework Fluent handling - all .ftl files for a language are concatenated into a single file at build time - all languages are included in the binary - external ftl files placed in the ftl folder can override the built-in definitions - constants are automatically generated for each string key - dropped the separate StringsGroup enum
2020-02-23 03:21:12 +01:00
[MASTER]
ignore-patterns=.*_pb2.*
initial Bazel conversion Running and testing should be working on the three platforms, but there's still a fair bit that needs to be done: - Wheel building + testing in a venv still needs to be implemented. - Python requirements still need to be compiled with piptool and pinned; need to compile on all platforms then merge - Cargo deps in cargo/ and rslib/ need to be cleaned up, and ideally unified into one place - Currently using rustls to work around openssl compilation issues on Linux, but this will break corporate proxies with custom SSL authorities; need to conditionally use openssl or use https://github.com/seanmonstar/reqwest/pull/1058 - Makefiles and docs still need cleaning up - It may make sense to reparent ts/* to the top level, as we don't nest the other modules under a specific language. - rspy and pylib must always be updated in lock-step, so merging rspy into pylib as a private module would simplify things. - Merging desktop-ftl and mobile-ftl into the core ftl would make managing and updating translations easier. - Obsolete scripts need removing. - And probably more.
2020-11-01 05:26:58 +01:00
persistent = no
update Python deps
2021-10-02 15:13:24 +02:00
extension-pkg-whitelist=orjson
rework Fluent handling - all .ftl files for a language are concatenated into a single file at build time - all languages are included in the binary - external ftl files placed in the ftl folder can override the built-in definitions - constants are automatically generated for each string key - dropped the separate StringsGroup enum
2020-02-23 03:21:12 +01:00
use top level defs for protobuf enum cases While mypy can understand nested references like ConfigBool.Key.COLLAPSE_RECENT, PyCharm doesn't understand the metaclass syntax, and shows the definitions as invalid.
2021-02-05 10:13:55 +01:00
[TYPECHECK]
ignored-classes=
Remove pb SortKind enum and use pb Columns instead
2021-04-09 18:50:30 +02:00
BrowserColumns,
Add BrowserRow to ignored classes
2021-03-20 16:06:26 +01:00
BrowserRow,
Switch frontend to use backend links
2021-07-22 10:07:13 +02:00
HelpPage,
in/out -> request/response The saved characters weren't worth the increased difficulty when reading, and the fact that we were deviating from protobuf norms.
2021-06-20 07:49:20 +02:00
FormatTimespanRequest,
use new API for test scheduler Avoids duplicate work, and is a step towards allowing the next states to be modified by third-party code. Also: - fixed incorrect underlined count, due to reviews being labeled as learning cards - fixed reviewer not refreshing when undoing a test review, by splitting up backend queue rebuilding from frontend reviewer refresh - moved answering into a CollectionOp
2021-05-11 03:37:08 +02:00
CardAnswer,
QueuedCards,
in/out -> request/response The saved characters weren't worth the increased difficulty when reading, and the fact that we were deviating from protobuf norms.
2021-06-20 07:49:20 +02:00
UnburyDeckRequest,
BuryOrSuspendCardsRequest,
NoteFieldsCheckResponse,
add routine to set deck collapse state Updating a deck via protobuf is now exposed on the backend, but not currently on the frontend - I suspect we'll be better off writing separate routines for the actions we need instead, and we get a better undo description for free. This is currently causing an ugly redraw in the browse screen, which will need fixing.
2021-04-05 02:21:50 +02:00
BackendError,
in/out -> request/response The saved characters weren't worth the increased difficulty when reading, and the fact that we were deviating from protobuf norms.
2021-06-20 07:49:20 +02:00
SetDeckCollapsedRequest,
rename Config in protobuf to avoid conflict with module name + use the enum directly, instead of wrapping it in an object Python code retains the old "Config" name.
2021-07-11 11:27:08 +02:00
ConfigKey,
replace the old stripHTML() methods with the backend implementation Python's regex engine performs pathologically on regexes like '<!--.*?-->' when fed a large string of repeating '<!--' clauses. Thanks to JaimeSlome / security@huntr.dev for the report; closes #1380. Solved by switching to the Rust implementation, which does not suffer from this issue. entsToText(), minimizeHTML(), and the old regex constants have been removed; they do not appear to be used by any add-ons.
2021-10-01 15:07:45 +02:00
HelpPageLinkRequest,
Backend Custom Study (#1600) * Implement custom study on backend * Switch frontend to backend custom study * Skip typecheck for new pb classes * Build tag search string on backend Also fixes escaping of special characters in tag names. * `cram.cards` -> `cram.card_limit` * Assign more meaningful names in `TagLimit` * Broaden rustfmt glob * Use `invalid_input()` helper * Assign `FilteredDeckForUpdate` to temp var * Implement `SearchBuilder` * Rewrite `custom_study()` with `SearchBuilder` * Replace match macros with `SearchBuilder` * Remove `into_nodes_list` & `concatenate_searches`
2022-01-20 05:25:22 +01:00
StripHtmlRequest,
CustomStudyRequest,
Cram,
Optionally restore original position and reset counts when forgetting (#1714) * Add forget prompt with options - Restore original position - Reset reps and lapses * Restore position when resetting for export * Add config context to avoid passing keys * Add routine to fetch defaults; use method-specific enum (dae) * Keep original position by default (dae) * Fix code completion for forget dialog (dae) Needs to be a symbolic link to the generated file
2022-03-09 07:51:41 +01:00
ScheduleCardsAsNewRequest,
Plaintext import/export (#1850) * Add crate csv * Add start of csv importing on backend * Add Menomosyne serializer * Add csv and json importing on backend * Add plaintext importing on frontend * Add csv metadata extraction on backend * Add csv importing with GUI * Fix missing dfa file in build Added compile_data_attr, then re-ran cargo/update.py. * Don't use doubly buffered reader in csv * Escape HTML entities if CSV is not HTML Also use name 'is_html' consistently. * Use decimal number as foreign ease (like '2.5') * ForeignCard.ivl → ForeignCard.interval * Only allow fixed set of CSV delimiters * Map timestamp of ForeignCard to native due time * Don't trim CSV records * Document use of empty strings for defaults * Avoid creating CardGenContexts for every note This requires CardGenContext to be generic, so it works both with an owned and borrowed notetype. * Show all accepted file types in import file picker * Add import_json_file() * factor → ease_factor * delimter_from_value → delimiter_from_value * Map columns to fields, not the other way around * Fallback to current config for csv metadata * Add start of new import csv screen * Temporary fix for compilation issue on Linux/Mac * Disable jest bazel action for import-csv Jest fails with an error code if no tests are available, but this would not be noticable on Windows as Jest is not run there. * Fix field mapping issue * Revert "Temporary fix for compilation issue on Linux/Mac" This reverts commit 21f8a261408cdae49ec031aa21a1b659c4f66d82. * Add HtmlSwitch and move Switch to components * Fix spacing and make selectors consistent * Fix shortcut tooltip * Place import button at the top with path * Fix meta column indices * Remove NotetypeForString * Fix queue and type of foreign cards * Support different dupe resolution strategies * Allow dupe resolution selection when importing CSV * Test import of unnormalized text Close #1863. * Fix logging of foreign notes * Implement CSV exports * Use db_scalar() in notes_table_len() * Rework CSV metadata - Notetypes and decks are either defined by a global id or by a column. - If a notetype id is provided, its field map must also be specified. - If a notetype column is provided, fields are now mapped by index instead of name at import time. So the first non-meta column is used for the first field of every note, regardless of notetype. This makes importing easier and should improve compatiblity with files without a notetype column. - Ensure first field can be mapped to a column. - Meta columns must be defined as `#[meta name]:[column index]` instead of in the `#columns` tag. - Column labels contain the raw names defined by the file and must be prettified by the frontend. * Adjust frontend to new backend column mapping * Add force flags for is_html and delimiter * Detect if CSV is HTML by field content * Update dupe resolution labels * Simplify selectors * Fix coalescence of oneofs in TS * Disable meta columns from selection Plus a lot of refactoring. * Make import button stick to the bottom * Write delimiter and html flag into csv * Refetch field map after notetype change * Fix log labels for csv import * Log notes whose deck/notetype was missing * Fix hiding of empty log queues * Implement adding tags to all notes of a csv * Fix dupe resolution not being set in log * Implement adding tags to updated notes of a csv * Check first note field is not empty * Temporary fix for build on Linux/Mac * Fix inverted html check (dae) * Remove unused ftl string * Delimiter → Separator * Remove commented-out line * Don't accept .json files * Tweak tag ftl strings * Remove redundant blur call * Strip sound and add spaces in csv export * Export HTML by default * Fix unset deck in Mnemosyne import Also accept both numbers and strings for notetypes and decks in JSON. * Make DupeResolution::Update the default * Fix missing dot in extension * Make column indices 1-based * Remove StickContainer from TagEditor Fixes line breaking, border and z index on ImportCsvPage. * Assign different key combos to tag editors * Log all updated duplicates Add a log field for the true number of found notes. * Show identical notes as skipped * Split tag-editor into separate ts module (dae) * Add progress for CSV export * Add progress for text import * Tidy-ups after tag-editor split (dae) - import-csv no longer depends on editor - remove some commented lines
2022-06-01 12:26:16 +02:00
ExportLimit,
CsvColumn,
CsvMetadata,
ImportCsvRequest,
use top level defs for protobuf enum cases While mypy can understand nested references like ConfigBool.Key.COLLAPSE_RECENT, PyCharm doesn't understand the metaclass syntax, and shows the definitions as invalid.
2021-02-05 10:13:55 +01:00
update TR references that contain arguments
2021-03-26 05:21:04 +01:00
[REPORTS]
output-format=colorized
enable some warnings in pylint
2019-03-04 08:27:39 +01:00
[MESSAGES CONTROL]
enable some pylint convention tests in pylib
2021-06-26 02:11:05 +02:00
disable=
R,
line-too-long,
too-many-lines,
missing-function-docstring,
missing-module-docstring,
missing-class-docstring,
import-outside-toplevel,
wrong-import-position,
wrong-import-order,
enable some warnings in pylint
2019-03-04 08:27:39 +01:00
fixme,
unused-wildcard-import,
attribute-defined-outside-init,
redefined-builtin,
wildcard-import,
broad-except,
bare-except,
unused-argument,
unused-variable,
redefined-outer-name,
global-statement,
protected-access,
arguments-differ,
update Python deps
2021-10-02 15:13:24 +02:00
arguments-renamed,
consider-using-f-string,
add a helper so we can get semi-automatic camelCase conversion
2021-06-26 03:33:35 +02:00
[BASIC]
PEP8 models.py
2021-06-27 05:49:58 +02:00
good-names =
id,
tr,
PEP8 collection.py
2021-06-27 07:12:22 +02:00
db,
PEP8 pylib (#1443) * PEP8 scheduler/base.py * PEP8 _backend/__init__.py * PEP8 _backend/genbackend.py * PEP8 _backend/genfluent.py * PEP8 scheduler/__init__.py * PEP8 __init__.py * PEP8 _legacy.py * PEP8 syncserver/__init__.py - Make 'ip' a good name - Overrule `global col` being identified as a constant * PEP8 syncserver/__main__.py * PEP8 buildinfo.py * Implement `DeprecatedNamesMixin` for modules * PEP8 browser.py * PEP8 config.py * PEP8 consts.py * PEP8 db.py * Format * Improve AttributeError for DeprecatedNamesMixin * print the line that imported/referenced the legacy module attr (dae) * DeprecatedNamesMixinStandalone -> ...ForModule
2021-10-22 12:39:49 +02:00
ok,
PEP8 for rest of pylib (#1451) * PEP8 dbproxy.py * PEP8 errors.py * PEP8 httpclient.py * PEP8 lang.py * PEP8 latex.py * Add decorator to deprectate key words * Make replacement for deprecated attribute optional * Use new helper `_print_replacement_warning()` * PEP8 media.py * PEP8 rsbackend.py * PEP8 sound.py * PEP8 stdmodels.py * PEP8 storage.py * PEP8 sync.py * PEP8 tags.py * PEP8 template.py * PEP8 types.py * Fix DeprecatedNamesMixinForModule The class methods need to be overridden with instance methods, so every module has its own dicts. * Use `# pylint: disable=invalid-name` instead of id * PEP8 utils.py * Only decorate `__getattr__` with `@no_type_check` * Fix mypy issue with snakecase Importing it from `anki._vendor` raises attribute errors. * Format * Remove inheritance of DeprecatedNamesMixin There's almost no shared code now and overriding classmethods with instance methods raises mypy issues. * Fix traceback frames of deprecation warnings * remove fn/TimedLog (dae) Neither Anki nor add-ons appear to have been using it * fix some issues with stringcase use (dae) - the wheel was depending on the PyPI version instead of our vendored version - _vendor:stringcase should not have been listed in the anki py_library. We already include the sources in py_srcs, and need to refer to them directly. By listing _vendor:stringcase as well, we were making a top-level stringcase library available, which would have only worked for distributing because the wheel definition was also incorrect. - mypy errors are what caused me to mistakenly add the above - they were because the type: ignore at the top of stringcase.py was causing mypy to completely ignore the file, so it was not aware of any attributes it contained.
2021-10-25 06:50:13 +02:00
ip,
Reference in New Issue Copy Permalink