langfingaz/anki
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
3beea5e1e4
anki/qt/aqt/taglimit.py

119 lines
4.4 KiB
Python
Raw Normal View History

update copyright and clarify licenses
2019-02-05 04:59:03 +01:00
# Copyright: Ankitects Pty Ltd and contributors
# License: GNU AGPL, version 3 or later; http://www.gnu.org/copyleft/agpl.html
run pyupgrade over codebase [python upgrade required] This adds Python 3.9 and 3.10 typing syntax to files that import attributions from __future___. Python 3.9 should be able to cope with the 3.10 syntax, but Python 3.8 will no longer work. On Windows/Mac, install the latest Python 3.9 version from python.org. There are currently no orjson wheels for Python 3.10 on Windows/Mac, which will break the build unless you have Rust installed separately. On Linux, modern distros should have Python 3.9 available already. If you're on an older distro, you'll need to build Python from source first.
2021-10-03 10:59:42 +02:00
from typing import Optional
merged libanki and ankiqt into single distro
2012-12-21 08:51:59 +01:00
import aqt
limit custom study to 100 tags The hard limit from sqlite may be larger, but things slow down as more tags are selected. https://forums.ankiweb.net/t/unable-to-create-custom-test/10467 There are a number of things that could be improved here: - we should show a live count so users are aware of the limit - we should be filling in the parent tags when they're not explicitly listed on a card - we should reconsider disabling the 'tags to include' by default It may make sense to defer these changes until we can move this screen into Svelte/handle the processing in the backend.
2021-06-02 03:01:30 +02:00
from anki.lang import with_collapsed_whitespace
add types to various other files Mainly automated with MonkeyType
2021-02-01 13:08:56 +01:00
from aqt.customstudy import CustomStudy
from aqt.main import AnkiQt
merged libanki and ankiqt into single distro
2012-12-21 08:51:59 +01:00
from aqt.qt import *
limit custom study to 100 tags The hard limit from sqlite may be larger, but things slow down as more tags are selected. https://forums.ankiweb.net/t/unable-to-create-custom-test/10467 There are a number of things that could be improved here: - we should show a live count so users are aware of the limit - we should be filling in the parent tags when they're not explicitly listed on a card - we should reconsider disabling the 'tags to include' by default It may make sense to defer these changes until we can move this screen into Svelte/handle the processing in the backend.
2021-06-02 03:01:30 +02:00
from aqt.utils import disable_help_button, restoreGeom, saveGeom, showWarning, tr
use isort to tidy up imports
2019-12-20 10:19:03 +01:00
merged libanki and ankiqt into single distro
2012-12-21 08:51:59 +01:00
class TagLimit(QDialog):
add types to various other files Mainly automated with MonkeyType
2021-02-01 13:08:56 +01:00
def __init__(self, mw: AnkiQt, parent: CustomStudy) -> None:
switch to new-style PyQt scoped enums and Qt6 The enum changes should work on PyQt 5.x, and are required in PyQt 6.x. They are not supported by the PyQt5 typings however, so we need to run our tests with PyQt6.
2021-10-05 05:53:01 +02:00
QDialog.__init__(self, parent, Qt.WindowType.Window)
add types to various other files Mainly automated with MonkeyType
2021-02-01 13:08:56 +01:00
self.tags: str = ""
run pyupgrade over codebase [python upgrade required] This adds Python 3.9 and 3.10 typing syntax to files that import attributions from __future___. Python 3.9 should be able to cope with the 3.10 syntax, but Python 3.8 will no longer work. On Windows/Mac, install the latest Python 3.9 version from python.org. There are currently no orjson wheels for Python 3.10 on Windows/Mac, which will break the build unless you have Rust installed separately. On Linux, modern distros should have Python 3.9 available already. If you're on an older distro, you'll need to build Python from source first.
2021-10-03 10:59:42 +02:00
self.tags_list: list[str] = []
merged libanki and ankiqt into single distro
2012-12-21 08:51:59 +01:00
self.mw = mw
fix a bunch of qt typing issues uncovered by the following commit
2021-03-17 05:51:59 +01:00
self.parent_: Optional[CustomStudy] = parent
self.deck = self.parent_.deck
merged libanki and ankiqt into single distro
2012-12-21 08:51:59 +01:00
self.dialog = aqt.forms.taglimit.Ui_Dialog()
self.dialog.setupUi(self)
convert setWindowFlags call into helper, and fix invalid variables "type: ignore" was masking the invalid references to self in places like showText()
2021-01-07 05:24:49 +01:00
disable_help_button(self)
apply black to all files
2019-12-23 01:34:10 +01:00
s = QShortcut(
switch to new-style PyQt scoped enums and Qt6 The enum changes should work on PyQt 5.x, and are required in PyQt 6.x. They are not supported by the PyQt5 typings however, so we need to run our tests with PyQt6.
2021-10-05 05:53:01 +02:00
QKeySequence("ctrl+d"),
self.dialog.activeList,
context=Qt.ShortcutContext.WidgetShortcut,
apply black to all files
2019-12-23 01:34:10 +01:00
)
use qconnect everywhere, and fix some typing issues a step towards check_untyped_defs in aqt, but there's still 100+ issues to resolve
2020-05-04 05:23:08 +02:00
qconnect(s.activated, self.dialog.activeList.clearSelection)
apply black to all files
2019-12-23 01:34:10 +01:00
s = QShortcut(
switch to new-style PyQt scoped enums and Qt6 The enum changes should work on PyQt 5.x, and are required in PyQt 6.x. They are not supported by the PyQt5 typings however, so we need to run our tests with PyQt6.
2021-10-05 05:53:01 +02:00
QKeySequence("ctrl+d"),
self.dialog.inactiveList,
context=Qt.ShortcutContext.WidgetShortcut,
apply black to all files
2019-12-23 01:34:10 +01:00
)
use qconnect everywhere, and fix some typing issues a step towards check_untyped_defs in aqt, but there's still 100+ issues to resolve
2020-05-04 05:23:08 +02:00
qconnect(s.activated, self.dialog.inactiveList.clearSelection)
merged libanki and ankiqt into single distro
2012-12-21 08:51:59 +01:00
self.rebuildTagList()
restoreGeom(self, "tagLimit")
.exec_() -> .exec() The former is not supported in PyQt6
2021-10-05 02:01:45 +02:00
self.exec()
merged libanki and ankiqt into single distro
2012-12-21 08:51:59 +01:00
add types to various other files Mainly automated with MonkeyType
2021-02-01 13:08:56 +01:00
def rebuildTagList(self) -> None:
PEP8 for rest of pylib (#1451) * PEP8 dbproxy.py * PEP8 errors.py * PEP8 httpclient.py * PEP8 lang.py * PEP8 latex.py * Add decorator to deprectate key words * Make replacement for deprecated attribute optional * Use new helper `_print_replacement_warning()` * PEP8 media.py * PEP8 rsbackend.py * PEP8 sound.py * PEP8 stdmodels.py * PEP8 storage.py * PEP8 sync.py * PEP8 tags.py * PEP8 template.py * PEP8 types.py * Fix DeprecatedNamesMixinForModule The class methods need to be overridden with instance methods, so every module has its own dicts. * Use `# pylint: disable=invalid-name` instead of id * PEP8 utils.py * Only decorate `__getattr__` with `@no_type_check` * Fix mypy issue with snakecase Importing it from `anki._vendor` raises attribute errors. * Format * Remove inheritance of DeprecatedNamesMixin There's almost no shared code now and overriding classmethods with instance methods raises mypy issues. * Fix traceback frames of deprecation warnings * remove fn/TimedLog (dae) Neither Anki nor add-ons appear to have been using it * fix some issues with stringcase use (dae) - the wheel was depending on the PyPI version instead of our vendored version - _vendor:stringcase should not have been listed in the anki py_library. We already include the sources in py_srcs, and need to refer to them directly. By listing _vendor:stringcase as well, we were making a top-level stringcase library available, which would have only worked for distributing because the wheel definition was also incorrect. - mypy errors are what caused me to mistakenly add the above - they were because the type: ignore at the top of stringcase.py was causing mypy to completely ignore the file, so it was not aware of any attributes it contained.
2021-10-25 06:50:13 +02:00
usertags = self.mw.col.tags.by_deck(self.deck["id"], True)
merged libanki and ankiqt into single distro
2012-12-21 08:51:59 +01:00
yes = self.deck.get("activeTags", [])
no = self.deck.get("inactiveTags", [])
yesHash = {}
noHash = {}
for y in yes:
yesHash[y] = True
for n in no:
noHash[n] = True
groupedTags = []
usertags.sort()
remove images and move away from qt resources - the bulk of image use is in webviews, so we move almost all used images to web/imgs, as it's easier to manage - change AnkiWebView to always use the local media server as a base, as much of the UI has come to depend on it - remove images from a few areas, as they felt dated - delete a bunch of unused images - href=# links were being opened in a browser window, so the code now ignores them - the HTML should really be updated to return false in the onclick handler - update a few icons
2017-08-11 12:59:15 +02:00
groupedTags.append(usertags)
add types to various other files Mainly automated with MonkeyType
2021-02-01 13:08:56 +01:00
self.tags_list = []
remove images and move away from qt resources - the bulk of image use is in webviews, so we move almost all used images to web/imgs, as it's easier to manage - change AnkiWebView to always use the local media server as a base, as much of the UI has come to depend on it - remove images from a few areas, as they felt dated - delete a bunch of unused images - href=# links were being opened in a browser window, so the code now ignores them - the HTML should really be updated to return false in the onclick handler - update a few icons
2017-08-11 12:59:15 +02:00
for tags in groupedTags:
merged libanki and ankiqt into single distro
2012-12-21 08:51:59 +01:00
for t in tags:
add types to various other files Mainly automated with MonkeyType
2021-02-01 13:08:56 +01:00
self.tags_list.append(t)
remove images and move away from qt resources - the bulk of image use is in webviews, so we move almost all used images to web/imgs, as it's easier to manage - change AnkiWebView to always use the local media server as a base, as much of the UI has come to depend on it - remove images from a few areas, as they felt dated - delete a bunch of unused images - href=# links were being opened in a browser window, so the code now ignores them - the HTML should really be updated to return false in the onclick handler - update a few icons
2017-08-11 12:59:15 +02:00
item = QListWidgetItem(t.replace("_", " "))
merged libanki and ankiqt into single distro
2012-12-21 08:51:59 +01:00
self.dialog.activeList.addItem(item)
if t in yesHash:
switch to new-style PyQt scoped enums and Qt6 The enum changes should work on PyQt 5.x, and are required in PyQt 6.x. They are not supported by the PyQt5 typings however, so we need to run our tests with PyQt6.
2021-10-05 05:53:01 +02:00
mode = QItemSelectionModel.SelectionFlag.Select
merged libanki and ankiqt into single distro
2012-12-21 08:51:59 +01:00
self.dialog.activeCheck.setChecked(True)
else:
switch to new-style PyQt scoped enums and Qt6 The enum changes should work on PyQt 5.x, and are required in PyQt 6.x. They are not supported by the PyQt5 typings however, so we need to run our tests with PyQt6.
2021-10-05 05:53:01 +02:00
mode = QItemSelectionModel.SelectionFlag.Deselect
merged libanki and ankiqt into single distro
2012-12-21 08:51:59 +01:00
idx = self.dialog.activeList.indexFromItem(item)
self.dialog.activeList.selectionModel().select(idx, mode)
# inactive
remove images and move away from qt resources - the bulk of image use is in webviews, so we move almost all used images to web/imgs, as it's easier to manage - change AnkiWebView to always use the local media server as a base, as much of the UI has come to depend on it - remove images from a few areas, as they felt dated - delete a bunch of unused images - href=# links were being opened in a browser window, so the code now ignores them - the HTML should really be updated to return false in the onclick handler - update a few icons
2017-08-11 12:59:15 +02:00
item = QListWidgetItem(t.replace("_", " "))
merged libanki and ankiqt into single distro
2012-12-21 08:51:59 +01:00
self.dialog.inactiveList.addItem(item)
if t in noHash:
switch to new-style PyQt scoped enums and Qt6 The enum changes should work on PyQt 5.x, and are required in PyQt 6.x. They are not supported by the PyQt5 typings however, so we need to run our tests with PyQt6.
2021-10-05 05:53:01 +02:00
mode = QItemSelectionModel.SelectionFlag.Select
merged libanki and ankiqt into single distro
2012-12-21 08:51:59 +01:00
else:
switch to new-style PyQt scoped enums and Qt6 The enum changes should work on PyQt 5.x, and are required in PyQt 6.x. They are not supported by the PyQt5 typings however, so we need to run our tests with PyQt6.
2021-10-05 05:53:01 +02:00
mode = QItemSelectionModel.SelectionFlag.Deselect
merged libanki and ankiqt into single distro
2012-12-21 08:51:59 +01:00
idx = self.dialog.inactiveList.indexFromItem(item)
self.dialog.inactiveList.selectionModel().select(idx, mode)
add a bunch of return types
2021-02-01 14:28:21 +01:00
def reject(self) -> None:
merged libanki and ankiqt into single distro
2012-12-21 08:51:59 +01:00
self.tags = ""
QDialog.reject(self)
add types to various other files Mainly automated with MonkeyType
2021-02-01 13:08:56 +01:00
def accept(self) -> None:
merged libanki and ankiqt into single distro
2012-12-21 08:51:59 +01:00
# gather yes/no tags
yes = []
no = []
for c in range(self.dialog.activeList.count()):
# active
if self.dialog.activeCheck.isChecked():
item = self.dialog.activeList.item(c)
idx = self.dialog.activeList.indexFromItem(item)
if self.dialog.activeList.selectionModel().isSelected(idx):
add types to various other files Mainly automated with MonkeyType
2021-02-01 13:08:56 +01:00
yes.append(self.tags_list[c])
merged libanki and ankiqt into single distro
2012-12-21 08:51:59 +01:00
# inactive
item = self.dialog.inactiveList.item(c)
idx = self.dialog.inactiveList.indexFromItem(item)
if self.dialog.inactiveList.selectionModel().isSelected(idx):
add types to various other files Mainly automated with MonkeyType
2021-02-01 13:08:56 +01:00
no.append(self.tags_list[c])
limit custom study to 100 tags The hard limit from sqlite may be larger, but things slow down as more tags are selected. https://forums.ankiweb.net/t/unable-to-create-custom-test/10467 There are a number of things that could be improved here: - we should show a live count so users are aware of the limit - we should be filling in the parent tags when they're not explicitly listed on a card - we should reconsider disabling the 'tags to include' by default It may make sense to defer these changes until we can move this screen into Svelte/handle the processing in the backend.
2021-06-02 03:01:30 +02:00
if (len(yes) + len(no)) > 100:
showWarning(with_collapsed_whitespace(tr.errors_100_tags_max()))
return
self.hide()
merged libanki and ankiqt into single distro
2012-12-21 08:51:59 +01:00
# save in the deck for future invocations
apply black to all files
2019-12-23 01:34:10 +01:00
self.deck["activeTags"] = yes
self.deck["inactiveTags"] = no
merged libanki and ankiqt into single distro
2012-12-21 08:51:59 +01:00
self.mw.col.decks.save(self.deck)
# build query string
self.tags = ""
if yes:
arr = []
for req in yes:
convert qt strings to f-strings with flynt Also revealed an incorrect type def in editor.py that mypy wasn't noticing before :-(
2021-02-11 01:09:06 +01:00
arr.append(f'tag:"{req}"')
self.tags += f"({' or '.join(arr)})"
merged libanki and ankiqt into single distro
2012-12-21 08:51:59 +01:00
if no:
arr = []
for req in no:
convert qt strings to f-strings with flynt Also revealed an incorrect type def in editor.py that mypy wasn't noticing before :-(
2021-02-11 01:09:06 +01:00
arr.append(f'-tag:"{req}"')
self.tags += f" {' '.join(arr)}"
merged libanki and ankiqt into single distro
2012-12-21 08:51:59 +01:00
saveGeom(self, "tagLimit")
QDialog.accept(self)
Reference in New Issue Copy Permalink