2020-11-01 05:26:58 +01:00
|
|
|
load("@npm//eslint:index.bzl", _eslint_test = "eslint_test")
|
|
|
|
|
|
update to latest rules_nodejs & switch to ts_project
ts_library() is deprecated and will presumably be dropped from a
future rules_nodejs, and it wasn't working with the jest tests
after updating, so we switch over to ts_project().
There are some downsides:
- It's a bit slower, as the worker mode doesn't appear to function
at the moment.
- Getting it working with a mix of source files and generated files
was quite tricky, especially as things behave differently on Windows,
and differently when editing with VS Code. Solved with a small patch
to the rules, and a wrapper script that copies everything into the
bin folder first. To keep VS Code working correctly as well, the built
files are symlinked into the source folder.
- TS libraries are not implicitly linked to node_modules, so they
can't be imported with an absolute name like "lib/proto" - we need
to use relative paths like "../lib/proto" instead. Adjusting "paths"
in tsconfig.json makes it work for TS compilation, but then it fails
at the esbuild stage. We could resolve it by wrapping the TS
libraries in a subsequent js_library() call, but that has the downside
of losing the transient dependencies, meaning they need to be listed
again. Alternatively we might be able to solve it in the future by
adjusting esbuild, but for now the paths have been made relative to
keep things simple.
Upsides:
- Along with updates to the Svelte tooling, Svelte typing has improved.
All exports made in a Svelte file are now visible to other files that
import them, and we no longer rebuild the Svelte files when TS files
are updated, as the Svelte files do no type checking themselves, and
are just a simple transpilation. Svelte-check now works on Windows again,
and there should be no errors when editing in VS Code after you've
built the project. The only downside seems to be that cmd+clicking
on a Svelte imports jumps to the .d.ts file instead of the original now;
presumably they'll fix that in a future plugin update.
- Each subfolder now has its own tsconfig.json, and tsc can be called
directly for testing purposes (but beware it will place build products
in the source tree): ts/node_modules/.bin/tsc -b ts
- We can drop the custom esbuild_toolchain, as it's included in the
latest rules_nodejs.
Other changes:
- "image_module_support" is moved into lib/, and imported with
<reference types=...>
- Images are now imported directly from their npm package; the
extra copy step has been removed.
Windows users may need to use "bazel clean" before building this,
due to old files lying around in the build folder.
2021-09-30 14:16:29 +02:00
|
|
|
def eslint_test(name = "eslint", srcs = None, exclude = []):
|
|
|
|
|
if not srcs:
|
|
|
|
|
srcs = native.glob([
|
2021-11-02 03:50:27 +01:00
|
|
|
"**/*.ts",
|
2022-02-04 09:36:34 +01:00
|
|
|
"**/*.svelte",
|
2021-10-01 10:28:38 +02:00
|
|
|
], exclude = exclude)
|
2020-11-01 05:26:58 +01:00
|
|
|
_eslint_test(
|
|
|
|
|
name = name,
|
|
|
|
|
args = [
|
|
|
|
|
"--max-warnings=0",
|
|
|
|
|
"-c",
|
2021-11-02 04:49:19 +01:00
|
|
|
"$(location @ankidesktop//ts:.eslintrc.js)",
|
2020-11-01 05:26:58 +01:00
|
|
|
] + [native.package_name() + "/" + f for f in srcs],
|
|
|
|
|
data = [
|
2021-11-02 04:49:19 +01:00
|
|
|
"@ankidesktop//ts:.eslintrc.js",
|
|
|
|
|
"@ankidesktop//:package.json",
|
2020-11-01 05:26:58 +01:00
|
|
|
"@npm//@typescript-eslint/parser",
|
|
|
|
|
"@npm//@typescript-eslint/eslint-plugin",
|
2022-02-04 09:36:34 +01:00
|
|
|
"@npm//eslint-plugin-svelte3",
|
|
|
|
|
"@npm//eslint-plugin-import",
|
|
|
|
|
"@npm//eslint-plugin-simple-import-sort",
|
2021-11-02 04:44:41 +01:00
|
|
|
"@npm//eslint-plugin-compat",
|
2020-11-01 05:26:58 +01:00
|
|
|
] + srcs,
|
|
|
|
|
)
|