langfingaz/SoftwareQuality
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 11 Wiki Activity

1b: inline temporary static fields

Browse Source
This commit is contained in:
Daniel Langbein 2024-11-19 10:47:43 +01:00
parent d937090e5f
commit 7c8f81ff1c
Signed by: langfingaz
GPG Key ID: 6C47C753F0823002
2 changed files with 2 additions and 31 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
boulder-dash/src/fr/enssat/BoulderDash/helpers/LevelSaveHelper.java
View File

@ -321,9 +321,9 @@ public class LevelSaveHelper {
} }
// Retrieve current values // Retrieve current values
groupValue = curGridElement.getGroupName(); groupValue = "field";
nameValue = curGridElement.getSpriteName(); nameValue = curGridElement.getSpriteName();
stateValue = curGridElement.getStateValue(); stateValue = "initial";
convertibleValue = curGridElement.isConvertible() ? "1" : "0"; convertibleValue = curGridElement.isConvertible() ? "1" : "0";
// Create sprite XML element // Create sprite XML element

29
boulder-dash/src/fr/enssat/BoulderDash/models/displayableElement/DisplayableElementModel.java
View File

@ -17,9 +17,6 @@ import java.io.IOException;
public abstract class DisplayableElementModel { public abstract class DisplayableElementModel {
private static String spriteStorageFolderPath = "./res/drawable/field/"; private static String spriteStorageFolderPath = "./res/drawable/field/";
private static String groupName;
private static String stateValue;
private boolean destructible; private boolean destructible;
private boolean moving; private boolean moving;
private boolean animate; private boolean animate;
@ -31,14 +28,6 @@ public abstract class DisplayableElementModel {
private boolean convertible; private boolean convertible;
private String collideSound; private String collideSound;
/**
* Static dataset
*/
static {
groupName = "field";
stateValue = "initial";
}
/** /**
* Class constructor * Class constructor
* *
@ -146,24 +135,6 @@ public abstract class DisplayableElementModel {
return this.moving; return this.moving;
} }
/**
* Gets the group name value
*
* @return Group name value
*/
public String getGroupName() {
return this.groupName;
}
/**
* Gets the state value
*
* @return State value
*/
public String getStateValue() {
return this.stateValue;
}
/** /**
* Gets the sprite name value * Gets the sprite name value
* *