From 5f6312555dbd6ae7cd6227e0ae068b11b83871ba Mon Sep 17 00:00:00 2001
From: 0nlineSam <uni@sam.tadjiky.de>
Date: Wed, 23 Oct 2024 20:17:04 +0200
Subject: [PATCH] Ueb01 Checkstyle

---
 boulder-dash/.idea/checkstyle-idea.xml        | 16 +++++++++
 .../BoulderDash/helpers/LevelSaveHelper.java  |  8 +++--
 boulder-dash/ueb01_checkstyle_config.xml      | 33 +++++++++++++++++++
 3 files changed, 55 insertions(+), 2 deletions(-)
 create mode 100644 boulder-dash/.idea/checkstyle-idea.xml
 create mode 100644 boulder-dash/ueb01_checkstyle_config.xml

diff --git a/boulder-dash/.idea/checkstyle-idea.xml b/boulder-dash/.idea/checkstyle-idea.xml
new file mode 100644
index 00000000..805be345
--- /dev/null
+++ b/boulder-dash/.idea/checkstyle-idea.xml
@@ -0,0 +1,16 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project version="4">
+  <component name="CheckStyle-IDEA" serialisationVersion="2">
+    <checkstyleVersion>10.18.2</checkstyleVersion>
+    <scanScope>JavaOnly</scanScope>
+    <option name="thirdPartyClasspath" />
+    <option name="activeLocationIds" />
+    <option name="locations">
+      <list>
+        <ConfigurationLocation id="bundled-sun-checks" type="BUNDLED" scope="All" description="Sun Checks">(bundled)</ConfigurationLocation>
+        <ConfigurationLocation id="bundled-google-checks" type="BUNDLED" scope="All" description="Google Checks">(bundled)</ConfigurationLocation>
+        <ConfigurationLocation id="5232a701-ef57-4b8f-b1df-ed9fcf2cc548" type="LOCAL_FILE" scope="All" description="Ueb 01 Checkstyle">$PROJECT_DIR$/ueb01_checkstyle_config.xml</ConfigurationLocation>
+      </list>
+    </option>
+  </component>
+</project>
\ No newline at end of file
diff --git a/boulder-dash/src/fr/enssat/BoulderDash/helpers/LevelSaveHelper.java b/boulder-dash/src/fr/enssat/BoulderDash/helpers/LevelSaveHelper.java
index c314a9a7..cbdc2eac 100644
--- a/boulder-dash/src/fr/enssat/BoulderDash/helpers/LevelSaveHelper.java
+++ b/boulder-dash/src/fr/enssat/BoulderDash/helpers/LevelSaveHelper.java
@@ -327,7 +327,11 @@ public class LevelSaveHelper {
         groupValue       = curGridElement.getGroupName();
         nameValue        = curGridElement.getSpriteName();
         stateValue       = curGridElement.getStateValue();
-        convertibleValue = curGridElement.isConvertible() ? "1" : "0";
+        if (curGridElement.isConvertible()) {
+            convertibleValue = "1";
+        } else {
+            convertibleValue = "0";
+        }
 
         // Create sprite XML element
         Element gridLineItemSpriteElement = document.createElement("sprite");
@@ -337,7 +341,7 @@ public class LevelSaveHelper {
         gridLineItemSpriteElement.setAttribute("name", nameValue);
         gridLineItemSpriteElement.setAttribute("state", stateValue);
 
-        if(convertibleValue == "1") {
+        if("1".equals(convertibleValue)) {
             gridLineItemSpriteElement.setAttribute("convertible", convertibleValue);
         }
 
diff --git a/boulder-dash/ueb01_checkstyle_config.xml b/boulder-dash/ueb01_checkstyle_config.xml
new file mode 100644
index 00000000..a24aaf1a
--- /dev/null
+++ b/boulder-dash/ueb01_checkstyle_config.xml
@@ -0,0 +1,33 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!DOCTYPE module PUBLIC "-//Puppy Crawl//DTD Check Configuration 1.3//EN" "http://www.puppycrawl.com/dtds/configuration_1_3.dtd">
+
+<module name="Checker">
+  <property name="severity" value="error"/>
+  <module name="TreeWalker">
+    <module name="NeedBraces">
+      <property name="tokens" value="LITERAL_DO,LITERAL_ELSE,LITERAL_FOR,LITERAL_IF,LITERAL_WHILE"/>
+    </module>
+    <module name="AvoidInlineConditionals"/>
+    <module name="DeclarationOrder"/>
+	<module name="ReturnCount"/>
+    <module name="NestedTryDepth"/>
+	<module name="SimplifyBooleanExpression"/>
+	<module name="HiddenField">
+		<property name="tokens" value="VARIABLE_DEF"/>
+	</module>
+	<module name="AbbreviationAsWordInName">
+      <property name="ignoreStaticFinal" value="true"/>
+	  <property name="ignoreFinal" value="false"/>
+      <property name="allowedAbbreviationLength" value="3"/>
+      <property name="tokens"
+               value="VARIABLE_DEF"/>
+    </module>
+	<module name="VisibilityModifier"/>
+	<module name="StringLiteralEquality">
+	  <property name="severity" value="warning"/>
+	</module>
+	<module name="EqualsAvoidNull">
+	  <property name="severity" value="warning"/>
+	</module>
+  </module>
+</module>