From f94e43f34a29be9b2d6393253556b29d96a3901c Mon Sep 17 00:00:00 2001
From: Daniel Langbein <daniel@systemli.org>
Date: Mon, 1 Jan 2024 16:29:36 +0100
Subject: [PATCH] pinentry not in path

---
 modules/nitrokey-gpg-smartcard.nix | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/modules/nitrokey-gpg-smartcard.nix b/modules/nitrokey-gpg-smartcard.nix
index a45e206..d0a7e72 100644
--- a/modules/nitrokey-gpg-smartcard.nix
+++ b/modules/nitrokey-gpg-smartcard.nix
@@ -4,16 +4,18 @@
   # https://nixos.wiki/wiki/Nitrokey
 
   # Test suite. TODO: Check all of this after config changes!
-  # - pinentry should be in $PATH
-  #   echo GETPIN | pinentry
+  # - pinentry should be in $PATH.
+  #   Note: Since NixOS 23.11 (and maybe earlier) this is no longer the case.
+  #   Yet, all other tests still work!
+  #     echo GETPIN | pinentry
   # - smartcard should be listed
-  #   gpg --card-status
+  #     gpg --card-status
   # - encryption should work (graphical pinentry should pop-up)
-  #   gpg -d ./passphrase.txt.gpg
+  #     gpg -d ./passphrase.txt.gpg
   # - ssh should work (graphical pinentry should pop-up)
-  #   ssh yodaNas
+  #     ssh yodaNas
   # - signed git commits should work in IntelliJ
-  #   IntelliJ IDE -> git commit -> graphical pinentry should pop-up
+  #     IntelliJ IDE -> Make a Git commit -> Graphical pinentry should pop-up
 
   # Restart gpg-agent after config change.
   # Otherwise there might be a gpg error about "no pinentry".